- May 20, 2010
-
-
scherkus@chromium.org authored
Patches by Frank Galligan (fgalligan@google.com), Tom Finegan (tomfinegan@google.com) and James Zern (jzern@google.com). BUG=none TEST=none Review URL: http://codereview.chromium.org/2093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47759 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=44617 TEST=none TBR=cbentzel,stoyan Review URL: http://codereview.chromium.org/2135008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47758 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
The two rc unittests are failing because it appears the data files checked into svn don't match. It's easier to change the tests because the data is in a different (internal only) repo. AFAICT, this has been broken forever. The other fix is because a test became more correct after r43930, but the test was passing anyway. Review URL: http://codereview.chromium.org/2131013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47756 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Review URL: http://codereview.chromium.org/2075016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47755 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
I didn't bother allocating new one because i thought none is using event object except for our code, but i was wrong. TextField is copying the struct, which was causing the warning. BUG=none TEST=none Review URL: http://codereview.chromium.org/2086017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47754 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=40455,40457 Review URL: http://codereview.chromium.org/2104013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47753 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=44612 TEST=none TBR=cbentzel,victorw Review URL: http://codereview.chromium.org/2095018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47752 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=chromiumos:3348 TEST=click on the new bug icon in the status bar, it should open bug reporting dialog Review URL: http://codereview.chromium.org/2135005 TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/2125013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47751 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 19, 2010
-
-
johnnyg@chromium.org authored
For notifications, use the same shadow border that the autocomplete dropdown uses rather than using images. This looks a lot sharper. BUG=none TEST=none Review URL: http://codereview.chromium.org/2078019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47750 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=chromium-os:3348 TEST=click on the new bug icon in the status bar, it should open bug reporting dialog Review URL: http://codereview.chromium.org/2135005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47749 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This gets set to either 1 or 0 depending on whether the user is currently logged in or not. I'm doing this as a step towards using the same window manager process during and after login; this will let the WM know which log file it should be using, for instance. BUG=chromium-os:2790 TEST=tried it, and will add an autotest for this soon Review URL: http://codereview.chromium.org/2078017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47748 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
I forgot to change these when I changed the test declarations. BUG=none TEST=Happy Mac valgrind bots. Review URL: http://codereview.chromium.org/2078020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47747 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
This test appears to be passing fine. TEST=NONE BUG=NONE TBR=dmazzoni@chromiun.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47746 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
BUG=none TEST=NigoriTest.* Review URL: http://codereview.chromium.org/2089019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47745 0039d316-1c4b-4281-b951-d872f2087c98
-
amit@chromium.org authored
This change corrects the offset and the condition to avoid crash in IBrowserService2::v_MayTranslateAccelerator. BUG=25457 Review URL: http://codereview.chromium.org/2109010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47744 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
version. This is useful during development, for switching themes, and for user scripts (since user scripts have no development mode). Since we can't always immediately delete the version directory for an extension after unloading it (because some files might be in use), this required changing the directory layout of the extensions directory to allow multiple copies of the same version of the same extension to be present at once. This was done by adding a counter to the version directory name. Also get rid of all the old "Current Version" cruft, since we no longer use that. BUG=26538 Review URL: http://codereview.chromium.org/1521039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47740 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
Finish nagivation to "about:blank" before checking the name returned by the window's IAccessible. BUG=44486 TEST=browser_tests:BrowserViewsAccessibilityTest.TestChromeWindowAccObj TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/2119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47739 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
Move some code into the anonymous namespace since it doesn't need to be exposed outside of pepper_var.cc. R=brettw BUG=none TEST=To be written once the new framework is available. Review URL: http://codereview.chromium.org/2123009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47738 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=44603 TEST=None Review URL: http://codereview.chromium.org/2088010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47737 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/2104011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47736 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Review URL: http://codereview.chromium.org/2108022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47735 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/2097011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47734 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
overlay window code into OverlayWindowMac class. This is an intermediate step toward a Cocoa and CGL implementation. Verified that mouse and key events continue to work in full-screen mode with full-screen sample and a modified render-mode.html in Firefox 3.6.3 on Mac OS X, where O3D continues to use the Quickdraw drawing model. BUG=http://code.google.com/p/o3d/issues/detail?id=221 TEST=none Review URL: http://codereview.chromium.org/2129015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47733 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
The TODO on AutocompleteEditViewMac about the popup needing the field for placement and font got half done. The placement part just seemed too intrusive to be worthwhile, but the font part seemed reasonable to get rid of. The others are all either not sensible anymore, or were addressed without being removed, or have been in there long enough that if nobody has complained by now, their subject must not matter. BUG=none TEST=none Review URL: http://codereview.chromium.org/2127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47732 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Fixes address type matching in |AddressField::AddressTypeFromText| method. Also, extends |AutoFillManager::FillAutoFillFormData| method to fill associated billing address when filling a credit card that has billing information set in preferences. Adds new unit test AutoFillManagerTest.FillCreditCardFormWithBilling and fixes others. BUG=44227 TEST=AddressFieldTest.ParseOneLineAddress, \ AddressFieldTest.ParseOneLineAddressBilling, \ AddressFieldTest.ParseOneLineAddressShipping, \ AutoFillManagerTest.FillCreditCardForm, \ AutoFillManagerTest.FillCreditCardFormWithBilling, \ FormStructureTest.HeuristicsSample8, \ and manual test with everything2.html bug file. Review URL: http://codereview.chromium.org/2078016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47731 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=17392 TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plugin" text should look slightly different than it did before. (this test depends on a small webkit patch) Requires commenting out if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin) return 0; in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load. Review URL: http://codereview.chromium.org/2075006 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2132018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47730 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Neither of these tests appear to have failed recently on the 10.6 bots. BUG=42340, 42086 TEST=Tests pass on 10.6 bots. Review URL: http://codereview.chromium.org/2086016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47729 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Before it would only try the next address in the list, for specific OS errors. Also did a slight refactoring to use a state machine for Connect(). BUG=44490 Review URL: http://codereview.chromium.org/2132014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47728 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47727 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=17392 TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plug-in" text should look slightly different than it did before. (this test depends on a small webkit patch) Requires commenting out if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin) return 0; in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load. Review URL: http://codereview.chromium.org/2075006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47726 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
This shouldn't affect Win/Linux/Mac. See http://codereview.chromium.org/2025010 for the change. BUG=http://crosbug.com/2426 TEST=See the bug TBR=mark Review URL: http://codereview.chromium.org/2092001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47725 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=44599 TEST=none TBR=cbentzel,joi Review URL: http://codereview.chromium.org/2071019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47724 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=44128 TEST=player_wtl.exe --video-threads=6 d:\mediatests\crowd\crowd2.mp4 Review URL: http://codereview.chromium.org/2080008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47723 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
If you have two extensions with page actions, you can get into a state where it crashes if you refresh Extension A, then Extension B and Extension A again. BUG=http://crbug.com/44415 TEST=Covered by new test ExtensionBrowserTest.PageActionRefreshCrash Review URL: http://codereview.chromium.org/2134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47722 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/2096008/showgman@chromium.org authored
now that ANGLE has been updated or gcc 4.4.1 TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47721 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
The test should now fit on an 800x600 display, which is apparently what the 10.6 bots have. Removes the FLAKY marker since it should now pass on 10.6 bots. BUG=36670 TEST=PluginConvertPointTest should pass on 10.6 bots Review URL: http://codereview.chromium.org/2100008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47720 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This CL addresses a few issues related to the behavior of the onUpdated event. Issue 1: The page re-entering the load state and the completing was causing multiple 'complete' status events to be fired. We now only report the first 'complete' after the didNavigate message is fired (iframe navigation, for example). Issue 2: We were initializing the URL when the TabEntry was created, and this caused us to fail to send the url with the first navigation because we thought it wasn't changing. BUG=27208,37149 Review URL: http://codereview.chromium.org/2111010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47717 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=http://crbug.com/44189 TEST=included in base_unittests Review URL: http://codereview.chromium.org/2110010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47714 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
TBR=gman@chromium.org Review URL: http://codereview.chromium.org/2095014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47711 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@google.com authored
Changed image resizing logic to show full size ghost and question mark images. BUG=chromiumos:2856 TEST=Login and logout. Check that user images are not shown partially for short period of time before drawn correctly. Review URL: http://codereview.chromium.org/2136018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47710 0039d316-1c4b-4281-b951-d872f2087c98
-