In the current code calling dispatcher->DidXxx in an operation's DidXxx method MAY indirectly delete the operation itself depending on the dispatcher's implementation.  I was confused by this several times and I want to make this flow more explicit.

This patch lets FileSystemOperation control its lifetime by itself so that each callback dispatcher implementation does not need to take care of it.

Also moved BrowserFileSystemCallbackDispatcher into file_system_dispatcher_host.cc as it's only used in it and its implementation is tightly coupled with the DispatcherHost.

BUG=60243
TEST=none

Review URL: http://codereview.chromium.org/4821005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67732 0039d316-1c4b-4281-b951-d872f2087c98

Converted some important logging to LOG(INFO).

See similar CL to branch
http://codereview.chromium.org/5291010/

Had to make 2 copies because update_screen.cc has been changed in trunk.

BUG=chromium-os:9654
TEST=Manual

Review URL: http://codereview.chromium.org/5366004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67731 0039d316-1c4b-4281-b951-d872f2087c98

- change comment style in ppb_audio_trusted_dev.h to c style
- change shm_size to uint32_t to match other interfaces

BUG=none
TEST=src/ppapi/examples/audio/audio.cc

Review URL: http://codereview.chromium.org/5292010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rohitrao

Review URL: http://codereview.chromium.org/5285009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan

Review URL: http://codereview.chromium.org/5301009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67728 0039d316-1c4b-4281-b951-d872f2087c98

R=agl
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4091005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67722 0039d316-1c4b-4281-b951-d872f2087c98

The old version was way out of date.  I generated a new one
using a script (not sure where to check it in) that goes
through all of the packages installed for a board, fetches
the tarball for each and looks for a license file in it, and
then falls back on the LICENSE variable from the ebuild
file.  There's a lot of one-off tweaking too. :-(

BUG=chromium-os:7840
TEST=looked at it

Review URL: http://codereview.chromium.org/5357010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67720 0039d316-1c4b-4281-b951-d872f2087c98

When a tab is closed, it takes a while before the GPU stops drawing into the window. Destroying the window before the GPU has flushed its drawing pipeline causes unsightly X11 errors. The custom widget class that we use for drawing
tab contents has a lock that is set when the GPU process is drawing to that widget. We use this lock to determine who should delete the associated window:
- if the lock is clear at the time of widget destruction, the widget destroys the window
- if the lock is set, the GPU process signals to the browser to destroy the widget (it has to be done in the browser process b/c the X window is wrapped in a GdkWindow that resides in the browser address space)

Most the management is done in GtkNativeViewManager. I've added another map from XID to GtkWidget to facilitate this management.

BUG=55158

TEST=Open two windows with http://webkit.org/blog-files/3d-transforms/poster-circle.html Close one of them. There should be no X11 errors generated.

Review URL: http://codereview.chromium.org/5275009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67719 0039d316-1c4b-4281-b951-d872f2087c98

The Clang mac build does not compile the EXPECT_EQ(false, blah...
statements. I'm not sure why, and it doesn't reproduce on my Linux box,
but hopefully this should green the bot. In any case, I believe
EXPECT_FALSE is the preferred style.

TEST=unit_tests
BUG=none

Review URL: http://codereview.chromium.org/5329008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67718 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review at http://codereview.chromium.org/3656002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67717 0039d316-1c4b-4281-b951-d872f2087c98

BUG=7721
TEST=None
Review URL: http://codereview.chromium.org/5367008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67716 0039d316-1c4b-4281-b951-d872f2087c98

as now we have selenium checkout on bots and it should work
BUG=50372
TEST=FullTabSeleniumTest.Core


Review URL: http://codereview.chromium.org/5380005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67714 0039d316-1c4b-4281-b951-d872f2087c98

The sheet will be shown when instant results are committed, either by mouse click or by pressing enter.  If the instant results are destroyed, the sheet is never made visible.

BUG=61373
TEST=Enable instant.  Paste in a URL that opens an http auth sheet.  The sheet should not be visible.  No crashy, either.  Press enter.  The sheet should show.
TEST=Enable instant.  Paste in a URL that opens an http auth sheet, then delete the last character.  Some sort of instant results should load, most likely a 404 page.  Retype the last character.  404 page will continue to show, but the sheet will not open.  Click on the preview.  The sheet should show.
Review URL: http://codereview.chromium.org/5301006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67712 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9692
TEST=Login as new user and skip profile picture screen several times. Verify profile pictures used for users.

Review URL: http://codereview.chromium.org/5346007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67711 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thomasvl

BUG=50060
TEST=none

Review URL: http://codereview.chromium.org/5396003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64635
TEST=net_unittests

http://codereview.chromium.org/5376005/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67709 0039d316-1c4b-4281-b951-d872f2087c98

This gives us the safety that we delete the files only when they are certainly not accessed by the webkit context anymore.

BUG=56249
TEST=IndexedDBBrowserTest.ClearLocalState

Review URL: http://codereview.chromium.org/5359005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64753
TEST=ContentSettingsProviderTest.*

Review URL: http://codereview.chromium.org/5269007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64660
TEST=build succeeds (no effective code change)

Review URL: http://codereview.chromium.org/5367006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64460
TEST=host_content_settings_map_unittest.cc

Review URL: http://codereview.chromium.org/5355005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67705 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67704 0039d316-1c4b-4281-b951-d872f2087c98

Revert 67385 - On windows filepaths need \\?\ prefix to allow extended file path names. Fix to bug 63574.

Turned out that we need more changes to make extended paths work.

BUG=63574
TEST=file_system_operation_unittest.cc and manually tested on FAT32.


Review URL: http://codereview.chromium.org/5259003

TBR=kkanetkar@chromium.org
Review URL: http://codereview.chromium.org/5357009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67703 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51105
TEST=None

Review URL: http://codereview.chromium.org/5259008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59024
TEST=none

Review URL: http://codereview.chromium.org/5393001
Patch from Peter Beverloo <peter@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67701 0039d316-1c4b-4281-b951-d872f2087c98

This change widens the suppression rules for Bug 61128 to cover new leaks started since Build 718 <http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20(valgrind)/builds/718/steps/memory%20test:%20unit/logs/stdio>.

TBR=thestig,timurrrr
BUG=61128
TEST=make the "Chromium Mac (valgrind)" bot green.
Review URL: http://codereview.chromium.org/5281013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4997001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67698 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erikkay@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67693 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67689 0039d316-1c4b-4281-b951-d872f2087c98

syntax. This should make it a bit easier to use.

BUG=64539
TEST=n/a

Review URL: http://codereview.chromium.org/5271009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67687 0039d316-1c4b-4281-b951-d872f2087c98

TEST=make sure chrome:mobilesetup page shows the new UI now with marketing message
BUG=chromium-os:9715

Review URL: http://codereview.chromium.org/5329007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67686 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67685 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67684 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67683 0039d316-1c4b-4281-b951-d872f2087c98

Changes notion of |PrimaryKey| to include address line 2 and email.  When submitting a filled form the Autofill merging of profiles now considers changes to address line 2 and email a trigger to create a new profile.

BUG=64669
TEST=PersonalDataManagerTest.AggregateSameProfileWithConflict

Review URL: http://codereview.chromium.org/5364007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=skerner

Review URL: http://codereview.chromium.org/5323006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5139006

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/5270010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67674 0039d316-1c4b-4281-b951-d872f2087c98

Also, only allow them to grow.

A later fix will remove this ifdef replacing it with code that works across platforms.

BUG=56693
TEST=Ran many tests manually. Automated test in progress (before closing the bug).

Review URL: http://codereview.chromium.org/5361006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67673 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/5271007/

BUG=chromium-os:8836,chromium:61847
TEST=Ran the new UI, checking and unchecking various boxes, trying different screenshots and submitting.

Review URL: http://codereview.chromium.org/5372007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67672 0039d316-1c4b-4281-b951-d872f2087c98

Replaced image for Chrome OS Guest mode NTP.

BUG=chromium-os:9692
TEST=Login as Guest and check that image on NTP page matches the one on Guest mode pod.
TBR=avayvod

Review URL: http://codereview.chromium.org/5255011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=fix build
TBR=estade
Review URL: http://codereview.chromium.org/5297009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67670 0039d316-1c4b-4281-b951-d872f2087c98