- Jul 14, 2010
-
-
tfarina@chromium.org authored
BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52272 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
First, don't queue excessive draws when the animation isn't changing. This should reduce cpu usage by about 75%. Second, don't animate the little dot when the browser window isn't active. For WMs that support _NET_ACTIVE_WINDOW, this should keep CPU usage steady no matter how many browser windows are open. The net effect of this patch is to reduce CPU usage from 100% in certain cases (when many windows are open) to a negligible amount (on metacity on my workstation). BUG=48909 TEST=open many windows and inspect CPU usage according to top Review URL: http://codereview.chromium.org/2985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52271 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
* Log an error message when an update job results in an error. * Log info messages for progress events and other update status changed events. * Consistently use "Application Cache" in the console messages. TEST=existing unit tests apply for functional correctness, manual testing to see the new console output BUG=none Review URL: http://codereview.chromium.org/2910007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52270 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
This suppresses a harmless LOG(ERROR) on SPECIFICS / SERVER_SPECIFICS not matching. That's because the server doesn't return preserve a URL field on folder entities, so if we set it locally (even to the empty string), it won't be returned in the result message. BUG=45610 TEST=create a folder, rename it, verify no 'LOG(WARNING) << "Specifics mismatch"' from syncer_util.cc Review URL: http://codereview.chromium.org/2904013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52269 0039d316-1c4b-4281-b951-d872f2087c98
-
chron@chromium.org authored
BUG=43462 TEST=Login to ChromeOS, log out, log in again, sync should still work. Get into GAIA credential failure state, out and in again and it should still work. Review URL: http://codereview.chromium.org/2978004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52268 0039d316-1c4b-4281-b951-d872f2087c98
-
feldstein@chromium.org authored
In progress downloads would clear the selection of the url every time the progress updates, making it impossible to copy a url. BUG=44982 TEST=Download a large file, and select it's URL as it is downloading. It should stay selected. Review URL: http://codereview.chromium.org/2966008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52267 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
- remove unneeded states - minor style and error handling improvements This change removes ACCT command support. It was really untested, and I think it wouldn't work in case it was needed. We may add it back when we get a good test case. However, people are unlikely to use a web browser to access servers that require usage of ACCT command. TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/2985004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52266 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=26443 TEST=trybots Signed-off-by:
Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2895007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52265 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@google.com authored
TEST=net_unittests BUG=47991 Review URL: http://codereview.chromium.org/2987002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52264 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
This is only the internal command buffer implementation. Connecting these functions publicly to PPAPI or whatever will happen separate from this CL. It's not clear to me where to put GL_READ_ONLY and GL_WRITE_ONLY Probably the same place we expose these 2 functions to the public. TEST=unit test BUG=none Review URL: http://codereview.chromium.org/2956005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52263 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Button label logic on mac should match other platforms and show "stop syncing" whenever sync setup is done, regardless of error state. BUG=48973 TEST=invalidate login creds on mac, check options panel Review URL: http://codereview.chromium.org/2918005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52262 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=48988 TEST=manual Review URL: http://codereview.chromium.org/2981010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52261 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
R=brettw TEST=none BUG=46311 Review URL: http://codereview.chromium.org/2896011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52260 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
Handle birthday errors by disabling sync and deleting sync data. Also added some CV broadcasts in SyncerThread, as changing vault_ fields and not signalling seems dubious (and I caught a hang in the debugger where the thread was waiting for an already true condition, thus deadlocked). BUG=46807,39070 Review URL: http://codereview.chromium.org/2923006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52259 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
XIB changes: added a new link to the sync group of the preferences dialog (required adding a continuation array). Slightly altered the spacing to fit. BUG=48844 TEST=mac preferences pane with the above switch Review URL: http://codereview.chromium.org/2891021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52258 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Always pass along the GAIA failure event, regardless of the local authentication condition. This is necessary since the UI is waiting for the event, and has no effect on the other listeners. BUG=19720 TEST=let server creds expire, then login with bad password; should get an error message not a hung UI Review URL: http://codereview.chromium.org/2988002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52257 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/2903009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52256 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=48844 TEST=run with --show-privacy-dashboard-link Review URL: http://codereview.chromium.org/2943010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52255 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=48697 TEST=change notifications content settings with preference sync enabled Review URL: http://codereview.chromium.org/2891012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52254 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
BUG=47226 TEST=Configure chrome with a PAC script that throws errors. Load a URL and should see the javascript error displayed on about:net-internals. Review URL: http://codereview.chromium.org/2978001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52253 0039d316-1c4b-4281-b951-d872f2087c98
-
jerrica@google.com authored
syncing of sessions. Created a method to track certain session modifications in order to determine what we want to track when syncing sessions BUG=30519 TEST=NONE Review URL: http://codereview.chromium.org/2930002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52252 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Also, convert it to a subpage. Also, make subpage nav items hidden when not in use. BUG=48863 TEST=manual Review URL: http://codereview.chromium.org/2901008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52251 0039d316-1c4b-4281-b951-d872f2087c98
-
chron@chromium.org authored
Add the TokenService to the chrome profile, and use it to pass the LSID from ChromiumOS login into Sync. This is just initial groundlaying for replacing the internal sync auth stack. IssueAuthToken is not yet used in this CL. TEST=Run chromium OS. Login using your credentials. Verify that sync works in about:sync. BUG=47093 Review URL: http://codereview.chromium.org/2872034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52250 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=11457 TEST=Go to google.com, drag logo around. Preview image should now look nice. Review URL: http://codereview.chromium.org/2963009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52249 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
Implemented error texture support in client and ParamArray class. Fixed bug in effect.js that broke checkerboard texture if running using CG shaders. TODO: Still a bug with render surface sets; will file issue and tackle problem in separate CL. Review URL: http://codereview.chromium.org/2803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52248 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=39070 BUG=skrul@chromium.org TEST=none Review URL: http://codereview.chromium.org/2981009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52247 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
I broke this in r52220 by remapping some of the function key accelerators for Chrome OS builds. BUG=none TEST=ran it Review URL: http://codereview.chromium.org/2892009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52245 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jul 13, 2010
-
-
oshima@chromium.org authored
TBR=albertb@chromium.org BUG=41186 TEST=none Review URL: http://codereview.chromium.org/2900010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52244 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=pam BUG=48980 TEST=Green heapcheck bot Review URL: http://codereview.chromium.org/2913011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52243 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52242 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52241 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
* Flatten HTML where possible * Move resources only referenced by files in browser/resources/ into there (and out of the theme dir) * Remove duplicate/unreferenced resources * Remove IDs for resources that are inlined due to flattening * Remove IDR_CHAT_MANAGER_MANIFEST but leave the files on disk (they will be moving elsewhere some time soon) BUG=none TEST=none Review URL: http://codereview.chromium.org/2897015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52239 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
* Alphabetize a couple entries * Move things to theme_resources.grd where possible; also fixes problems in chrome.gyp and theme_resources.grd that were causing "toolkit_views" to not be properly handled here, so this won't cause problems * Scope things only used by views under an appropriate conditional BUG=none TEST=none Review URL: http://codereview.chromium.org/2987003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52238 0039d316-1c4b-4281-b951-d872f2087c98
-
seanparent@google.com authored
BUG=chromium-os:1178 1610 2033 TEST=UpdateBrowserTest.Notifications Review URL: http://codereview.chromium.org/2859043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52237 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
ChromeFrame back forward navigations at times would mess up the navigation history if the back and the current page both were rendered in ChromeFrame. This was because the back operation would incorrectly navigate twice. Once via IE history navigation and the other navigation would originate within the renderer and would execute as a new navigation in IE. Fix is to not report backforward navigations as top level navigations to the external host. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44403 Bug=44403 Test=Covered by ChromeFrame test Review URL: http://codereview.chromium.org/2982003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52235 0039d316-1c4b-4281-b951-d872f2087c98
-
slightlyoff@chromium.org authored
After verifying the startup win though more testing, removing the guards around the pre-reading optimization. BUG=45510 TEST=None Review URL: http://codereview.chromium.org/2891014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52234 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
FAILS_. TBR=estade BUG=11761 TEST=FindInPageControllerTest.FindInPagePrematureEnd Review URL: http://codereview.chromium.org/2950007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52233 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
image and pboard were always initialized, but warning that they couldn't only happened on opt build, which I didn't, mea culpa... BUG=none TEST=none Review URL: http://codereview.chromium.org/2951012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52232 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
overriding the built-in set. - Per locale providers not allowed. BUG=47440 TEST=unittest included, for manual testing see bug. Review URL: http://codereview.chromium.org/2974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52228 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=48912 TEST=none Review URL: http://codereview.chromium.org/2955010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52227 0039d316-1c4b-4281-b951-d872f2087c98
-