TBR=joi

Review URL: http://codereview.chromium.org/6010005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70138 0039d316-1c4b-4281-b951-d872f2087c98

Clean up Automation and Chrome Frame IPC code.-only use routed messages when needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile.
Review URL: http://codereview.chromium.org/5998006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98

will allow automation clients to know which tab generated each API call.

BUG=none
TEST=ui_tests.exe

Review URL: http://codereview.chromium.org/5222004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66963 0039d316-1c4b-4281-b951-d872f2087c98

Move the automation message files from chrome/test/automation to
chrome/common/. This requires a temporary override to chrome/common/DEPS until
Part 3 lands.

BUG=51409
TEST=compiles

Review URL: http://codereview.chromium.org/4758001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637).

TBR=nirnimesh@

BUG=51409
TEST=none

Review URL: http://codereview.chromium.org/4194007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98

automation_messages used to live in chrome/test/automation, when it's needed by
browser and chrome_frame. When I started lifting code out of headers and into
implementation files, I was getting link errors and temporarily solved the
problem by compiling the cc files manually into libbrowser.a. Now this is part
of chrome/common/ which is included by all targets needed.

While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams.

BUG=51409
TEST=none

Review URL: http://codereview.chromium.org/4200007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=N/A

Review URL: http://codereview.chromium.org/4135007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64150 0039d316-1c4b-4281-b951-d872f2087c98

These are two common patterns in Chrome code: copying a
subset of switches from one CommandLine to another, and
appending a FilePath to a CommandLine.  This sets me up
to do a lot more deprecation in a follow-up change.

Review URL: http://codereview.chromium.org/3012021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54218 0039d316-1c4b-4281-b951-d872f2087c98

Adds bug annotation to the tests that still needs porting work.

BUG=45766,45753,45770,45771
TEST=Compling ui_tests still works

Review URL: http://codereview.chromium.org/2605001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48875 0039d316-1c4b-4281-b951-d872f2087c98

Implement most of the ridealong fixes/cleanups I suggested during review for enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2395001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98

windows builds more similar to linux/mac, which already treat signed/ 
unsigned equality comparisons as warnings (and hence errors). 

BUG=44471
TEST=none 

Review URL: http://codereview.chromium.org/2222002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98.

Revert "Missed a file as part of checkin for r48186"

This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b.

Revert "Enable warning 4389 as an error on windows builds.  This will make"

This reverts commit c78936bcfc65b98edf288191d927a495b0364621.

TBR=mbelshe

Review URL: http://codereview.chromium.org/2253001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98

windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).

BUG=44471
TEST=none

Review URL: http://codereview.chromium.org/2081007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=44650
TEST=None

Review URL: http://codereview.chromium.org/2083017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=44599
TEST=none
TBR=cbentzel,joi

Review URL: http://codereview.chromium.org/2071019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47724 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta

TEST=flaky
BUG=37554

Review URL: http://codereview.chromium.org/1695024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45947 0039d316-1c4b-4281-b951-d872f2087c98

- use timeouts correctly
- use more automation methods to make test code more clear
- use more reliable ways of waiting
- remove unnecessary automation calls

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1553016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43932 0039d316-1c4b-4281-b951-d872f2087c98

- unify timeout handling
- remove unneccessary assertions that clutter the code

They were mostly there because earlier the automation
framework was less reliable. Now the same checks (or
equivalent) are always done in the framework itself.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1377001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42767 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98

them settable in chrome.windows.create().

BUG=12658
BUG=28599

Review URL: http://codereview.chromium.org/669189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40961 0039d316-1c4b-4281-b951-d872f2087c98

ExternalTabContainer tests create the host window and the automationproxy in the main thread, that will cause deadlock (especially when host window is visible).
Added test for openening popup windows.

TEST=ui_tests
Review URL: http://codereview.chromium.org/661028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40072 0039d316-1c4b-4281-b951-d872f2087c98

--enable-experimental-extension-apis . The UI needs work. Tab and window
events are hooked up so that they work with incognito tabs/windows when
enabled.

BUG=32365
BUG=36292

Review URL: http://codereview.chromium.org/657041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40057 0039d316-1c4b-4281-b951-d872f2087c98

This is in anticipation of the new, strict, JSON.parse landing in v8.

Review URL: http://codereview.chromium.org/560040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38105 0039d316-1c4b-4281-b951-d872f2087c98

tests over to ExternalTabUITest.

BUG=27326
TEST=ui_tests.exe

Review URL: http://codereview.chromium.org/468013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33902 0039d316-1c4b-4281-b951-d872f2087c98

* Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs.
* Use these APIs with all key iterator usage.
* SetXXX() calls cannot fail, so change them from bool to void.
* Change GetSize() to size() since it's cheap, and add empty().

Other:
* Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop).
* Shorten a few bits of code.

BUG=567
TEST=none
Review URL: http://codereview.chromium.org/441008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98

tab for all extension views.  Previously, API routing to the
automation client would only work for extension views that were
contained in the particular ExternalTab instance being automated. This
meant you couldn't test API calls from e.g. background pages.

Also using async functions instead of the previous RVH-based hack.

Updating one of the UI tests to make the API calls from a background
page, to provide an end-to-end test of the new routing.

This makes AutomationProvider::SetEnableAutomationExtension
Windows-only, but it effectively always was since it was already
dependent on ExternalTabContainer (indirectly, to provide a non-empty
implementation of TabContentsDelegate::ForwardMessageToExternalHost).

BUG=none
TEST=ui_tests.exe, chrome_frame_tests.exe, chrome_frame_unittests.exe

Review URL: http://codereview.chromium.org/366025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21729
TEST= Manually tested that onUpdated sends all tab info.  Updated unit tests.
Review URL: http://codereview.chromium.org/289006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30341 0039d316-1c4b-4281-b951-d872f2087c98

makes the naming of string_escape more clear (it's actually JSON-specific).
Move the files into the base namespace.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/316016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29934 0039d316-1c4b-4281-b951-d872f2087c98

APIs to forward (and thus stub out in your test), while others will
keep being fulfilled as per usual.  This lets you build tests that
stub out one piece of behavior while testing that some side effects of
another API happen as expected.

BUG=none
TEST=Run ui_tests.exe

Review URL: http://codereview.chromium.org/314015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29919 0039d316-1c4b-4281-b951-d872f2087c98

needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the
HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back.

The ChromeFrame changes are basically around the same lines with one exception. When we handle the
AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable
to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then
save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading
the referer and passing it off to Chrome in the NavigateInExternalTab message.

Added a unit test in ChromeFrame which tests this case.

This fixes http://code.google.com/p/chromium/issues/detail?id=22994

Bug=22994

Review URL: http://codereview.chromium.org/274071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29420 0039d316-1c4b-4281-b951-d872f2087c98

of incrementing a static counter.

BUG=21281
TEST=Load an unpacked extension from chrome://extensions/ that
does not have an ID in its manifest. The resulting ID should
be random-looking, not something like "aaaaaa".

Review URL: http://codereview.chromium.org/256049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: http://codereview.chromium.org/195030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26771 0039d316-1c4b-4281-b951-d872f2087c98

Browse the newly created external tab to the specified initial URL
if present, to about:blank otherwise. Also send information about
SSL status when sending navigation updates to the automation client.

BUG=none
TEST=CreateExternalTabWithUrl UI test

Review URL: http://codereview.chromium.org/193054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20573
TEST=Install sample extensions without modifying command line flags. They should install (and run on next startup).

Review URL: http://codereview.chromium.org/179032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20288

Review URL: http://codereview.chromium.org/180016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18711

Review URL: http://codereview.chromium.org/173034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24068 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/174148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23884 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw
Review URL: http://codereview.chromium.org/160470

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22177 0039d316-1c4b-4281-b951-d872f2087c98

CID=4199,4685
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159677

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22173 0039d316-1c4b-4281-b951-d872f2087c98

In this step, All "normal" api calls and events (those that arrive or originate from the browser process) are routed through a single v8::Extension API Call ("StartRequest").

Additionally, internal string names for methods and events now match the js namespace (i.e. "RemoveTab" -> "tabs.remove"), in anticipation of having names be implicit from their api module & name in the api "IDL".

TBR=aa,mpcomplete

Review URL: http://codereview.chromium.org/149730

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20910 0039d316-1c4b-4281-b951-d872f2087c98