- Aug 26, 2009
-
-
tony@chromium.org authored
able to resolve its hostname, so just put in a placeholder value. TBR=nirnimesh Review URL: http://codereview.chromium.org/174536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24473 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
HTTP/HTTPs. It seems that Firefox is doing the same thing. BUG=16534 (http://crbug.com/16534) TEST=Visit any website and append double-quote (") for the URL and invoke "Select All" by Control-A, then copy the URL by Control-C. Paste the result into notepad and check if the double-quote is NOT encoded. TEST=Access file:///" and select whole Omnibox and copy the URL. Paste the text into notepad and check if the double-quote is NOT URL encoded. TEST=Put " in Omnibox and type enter key so that you will be navigated to http://www.google.co.jp/search?sourceid=chrome&ie=UTF-8&q=%22. Copy whole content in Omnibox and paste it into notepad. Then, check if the double-quote is URL-encoded (%22). Original Review: http://codereview.chromium.org/155495/show Patch by hamaji@chromium.org (he's on vacation and asked me to land) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24472 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
These profiles were originally created on Windows, so they had 1601 epoch. Brett upgraded them during his Linux/Mac epoch fix, which incorrectly assumed they were 1970 epoch and added 369 years. Review URL: http://codereview.chromium.org/173492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24471 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
If 'profile' is NULL, we should return ResultCodes::NORMAL_EXIT so that we won't go on to dereference 'profile'. R=brettw,estade BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/171007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24469 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
It should no longer be failing as of WebKit r47729. BUG=16850 TEST=green build Review URL: http://codereview.chromium.org/174358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24468 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
BUG=None TEST=Infobar buttons should be smaller, with smaller text. The icon should align (roughly) with the back button. Functionality should be unchanged. Review URL: http://codereview.chromium.org/174525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24463 0039d316-1c4b-4281-b951-d872f2087c98
-
deanm@chromium.org authored
Review URL: http://codereview.chromium.org/173484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24460 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
depends on are ready. UMR should be fixed after setting new appcache variable. BUG=no TEST=no Review URL: http://codereview.chromium.org/173482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24459 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
This allows for geometry updates while the plugin is hidden so that when it becomes visible, the plugin is properly positioned. In this change, I also revised RenderWidget::SchedulePluginMove to properly merge a move that only updates the visible state, and I fixed up TestShell to properly handle moves that only update the visible state. R=jam BUG=19888,20260 TEST=covered by layout tests Review URL: http://codereview.chromium.org/174513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24457 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
BUG=20314 TEST=none TBR=ager Review URL: http://codereview.chromium.org/174532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24456 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
BUG=http://crbug.com/20131 TEST=see bug; was very specific. Review URL: http://codereview.chromium.org/173428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24455 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=16400 TEST=See bug description Review URL: http://codereview.chromium.org/173414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24454 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay the framework include path so someone can include the header without errors. BUG=none TEST=none Review URL: http://codereview.chromium.org/173363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24453 0039d316-1c4b-4281-b951-d872f2087c98
-
tejasshah@google.com authored
Review URL: http://codereview.chromium.org/174503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24452 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
BUG=20249 TEST=Browser still works Review URL: http://codereview.chromium.org/174482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24451 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@chromium.org authored
TBR=scherkus BUG=16779 TEST=none Review URL: http://codereview.chromium.org/173478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24450 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=Covered by net_unittests. http://crbug.com/20112 Review URL: http://codereview.chromium.org/173270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24449 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
Modify the RenderThread to track the number of widgets and "hidden widgets" which are running through that thread. By knowing the if the widgets are all hidden, the thread can accurately inform V8 when it is idle so that V8 can better cleanup unused memory when idle. BUG=none TEST=none Review URL: http://codereview.chromium.org/173466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24448 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@chromium.org authored
R=scherkus TEST=none BUG=16779 Review URL: http://codereview.chromium.org/173381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24447 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
We need to wait for correct number of navigations when going back or forward to the LinkDoctor page. Re-enable previously disabled tests and remove the now-duplicate browser test. The test is still not very solid, because the LinkDoctor should be mocked. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/174396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24446 0039d316-1c4b-4281-b951-d872f2087c98
-
kathyw@google.com authored
into a new NPAPI page. TBR=aa Review URL: http://codereview.chromium.org/174526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24445 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
This CL fixes issue 19081 by setting im context's client window when host view's native widget is realized rather than focused in. When setting im context's client window, GtkIMMulticontext will destroy and recreate its slave im context, which will cause this issue. BUG=19081: Linux: Not able to switch input method correctly in web page using SCIM TEST=Export GTK_IM_MODULE=scim then open chrome, open www.google.com and place cursor in search box, hit ctrl-space to open SCIM then click scim bar or tray icon and select another input method, then check if input method was switched correct. Review URL: http://codereview.chromium.org/174217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24442 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
Cache GTMTheme across windows to avoid re-creating it every time we create a new window. Cache gradient to avoid re-creating it every time we draw a button cell. BUG=none TEST=switch themes, ensure it works. Make sure buttons draw correctly. Review URL: http://codereview.chromium.org/173445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24441 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
BUG=19850 Review URL: http://codereview.chromium.org/160098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24440 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
The only change is to not shrink new space on compacting GCs but only on idle notifications. Shrinking new space on all compactions regressed the morejs page cycler and SunSpider and it is not obvious that it is a good thing to do. TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/173472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24438 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
This version contains a fix for crashes that happened if we got idle notifications before V8 was set up. TEST=none BUG=20209 Review URL: http://codereview.chromium.org/173467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24437 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@chromium.org authored
in order for each configuration to get fully populated in configuration manager. BUG=None TEST=None Review URL: http://codereview.chromium.org/174483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24436 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
TEST=None BUG=None Review URL: http://codereview.chromium.org/173459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24435 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
This and LayoutTests/fast/text/stroking-decorations.html were fixed in WebKit 47748. BUG=20130 TEST=none Review URL: http://codereview.chromium.org/174510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24433 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
One more deferred load fix. The ResourceDispatcher on receiving a message checks whether there are pending requests for the corresponding request id and if yes dispatches those first. However the request can get deferred in this context and hence the new message needs to be queued up. Fixes bug http://code.google.com/p/chromium/issues/detail?id=19393 This fixes an issue where flash videos on youtube would not work correctly at times. Bug=19393 Review URL: http://codereview.chromium.org/174499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24432 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
BUG=20130 TEST=none Review URL: http://codereview.chromium.org/174506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24431 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@google.com authored
This reverts 24426 TBR=yutak Review URL: http://codereview.chromium.org/173460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24429 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@google.com authored
BUG=19653 Review URL: http://codereview.chromium.org/174462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24426 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=20289 TEST=run media_bench on sonyh2.ogv. formatting looks bad Review URL: http://codereview.chromium.org/173455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24425 0039d316-1c4b-4281-b951-d872f2087c98
-
yutak@chromium.org authored
BUG=20291 TBR=huanr TEST=none Review URL: http://codereview.chromium.org/173457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24424 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
This CL fixes issue 19689 by handling command line values with native encoding on non-Windows systems. For Linux, native encoding specified in current locale is used. For Mac, UTF-8 will always be used. This CL only changes command line values and program name to use native encoding, command line switches still use ASCII. BUG=19689: Command line URL parameter does not support Chinese TEST=Execute chrome with "http://www.google.com/search?q=中文" to see if this url can be opened successfully. Review URL: http://codereview.chromium.org/174139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24423 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
This CL improves the key event handing code of BrowserWindowGtk. Issue 20118 is also fixed. BUG=20118: Typing a colon (:) into the address bar causes the browser to freeze TEST=Run chrome with a XIM input method, chrome and x server's cpu usage shall be very low after pressing shift key (or any other modifier key) in omnibox. Review URL: http://codereview.chromium.org/173344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24422 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Turns out download item views need to be destroyed before the associated download item is destroyed. Review URL: http://codereview.chromium.org/173456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24421 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
. Moves listening from DidProcess to WillProcess. This is necessitated by the bookmark bar (chrome menu) tests that spawn a nested run loop, which results in DidProcess not getting sent and the test wedging. This brings the code closer in line with Windows. . If there is a mouse/keyboard grab, mouse/keyboard events are sent to the grabbed widget. . Deals with a NULL widget for sending keyboard events (tries to find focused widget). BUG=none TEST=none Review URL: http://codereview.chromium.org/173392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24420 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
BUG=11547 TEST=See bug. Review URL: http://codereview.chromium.org/173239 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/174501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24419 0039d316-1c4b-4281-b951-d872f2087c98
-