- Nov 05, 2024
-
-
Chrome Release Bot (LUCI) authored
Change-Id: Iaddbd5152430c6f5377169cbe76030ea6708c744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996670 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1756} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Jingyuan Liang authored
TEST=out/Default/events_unittests (cherry picked from commit 189de3d6) Bug: b:318431165 Change-Id: I5684a611bfcd1845c02c9a77681dc7148d292d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958687 Reviewed-by:
David Padlipsky <dpad@google.com> Reviewed-by:
William Mahon <wmahon@google.com> Auto-Submit: Jingyuan Liang <jingyliang@chromium.org> Commit-Queue: Jingyuan Liang <jingyliang@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1373586} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989704 Reviewed-by:
Kenneth Albanowski <kenalba@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1755} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730840280-92312eb5f23e384c12410fbe411d9eb9aee59cee-bb3133f6.profdata to chrome-android64-6778-1730844335-d2d4c9a7361340f5cb4c960c8382ee835e4be20c-7ee2f18b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I33d7e0281c0949938e45275e2c62d492091bc3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994919 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1754} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1730836759-167abf446aa69ba38a2b60163981d3e7fb1d4e5e-e897bdc2.profdata to chrome-mac-arm-6778-1730842182-d51ac6314da4fc37f490948acfe1c7e9f9cf40dc-ddca7b0a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I901ce5db15e2aaa1ae85d65d8a6fe5fd9294141a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995327 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1753} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I403e8dc9cde113033c0ef91027a98f7fc34be071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995146 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1752} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730838500-1a2330a20d450e1432ab536efd7e7929eed029d4-baad0432.profdata to chrome-android64-6778-1730840280-92312eb5f23e384c12410fbe411d9eb9aee59cee-bb3133f6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Icd7ce760a8ff9efc20c485714a52e8ecebd1197e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995060 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1751} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I0ee6349ad01ee1f218d04a3faf592a6eab094c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995323 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1750} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I6a76c91f19e6f9585423562ce7b348d2ba1eaa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996310 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1749} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I1b0420b4088317f5158c68632b7f0de6e111d0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996231 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1748} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I6a7fff23b402332b5f3c4f26afbd29b89754d155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996290 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1747} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I9d1f30f4fb73ce8dfd7a05d65a52ce0b615077fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995494 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1746} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I005efea3aa9fd8d8a20fa40c573226607e69cab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994751 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1745} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Bot (LUCI) authored
Change-Id: I3821b8ad2f78f892b8ef1d7606aee26248dd7617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996230 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1744} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-6778-1730807803-678b3c4cb8bba75c3beae05b3e2d4a286e6219a8-6614ce9f.profdata to chrome-win64-6778-1730827753-fa014dd36f8efa7eb7c0569b13b320178b8dd67e-2a65fd33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie42943500adda081c1ffe73348164d1ad4d24a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994478 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1743} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730835568-c39d82746b7a4d14216c9ab74d08f2925cc57304-9a26d3bf.profdata to chrome-android64-6778-1730838500-1a2330a20d450e1432ab536efd7e7929eed029d4-baad0432.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I681410b61b6dbd02bcaf5b9ab24826f4a0ab89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995076 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1742} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Michael Wilson authored
We plan to start experimenting with this feature, which was added in https://crrev.com/c/3422428 Since this may adversely affect audio quality, add an Enterprise Policy to allow organizations to disable the feature. This policy needs to be able to override the Finch-controlled feature WebAudioBypassOutputBuffering. To that end, the following was done: - Add a new feature WebAudioBypassOutputBufferingOptOut - Make both features runtime-enabled - Use a command-line switch to communicate the Enterprise Policy value to the renderer process (following the example of KeyboardFocusableScrollersOptOut) - Allow runtime_enabled_features.h in renderer/platform/audio, following the example of other subdirectories of platform (cherry picked from commit 127e720c) Bug: 367276023 Bug: 377339183 Change-Id: I6281c6e35d3cdf1c54917fc202b39e01e88b9cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924976 Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Michael Wilson <mjwilson@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1377972} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991740 Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#1741} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-6778-1730807803-af712e04f3079eb16c566089cbda8a66310e25ea-6614ce9f.profdata to chrome-mac-6778-1730827753-7d498772b25695f7dbe6e4a688ace632df2bef11-2a65fd33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id9fa071ca9193696ffaaaa0eb4ce4959914d3696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994422 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1740} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1730827753-58e3318950c4d036e3c14819e1880edd1e9b4ae3-2a65fd33.profdata to chrome-mac-arm-6778-1730836759-167abf446aa69ba38a2b60163981d3e7fb1d4e5e-e897bdc2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I56e27df2f207718225531b68b5c18d2afed3091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995233 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1739} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730833284-cde6e2cbf49fc2014cbe56402b3aac5bde3707e4-bee764ad.profdata to chrome-android64-6778-1730835568-c39d82746b7a4d14216c9ab74d08f2925cc57304-9a26d3bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I495cf4e3b786a061b9a71914b3b0c25a13dafd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995073 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1738} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Lijin Shen authored
Add fix on java side and do not report crash on gesture mode. (cherry picked from commit 4bc4cd4f) Bug: 373202292, 377519709 Change-Id: Ib8e8e76f2b9af22b8a0e5920661c2d39059ae5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5974554 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Khushal Sagar <khushalsagar@chromium.org> Commit-Queue: Theresa Sullivan <twellington@chromium.org> Reviewed-by:
Theresa Sullivan <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1377205} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993936 Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1737} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730827753-eaf303d288982314aa95f1d1b05eb1d12fe2d17a-2a65fd33.profdata to chrome-android64-6778-1730833284-cde6e2cbf49fc2014cbe56402b3aac5bde3707e4-bee764ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I54031f8820207bee7ddb67d0e35fa014fac02ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995135 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1736} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
vincb authored
This switch is enabled by default and allows disabling the form scan triggered when the forms forest calls TriggerFormExtractionInDriverFrame(). TriggerFormExtractionInDriverFrame() can be expensive on iOS, we're working on optimizing the cost of form fetches through throtttling but this may take some time to deploy, so in the meantime we thought that disabling the scans could help launching xframe in the case terminations are judged problematic. The switch keeps the status quo by default. (cherry picked from commit 87f4aa88) Change-Id: I2ac25d925891a00bd86f9006dd1ccae9790729d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5987311 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1377664} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992053 Reviewed-by:
Harry Souders <harrysouders@google.com> Commit-Queue: Harry Souders <harrysouders@google.com> Owners-Override: Harry Souders <harrysouders@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1735} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Kent Tamura authored
This reverts commit 45fbd32d. Reason for revert: crbug.com/376720481 Original change's description: > FindRuby: Enable the feature by default > > Bug: 40755728 > Change-Id: I31b895035b54911c5560294f9da3af5dfdbbdc86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5897147 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by:
Koji Ishii <kojii@chromium.org> > Auto-Submit: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1361656} (cherry picked from commit 3be92225) Bug: 40755728, 376720481 Change-Id: I22df1f46f89bace0339616529c066f19ed3332ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981456 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by:
Mason Freed <masonf@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1376665} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993935 Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1734} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
François Doray authored
DocumentResourceCoordinator is cleared in Document::Shutdown and shouldn't be recreated afterwards. Today, a MediaStreamTrackImpl creates a SchedulingAffectingFeatureHandle when it becomes "ready", which notifies the Document's DocumentResourceCoordinator that WebRTC is in use. This handle may be deleted in the destructor of MediaStreamTrackImpl, which may run after the Document is detached. This recreates a DocumentResourceCoordinator and notifies it that WebRTC is no longer in use. This triggers a CHECK failure, because that DocumentResourceCoordinator was never notified that WebRTC was in use. Not recreating the DocumentResourceCoordinator when the Document is detached resolves the issue. MediaStreamTrackImpl should probably always delete its SchedulingAffectingFeatureHandle before its destructor runs, as it is perilous for a garabage-collected object to do work in its destructor, but that will be addressed in a separate CL. This CL is kept as simple as possible to make a merge possible. (cherry picked from commit 23008251) Bug: 375923380 Change-Id: I14d7c49f44ad25a877f3b9fc90214990b82b98ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979265 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1377606} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994550 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1733} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730826433-bb2af483627f27c004345df040048cba650600d4-ba434498.profdata to chrome-android64-6778-1730827753-eaf303d288982314aa95f1d1b05eb1d12fe2d17a-2a65fd33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I4cf26823b4c980f312a6a46b49d42c2e7357fcf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994612 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1732} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-6778-1730807803-f642dfdd1a16bb55122a82a546b7e83ce7753fa5-6614ce9f.profdata to chrome-linux-6778-1730827753-7ae6d11df2a61c928a8931358ca406168fbd8775-2a65fd33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I557ed7e38abdc4c84027b736cebedb71b08000d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994126 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1731} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1730822386-93e11a74ca52fa815e3aea511903b0bdcadcfee8-2b5d0fbc.profdata to chrome-mac-arm-6778-1730827753-58e3318950c4d036e3c14819e1880edd1e9b4ae3-2a65fd33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I90dbc4cbd797a1a64a894276db5f2904db47d585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994147 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1730} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Guillem Perez authored
This CL adds a nullability check to ensure the checks return early before the TemplateURLService null pointer is used. Bug: 377181060 Fixed: 377325315 Change-Id: Iae117962e7d2fc3d12f9443f8456e5d369015dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988299 Auto-Submit: Guillem Perez <guiperez@google.com> Reviewed-by:
Harry Souders <harrysouders@google.com> Commit-Queue: Harry Souders <harrysouders@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1729} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730824134-9f68b734e18e113997c8aa008a27363941f5c9da-f91de1e1.profdata to chrome-android64-6778-1730826433-bb2af483627f27c004345df040048cba650600d4-ba434498.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I86fa6a804733097be9438320c5ba4ae506ca94a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994476 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1728} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Moe Ahmadi authored
Bug: 368416476, 377365383 Change-Id: I1b7d55057ad180bc12b0d7efe098afbe30785e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991370 Reviewed-by:
Mickey Burks <mickeyburks@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#1727} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Shu Yang authored
The PdfPage may become a FrozenNativePage while downloading. Need to check before cast to PdfPage. (cherry picked from commit a859c025) Low-Coverage-Reason: TRIVIAL_CHANGE Bug: 377305897 Change-Id: I4eefe7de95e344a07ede7c94babe3352d626f229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5985554 Commit-Queue: Shu Yang <shuyng@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1377765} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989896 Cr-Commit-Position: refs/branch-heads/6778@{#1726} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Min Qin authored
back/forward button on PDF the callback is moved, so changing the code order to avoid using a null cb (cherry picked from commit 6567bbee) Low-Coverage-Reason: TRIVIAL_CHANGE Bug: 377301543 Change-Id: I296466d6873e7f2edf9746717585273670e0ce5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988331 Reviewed-by:
Shu Yang <shuyng@google.com> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1377757} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989723 Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shu Yang <shuyng@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#1725} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-6778-1730785877-8a12bfed7df863d8babe1203ca0741f802c827fc-99842a97.profdata to chrome-win32-6778-1730807803-2484a938bf99122f7c44d82005a9f803d4104bd6-6614ce9f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id7dfd7dc7cedafcfdae01994966ed9fda62c8c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993169 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1724} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730820938-b205e08f263561572b8f4126b8adcd7f937fb925-e379c924.profdata to chrome-android64-6778-1730824134-9f68b734e18e113997c8aa008a27363941f5c9da-f91de1e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib50e4cb5ff86daa42eb39f2c77b65ba88d9f4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994138 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1723} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
ChromeOS bot authored
Uploaded by https://ci.chromium.org/b/8732148788850418385 Change-Id: Iee6c56e80556dd73d43af3130f676b2cebb80221 CrOS-LKGM: 16063.24.0 Cr-Original-Build-Id: 8732148788850418385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994151 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1722} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1730811735-c7b5491c082bf0ab3c5de06333197453c4db9ebf-7edfdc62.profdata to chrome-mac-arm-6778-1730822386-93e11a74ca52fa815e3aea511903b0bdcadcfee8-2b5d0fbc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Icce114a2c13268f59e17ee4d60338d68c3922e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994411 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1721} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730818818-7e1487ce161d4d0bc31165fda2fc46037fa572c7-73e7231e.profdata to chrome-android64-6778-1730820938-b205e08f263561572b8f4126b8adcd7f937fb925-e379c924.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I79794f4f625f5b691233ac10a8323ce0f16896e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994137 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1720} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Aaron Leventhal authored
This condition actually occurs only on Mac, because it is the only platform that needs to use MarkDocumentDirty() when aria-modal dialogs are created or destroyed. There is no real additional cost to keep the code for all platforms. Will do test as a follow-up. Repro is to load pepboys.com and continually click on "Your store" on the right side of the toolbar. (cherry picked from commit f2eb83b5) Fixed: 372508699,375669433 Change-Id: I524479e035d27e6118a53fdccef77fc9ad5d7dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979112 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1376030} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981914 Cr-Commit-Position: refs/branch-heads/6778@{#1719} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Benoît Lizé authored
(cherry picked from commit be420047) Bug: 366424215 Change-Id: I68a9b53ea4cdd002672ab565ef8531d0c7266456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961724 Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1373336} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993503 Commit-Queue: Egor Pasko <pasko@chromium.org> Auto-Submit: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#1718} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1730815371-4856ad4c715eed0f789d6e7f98947c04eab372c6-1db674df.profdata to chrome-android64-6778-1730818818-7e1487ce161d4d0bc31165fda2fc46037fa572c7-73e7231e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I124b44e76e48b964df4f320b77541da980adb389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994114 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#1717} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-