- Sep 23, 2009
-
-
estade@chromium.org authored
BUG=22372 Review URL: http://codereview.chromium.org/211056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26890 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=dank BUG=22702 TEST=Linux valgrind bots Review URL: http://codereview.chromium.org/222001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26889 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=paul BUG=None TEST=Webkit Mac10.5 Debug Review URL: http://codereview.chromium.org/219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26888 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
I didn't update the big_test although I'm happy to do that in another CL. I changed the CB renderer code to use this. The only place I didn't is the state handling code. I'll consider changing that in another CL. I changed DoCommand so it gets passed the entire command data including the command itself where as it used to get passed the command buffer entry after the command. I wanted to put the commands into the structures as I think it makes them easier to use since they can then correctly set their header. I could have left DoCommand as is but there would have been a lot of funky pointer math and I thought this change made it cleaner. Some questions I had while doing this. There are a few places in the code that use unsigned int instead of uint32. It seems we should use uint32 because unsigned int is not guarnteed to be 32bits. So for example ResourceID is unsigned int right now. The CMD::Set/CMD::Init/CommandBufferHelper commands are currently fairly untyped. For example DESTROY_TEXTURE takes a uint32 id. Should it take a ResourceID instead? DRAW should maybe take an enum for primitive_type? If we decide to do that I'd like to do it in another CL. There's no checking for overflow. We could add a bunch of DCHECK like DCHECK_LE(width, 65536) or DCHECK_LE(semantic_index, 16). I'd like to do those in another CL as well as I think we need to discuss what commands we want to change. All the code is in .h files because we want all of this code to inline. Theoretically this should be just as efficient as poking values into arrays in the opt builds. Review URL: http://codereview.chromium.org/212018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26886 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
the number of skipped results on sharded builders. This has been true forever. I'll have a partial fix for that in a separate change. This time, the data format is really done and ready to be turned into pretty graphs. The data for each row in this table is created as an array, then getHTMLForTableRow is called. The graph version of this should be able to just rewrite getHTMLForTableRow to use canvas instead. Review URL: http://codereview.chromium.org/208062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26885 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=nsylvain BUG=22711 TEST=Selenium test bot Review URL: http://codereview.chromium.org/212054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26884 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 22, 2009
-
-
stuartmorgan@chromium.org authored
TBR=paul BUG=None TEST=Linux webkit dbg Review URL: http://codereview.chromium.org/215061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26882 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
TBR:paulg BUG:22702 Review URL: http://codereview.chromium.org/212052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26881 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
the product dir. Review URL: http://codereview.chromium.org/210044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26880 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
August 3rd rev 22348. The scary thing is that's a little hard to believe it's been broken that long and no one noticed so I hope this is the correct fix but it does appear to be wrong. The '/'s that were removed are used in a string concat in the HTML templates. Sometimes they need to be '' and sometimes 'folder/' so that urls become http://foo/bar.html or http://foo/folder/bar.html Review URL: http://codereview.chromium.org/213033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26879 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=dank BUG=22702 TEST=Mac and Linux valgrind bots Review URL: http://codereview.chromium.org/214059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26874 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=To be created. TEST=Covered by layout tests. Review URL: http://codereview.chromium.org/207064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26873 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Keep TIMEOUT for Windows. TBR=dumi BUG=21442,22296,19766 TEST=N/A Review URL: http://codereview.chromium.org/207063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26872 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
See o3d/command_buffer/service/cross/cmd_buffer_engine.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/207061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26871 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
full-screen changes in http://codereview.chromium.org/210005 . Call CComControlBase::IOleInPlaceObject_SetObjectRects directly as the superclass implementation of CHostControl::SetObjectRects. Review URL: http://codereview.chromium.org/216055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26870 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=dumi BUG=21442,22296,19766 TEST=N/A Review URL: http://codereview.chromium.org/217023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26869 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=22696 TEST=Covered by ui_tests. Review URL: http://codereview.chromium.org/211053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26868 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/217018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26865 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
why we're not going to implement some. BUG=none TEST=none Review URL: http://codereview.chromium.org/207057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
Remove potential for command-key equivalents to beat the file menu fix-up timer by clearing the command keys for close tab/window before we fire the timer. BUG=16689 TEST=cmd-w closes tabs/windows correctly based on number of tabs in the window and if the window is a browser window. Also comment 16 in the bug. Review URL: http://codereview.chromium.org/215056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26862 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/210027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26860 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=none. Test=Covered by layout tests. Review URL: http://codereview.chromium.org/208065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26859 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CID=6212 BUG=none TEST=none Review URL: http://codereview.chromium.org/208051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26858 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
Added support for registering additional shared memory objects (textures and buffers etc) with the CommandBuffer. TEST=none BUG=none Review URL: http://codereview.chromium.org/216043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26857 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Eliminate a bunch of color conversions. I was going to try and clean up the code for these but discovered to my surprise that no one actually uses them. Also clean up a few other things, like my AlphaBlend() function using hex alpha values where everyone else uses decimal, or unnecessary global qualifiers, or needlessly long code. I avoided changing postincrement to preincrement :D BUG=none TEST=none Review URL: http://codereview.chromium.org/214054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26856 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
BUG=21442 TEST=none Review URL: http://codereview.chromium.org/203074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26855 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
and SSLCertRequestInfo, simply declaring the forward class definition is not enough to include this header. This header is really dependent on those two class definitions. BUG=none TEST=none Review URL: http://codereview.chromium.org/216032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26854 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark BUG=17360 Review URL: http://codereview.chromium.org/216052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26853 0039d316-1c4b-4281-b951-d872f2087c98
-
dank@chromium.org authored
add a couple new suppressions, widen a couple others, all found on a -O1 -fno-inlining big-redzone fishing expedition on mac 'caliban'. BUG=11134,20541,20459,20653,22450,22519 TEST="sh tools/valgrind/shard-all-tests.sh base_unittests net_unittests ui_tests unit_tests" on mac pro overnight Review URL: http://codereview.chromium.org/212028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26851 0039d316-1c4b-4281-b951-d872f2087c98
-
dank@chromium.org authored
If https://bugs.kde.org/show_bug.cgi?id=208197 is ever fixed, we can get rid of the patch and change the redzone size with a commandline option instead. Install to /usr/local/valgrind-10880-redzone to make it easier to tell which machines have the updated valgrind. Add DIRNAME variable to valgrind build script to simplify changing name of tarball/build dir/install dir. Also give -f option to mv because macosx's mv is timid about overwriting symlinks. Review URL: http://codereview.chromium.org/216048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26849 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The behavior was broken in r20876. BUG=18749 TEST=window.print() on a subframe works. Review URL: http://codereview.chromium.org/206033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26847 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
- Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758 Review URL: http://codereview.chromium.org/211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
Review URL: http://codereview.chromium.org/209023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26845 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
There is one appcache service per profile and several request context per profile. The profile holds a reference to the appcache service. Those request contexts which are subject to retrieval from appcaches hold a reference to the appcache service too. The appcache service is provided with a pointer back to the 'main' request context, this context is used when updating appcaches. Initialization is a little tricky because profiles can't be used on the IO thread and request contexts can't be used on the UI thread. BUG=22597,22125 TEST=many existing tests exercise profile/context creation Review URL: http://codereview.chromium.org/215024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26844 0039d316-1c4b-4281-b951-d872f2087c98
-
kathyw@google.com authored
Besides the usual code.google.com analytics, there's also an account for just Chrome-related docs. Also deleted some end-of-line spaces to avoid presubmit errors. TBR=rafaelw Review URL: http://codereview.chromium.org/209067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26843 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
These keep causing bogus automatic tree closures. BUG=21538,22666 TEST=N/A Review URL: http://codereview.chromium.org/209068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26841 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=None. TEST=Covered by layout tests. Review URL: http://codereview.chromium.org/212042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26840 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/215047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26839 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
Review URL: http://codereview.chromium.org/207056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26838 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
Review URL: http://codereview.chromium.org/209026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26837 0039d316-1c4b-4281-b951-d872f2087c98
-