- Apr 30, 2010
-
-
willchan@chromium.org authored
Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This should have made it in with http://codereview.chromium.org/1758004/show (note change to RenderView) which is in anticipation of a webkit patch to actually change the ChromeClient to use the new signature. Review URL: http://codereview.chromium.org/1695027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46024 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadt@chromium.org authored
mode, shutdown and restart the new instance. This is already done for Windows, this CL enables the functionality for Linux. We don't yet have a unit test for this. Local testing is done by: 1) Reducing the timer to 30 seconds. 2) Changing BrowserList::IsInPersistentMode to return true. 3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval. 4) Running "touch" command on chrome exe to pretend there is an update. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1633021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
instructions at the bottom of the page. BUG=none TEST=ran pool sample Review URL: http://codereview.chromium.org/1706020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46022 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
The goal of this refactoring is to allow splitting the different parts of the NTP into different reusable components. BUG=None TEST=Manually Review URL: http://codereview.chromium.org/1695022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46021 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
The name of a test file was not correct. BUG=41563 TEST=unittest Review URL: http://codereview.chromium.org/1792011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46020 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
BUG=none TEST=ran built pool sample TBR=petersont Review URL: http://codereview.chromium.org/1812006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46019 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
TEST=conformance tests don't crash. BUG=none Review URL: http://codereview.chromium.org/1697018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46018 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
TEST=unit test BUG=42859 Review URL: http://codereview.chromium.org/1806003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46017 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
needed for WebGL asset conversion. BUG=none TEST=built on Windows TBR=gman Review URL: http://codereview.chromium.org/1755019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46016 0039d316-1c4b-4281-b951-d872f2087c98
-
- Apr 29, 2010
-
-
willchan@chromium.org authored
BUG=42897 Review URL: http://codereview.chromium.org/1748018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46014 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46013 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
by enumerating all files needing to be copied. BUG=none TEST=built on Windows TBR=gman Review URL: http://codereview.chromium.org/1695030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46012 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
compiler. BUG=none TEST=ran o3d-webgl pool on Windows with NVIDIA hardware already reviewed=petersont Review URL: http://codereview.chromium.org/1748017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46010 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
Review URL: http://codereview.chromium.org/1745004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46009 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
objects and their associated shared memory segments. This avoids a shared memory leak and file descriptor leak. BUG=38383 TEST=Using test_chrome_fd_leak from bug 38383 and lsof, the renderer process should not show an fd leak on Mac or Linux. Review URL: http://codereview.chromium.org/1703017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46007 0039d316-1c4b-4281-b951-d872f2087c98
-
feldstein@chromium.org authored
Originally we were clearing the dragData member in a few places, including experimental.bookmarkManager.onDrop. This was triggered before the javascripts drop event so when it got to that point to drop a valid bookmark, it had already cleared itself out. Now it just posts a task with 0ms delay to let the real drop event handle the data before clearing it. Also clear the data on mouse up, which wasn't being handled in the case where you drag an element just a tiny bit, and no action is performed. BUG=none TEST=Ensure you can still drop stuff in the bmm Review URL: http://codereview.chromium.org/1780015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46006 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
Code is untested. From gChat: me: do you have a good test I can use to make sure mac impl of ui_controls for sending events works OK? Or would you prefer I send you CLs to play with and we iterate by hand? Joe: I would like the CL to play with to see if I can get it to work with the code I wrote Warning to Joe: mouse moved events currently use the Mac coordinate frame (0,0 is bottom-left not top-left). That's easy to switch; I'd like to do whatever is easiest to get WebDriver working. BUG=26102 Review URL: http://codereview.chromium.org/1701006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46005 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/1736006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46004 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
conversion step always occurs before the copying step, which fixes a build problem on Windows. Worked around a gyp issue on Windows to properly convert both the plugin and WebGL versions of a couple of the assets. BUG=none TEST=built on Windows TBR=gman Review URL: http://codereview.chromium.org/1801008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46002 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@chromium.org authored
GFE and the SPDY spec both require lower-case headers, so I've updated the Chrome SPDY stack and the unit tests to use lower-case x-associated-content. Also fixes a bug in SpdyStream::DoReadBody that breaks push streams in certain situations (they never get their body data). Landing for Matthew Lloyd (mlloyd@google.com) BUG=none TEST=SpdyNetworkTransactionTest.ServerPush Review URL: http://codereview.chromium.org/1755017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46000 0039d316-1c4b-4281-b951-d872f2087c98
-
kathyw@chromium.org authored
TBR=rafaelw BUG=none TEST=none Review URL: http://codereview.chromium.org/1783012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45999 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
Some users have a small sparsely separated enumerated list of plausible samples which don't fit well into a default (log space) histogarm, or a consistently spaced (LinearHistogram). This implementation does not yet support renderer histograms of this sort, but it at least unblocks the dependent bug that needs support for these sparse histograms in the browser. The bulk of this patch was written by Raman Tenetti, in CL 1706012. BUG=40953 r=eroman Review URL: http://codereview.chromium.org/1737017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45998 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
Adjust Mac 10.6 intl1 expectations. Improvement maybe from WebKit roll and changes upstream around r45865. xp-dual/moz/total_byte_* regressed in r45424. BUG=42841,42882 TEST=xp-dual/moz/total_byte_* is green, Mac10.6 intl1 page cycler is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1759018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45997 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=42880 Review URL: http://codereview.chromium.org/1784011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45996 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
Empty searches are not shown now, instead we go to "Bookmarks bar" folder. Clicking the logo button clears the search and takes the user to the "Bookmarks bar" folder. BUG=None TEST=See above Review URL: http://codereview.chromium.org/1816001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45995 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
dir name "history" is not the same as "History" on linux, though it is on Mac on which I tried first. :( TEST=python chrome/test/functional/history.py Review URL: http://codereview.chromium.org/1789009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45994 0039d316-1c4b-4281-b951-d872f2087c98
-
petersont@google.com authored
Review URL: http://codereview.chromium.org/1703014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45993 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=42877 Review URL: http://codereview.chromium.org/1763021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45992 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
Remove accidental #if's. Make old folder window menu go away when mousing over a non-folder bookmark in the bookmark bar. BUG=None. TEST=Pop up a folder bookmark item on the bookmark bar then mouse over a non-folder bookmark and verify that the old folder menu is dismissed. Review URL: http://codereview.chromium.org/1752020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45991 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Added third_party/angleproject to SPECIAL_CASES becuase it is checked-out directly from upstream. FYI licenses.py is still complaining about missing README.chromium for SPECIAL_CASES. Review URL: http://codereview.chromium.org/1712014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45989 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/1712020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45988 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
testDownloadNoHistory,testRedirectHistory -- from Deepak. Also, move _DownloadAndWaitForStart (re-used by the new tests) to a common location. TEST=python chrome/test/funtional/history.py Review URL: http://codereview.chromium.org/1702010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45987 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
Changing linux platform for chromeos. This involved moving platform_util and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/1705009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=42866 Review URL: http://codereview.chromium.org/1790008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45984 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://resources/images/arv@chromium.org authored
This fixes a bug where we would have missing images in the bookmark manager. BUG=42817 TEST=Open the bookmark manager. No icons should be missing. Review URL: http://codereview.chromium.org/1697017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45983 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
BUG=42698 TEST=per bug. Might want to re-test dragging single tabs and dragging tabs out when there are pinned tabs (not phantoms). Review URL: http://codereview.chromium.org/1727013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45982 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
initial value for kHomePageIsNewTabPage. BUG=42669 TEST=TwoClientLivePreferencesSyncTest.Sanity Review URL: http://codereview.chromium.org/1801006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45979 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
The documentation states that we can't pass NULL as the fourth parameter to png_set_write_fn(). BUG=28399 TEST=none Review URL: http://codereview.chromium.org/1759016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45978 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This makes "./out/Debug/test_shell path/to/file.html" do the right thing. In theory I should use URLFixerUpper but that's deep inside chrome/browser/; this is simple enough anyway. Review URL: http://codereview.chromium.org/1711024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45977 0039d316-1c4b-4281-b951-d872f2087c98
-