BUG=http://code.google.com/p/chromium-os/issues/detail?id=8641
TEST=Disable cellular; enable cellular; activate cellular network. Verify no crash.

Review URL: http://codereview.chromium.org/4374003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crosbug.com/8458
TEST=Manual

Review URL: http://codereview.chromium.org/4324001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64901 0039d316-1c4b-4281-b951-d872f2087c98

Added handling of network ("service" in flimflam parlance) property changes. 
NetworkLibrary updates its Network objects in response to property changes, 
then calls any NetworkObservers that have registered for the given network. 

Use the is_active member of Network in various places to ensure that we are 
dealing with the correct network. 

Created separate observer classes for NetworkManager, Network, and 
CellularDataPlan, so that monitors can be established independently for each 
of them. Changed the callback method names to prepend "On", i.e., 
OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. 

Wired up signal strength update and network technology update in the status 
bar, network dropdown menu, and internet settings page. 

Added new icon badges for 1xRTT radio technology. These are used when EVDO 
coverage switches to 1xRTT. Just as is the case for the 3G icons, there are 
three 1x icons: normal, warn, and error. Please consider these icons to be 
placeholders if the UI folks think they need to be redesigned. 

Centralized choosing of the network technology badge in 
NetworkMenu::BadgeForNetworkTechnology. 

BUG=chromium-os:5612:chromium-os:7619,chromium-os:5917,chromium-os:4674 
TEST=Extensive manual testing with different combinations of wi-fi and 
cellular networks connected and disconnected. Used a modified version 
of flimflam that randomly changes reported signal strength, network 
technology, and roaming state, and verified that the UI correctly reflected 
current values for the active network (roaming is not handled in the UI 
at this time).
Review URL: http://codereview.chromium.org/4235005

TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/4229006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64889 0039d316-1c4b-4281-b951-d872f2087c98

Added handling of network ("service" in flimflam parlance) property changes. 
NetworkLibrary updates its Network objects in response to property changes, 
then calls any NetworkObservers that have registered for the given network. 

Use the is_active member of Network in various places to ensure that we are 
dealing with the correct network. 

Created separate observer classes for NetworkManager, Network, and 
CellularDataPlan, so that monitors can be established independently for each 
of them. Changed the callback method names to prepend "On", i.e., 
OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. 

Wired up signal strength update and network technology update in the status 
bar, network dropdown menu, and internet settings page. 

Added new icon badges for 1xRTT radio technology. These are used when EVDO 
coverage switches to 1xRTT. Just as is the case for the 3G icons, there are 
three 1x icons: normal, warn, and error. Please consider these icons to be 
placeholders if the UI folks think they need to be redesigned. 

Centralized choosing of the network technology badge in 
NetworkMenu::BadgeForNetworkTechnology. 

BUG=chromium-os:5612:chromium-os:7619,chromium-os:5917,chromium-os:4674 
TEST=Extensive manual testing with different combinations of wi-fi and 
cellular networks connected and disconnected. Used a modified version 
of flimflam that randomly changes reported signal strength, network 
technology, and roaming state, and verified that the UI correctly reflected 
current values for the active network (roaming is not handled in the UI 
at this time).
Review URL: http://codereview.chromium.org/4235005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8193
TEST=manual
Review URL: http://codereview.chromium.org/4237001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64808 0039d316-1c4b-4281-b951-d872f2087c98

Rewritten parts of NetworkLibrary to work around memory corruption that prevented proper dbus functioning for 3G actrivation.

The principle behind this change is pretty simple - there is only one instance of chromeos::Network specialization representing a network service at the time. Please note that there are parts of obsolete UI elements where object copies were still made. 

The cellular plan part is still work in progress, but there is enough to be reviewed now so I want to get an early start right now.

BUG=chromium-os:7619
TEST=none

Review URL: http://codereview.chromium.org/4169001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64445 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/4136002/show

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8114
TEST=All of the network menu

Review URL: http://codereview.chromium.org/4210002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64268 0039d316-1c4b-4281-b951-d872f2087c98

This includes some cleanup of the network_menu code to work with or without DOMUI menus.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8114
TEST=All of the network menu

Review URL: http://codereview.chromium.org/4136002

TBR=stevenjb@chromium.org
Review URL: http://codereview.chromium.org/4200008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64193 0039d316-1c4b-4281-b951-d872f2087c98

This includes some cleanup of the network_menu code to work with or without DOMUI menus.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8114
TEST=All of the network menu

Review URL: http://codereview.chromium.org/4136002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8158
TEST=manually

Review URL: http://codereview.chromium.org/4102003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64006 0039d316-1c4b-4281-b951-d872f2087c98

Cleaned up hacks for positioning statusbar icons.
Changed network connecting animation to fading in and out of network bars.
BUG=chromium-os:8135
TEST=manual
Review URL: http://codereview.chromium.org/4154002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63984 0039d316-1c4b-4281-b951-d872f2087c98

Merge 63135 - Update icons to show lowdata and very lowdata for 3G data.
BUG=chromium-os:5608
TEST=manual
Review URL: http://codereview.chromium.org/3748005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63155 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be repsonsible for a compile failure.

BUG=chromium-os:5608
TEST=manual
Review URL: http://codereview.chromium.org/3748005

TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/3923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5608
TEST=manual
Review URL: http://codereview.chromium.org/3748005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63135 0039d316-1c4b-4281-b951-d872f2087c98

Changed lookups based on name to use service_path instead.
Added wifi_network() and cellular_network() to network_library and removed wifi_name, wifi_strength, celular_name, cellular_service_path, and cellular_strength to simplify API.

BUG=chromium-os:5495
TEST=Network menu tests. Set up two networks with the same name, one encrypted and one not. Confirm that all operations on each work as expected.

Review URL: http://codereview.chromium.org/3744009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62839 0039d316-1c4b-4281-b951-d872f2087c98

Also modified NetworkMenu::ActivatedAt to use ConnectToNetworkAt() to reduce duplicated logic.

BUG=chromium-os:7343
TEST=Test network menu

Review URL: http://codereview.chromium.org/3796008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62822 0039d316-1c4b-4281-b951-d872f2087c98

* Added NetworkMenu::UpdateMenu()
* Added NetworkMenu::ConnectToNetworkAt()

BUG=http://code.google.com/p/chromium-os/issues/detail?id=7343
TEST=Test the network menu (it still looks ugly). Specifically, selecting a non secure network, or one with a certificate installed should connect to it. Also, temporarily, using 'space' or 'return' to select a network should connect to it without closing the menu.

Review URL: http://codereview.chromium.org/3678006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62598 0039d316-1c4b-4281-b951-d872f2087c98

Implement the network menu as a subclass of MenuUI (c++) and Menu (js).

BUG=chromium-os:7343
TEST=Test that the network menu is still functional. NOTE: With this CL, the menu won't look pretty, and it still has the old behavior. There will be a followup CL that will fix the UI.

Review URL: http://codereview.chromium.org/3675002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:7216
TEST=Verify all windows/dialogs use new bubble design, e.g. JS dialog, page info window, certificate view, extension install confirmation, save as dialog etc.

Review URL: http://codereview.chromium.org/3538012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:7273
TEST=none

Review URL: http://codereview.chromium.org/3526020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:7100
TEST=Boot device. On "Select network" screen click on the network
selection combo box. The networks menu that will appear has the same
width as combo box itself.

Review URL: http://codereview.chromium.org/3586005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61173 0039d316-1c4b-4281-b951-d872f2087c98

This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497)

Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3533001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:4023, chromium-os:4117, chromium-os:4117
TEST=Manual test first OOBE screen

Review URL: http://codereview.chromium.org/3166028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57234

Review URL: http://codereview.chromium.org/3158014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58526 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r57234

TBR: stevenjb

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).

Review URL: http://codereview.chromium.org/3158014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57234 0039d316-1c4b-4281-b951-d872f2087c98

If ethernet is not available (i.e. no wired nic), don't show ethernet in status menu, about:networks, and options pages.
Also fixed a small issue where we should not be displaying "Other..." if wifi is disabled.
BUG=chromium-os:5570
TEST=manual
Review URL: http://codereview.chromium.org/3108011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55915 0039d316-1c4b-4281-b951-d872f2087c98

We are no longer using the code. If we decide that we need it later, we will likely do something different.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3084027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55432 0039d316-1c4b-4281-b951-d872f2087c98

ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.

In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98

Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke 
it before retrieving/displaying network information, so that we 
successfully display data that the user has just changed via another 
mechanism. 
BUG=chromium-os:3972 
TEST=Configure certificates via entd and log out. Log back in and select the 
network menu, then (immediately) the relevant SSID. Check for the proper 
certificate information, rather than unset fields.
Review URL: http://codereview.chromium.org/3019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53227 0039d316-1c4b-4281-b951-d872f2087c98

Fix ChromeOS reliance on implicit ordering of resource IDs.  This was supposed to have landed before/with r51906, but accidentally got separated.

BUG=CROS4759
TEST=Wifi status indicator reads correctly above 80%
TBR=chocobo


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52149 0039d316-1c4b-4281-b951-d872f2087c98

Made certificate_path_ a string instead of a FilePath.
Modify ConnectToWifiNetwork to take std::string.
BUG=None
TEST=manual

Review URL: http://codereview.chromium.org/2869019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51290 0039d316-1c4b-4281-b951-d872f2087c98

Issue 2848016: Store wifi network in network_menu_button.cc as a path instead of as a struct.
Store wifi network in network_menu_button.cc as a path instead of as a struct. 
This should address a potential edge case where wifi network information gets updated after the menu is opened and before a network is selected. 

BUG=None 
TEST=None
Review URL: http://codereview.chromium.org/2817036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51064 0039d316-1c4b-4281-b951-d872f2087c98

- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.

This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50854 0039d316-1c4b-4281-b951-d872f2087c98

- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.

This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2825018

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2811032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98

- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.

This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2825018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98

Pass default profile and correct top window in OOBE.

BUG=http://crosbug.com/2978
TEST=On welcome screen select encrypted 802.1X network and open "select certificate" dialog. It should open withot crash.

Review URL: http://codereview.chromium.org/2053001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47125 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ran browser tests and also manually made sure everything still works.
Review URL: http://codereview.chromium.org/2010001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46598 0039d316-1c4b-4281-b951-d872f2087c98

for creating a different animation subclass (which you'll see
shortly).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1961001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46433 0039d316-1c4b-4281-b951-d872f2087c98

WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any. 
Pass these values down the stack into ConnectToWifiNetwork(). 

TEST=Compiles and login dialog shows new fields when security is 802.1x.
BUG=none
TBR=njw
Review URL: http://codereview.chromium.org/1692005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45229 0039d316-1c4b-4281-b951-d872f2087c98