git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35787 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/523138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=BlacklistTest.QueryStringMatch

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35785 0039d316-1c4b-4281-b951-d872f2087c98

http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2628/steps/browser_tests/logs/Storage

http://chrome-buildbot.corp.google.com:8010/builders/XP%20Tests%20(dbg)(4)/builds/2604/steps/browser_tests/logs/Storage

ExtensionApiTest.Storage:
Got EXTENSION_LOADED notification.
Got EXTENSION_HOST_DID_STOP_LOADING notification.
C:\b\slave\chromium-dbg-builder\build\src\chrome\test\in_process_browser_test.cc(293): error: Test timed out. Each test runs for a max of 30000 ms (kInitialTimeoutInMS).
C:\b\slave\chromium-dbg-builder\build\src\chrome\browser\extensions\extension_storage_apitest.cc(8): error: Value of: RunExtensionTest("storage")
  Actual: false
Expected: true
No response from message loop.

BUG=22006
TBR=lzheng,japhet

Review URL: http://codereview.chromium.org/525110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35784 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35783 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/524068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35781 0039d316-1c4b-4281-b951-d872f2087c98

occurring sometimes.

Flakiness dashboard
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/editing/inserting/12882.html

BUG=31803
TBR=lzheng,japhet

Review URL: http://codereview.chromium.org/517075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35779 0039d316-1c4b-4281-b951-d872f2087c98

Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host browser (IE) we send over the
response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over to Chrome.

However this API returns session cookies as well as persistent cookies. There is no documented way to return
only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the url request automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie.

When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786

The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they
conflict with similar functions in NACL.

Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight.

Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added
    URLRequestAutomationJob::IsCookiePresentInCookieHeader function

TBR=amit

Review URL: http://codereview.chromium.org/521072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35778 0039d316-1c4b-4281-b951-d872f2087c98

Already fixing work is started for this issue, but since the test hangs
the builder too frequently, I'd like to disable this test until it becomes
stable.

BUG=30307
TBR=lzheng,japhet

Review URL: http://codereview.chromium.org/523160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35777 0039d316-1c4b-4281-b951-d872f2087c98

Move TestURLRequestContextGetter and friends from CookieTreeModelTest and
CookiesWindowControllerTest into TestingProfile. In the TestingProfile, return
a valid CookieMonster and URLRequstContextGetter, if CreateRequestContext() is
called.

Original CL: http://codereview.chromium.org/525072/show

BUG=None
TEST=Covered by unit tests

Review URL: http://codereview.chromium.org/525106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35776 0039d316-1c4b-4281-b951-d872f2087c98

Initially, this test was marked CRASH on WebKit rollout.

And, in this revision, CRASH has been removed, but still crashing.
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?view=diff&r1=35406&r2=35407

BUG=31302
TBR=lzheng,japhet

Review URL: http://codereview.chromium.org/517074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35775 0039d316-1c4b-4281-b951-d872f2087c98

Flakiness dashboard
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/storage/domstorage/localstorage/enumerate-storage.html

BUG=31794
TBR=lzheng,japhet

Review URL: http://codereview.chromium.org/525108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=31360
TEST=LayoutTests/fast/events/keydown-numpad-keys.html

Review URL: http://codereview.chromium.org/518036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35773 0039d316-1c4b-4281-b951-d872f2087c98

Adds a NetworkChangeNotifier dependency to ProxyService; when we observer a network change through the notifier, the ProxyService re-configures itself.

So for example, if you were to switch to VPN and are using a custom PAC URL, we will re-download that URL on the new network.
Similarly if you are using auto-detect PAC settings, we will re-run the autodiscovery steps for the next resolve.

Note that Chromium is still passing a NULL NetworkChangeNotifier dependency into its ProxyService -- until it passes a real implementation, this will not impact Chrome.

BUG=12293
TEST=ProxyServiceTest.NetworkChangeTriggersPacRefetch
Review URL: http://codereview.chromium.org/525104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35772 0039d316-1c4b-4281-b951-d872f2087c98

Linux Builder (ChromiumOS) failed.

http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(ChromiumOS)/builds/2050/steps/compile/logs/stdio

Please add changes to external_cookie_handler_unittest.cc no to break compilation
and reland?

----

Revert 35769 - Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host browser (IE) we send over the
response headers which include the SetCookie header and a list of cookies retreived via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over to Chrome.

However this API returns session cookies as well as persistent cookies. There is no documented way to return
only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the url request automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie.

When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786

The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they
conflict with similar functions in NACL.

Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight.

Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added
     URLRequestAutomationJob::IsCookiePresentInCookieHeader function

Review URL: http://codereview.chromium.org/518054

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/517070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35771 0039d316-1c4b-4281-b951-d872f2087c98

If a URL is requested by the POST method and then the page is
redirected to another URL, NavigationEntry::has_post_data_ is not
cleared correctly with the prior code. So "Confirm form resubmission"
dialog is shown when a user asks reloading the redirected page.


TEST=Add a unit test
BUG=21245

Review URL: http://codereview.chromium.org/524057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35770 0039d316-1c4b-4281-b951-d872f2087c98

Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host browser (IE) we send over the
response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over to Chrome.

However this API returns session cookies as well as persistent cookies. There is no documented way to return
only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the url request automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie.

When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786

The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they
conflict with similar functions in NACL.

Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight.

Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added
     URLRequestAutomationJob::IsCookiePresentInCookieHeader function

Review URL: http://codereview.chromium.org/518054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35769 0039d316-1c4b-4281-b951-d872f2087c98

 Spoke too soon. It's still crashing.

This reverts commit 005f42a518774136337cd4be88431f21c50aba68.

BUG=chromium-os:1010
TEST=None
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/518077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35768 0039d316-1c4b-4281-b951-d872f2087c98

Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and EmptyGURL(), since the code in question can just use the default constructor.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Run sync_unit_tests

Review URL: http://codereview.chromium.org/526002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35765 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/527024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35764 0039d316-1c4b-4281-b951-d872f2087c98

We should not return the raw Google Update branch code if we fail to determine what branch we are on. We should just assume stable.

We should also not add the branch code information to the version string, since it needs to be parsable by Version object. If we append the raw branch code, it might contain dots, which confuses the parsing done by the Version object.

BUG=31772
TEST=Change your branch code to something like 3.0-dev or 2.0-dev-somerandomstring. Chrome should not crash when you open the About box.
Review URL: http://codereview.chromium.org/523151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35763 0039d316-1c4b-4281-b951-d872f2087c98

if the server doesn't provide a strong validator.

We require:
- A strong etag or a strong last modified date.
- The total Content length.
- Lack of an explicit rejection of ranges (Accept-ranges: none) 

This aligns better with the conditions used by Firefox.

BUG=30220, b/2329250
TEST=unittests

Review URL: http://codereview.chromium.org/517043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35761 0039d316-1c4b-4281-b951-d872f2087c98

This should make it run on reliability on Valgrind UI test bots where the previous grouping was running near the max timeout per test.

Review URL: http://codereview.chromium.org/521049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35760 0039d316-1c4b-4281-b951-d872f2087c98

We were hitting a stack overflow on renderer startup, because of the following:
When we patch out syscalls, we need a scratch space near (within a 32-bit jump)
of the original code.  We pick the scratch space as the end of the nearest empty
region available before the code we're patching.  For the vdso region, the
stack lies directly before it and so the region we'd grab was directly before
the stack.  This meant that as soon as the stack attempted to grow it'd fail
because it ran into our patch region, and we'd hit a stack overflow.

The fix is to specially note when we're near the stack region, and instead put
our scratch space as far away from the stack as possible.

Review URL: http://codereview.chromium.org/518071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35759 0039d316-1c4b-4281-b951-d872f2087c98

Added an application framework for demos. This framework currently only supports stand-alone apps. It will be extended to support trusted pepper and untrusted nacl apps.
BUG=26099
Review URL: http://codereview.chromium.org/525083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35758 0039d316-1c4b-4281-b951-d872f2087c98

the browser with OOM.

BUG=20233
TEST=NONE

Review URL: http://codereview.chromium.org/523088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35757 0039d316-1c4b-4281-b951-d872f2087c98

These are all due to http://trac.webkit.org/changeset/52947.

TBR=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/525103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35756 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/523152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35755 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/changeset/52947 created some redness, but all are rebaselines.

TBR=johnnyg
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/523150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35754 0039d316-1c4b-4281-b951-d872f2087c98

Still causes redness on the reliability bot.

The code would crash if multiple PageContents notifications
were received rapidly.  The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unittests to validate these cases in web_contents_unittest.cc.

Note that patch set 1 is the original patch, patch set 2 contains the new changes.

Original review:
http://codereview.chromium.org/492024/show

BUG=30662
TEST=Run the unittests.

Review URL: http://codereview.chromium.org/504051

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/523149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35753 0039d316-1c4b-4281-b951-d872f2087c98

 FindBar is behind other gdk window (i believe the tab content) when re-showing
 and is not visible. This fixed the issue.

BUG=31735
TEST=None

Review URL: http://codereview.chromium.org/519082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35751 0039d316-1c4b-4281-b951-d872f2087c98

All caused due to http://trac.webkit.org/changeset/52904.

TBR=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/523144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35750 0039d316-1c4b-4281-b951-d872f2087c98

Examples of what the logged text looks like:

  "Resolved proxy list: PROXY foobar:6233"
  "Resolved proxy list: DIRECT"
  "Resolved proxy list: PROXY foobar:80;SOCKS5 baz:1080;DIRECT"

Review URL: http://codereview.chromium.org/518042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35749 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/521065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35748 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25440
TEST=SOCKSClientSocketTest.DisconnectWhileHostResolveInProgress

Review URL: http://codereview.chromium.org/525084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35747 0039d316-1c4b-4281-b951-d872f2087c98

between the time we called into the model when the user selected an
item and the time MessageLoop::Quit is processed the menu was
destroyed, we would crash. As MessageLoop::Quit isn't immediate, and
we really don't want to call out from a nested message loop, we wait
until the quit is processed, then notify the model.

CROS_BUG=1108
TEST=see bug

Review URL: http://codereview.chromium.org/521063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35746 0039d316-1c4b-4281-b951-d872f2087c98

the right fix. Current code is correct.

BUG=31132
TEST=none
TBR=oshima

Review URL: http://codereview.chromium.org/523141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35745 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/525101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35744 0039d316-1c4b-4281-b951-d872f2087c98