- Nov 02, 2009
-
-
estade@chromium.org authored
mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show Review URL: http://codereview.chromium.org/354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30726 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
Currently lengthReceived always has the same value as dataLength when Safari calls ResourceHandle::didReceiveData. In Chrome expected content length is passed as lengthReceived parameter which leads to incorrect content length to be stored in InspectorResource. InspectorResource expects lengthReceived to be the length of current data chunk(see InspectorResource::addLength). So I changed lengthReceived parameter to be dataLength. Darin, I see your TODO comment at line 581 in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296 (the comment was deleted later) so I think you are right person to review the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and feel free to leave devtools specific changes to Alex and Pavel. BUG=25213 TEST=DevToolsSanityTest.TestResourceContentLength Review URL: http://codereview.chromium.org/295041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30725 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
It was removed in r30644. Review URL: http://codereview.chromium.org/350011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30724 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=23400 TEST=none Review URL: http://codereview.chromium.org/350012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30723 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
Needed to clear RenderWidgetHost::in_flight_size_ if the renderer crashed. BUG=25097 TEST=RenderWidgetHostTest.ResizeThenCrash Review URL: http://codereview.chromium.org/348025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30722 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Review URL: http://codereview.chromium.org/344045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30721 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Destroy the TaskManagerGtk singleton instance when its window is destroyed, otherwise its treeview will still be getting notifications and trying to manipulate the destroyed treeview. BUG=none TEST=Install an extension, open the task manager, and quit the browser should not result in a GTK error. Review URL: http://codereview.chromium.org/345031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30720 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
BUG=26291 TEST=green Review URL: http://codereview.chromium.org/341068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30719 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/327009thakis@chromium.org authored
BUG=TEST=none Review URL: http://codereview.chromium.org/354009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30718 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@chromium.org authored
Also, introduce (stubbed out) WebAccessibilityController. R=darin TEST=none BUG=24616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30716 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=26489 TEST=Mac UI valgrind bots Review URL: http://codereview.chromium.org/348040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30715 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=9295,8077 TEST=trybots Review URL: http://codereview.chromium.org/340052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30714 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/343075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30713 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
BUG=26319 TEST=none Review URL: http://codereview.chromium.org/342076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30712 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
Patch by Anton Muhin R=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/345040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30711 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
BUG=26486 TEST=none Review URL: http://codereview.chromium.org/353007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30708 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=26279 TEST=see bug Review URL: http://codereview.chromium.org/339092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30707 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=21440 TEST=Open prefs, select 2nd tab. close & reopen prefs window. 2nd tab should still be selected. close & reopen chrome, open prefs. 2nd tab should still be selected. Review URL: http://codereview.chromium.org/352003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30705 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
Review URL: http://codereview.chromium.org/341066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30704 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=none TEST=green linux webkit bots TBR=dglazkov Review URL: http://codereview.chromium.org/351008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30703 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
10.6 loads xibs differently, breaking GTMIBArray TBR=mark@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30702 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
- Get rid of Arial as default - Update non-English font choices (based mostly on Mozilla's choices, <http://mxr.mozilla.org/seamonkey/source/modules/libpref/src/init/all.js> cross-referenced with what's installed with the OS) BUG=http://crbug.com/19135; http://crbug.com/20171 TEST=as in bugs Review URL: http://codereview.chromium.org/335031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30701 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
* Fix the logic in -[SearchEngineListModel defaultIndex]. * Make the test data URLs in SearchEngineListModelTest replaceable, enabling more tests. * Add a test for this bug 21898. TEST=Preferences-->Manage. Add two new search engines. Make the second one default. The list in main Preferences should not have a blank entry. BUG=21898 Review URL: http://codereview.chromium.org/341060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30700 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=none TEST=none TBR=dglazkov Review URL: http://codereview.chromium.org/343077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30699 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
TEST=none BUG=none TBR=dglazkov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30698 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
The test hangs and/or crashes with both Valgrind tools we use. BUG=25917,22608 Review URL: http://codereview.chromium.org/351006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30697 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
- These two pages should now auto size vertically the labels. - The label should be top aligned with controls in the group when the group is taller. - The content should be vertically centered when the label is taller. - All the textfields should always be tall enough to show content. - Radios/checkbox should word wrap to show all their text. - The spacing between groups is a little more even - DEPS roll to pick up newer GTM with GTMIBArray. - A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc. Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment). Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up). TEST=see cl description for what should be working now. BUG=20538 Review URL: http://codereview.chromium.org/340045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30696 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
Roll DEPS for WebKit 50358:50395. Includes build fix for WebGL (fallout from http://trac.webkit.org/changeset/50394). BUG=none TEST=will it blend-er, build? R=kbr Review URL: http://codereview.chromium.org/352002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30695 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=dank Review URL: http://codereview.chromium.org/353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30694 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=Covered by net_unittests. BUG=25023 Review URL: http://codereview.chromium.org/340054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30693 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
This was added erroneously and has never worked, removing. BUG=7271 TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" , tapuz should not be displayed as a search provider. Review URL: http://codereview.chromium.org/346013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30692 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
TBR=darin Review URL: http://codereview.chromium.org/354001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30691 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 TBR=estade Review URL: http://codereview.chromium.org/353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30690 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
BUG=26406 TEST=Compile and see chrome://extensions Review URL: http://codereview.chromium.org/340056 Patch from Ramkumar Ramachandra <artagnon@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30689 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Add the ability for objects which derive from RefCountedThreadSafe to specify a destructor trait. This allows browser objects to specify which thread they're terminated on. The benefit is we avoid the need to do manual ref counting when an object posts tasks to itself on different threads, if an object must be destructed on a specific thread. This patch adds initial support and only shows one example with ResourceMessageFilter. I will do the rest in a follow-up patch to keep things small. BUG=25354 TEST=added unit tests Review URL: http://codereview.chromium.org/338065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30688 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
to an Xcode variable, $(BUILT_PRODUCTS_DIR), which is not a shell variable. The shell tries to treat it as a command expansion. Use ${BUILT_PRODUCTS_DIR} directly. BUG=none TEST=Nico Review URL: http://codereview.chromium.org/353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30686 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
So when you select: "http://www.google.com" The context menu that will appear will be: "Go to http://www.google.com" Instead of: "Search Google for http://www.google.com" BUG=1978 TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it, see if it goes to the desired page. Review URL: http://codereview.chromium.org/326026 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30685 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
Lots of fixes to deal better with the floating bar on the NTP (e.g. chevron resize, chevron enabling only when there is overflow, ...) Move layoutSubviews logic from bookmark_bar_toolbar_view to bookmark_bar_controller to better honor MVC. BUG=http://crbug.com/24985, http://crbug.com/24827, http://crbug.com/22018 TEST=Lots of moves: New browser with no bookmarks. Go to New Tab Page. Show Bookmark Bar. See "Other Bookmarks" button on right. Do NOT see chevron. Hover over and click on Other Bookmarks to be sure it doesn't draw out of bounds. Disable bookmark bar (so it is now floating). Repeat hover/click test. Enable (so now attached). Add bookmarks until chevron shows up. Repeat hover/click test with chevron and Other Bookmarks. Make browser wider and thinner; each time repeat hover/click test. Detach bookmark bar (so floating on NTP). Make browser wider and thinner; each time repeat hover/click test. Carefully make browser wider/thinner so chevron appears/disappears. Make sure chevron never overlaps a bookmark. With chevron visible, quit & relaunch. Make sure chevron visible. With chevron NOT visible, quit & relaunch. Make sure chevron not visible. Review URL: http://codereview.chromium.org/348017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30684 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 01, 2009
-
-
bradnelson@chromium.org authored
These do not build, but are for experimentation. BUG=None TEST=None Review URL: http://codereview.chromium.org/344041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30683 0039d316-1c4b-4281-b951-d872f2087c98
-