BUG=56843
TEST=none

Review URL: http://codereview.chromium.org/5008004
Patch from James Maclean <wjmaclean@chromium.org>.

TBR=scottbyer@google.com
Review URL: http://codereview.chromium.org/5137002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66473 0039d316-1c4b-4281-b951-d872f2087c98

DOMUI: Add |ignore_path| to NavigateParams and use this to implement opening a singleton settings window.

BUG=59889
TEST=none

Review URL: http://codereview.chromium.org/4145013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=56843
TEST=none

Review URL: http://codereview.chromium.org/5008004
Patch from James Maclean <wjmaclean@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38859
TEST=none


Review URL: http://codereview.chromium.org/5112002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66468 0039d316-1c4b-4281-b951-d872f2087c98

These appear to have been following the pattern of:

  ScreenLocker::Show();
  ...
  ui_test_utils::WaitForNotification(
      NotificationType::SCREEN_LOCK_STATE_CHANGED);

I believe that this hangs until the test times out if the
notification is sent before we return from Show() (since we
won't yet be listening for the notification at the time).

I'm changing them to:

  ScreenLocker::Show();
  ...
  if (!chromeos::ScreenLocker::GetTester()->IsLocked())
    ui_test_utils::WaitForNotification(
        NotificationType::SCREEN_LOCK_STATE_CHANGED);

The old version looks like it started failing with my
r66287, which I don't understand -- I thought that we were
already generating the notification immediately as of
r66131, which fixed a bug where the initial attempt to grab
the pointer and keyboard always failed (thus ensuring that
the notifications wouldn't be sent until the next time that
the event loop was run).

BUG=none
TEST=all screen locker tests passed on my local machine

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66340

Review URL: http://codereview.chromium.org/5054004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66464 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a memory leak in the Chrome Frame automation code.

BUG=61609
TEST=Chrome.exe always loads the specified chrome.dll when run by Chrome Frame.


Review URL: http://codereview.chromium.org/5090001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=56449
TEST=none


Review URL: http://codereview.chromium.org/5124001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66461 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, if it's already in its own window group, it won't
be able to break other widgets' grabs.

This also separates out the showing and grabbing code, so we
can show the widget before mapping the locker window and then
grab the pointer and keyboard afterwards.

BUG=chromium-os:8999,chromium-os:9200
TEST=opened a context menu and checked that screen locks immediately.  also tested that the original problem with modal dialogs didn't regress

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66287

Review URL: http://codereview.chromium.org/5013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66460 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/4991002/

New unittests for infobar. 
BUG=None 
TEST=None 


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66459 0039d316-1c4b-4281-b951-d872f2087c98

When snap startting, we can hit a case where we predicted that we would
negotiation an NPN protocol with a server, but then found that we were
wrong.

r65837 deal with this from the HTTP stack's point of view. This change
adds tests to make sure that we can recover from the misprediction and
get it right next time.

BUG=none
TEST=snap_start_tests

http://codereview.chromium.org/4854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66458 0039d316-1c4b-4281-b951-d872f2087c98

Set ADD_SELECTED to foreground/singleton tabs, and set show_window when a new window is created during Navigate().

BUG=62022,62137,62545,62923,63019
TEST=see bugs

Review URL: http://codereview.chromium.org/4647007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63469
TEST=none

Review URL: http://codereview.chromium.org/5118003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66456 0039d316-1c4b-4281-b951-d872f2087c98

Chromium overrides only for MAC for fast/forms/select-visual-hebrew.html and fast/forms/visual-hebrew-text-field.html

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5156001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63143
TEST=as in bug; also verify that it doesn't regress the feature with Italian keyboard layout which has numbers requiring shift

Review URL: http://codereview.chromium.org/5072003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63176
TEST=none

Review URL: http://codereview.chromium.org/5078002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66451 0039d316-1c4b-4281-b951-d872f2087c98

IE CEEE: Add another layer of isolation to content scripts execution through use of window vs unsafeWindow.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66450 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9223
TEST=unit test

Review URL: http://codereview.chromium.org/5108001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66449 0039d316-1c4b-4281-b951-d872f2087c98

Fixing expectations for fast/forms/select-visual-hebrew.html and fast/forms/visual-hebrew-text-field.html

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66448 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66447 0039d316-1c4b-4281-b951-d872f2087c98

I used padding this time.  pragma pack didn't work on Mac x86-32.  It seems to be an issue that only some (very recent?) versions of GCC support it.  I could do it with macros, but it would be ugly.  See the updated bug for more details.

Try was clean:
http://build.chromium.org/p/tryserver.chromium/waterfall?committer=dmichael@google.com

BUG=62983
TEST=I use a compile assert to ensure the size is consistent.

Assuming this goes well, I'll do a future CL to scan other structs and tweak them to get consistent alignment if I find any other problems.
Review URL: http://codereview.chromium.org/5001002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66446 0039d316-1c4b-4281-b951-d872f2087c98

When tab-switching happens, the state of the tab is stored so that it can be restored later. However, when a background tab is being closed, it doesn't cause a tab-switch, and trying to save the state causes problems in some cases (e.g. 61588). So do not save state of a background tab.

BUG=61588
TEST=see bug

Review URL: http://codereview.chromium.org/5075001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66445 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66444 0039d316-1c4b-4281-b951-d872f2087c98

TBR=derat@chromium.org
BUG=none
TEST=ScreenLockerTest.TestBasic passes.

Review URL: http://codereview.chromium.org/5121003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66443 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66442 0039d316-1c4b-4281-b951-d872f2087c98

This was needed because the native_client tree referred to this
function directly and #included renderer_sandbox_support_linux.h, but
this direct reference has now been removed.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
TEST=NaCl's test_runner.html

Review URL: http://codereview.chromium.org/4810002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62476
TEST=unit_tests: DeviceTokenFetcherTest.UnmanagedDevice

Review URL: http://codereview.chromium.org/4967005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66440 0039d316-1c4b-4281-b951-d872f2087c98

Trying to simplify cleanup for more unit tests.

BUG=None
TEST=net_unittests

Review URL: http://codereview.chromium.org/5034001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66439 0039d316-1c4b-4281-b951-d872f2087c98

Leaves the declared NSS-only methods (CreateSensitive.. & FindFromPublicKeyInfo) as UNIMPLEMENTED.

BUG=None
TEST=base_unittests --gtest_filter=RSA*

Review URL: http://codereview.chromium.org/5047003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66438 0039d316-1c4b-4281-b951-d872f2087c98

Revert "chromeos: Add screen locker to window group *after* grab."
This reverts commit e050443eb5bfa7e63c58f40e6e5ec1757f86d348.

Revert "chromeos: Fix screen locker tests."
This reverts commit 67b57b4b0f303add09f665d86abb40a3be103fef.

BUG=chromium-os:8999,chromium-os:9200
TEST=none
TBR=derat

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62798
TEST=unit tests: DeviceTokenFetcherTest.StoreAndLoad

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66415

Review URL: http://codereview.chromium.org/4949003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66435 0039d316-1c4b-4281-b951-d872f2087c98

This gives us dynamic loading support in the Mac sandbox.

It will allow us to address a TODO in renderer_sandbox_support_linux.h.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
BUG=http://code.google.com/p/nativeclient/issues/detail?id=583
TEST=nacl_ui_tests

Review URL: http://codereview.chromium.org/4807003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66434 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mnaganov

Review URL: http://codereview.chromium.org/5169002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66433 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8956
TEST=See bug

Review URL: http://codereview.chromium.org/5163001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66431 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66429 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5171001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8829
TEST=Run chromium. Use wrench menu to open 'Find' window. Notice that
focus is inplace.

Review URL: http://codereview.chromium.org/5009001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62478
TEST=PrefValueStore*:PrefService*

Committing for danno@chromium.org

Review URL: http://codereview.chromium.org/4876002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60966
TEST=NONE

Review URL: http://codereview.chromium.org/5116002
Patch from Peter Beverloo <peter@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66424 0039d316-1c4b-4281-b951-d872f2087c98