- May 28, 2009
-
-
sgk@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/113957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17090 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Also, on linux, assume the user denies every download which we would have prompted him with. BUG=12709 TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once. Review URL: http://codereview.chromium.org/113925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17089 0039d316-1c4b-4281-b951-d872f2087c98
-
mad@google.com authored
BUG=none TEST=We should run those scripts with and without the optional arguments :-) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17088 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
The CPP logic on the log dir seems to have been wrong since last year. Changed so debug writes next to the executable, and release writes to userdata dir. It was the reverse. Drop two paths that aren't used any more. BUG=12834 TEST=run app, make sure we don't create a log file inside the MacOS folder. Review URL: http://codereview.chromium.org/115868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17087 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
svn:ignore the new gyp-generated files. BUG=none TEST=none Review URL: http://codereview.chromium.org/115867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17085 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
TEST=SeekableBufferTest.* Updating media::SeekableBuffer and unit tests to meet code style standards. Review URL: http://codereview.chromium.org/114042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17084 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17082 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Do endian swapping for the identifier in dump_syms. Fill in the pdb_file_name (debug_file) field for modules. BUG=none TEST=none Review URL: http://codereview.chromium.org/113943 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17081 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/113954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17080 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
BUG=8317 TEST=make sure we don't create a dictionary directory within the app. Review URL: http://codereview.chromium.org/115863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17079 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
Not sure what is causing the crasher. Hopefully after this clean-up we'll get a different stack-trace that might help. BUG=10699 TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Review URL: http://codereview.chromium.org/113932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17078 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
BUG=12413 TEST=Focus the omnibox. Press Shift-Ctrl-Delete, the Clear Browsing Data dialog should show. Make sure cut/copy/paste shortcuts still work as expected (Ctrl/x, Ctrl/c, Ctrl/v, Shift/Delete, Shift/Insert). Review URL: http://codereview.chromium.org/113872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17077 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
side. BUG=none TEST=none Review URL: http://codereview.chromium.org/114054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17076 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/115864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17075 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/113953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17074 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/113951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17073 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
Now data for each profiling session is collected separately (previously they were accumulated in a single profile). BUG=none TEST=none Review URL: http://codereview.chromium.org/113950 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17072 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
Use CERT_PKIXVerifyCert() with CRL to verify certificate. With OCSP, CERT_PKIXVerifyCert() failed with SEC_ERROR_INVALID_ARGS. Increase stack size. It was not enough size if we use CERT_PKIXVerifyCert() on some sites. For example, https://www.google.com/ works, but https://bugs.webkit.org/ or https://www.thawte.com/ would die by SIGSEGV. This is because pkix_List_Destroy() routine destroys PKIX_List recursively, so if there are some long PKIX_Lists, it consumes stack a lot and dies by stack overflow. Note that X509Certificate::Verify isn't used in SSLClientSocketNSS yet. BUG=10911 TEST=net_unittests passes Review URL: http://codereview.chromium.org/113578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17071 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@chromium.org authored
Initially these will be drop in replacements for the existing projects. These were generated mechanically in lieu of a looping syntax. Review URL: http://codereview.chromium.org/115853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17070 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Learned how to do a clobber build so retrying with that. Hope springs eternal. Original Review URL: http://codereview.chromium.org/113807 Review URL: http://codereview.chromium.org/113938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17068 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Review URL: http://codereview.chromium.org/115854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17067 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
This checkin adds gmock, and a small example of how to write a gmock-based unittest. Original Review URL: http://codereview.chromium.org/113807 Review URL: http://codereview.chromium.org/115846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17066 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
* test/ui/sandbox_uitest.cc * test/ui/v8_benchmark_uitest.cc * worker/worker_uitest.cc * browser/autocomplete/search_provider_unittest.cc * browser/extensions/extension_process_manager_unittest.cc * browser/extensions/extension_view_unittest.cc * browser/find_backend_unittest.cc * browser/safe_browsing/safe_browsing_blocking_page_unittest.cc * browser/search_engines/template_url_scraper_unittest.cc Also the utility module: * test/ui/javascript_test_util.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/115844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17065 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
bsdiff and bspatch. svn:ignore the new generated ones. BUG=none TEST=none Review URL: http://codereview.chromium.org/115819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17064 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17063 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17062 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17061 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17060 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Review URL: http://codereview.chromium.org/115850 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17059 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
link stub is not necessary. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17058 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Review URL: http://codereview.chromium.org/113937 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17057 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Review URL: http://codereview.chromium.org/115827 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17056 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
TBR=nsylvain Review URL: http://codereview.chromium.org/115848 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17053 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
It is possible that the size for the index table is reduced when the cache is restarted (the available disk space could be lower than what it was when the cache was originally created). If that is the case, not resetting mask_ to 0 will prevent the mask to be set correctly for the new table size, resulting in a crash. BUG=12378 TEST=unittests Review URL: http://codereview.chromium.org/113930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17052 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@google.com authored
pages into an HTML label tag, to make it clickable and more friendly to screen readers. TEST= Navigate to ianfette.org and click on the text "I understand that visiting this site may harm my computer". Checkbox should toggle. BUG= 12714 Original patch by chromium@willhirsch.co.uk Original review: http://codereview.chromium.org/115815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17050 0039d316-1c4b-4281-b951-d872f2087c98
-
glen@chromium.org authored
TBR=ben BUG=11904 TEST=See bug, verify that home buttons don't look like provided image. Review URL: http://codereview.chromium.org/115845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17049 0039d316-1c4b-4281-b951-d872f2087c98
-
glen@chromium.org authored
BUG=10638 TEST=Go to about:credits and verify that there's no reference to JSCRE Original review URL: http://codereview.chromium.org/113683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17048 0039d316-1c4b-4281-b951-d872f2087c98
-
glen@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/115728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17047 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Since media in chrome renderer doesn't use file handle anymore, and these two files are deprecated, remove them from the tree. Review URL: http://codereview.chromium.org/115841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17046 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
BUG=none TEST=ran gclient sync to verify syntax of DEPS change. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17045 0039d316-1c4b-4281-b951-d872f2087c98
-