- Apr 27, 2010
-
-
thestig@chromium.org authored
BUG=42622 TEST=Valgrind Mac 2, please turn green. TBR=tony Review URL: http://codereview.chromium.org/1753011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45679 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=40659 TEST=Mac Valgrind gets another shade greener. TBR=mark Review URL: http://codereview.chromium.org/1789004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45677 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=42590 TEST=Mac Valgrind gets greener. TBR=wtc Review URL: http://codereview.chromium.org/1805001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45676 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=35955 TEST=Valgrind Mac gets slightly greener. TBR=huanr git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45675 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
On Mac (prior EasyStreet), http://www.google.com might be redirected to wifi.corp.google.com, so that google:baseURL would be set to wifi.corp.google.com, but user might want to use the URL for default search. BUG=38472 TEST=GoogleURLTrackerTest.CheckAndConvertURL passes Review URL: http://codereview.chromium.org/1780006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45674 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Committing for rsimha@chromium.org. Original review: http://codereview.chromium.org/1739007/show Added a boolean field to class ChromeTestSuite, called "created_user_data_dir_". It defaults to false, and is set to true if no value is passed for --user_data_dir via command line. If the flag is false, the directory specified by the user is not deleted after test execution, and if it is true, the directory is deleted, as it always has been. Note: user_data_dir is emptied before test execution -- this behavior remains unaltered. BUG=42374 TEST=User profile directory still exists after running a test with --user-data-dir. Review URL: http://codereview.chromium.org/1755009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45673 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=40037 TEST=Linux Views bot goes green? TBR=oshima Review URL: http://codereview.chromium.org/1792004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45672 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=42514 TEST=CrOS bot goes green. TBR=oshima Review URL: http://codereview.chromium.org/1726010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45671 0039d316-1c4b-4281-b951-d872f2087c98
-
yuzo@chromium.org authored
Webkit Mac10.5 (dbg)(3) : webkit_tests 324 fixable (30 skipped) failed 15 change-version.html database-lock-after-reload.html executesql-accepts-only-one-statement.html null-callbacks.html open-database-creation-callback-isolated-world.html open-database-creation-callback.html open-database-set-empty-version.html quota-tracking.html statement-error-callback-isolated-world.html statement-error-callback.html statement-success-callback-isolated-world.html success-callback.html transaction-callback-isolated-world.html transaction-error-callback-isolated-world.html transaction-error-callback.html unexpected flaky 2 change-version-handle-reuse.html bug28341.html . [ stdio ] Linux Tests x64 : browser_tests 3924 flaky did not complete failed 2 Flakiness dashboard . [ stdio FLAKY_BlockBadURLs ] Webkit Linux (dbg)(2) : webkit_tests 198 fixable (21 skipped) failed 2 sandboxed-iframe-storage.html exceptions-thrown-in-callbacks.html . [ stdio ] Webkit Linux (dbg)(3) : webkit_tests 321 fixable (27 skipped) failed 15 change-version.html database-lock-after-reload.html executesql-accepts-only-one-statement.html null-callbacks.html open-database-creation-callback-isolated-world.html open-database-creation-callback.html open-database-set-empty-version.html quota-tracking.html statement-error-callback-isolated-world.html statement-error-callback.html statement-success-callback-isolated-world.html success-callback.html transaction-callback-isolated-world.html transaction-error-callback-isolated-world.html transaction-error-callback.html unexpected flaky 2 change-version-handle-reuse.html patternPreserveAspectRatioA.svg . [ stdio ] BUG=none TEST=none TBR=jorlow Review URL: http://codereview.chromium.org/1736017 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/1795004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45670 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
1. Removed SeekableBuffer::Buffer. 2. Extended SeekableBuffer to support all the features of BufferQueue. 3. BufferQueue removed and replaced with SeekableBuffer. BUG=28654 TEST=none Review URL: http://codereview.chromium.org/1736012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45669 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
. Makes copy prefix the text with http if the user hasn't edited the text, and the scheme is http but the text doesn't include http. . Makes copying use the url as the text if the user hasn't edited the text and it's http/https. . Makes control-insert/shift-insert use our copy/paste. BUG=41639 41489 41493 TEST=make sure copy/paste from the omnibox work sanely. Seriously though, see the three bugs for specifics. Review URL: http://codereview.chromium.org/1761002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45667 0039d316-1c4b-4281-b951-d872f2087c98
-
yuzo@chromium.org authored
BUG=none TEST=none TBR=jorlow Review URL: http://codereview.chromium.org/1736017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45666 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/1746010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45665 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
1) When one of the mini tabs is an app (nano) tab, we now increase the margin between the mini tabs and the regular tabs by a few pixels. This is because with the large icons for nano tabs, it looks a little squished against the regular tabs in the tabstrip. 2) When dragging a nano tab within the tab strip, the background "handle" would grow to be as large as a regular tab (while dragging) due to the fact that UpdateData (that DraggedTabView calls) was not transferring the app tab bit to the new Tab. BUG=None TEST=Visual inspection. Review URL: http://codereview.chromium.org/1700016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45664 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
directory for the cgc executable, to match the layout of the prebuilt O3D COLLADA converter binaries which already bundle cgc and its dependent DLLs. BUG=none TEST=verified new searching code manually on Windows and Mac TBR=amarinichev Review URL: http://codereview.chromium.org/1804001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45663 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=42514 TEST=Bot goes green. TBR=oshima Review URL: http://codereview.chromium.org/1794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45662 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1752007 TBR=albertb@chromium.org Review URL: http://codereview.chromium.org/1763013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45661 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: http://codereview.chromium.org/1723014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45659 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=42593 TEST=Mac Valgrind unit_tests goes green TBR=wtc Review URL: http://codereview.chromium.org/1692010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45658 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: http://codereview.chromium.org/1732014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45657 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=37839 TEST=Tsan goes green. TBR=sanjeevr Review URL: http://codereview.chromium.org/1783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45656 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=42590 TEST=Valgrind ui_tests goes green. TBR=wtc Review URL: http://codereview.chromium.org/1699014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45655 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
for buffers, textures, programs, etc.. This is needed to pass GLES2 conformance tests. TEST=old unit tests BUG=none Review URL: http://codereview.chromium.org/1747013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45654 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
This test is no longer flaky now that it is run as an interactive UI test. Changing the name to match. BUG=32807 TEST=none Review URL: http://codereview.chromium.org/1727008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45651 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Fix for crash seen in the field. The AutoFillType class was not thread-safe. These changes make it so. Also adds unit tests that cover mappings from type to group and subgroup, and out of range conditions. BUG=42341 TEST=AutoFillTypeTest Review URL: http://codereview.chromium.org/1789001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45650 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Fix a chrome frame crasher reported on the crash server. It occurs while processing a call to SetPositionCookie while dereferencing a NULL automation client pointer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42598 Bug=42598 Review URL: http://codereview.chromium.org/1763011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45646 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Make sure the "cancel leaked host resolver requests shutdown hack" gets run before the message loop is destroyed. BUG=41966 Review URL: http://codereview.chromium.org/1798001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45644 0039d316-1c4b-4281-b951-d872f2087c98
-
- Apr 26, 2010
-
-
michaeln@chromium.org authored
Add ResourceRequest target types for worker and shared worker resources. This is the first patch of a two-sided change that involves WebKit API changes which haven't been made yet. BUG=39368 TEST=none Review URL: http://codereview.chromium.org/1666002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45643 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
Put in place a noop impl of createApplicationCacheHost() on all WebCommonWorkerClient subclasses. That factory method is soon to be added to the WebKit::WebCommonWorkerClient class as a pure virtual. Adding these methods in advance so it builds when that pure virtual shows up later. BUG=39368 TEST=none Review URL: http://codereview.chromium.org/1729015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45642 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
BUG=30401 TEST=open Import Bookmarks dialog, uncheck all checkboxes, see if the "Import" button is disabled. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1604025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45641 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
so that the sync backend can register as an observer. BUG=35038 TEST=none Review URL: http://codereview.chromium.org/1752007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45640 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This makes it so toolkit_views==1 is always true for views builds, either on Windows or ChromeOS. Three levels of nesting are needed for this chained conditional: 1) Set the default value of ChromeOS. 2) Depending on ChromeOS value, set the default value of toolkit_views. 3) Depending on toolkit_views value, set the rest of the build variables. This should have no affect on the build, but will allow subsequent cleanup. Review URL: http://codereview.chromium.org/1799002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45639 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=Visiting about:plugins with MOZ_PLUGIN_PATH=/tmp does not hang when there is a pipe in /tmp. Review URL: http://codereview.chromium.org/1700014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45638 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Review URL: http://codereview.chromium.org/1789003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45637 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/1701012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45636 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
related code Review URL: http://codereview.chromium.org/1708006 Patch from Wei Jia <wjia@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45635 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45633 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
BUG=None TEST=Manual Review URL: http://codereview.chromium.org/1759007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45631 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=42497 Review URL: http://codereview.chromium.org/1745016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45630 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
Calling -[NSWindow makeFirstResponder:] to give focus to the AutocompleteTextField will select the entire contents of the field. If the field is already focused and "select all" is not desired, avoid making this call. If "select all" is desired, or if the field is not focused (regardless of the value of select_all), the field will be focused and its entire contents selected. BUG=40322, 40682 TEST=With a profile primed so that "google.com" is the first suggestion when typing "g" in the location bar, and no windows open, quickly press command-N and begin typing "google" while the tab is being created. Expect all of the entered characters to make it to the location bar. When the bug occurs, the location bar in its entirety will be selected at some point during or immediately following tab creation, which will cause previously-typed text to be lost or the first autocomplete suggestion to be chosen, and something like "ogle" or "google.com/ogle" to appear in the location bar. Review URL: http://codereview.chromium.org/1709010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45628 0039d316-1c4b-4281-b951-d872f2087c98
-