- Jul 15, 2010
-
-
jshin@chromium.org authored
BUG=4456 TEST=Change the UI languge to Japanese and log out. At the lower-left corner of the login screen, there's no more sequence of 'black question marks'. Review URL: http://codereview.chromium.org/2864033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52448 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=45612 TEST=new unit tests Review URL: http://codereview.chromium.org/2966011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52447 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later. BUG=1715,36939 TEST=Run chrome.exe on the screen resolution higher than 120 DPI. Review URL: http://codereview.chromium.org/2867031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52446 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
incorrectly to clean this up). TEST=none BUG=none Review URL: http://codereview.chromium.org/2858054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52445 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
in the renderer, and just invalidates that region so it's repainted by WebKit. TEST=covered by ppapi unit test (to be enabled) BUG=none Review URL: http://codereview.chromium.org/2909017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52444 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/2941014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52443 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
functions when available, and on Linux implements a simple manual scroll function since Cairo/Skia doesn't provide one. BUG=none TEST=included unit test Review URL: http://codereview.chromium.org/2967008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52442 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
There was a regression in the moz page cycler around when landed. This was ONLY a single core regression, which suggests it was time spent in the browser becoming critical path. This change involved font layout in the browser, and so it MIGHT be related. I'll land this, let the per bots start their run, and then revert. TBR=pkasting Review URL: http://codereview.chromium.org/2895017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52441 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/2987005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52440 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Omnibox recently got taller on Mac, which screwed up the centering. Visually inspect and re-center. BUG=49101 TEST=https://www.thawte.com/, lock should be centered vertically. Review URL: http://codereview.chromium.org/2856037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52439 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
My http://codereview.chromium.org/2998004 refactored calculation of the page-action info-bubble position, but didn't fully factor in a coordinate-system change. BUG=none TEST=Page-action info-bubble position at bottom, not top. Review URL: http://codereview.chromium.org/2980014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52438 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* Added OfflineResourceHandler that intercept the request and show interstitial page. * Added OfflineLoadPage that is shown when offline. This gets deleted when - User pressed "Load now" btton to proceed or - User pressed "Cancel" button to cancel loading - Network become available. The page first appears as blank page (a little darker than white for now. I'll update when mock is ready), and then options become available after 3 seconds maximum. * Added unit test for OfflineLoadPage class. * OfflineLoadService class to control when/if a load request should proceed regardless of network status. The current implementation is tentative and will proceed if if loading was requested in a given tab. I'll revisit this class to improve the logic in separate CL later. Known Issue: - thumbnail is not working yet. I'll working on this in separate Cl. - a tab shows URL instead of title string. I'll fix this in separate CL. - InitNavigationParams in offline_load_page_unittest is copied from safe_browsing_blocking_page_unittest. I'll move this to common place in separate CL. (hopefully before checking this in) BUG=chromium-os:3605 TEST=unit test: offline_load_page_unittest manual: disable wifi and ethernet, then login. chrome will show the offline page when tab is activated. Enable network (wifi or ethernet) and all tab will start loading again. Review URL: http://codereview.chromium.org/2931005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52433 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
BUG=49123 TEST=Start autocompleting something, check that things line up. Review URL: http://codereview.chromium.org/2968012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52432 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
Erik ran into a problem related to this while working on some changes to permissions handling for event listening. BUG=none TEST=Context Menus API onclick callbacks should work normally. Review URL: http://codereview.chromium.org/2963012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52431 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2919013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52429 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
R=davidben,ian BUG=31646 TEST=https://www.startssl.com/ should be displayed with EV status. Review URL: http://codereview.chromium.org/2984001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52425 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
label from the strings that can be displayed. The old approach resulted in too small a width and clipping. BUG=chromium-os:4406 TEST=see bug Review URL: http://codereview.chromium.org/2993005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52424 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
r51734 added the relevant locks. BUG=48006 TEST=KeygenHandlerTest.ConcurrencyTest Review URL: http://codereview.chromium.org/2978007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52423 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Refactor to convert star decoration to LocationBarDecoration. BUG=none TEST=Star icon continues to work. TEST=Bookmark bubble pops in the right place. Review URL: http://codereview.chromium.org/2971004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52422 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
BUG=49120 TEST=manually tested Review URL: http://codereview.chromium.org/2950009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52421 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
CID=9159 BUG=none TEST=none Review URL: http://codereview.chromium.org/2924014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52420 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
CID=9433 TEST=none BUG=none Review URL: http://codereview.chromium.org/2943012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52419 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52418 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jul 14, 2010
-
-
ojan@google.com authored
Review URL: http://codereview.chromium.org/2893017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52417 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TBR=estade TEST=compile, please... BUG=42892 Review URL: http://codereview.chromium.org/2917015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52416 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Flaky on linux/views as well as chromeos. BUG=48920 TEST=tree stays marginally greener TBR=dmazzoni Review URL: http://codereview.chromium.org/3000003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52415 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=none BUG=42892 Review URL: http://codereview.chromium.org/2847050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52412 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
TEST=Tested by gmerge chromeos-chrome onto device and checking about histograms. Review URL: http://codereview.chromium.org/2899014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52411 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
CID=8190,9146 TEST=none BUG=none Review URL: http://codereview.chromium.org/2997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52410 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52409 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2986006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52408 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
AudioRendererBase::FillBuffers() sends ended event only when playback_delay == 0, but with ALSA output the delay was never set to 0 because it includes hardware delay. Changed ALSA output to include only internal buffers in the delay value: this matches windows and mac versions. BUG=45074 TEST=<audio> fires ended event when necessary Review URL: http://codereview.chromium.org/2978005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52407 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
TEST=None BUG=None Review URL: http://codereview.chromium.org/2958001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52406 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
access to an entry to the transaction that has exclusive access to that entry. This means that requests that are blocked on the single writer lock of the http cache will report the load state of the request that has the lock, and WAITING_FOR_CACHE is reserved for requests that are actually waiting for the entry to be created by the cache. BUG=43582 TEST=net_unittests Review URL: http://codereview.chromium.org/2976004 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/2921010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52405 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
TBR=stuartmorgan@chromium.org BUG=48980 TEST=none Review URL: http://codereview.chromium.org/3002002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52404 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
This may have lead to some bad stats in Sync.UserPerceivedAuthorizationTime histogram. CID=11400 TEST=none BUG=none Review URL: http://codereview.chromium.org/2976003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52403 0039d316-1c4b-4281-b951-d872f2087c98
-
alyssad@chromium.org authored
Review URL: http://codereview.chromium.org/2909005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52402 0039d316-1c4b-4281-b951-d872f2087c98
-
huanr@chromium.org authored
BUG=38334,48921 TEST="mini_installer --chrome-sxs", check about box, about:version, start menu shortcut name Review URL: http://codereview.chromium.org/2931018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52401 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
- The local state and the overall size of the profile dir BUG=42561 Review URL: http://codereview.chromium.org/2934019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52400 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
CID=10885 BUG=none TEST=none Review URL: http://codereview.chromium.org/2942009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52399 0039d316-1c4b-4281-b951-d872f2087c98
-