- Oct 14, 2024
-
-
Gyuyoung Kim authored
(cherry picked from commit c333ed99) Fixed: 368208152 Change-Id: I0e2ece4b0857b225d229134b2e55abc3e08348ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5876623 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1358968} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901253 Owners-Override: Artem Sumaneev <asumaneev@google.com> Reviewed-by:
Artem Sumaneev <asumaneev@google.com> Commit-Queue: Gyuyoung Kim (xWF) <qkim@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1983} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Oct 11, 2024
-
-
ChromeOS bot authored
Uploaded by https://ci.chromium.org/b/8734410844625026161 Change-Id: I10defb98d5bfcf30faa180b9919ff2aeaa69dac7 CrOS-LKGM: 15886.80.0 Cr-Original-Build-Id: 8734410844625026161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5925498 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1982} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Change-Id: I17d22a61e929ec040969b696d42faee41918453c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5921029 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1981} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Oct 10, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/v8 in M126 from e4d80ab56762 to c36b4f9856f7 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/e4d80ab56762..c36b4f9856f7 Generated by: http://go/bbid/8734478715662874657 Change-Id: I15d89e64724c2a0b7a35c0ca9b02c349a9c8c35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5923433 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1980} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Oct 08, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/third_party/angle in M126 from efca5c3874f3 to 1eb6afe32f70 Commits rolled: https://chromium.googlesource.com/angle/angle.git/+log/efca5c3874f3..1eb6afe32f70 Generated by: http://go/bbid/8734624045953429361 Change-Id: I4c67edc133f75ac4d8c67d76dfeeb5eb11da7a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5916946 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1979} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Oct 04, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/internal in M126 from 826068a89d28 to 13a6bad1a34c Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/826068a89d28..13a6bad1a34c Generated by: http://go/bbid/8734971336901250241 Change-Id: I4b503f48fc586a97d1b9570b0c84c47d6d1fbfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5909252 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1978} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Oct 03, 2024
-
-
Qijiang Fan authored
As agreed with Fleet, we will remove all DUTs on chrome pool, and switch internal testing to chromeos pool. The changes have been landed in trunk in August but branched builders also need such changes so we can remove DUTs as early as possible. This CL does a spiritual cherry-pick [1] of https://chromium-review.googlesource.com/c/chromium/src/+/5802735 https://chromium-review.googlesource.com/c/chromium/src/+/5803388 https://chromium-review.googlesource.com/c/chromium/src/+/5837958 [1] Some files are moved between m126 and trunk, spiritual cherry-picks ensures minimum changes to m126. Bug: b/370411570 Change-Id: Ibafa74229746b31a1f5cdb0af36b33179f96ebef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903237 Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Qijiang Fan <fqj@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1977} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Oct 01, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/v8 in M126 from 6f67c44a3ccb to e4d80ab56762 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/6f67c44a3ccb..e4d80ab56762 Generated by: http://go/bbid/8735307300054348849 Change-Id: I7547acf79e6afc6b894f3d805633650bf6edab5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5899002 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1976} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Roll src/v8 in M126 from efaa0ffbcd1e to 6f67c44a3ccb Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/efaa0ffbcd1e..6f67c44a3ccb Generated by: http://go/bbid/8735316737514517521 Change-Id: I3f7117fac0a50932ee07f51df6a68b3cbe8156a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901259 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1975} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Gyuyoung Kim authored
ParsePseudoType crashes on ASAN when given non-ASCII characters, so returning early if those are present. (cherry picked from commit f50b84cf) Bug: 350779647 Change-Id: Ic77351a1c95437a226dce66c7826b7b8481b8d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5686295 Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1346768} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872266 Owners-Override: Victor Gabriel Savu <vsavu@google.com> Reviewed-by:
Victor Gabriel Savu <vsavu@google.com> Commit-Queue: Gyuyoung Kim (xWF) <qkim@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1974} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 30, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/third_party/skia in M126 from b5bb998be272 to 234e3d4b37e9 Commits rolled: https://skia.googlesource.com/skia.git/+log/b5bb998be272..234e3d4b37e9 Generated by: http://go/bbid/8735360149256442257 Change-Id: Icb358661f164c8c1c5f2a60aa4beeb33e84a1f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898485 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1973} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 27, 2024
-
-
ChromeOS bot authored
Uploaded by https://ci.chromium.org/b/8735679546801912241 Change-Id: Iebade4122b1905771725952a6758518151da225a CrOS-LKGM: 15886.79.0 Cr-Original-Build-Id: 8735679546801912241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5896133 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1972} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Change-Id: I27dc004ec92491f697bd964d5ba61875c6c2df6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893460 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1971} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 24, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/internal in M126 from 33b7ac433b8c to 826068a89d28 Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33b7ac433b8c..826068a89d28 Generated by: http://go/bbid/8735882968219954913 Change-Id: I5521d31a9167b04a393c51bd2be88c1c7e968a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888008 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1970} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 19, 2024
-
-
ChromeOS bot authored
Uploaded by https://ci.chromium.org/b/8736423114990160033 Change-Id: Ieed59a90a14b61c669dd92799046012494fd138b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873429 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1969} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 18, 2024
-
-
Chrome Release Bot (LUCI) authored
Change-Id: Ibbfd19aaed46d04e1b0c4c7d34592c237d92c380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874780 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1968} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Roll src/internal in M126 from cbc9e894790c to 33b7ac433b8c Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbc9e894790c..33b7ac433b8c Generated by: http://go/bbid/8736426550229318129 Change-Id: I948384f01c18bd4f658d3cee1e4e7ee59c7f9021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874441 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1967} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Garrett Beaty authored
M126 is only being pushed for CrOS LTS at this point. Change-Id: I9788fa3047e2c3b317afd2f44c5fcb49cb1a5071 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873994 Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1966} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Daniel Murphy authored
(cherry picked from commit 3db62259) Fixed: b:348445406 Change-Id: I5346f7e6a89d54403ca8a80c6b967238b9a0f04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5735615 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1331905} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807208 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1965} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Hiroshige Hayashizaki authored
Theoretically `ThrottlingURLLoader` can be deleted during throttle calls and some call sites have already protection for such cases. This CL adds the protection for more call sites. This CL also adds more unit tests for cancelling/deleting `ThrottlingURLLoader` during throttle calls. (cherry picked from commit c40f8866) Bug: 349342289 Change-Id: I80d64be9ba1a3ac920315f5b4012b29c9737e414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5665925 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1323986} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5845051 Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Giovanni Pezzino <giovax@google.com> Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1964} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 17, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/third_party/skia in M126 from 8618b9f741ce to b5bb998be272 Commits rolled: https://skia.googlesource.com/skia.git/+log/8618b9f741ce..b5bb998be272 Generated by: http://go/bbid/8736520921494854881 Change-Id: Id1ea1f05f7aafbe58ad9e957fcb49a6cef03596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5870057 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1963} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Hongchan Choi authored
This CL fixes non-deterministic (racy) data change on AudioParamHandler::automation_rate_. It also revises incorrect logic in the DelayHandler's process function; the process function needs to process all the channels in the delay kernel in the same rate. However, the previous code allowed the automation rate to change any time even in the middle of processing. This fix is locally confirmed with the provided repro case, and also a test was added to verify other related API surfaces. (cherry picked from commit ec85a32b) Bug: 357391257 Change-Id: I7ce953837edd818e435e3a1b917f6b3c6147d95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5767447 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1345091} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854511 Reviewed-by:
Giovanni Pezzino <giovax@google.com> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Michael Wilson <mjwilson@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1962} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 13, 2024
-
-
Gyuyoung Kim authored
(cherry picked from commit 19fac6ad) Bug: 339654392 Change-Id: I97c105276c4442d80b9f506d0ae111aa13837f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721458 Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1331313} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5849128 Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Owners-Override: Artem Sumaneev <asumaneev@google.com> Commit-Queue: Gyuyoung Kim (xWF) <qkim@google.com> Reviewed-by:
Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1961} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 12, 2024
-
-
Koji Ishii authored
This is a reland of commit ba40b993 The original change failed on mac11-arm64-rel and reverted at crrev.com/c/5776005. This is because the unit tests assumed that the `SECURITY_DCHECK` is always enabled, but it's actually enabled only for DCHECK-enabled builds. This patch fixes it by wrapping the unit tests by `#if`. Original change's description: > Fix `StringView` to crash when `offset + length` overflows > > This patch fixes `SECURITY_DCHECK` in `StringView` for when > `offset + length` overflows the `unsigned`. > > Bug: 357622693, 355731798 > Change-Id: I5a7a7979192fe132496661b1272c5902cdbdb09a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775486 > Auto-Submit: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1340005} (cherry picked from commit 5fe8d131) Bug: 357622693, 355731798 Change-Id: I5402234a5fe54bf8dec2c986ab0ab388e1bc783d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782718 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1340817} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807454 Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Fahad Mansoor <fahadmansoor@google.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1960} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Koji Ishii authored
crrev.com/c/5776342 fixed a range `CHECK` in `CollectFallbackHintChars`, but depends on the CSS and font configurations, it's possible that the code doesn't go to `CollectFallbackHintChars` and the following code may hit the same issue. This patch adds another `CHECK` for the case. (cherry picked from commit ef6f7b45) Bug: 355731798, 357622693 Change-Id: Ieb4ada7699c80564e8a4b866cb6a6ffbc665ebc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776204 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1340006} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806849 Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fahad Mansoor <fahadmansoor@google.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1959} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Koji Ishii authored
This patch fixes a `CHECK` for a range of a string when `offset + length` overflows the `unsigned`. (cherry picked from commit 59c286e8) Bug: 355731798 Change-Id: If04222f10f2b73b6dcd6b412cf4d82fa5b71bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776342 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1339526} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804713 Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Fahad Mansoor <fahadmansoor@google.com> Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1958} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 11, 2024
-
-
Aaron Krajeski authored
All other methods that use Path2D use path2d_use_paint_cache_ except for clip() which was always enabled. This could allow for situations where a DCHECK was triggered in the paint op buffer. See attached bug. (cherry picked from commit 2658f941) Bug: 349903568 Change-Id: I179037bdd15d474cb2ef182e041f2b47b0ee868c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5716900 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1329058} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5834804 Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Owners-Override: Artem Sumaneev <asumaneev@google.com> Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Reviewed-by:
Artem Sumaneev <asumaneev@google.com> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1957} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Hiroshige Hayashizaki authored
This CL avoid use-after-free around `EmbeddedWorkerInstance::ReleaseProcess()`: 1. During `ReleaseProcess()`: This CL protects `ServiceWorkerVersion` and its `EmbeddedWorkerInstance` from deletion. 2. In the direct callers of `ReleaseProcess()`: This CL early returns if `this` is deleted during `ReleaseProcess()`. Skipping `listener_list_` should be fine because `listener_list_` is the `owner_version_` (at least in non-test) that is already deleted if `this` is deleted. This CL also adds explicit comments that the methods calling `ReleaseProcess()` may delete `this`. 3. In the callers of 2.: As far as I checked, the callers should work even in the case of deletion of `ServiceWorkerVersion`. (cherry picked from commit 76ce1fe9) Bug: 350407902 Change-Id: If59e8354ae9832009b62408a8f0058cb6f6e803f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5685760 Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1324689} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806117 Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Owners-Override: Artem Sumaneev <asumaneev@google.com> Reviewed-by:
Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1956} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Roll src/third_party/skia in M126 from be621ea04206 to 8618b9f741ce Commits rolled: https://skia.googlesource.com/skia.git/+log/be621ea04206..8618b9f741ce Generated by: http://go/bbid/8737079603465219137 Change-Id: If940b0ddbcd84715931aaf7834994b49f88ad995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854939 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1955} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 05, 2024
-
-
conniekxu authored
For managed guest session (MSG), as long as the policy permits, user should be able to update the timezone settings. Instead of using the function `IsGuestModeActive` to determine whether or not to disable timezone settings, using `CanSetSystemTimezone`. Screenshots: - Before fix: https://screenshot.googleplex.com/B6HfGfrgkQqGkfo - After fix: https://screenshot.googleplex.com/ApQPDZYC77GZf24 https://screencast.googleplex.com/cast/NTM1NTQ5ODQxNjExMTYxNnxkMmNkMzhiOC1lYQ (cherry picked from commit 045f2e90) Bug: b/349819718 Change-Id: I695818ac4465fd925d0e6340862a21d567267bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5709714 Reviewed-by:
Wes Okuhara <wesokuhara@google.com> Commit-Queue: Connie Xu <conniekxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1328518} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838136 Cr-Commit-Position: refs/branch-heads/6478@{#1954} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Jiacheng Guo authored
Partial Merge: Fails on M126 linux-chromeos-rel as well The test DynamicColorSystemWebAppBrowserTest.Colors runs only on ChromeOS so there is no need for an extra guard. (cherry picked from commit 60f165cb) Bug: 364148340 Change-Id: Ieb401e9df4f304e584e3bc2d66c7aa14bb2e4ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829010 Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Jiacheng Guo <gjc@google.com> Owners-Override: Jiacheng Guo <gjc@google.com> Commit-Queue: Jiacheng Guo <gjc@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1350010} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836167 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Osama Fathy <osamafathy@google.com> Reviewed-by:
Osama Fathy <osamafathy@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1953} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
ChromeOS bot authored
Uploaded by https://ci.chromium.org/b/8737682121726242353 Change-Id: Ie97230a48fc0a219a256eb22aa6343da19e1b64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838913 Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1952} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 04, 2024
-
-
Chrome Release Bot (LUCI) authored
Change-Id: Ic156b0831a50060c7714f234fce53231954a654e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837841 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1951} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Roll src/v8 in M126 from ba31009c2c78 to efaa0ffbcd1e Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/ba31009c2c78..efaa0ffbcd1e Generated by: http://go/bbid/8737691131781299745 Change-Id: I6d2f82623d5acc427af24e8e4b5b3abb073cf6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837681 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1950} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Tzarial Kuznia authored
(cherry picked from commit 75749f51) Change-Id: Ia51197a4e08a737b3fa31823b8220a86f47dd966 Fixed: 345562940 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5622897 Commit-Queue: Tzarial Kuznia <zork@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1314674} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5834880 Reviewed-by:
Tzarial Kuznia <zork@chromium.org> Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <rzanoni@google.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1949} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Sep 03, 2024
-
-
Renato Silva authored
Fixes an issue on the Network Screen that could cause visibility issues for the QuickStart flow. Also adds checks to harden common flows. Additionally adds a couple of tests to ensure correctness. Test=Manual testing of many flows. (cherry picked from commit 6f99f4bc) Bug: b/362262041, b/361236374 Change-Id: I915bf51d08ce5d5cb9aa054573c6f686c1840e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5812906 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Brittany Hartmire <bhartmire@google.com> Commit-Queue: Brittany Hartmire <bhartmire@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1347097} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829410 Reviewed-by:
Andrey Davydov <andreydav@google.com> Cr-Commit-Position: refs/branch-heads/6478@{#1948} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
- Aug 27, 2024
-
-
Chrome Release Bot (LUCI) authored
Roll src/internal in M126 from 3dff76d71a7a to cbc9e894790c Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3dff76d71a7a..cbc9e894790c Generated by: http://go/bbid/8738425344091383329 Change-Id: I2d9a32010c394dbb70f07ac3c03479dedb54307b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5818413 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1947} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Garrett Beaty authored
M126 is no longer being pushed for Android, iOS or linux. Change-Id: I3b6413b0f25319ca6541b0d6254b5f0e5055c802 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5818191 Reviewed-by:
Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#1946} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Roll src/clank in M126 from 35dfe91238d9 to 95961c38be4e Commits rolled: https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/35dfe91238d9..95961c38be4e Generated by: http://go/bbid/8738451766981461969 Change-Id: I574704fd03cec958d77487cc22842070b8967929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817493 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1945} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-
Chrome Release Bot (LUCI) authored
Roll src/v8 in M126 from 9c1174a2b44e to ba31009c2c78 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/9c1174a2b44e..ba31009c2c78 Generated by: http://go/bbid/8738461207818952081 Change-Id: I92a4cd7b5845b7e3b095e2c041ca6396f7c2b59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5816968 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#1944} Cr-Branched-From: e6143acc-refs/heads/main@{#1300313}
-