Review URL: http://codereview.chromium.org/159771

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22251 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159759

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22250 0039d316-1c4b-4281-b951-d872f2087c98

Too much red :-(

BUG=None
TEST=None
TBR=erikkay

Review URL: http://codereview.chromium.org/159763

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22247 0039d316-1c4b-4281-b951-d872f2087c98

This papers over a race resulting from the original hack (which itself masks a real problem).
I am trying to find the real culprit (so this temp hack can be decomissioned) as part of <http://codereview.chromium.org/160447>.

BUG=http://crbug.com/16972

Review URL: http://codereview.chromium.org/160478

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22246 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/160276

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22245 0039d316-1c4b-4281-b951-d872f2087c98

Ever closer. Extract a client interface out of CrxInstaller
and use it to implement ExtensionInstallUI.

There is (still) no dialog here. But the next CL will, um,
definitely have it.

Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is
already previewed.

TBR=mpcomplete@chromium.org
BUG=17932

Review URL: http://codereview.chromium.org/160501

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22244 0039d316-1c4b-4281-b951-d872f2087c98

Updated Hunspell to version 1.2.8 which properly deals with UTF8 and fixes many bugs. This CL will use the BDict format and remove the usage of FileMgr. Removed the unwanted "key" parameter constructors from hunspell since we are managing them through bdict. Removed all line numbers from the errors  since we don't support that.

BUG= 14756 (http://crbug.com/14756)
TEST= Compiled Hunspell, Compiled Chromium, Ran Chromium, Fixed some of my spelling mistakes. Ran unit tests for SpellCheckTest.*
Review URL: http://codereview.chromium.org/155841

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22243 0039d316-1c4b-4281-b951-d872f2087c98

So it looks like some themeing engines in distros more recent than Hardy paint
random boxes of the default background if you don't pass an explicit clip area
to gtk_paint_shadow().

http://crbug.com/18129

Review URL: http://codereview.chromium.org/159754

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22242 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/160495

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22241 0039d316-1c4b-4281-b951-d872f2087c98

I introduced the error in r22193; it shows up when there's no X
server to connect to.  I get a "GLib-GObject-CRITICAL **:
g_object_get: assertion `G_IS_OBJECT (object)' failed" message with
this change, but I'm not sure if it's from my code or if it was
already there, and the tests still pass.

TEST=ran VisitedLinkEventsTest.Coalescense under Valgrind with DISPLAY=:6

Review URL: http://codereview.chromium.org/159753

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16661,18215,18218,18219
TEST=watch mac valgrind ui tests go greener

Review URL: http://codereview.chromium.org/159757

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22239 0039d316-1c4b-4281-b951-d872f2087c98

Also, fix the code that makes the unit tests have
consistent results.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160485

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16011
TEST=audio_renderer_base_unittest.cc and buffer_queue_unittest.cc
Review URL: http://codereview.chromium.org/155695

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22237 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159755

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22236 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvain

Review URL: http://codereview.chromium.org/160491

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22235 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22233 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159749

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22232 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mpcomplete@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22231 0039d316-1c4b-4281-b951-d872f2087c98

Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on shutdown due to a check in OwnedWidgetGtk for unbalanced refcnt.

The NativeViewHostGtk now owns the GtkWidget attached to it for the lifetime of its attachment. This removes my crazy ownership games from before and makes it a lot simpler.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159751

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22230 0039d316-1c4b-4281-b951-d872f2087c98

Add CreateTransparentFloatingWidget method to Widget and add Init/SetContentsView methods.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160474

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22229 0039d316-1c4b-4281-b951-d872f2087c98

use it to implement ExtensionInstallUI.

There is (still) no dialog here. But the next CL will, um,
definitely have it.

Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed.

BUG=17932

Review URL: http://codereview.chromium.org/160483

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22228 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=17772

Review URL: http://codereview.chromium.org/159748

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159739

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22225 0039d316-1c4b-4281-b951-d872f2087c98

declaration.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/159735

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159714

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18152
TEST=none

TBR=erg

Review URL: http://codereview.chromium.org/160488

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/159732

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22220 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159747


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22219 0039d316-1c4b-4281-b951-d872f2087c98

but the tabstrip wasn't in our widget hierarchy for app mode
windows.  Now we always put the tabstrip in the hierarchy, even
if we don't show it.

BUG=18202

Review URL: http://codereview.chromium.org/159745


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22218 0039d316-1c4b-4281-b951-d872f2087c98

ftp://ftp.mozilla.org/pub/addons/

The problem is that data was spooling on network stack and
after 8K data TCP Window size becomes small and no more
data is received after 8K.  The fix is to change the
ERROR_CLASS_INITIATED case in the ProcessResponseLIST
function to not go back to the STATE_CTRL_READ state.

In URLRequestNewFtpJob::ProcessFtpDir. construct the
std::string from buf->data() and its length so that
buf->data() doesn't need to be null-terminated.

Author: Ibrar Ahmed <ibrar.ahmad@gmail.com>

Original review: http://codereview.chromium.org/146137

R=wtc,phajdan.jr
BUG=http://crbug.com/4965
TEST=ftp://ftp.mozilla.org/pub/addons/
Review URL: http://codereview.chromium.org/159663

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22217 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mark
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/160487

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22216 0039d316-1c4b-4281-b951-d872f2087c98

Try increasing the stack size of the main thread, to see if it changes chromebot crashes.  Just a temporary change, I'll revert after a chromebot run.
Review URL: http://codereview.chromium.org/160486

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/16371

Review URL: http://codereview.chromium.org/159730

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22214 0039d316-1c4b-4281-b951-d872f2087c98

LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases.

BUG= http://crbug.com/18140
TEST= none.

Review URL: http://codereview.chromium.org/159711

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22213 0039d316-1c4b-4281-b951-d872f2087c98

Use a real notification for download completion - that's the main unflakying point.

TEST=none
http://crbug.com/3791

Review URL: http://codereview.chromium.org/160480

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22212 0039d316-1c4b-4281-b951-d872f2087c98

No chrome side changes.

TBR=brettw

Review URL: http://codereview.chromium.org/160482


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22211 0039d316-1c4b-4281-b951-d872f2087c98

The MessageLoop had to be modified to support Dispatchers on Linux.

BUG=None
TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests.

Review URL: http://codereview.chromium.org/159046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10809
TEST=Visit a sit with Flash content. Playback should work, interacting with the plugin is still buggy.

Review URL: http://codereview.chromium.org/159729

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22209 0039d316-1c4b-4281-b951-d872f2087c98

The root cause is a bug in the code. I'm working on a fix.

TEST=none
http://crbug.com/18036

Review URL: http://codereview.chromium.org/160484

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22208 0039d316-1c4b-4281-b951-d872f2087c98