- Dec 17, 2010
-
-
yurys@chromium.org authored
BUG=None TEST=None TBR=tonyg Review URL: http://codereview.chromium.org/5995001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69541 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=67301 TBR=glider Review URL: http://codereview.chromium.org/5993001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69539 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
Remove unnecessary double->Int64->double conversion. Conditionally Disable GeolocationPermissionContextTests.StopUpdating for client-based geolocation. BUG=59907 Review URL: http://codereview.chromium.org/5984001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69538 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This chage just suppresses the leak for Bug 67291 started since <http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20UI%20(valgrind)(2)/builds/841/steps/memory%20test:%20ui/logs/stdio>. I'm not sure what caused this leak, though. TBR=thestig,timurrrr BUG=67291 TEST=make the "Chromium Mac UI (valgrind)(2)" bot green. Review URL: http://codereview.chromium.org/5989001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69537 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change adds a suppression for Bug 67289, which started since <http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20(valgrind)(1)/builds/737>. TBR=thestig,timurrrr BUG=67289 TEST=make the "Linux Tests (valgrind)(1)" bot green Review URL: http://codereview.chromium.org/5987001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69534 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/5986001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69533 0039d316-1c4b-4281-b951-d872f2087c98
-
gfeher@chromium.org authored
Also try to make the handling of pref_ more robust by making it private and always initializing it in the constructor of subclasses. BUG=65925 TEST=ExtensionManagementTest.{ExternalUrlUpdate,ExternalPolicyRefresh} Review URL: http://codereview.chromium.org/5784004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69532 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69530 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
Test doing something that should throw an exception, and make sure the exception code is as expected. This depends on WebKit r74188. BUG=67006 TEST=browser_tests Review URL: http://codereview.chromium.org/5904004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69528 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@chromium.org authored
this has been upstreamed to webkit. Review URL: http://codereview.chromium.org/5980002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69527 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
It was reverted in 69437 because it seemed to have broken SSLUITest.TestHTTPWithBrokenHTTPSResource SSLUITest.TestHTTPSExpiredCertAndProceed SSLUITest.TestCNInvalidStickiness SSLUITest.TestRefNavigation on Linux & Linux64. But those tests passed on the try servers, still pass on my machine, and have nothing to do with my patch (that I can imagine). Landing when the tree is calm to see how it goes. BUG=64060 TEST=none TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/5983001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69526 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
Review URL: http://codereview.chromium.org/5977001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69525 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
BUG=65506 Review URL: http://codereview.chromium.org/5861008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69524 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
This is based on the original CL http://codereview.chromium.org/3142008. The key difference is * This uses Textfield framework and NativeTextfieldView implements NativeTextfieldWrapper. This allows us to swap the implementation without recompling the tree and can start testing on bots. * Changed the name of the model to TextfieldViewModel as TextfieldModel may be confusing as other Textfield implementations are not using it. I also changed to use string16 instead of gap buffer as it's enough for single line text. We can update the model to use GapBuffer when necessary. * Changed to use string16 as that's what chrome codebase should use. * Added a switch to turn on TextfieldView. I also filled a couple of features such as: * selection by key * mouse actions (move cursor, selection) * used WordIterator, which is i18n compatible, to move cursor by word * blinking cursor This is only for linux based build due to KeyStroke difference. I'm going to move some of test utlity function in chrome/browser/automation/ui_controls to app/test and will add more test once the migration is done. BUG=none TEST=new unit tests are added : NativeTestfieldViewTest and TextfieldViewModelTest. Review URL: http://codereview.chromium.org/5857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69523 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69522 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Some web sites don't understand 'en-US' but 'en' in Accept-Language header. Hence we should add 'en' in addition to 'en-US'. BUG=chromium-os:9884 TEST=Added Finnish and confirmed that Accept-Language looked like "en-US,en;q=0.8,fi;q=0.6" using http://pgl.yoyo.org/http/browser-headers.php. Also visited sidneyspage.blogspot.com and confirmed that English contents were shown. Review URL: http://codereview.chromium.org/5895005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69521 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
Screenshots: http://www.dropmocks.com/mNkqe BUG=47731 TEST=none Review URL: http://codereview.chromium.org/5857007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69520 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change moved the suppression rule for Bug 67261 to cover Chromium OS bots. TBR=thestig,timurrrr BUG=67261 TEST=make the "Chromium OS UI (valgrind)(3)" bot greener. Review URL: http://codereview.chromium.org/5898005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69519 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change suppresses occasional leaks in appcache::PrepareCachedStatement(), such as <http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20UI%20(valgrind)(1)/builds/730/steps/memory%20test:%20ui/logs/stdio>. TBR=thestig,timurrrr BUG=67261 TEST=make the "Chromium Mac UI (valgrind)(1)" bot green. Review URL: http://codereview.chromium.org/5934003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69518 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This just moves a suppression rule for Bug 56359 to Bug 42952 becuase it is also a SQL leak in CookieMonster. (Bug 56359 is a leak in URLRequest::Start(), which does not seem to be related to this rule.) TBR=thestig,timurrrr BUG=42942 TEST=none (This does not change any existing suppressions.) Review URL: http://codereview.chromium.org/5830007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69517 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=64388 TEST=none Review URL: http://codereview.chromium.org/5845004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69516 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change widen the suppression rule for Bug 49279 more to cover the same leak on Mac <http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20UI%20(valgrind)(1)/builds/729/steps/memory%20test:%20ui/logs/stdio>. TBR=thestig,timurrrr BUG=49279 TEST=make the "Chromium Mac (valgrind)(1)" bot greener. Review URL: http://codereview.chromium.org/5904006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69515 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
to be consumed by chrome. Among other things, this will allow the proxy to inform the user that the hostname could not be resolved or similar conditions. This adds a new OnHttpsProxyTunnelConnectionResponse method to StreamRequest::Delegate which is invoked when an HTTPS proxy returns a non-200, non-407 response. The method is called with an HttpResponseInfor argument to access the request headers, and an HttpStream argument to access the response body. BUG=none TEST=HttpNetworkTransactionTest Review URL: http://codereview.chromium.org/4935001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69513 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@google.com authored
BUG=none TEST=with pepper flash, rate control works Review URL: http://codereview.chromium.org/5944001 TBR=piman@google.com Review URL: http://codereview.chromium.org/5835007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69512 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@google.com authored
BUG=none TEST=with pepper flash, rate control works Review URL: http://codereview.chromium.org/5944001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69511 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/5941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69510 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5875005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69507 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
Because OpaqueBrowserFrameView overrides Layout and does not layout it's children we have to explicitly layout the keyboard. BUG=none TEST=keyboard now shows properly even immediately after startup Review URL: http://codereview.chromium.org/5847004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69505 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5913004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69504 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Added inputting i18n form file and write out and/or compare test result against expected test result in output directory. Also add the initial English version of test form html and expected test result file. BUG=60022 TEST=none Review URL: http://codereview.chromium.org/5781005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69503 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@google.com authored
correct asynchronous version of Importer. BUG=none TEST=none Review URL: http://codereview.chromium.org/5873005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69502 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5915005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69501 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
BUG=67233 Review URL: http://codereview.chromium.org/5841004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69500 0039d316-1c4b-4281-b951-d872f2087c98
-
dyu@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5151001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69499 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/5921005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69498 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
the gtk extension installed button doesn't need to be themed because the background is always white (and is not the tab color, like it is in most other places in the UI) the list item x isn't changing (the images are the same), only the URL is changing. I think this is the 'x' we want, because it's what we use on the NTP. BUG=none TEST=manual Review URL: http://codereview.chromium.org/5880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69497 0039d316-1c4b-4281-b951-d872f2087c98
-
dyu@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5692005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69496 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5854004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69495 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
If you try to exclude a test that hasn't been included, pyauto will complain and it won't run anything. Sometimes it's harder to add exclusions per platform, and it'd be easier to ignore tests that need to be excluded but haven't been included. Review URL: http://codereview.chromium.org/5913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69494 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
fixes the includes for cros to use "third_party" so that everything works. TEST=none BUG=none Review URL: http://codereview.chromium.org/5854003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69493 0039d316-1c4b-4281-b951-d872f2087c98
-