- Nov 03, 2009
-
-
mirandac@chromium.org authored
BUG= http://crbug.com/19282 TEST= Use report bug dialog on Mac OSX. Review URL: http://codereview.chromium.org/340039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30815 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/340069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30813 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-bot@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30811 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Add a CHECK when an object tries to remove itself as an observer from NotificationService but no matching entry is found. This is most likely an object being deleted on the wrong thread, and it'll lead to a crash later. BUG=25354 Review URL: http://codereview.chromium.org/342091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30801 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
The command line is: --fixed-server=host:port When set, all traffic will be diverted through this server. This is useful for testing purposes with fixed servers. BUG=none TEST=none Review URL: http://codereview.chromium.org/345034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30798 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
when scripts are allowed despite user preferences disabling them. Adds more accessors and comments to WebSecurityOrigin. Removes no longer necessary webkit_glue functions. Removes no longer necessary TemporaryGlue.h file. R=abarth BUG=none TEST=browser features like the new tab page and history view should still work when passing --disable-javascript to chrome. similarly, file and ftp directory listings should remain functional when that command line flag is specified. Review URL: http://codereview.chromium.org/351013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30797 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
document_idle." Original code review: http://codereview.chromium.org/339064 BUG=26126 TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30796 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
Remove some dead code. Remove valgrind suppression which suppressed this error. BUG=http://crbug.com/26489 TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping Review URL: http://codereview.chromium.org/355006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30793 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=26493 Review URL: http://codereview.chromium.org/353011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30789 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30787 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Semantically, document-idle means "when the DOM is ready and layout has been idle for awhile", or more loosely, "as soon as we get around to it". Right now this uses a simple heuristic. It injects scripts 200ms after DOMContentLoaded, or immediately after onload, whichever happens first. BUG=26126 TEST=Manual. Extensions with content scripts should work. Review URL: http://codereview.chromium.org/339064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30784 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=ExtensionsServiceTest shouldn't leak temp files. Review URL: http://codereview.chromium.org/342085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30781 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=http://crbug.com/23995 TEST=Uninstall Chrome Frame in such a way that a reboot is not required. Verify that a confirmation dialog appears. Review URL: http://codereview.chromium.org/355002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30780 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/276029/showmad@chromium.org authored
BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30778 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
BUG=26540 Review URL: http://codereview.chromium.org/341075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30776 0039d316-1c4b-4281-b951-d872f2087c98
-
pam@chromium.org authored
Reverting 30766. It caused failures in ui_tests BrowserTest.SingleBeforeUnloadAfterWindowClose and apparently made the browser_tests crash. BUG=26398 TEST=covered by ui_tests and browser_tests Review URL: http://codereview.chromium.org/354015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30775 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 02, 2009
-
-
estade@chromium.org authored
Handle GTK enter and leave notification events and pass them to WebKit as mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30771 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
might cause trouble and work around it. BUG=26181 TEST=keystone_install_test.sh It should now be possible to update Chrome when you have write permission on all of the directories but none of the files or symbolic links on disk. Review URL: http://codereview.chromium.org/341072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30768 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Need to add theme resources to this binary as well. Missed in r30755. TBR=rafael Review URL: http://codereview.chromium.org/348049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30767 0039d316-1c4b-4281-b951-d872f2087c98
-
pam@chromium.org authored
actually move to the next one in the queue instead. BUG=26398 TEST=Make sure alert/confirm boxes work properly. Make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Especially make sure http://crbug.com/10699 doesn't recur. Review URL: http://codereview.chromium.org/339094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30766 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
TODO: Use LoadLog in FLIP code. Review URL: http://codereview.chromium.org/344026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30765 0039d316-1c4b-4281-b951-d872f2087c98
-
yaar@chromium.org authored
(in preparation for upstreaming the api) Review URL: http://codereview.chromium.org/340049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30764 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
BUG=http://crbug.com/19408 TEST=Create a bookmark. Create 2 bookmark folders both with the same name, "foo". Go to your bookmarked page. Click STAR to get bookmark bubble. Change parent folder to the 1st "foo". Confirm it's there on the bar. Click STAR to get bookmark bubble. Change parent folder to the 2nd "foo". Confirm it's there on the bar. Click STAR to get bookmark bubble. Chose "choose another folder" to be sure that logic still works. Review URL: http://codereview.chromium.org/340042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30762 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Avoid a CHECK when the modal_loop_pump_messages_event handle comes in as NULL to the renderer. This happens with some "virus scanners". BUG=25583 Review URL: http://codereview.chromium.org/348046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30760 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@chromium.org authored
BUG=26502 TEST=none Review URL: http://codereview.chromium.org/345043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30758 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=26386 TEST=Try to print from the Page menu on the Mac; the Print item should be enabled. Review URL: http://codereview.chromium.org/341071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30757 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035 Review URL: http://codereview.chromium.org/348033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
(Related to http://codereview.chromium.org/348025) BUG=25097 TEST=RenderWidgetHostTest.ResizeThenCrash Review URL: http://codereview.chromium.org/353008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30753 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/348037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30751 0039d316-1c4b-4281-b951-d872f2087c98
-
craig.schlenter@chromium.org authored
Needed since r732 of gyp. TEST=Shared build on linux finds libs now without needing to manually adjust LD_LIBRARY_PATH. Review URL: http://codereview.chromium.org/340060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30749 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Fix a problem in the implementation of search-vs.-go-in-context-menus. We were eliding the text before passing it to the classifier, resulting in wrong destination URLs for elided strings. This also eliminates a couple string conversions and shortens the EscapeAmpersand() algorithm. BUG=1978 TEST=Highlight a long string in a page. Right-click it. Verify the string is elided in the context menu. Click the search entry. Verify the string you searched for is not elided. Review URL: http://codereview.chromium.org/343081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30745 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=25822 TEST=none Review URL: http://codereview.chromium.org/343067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30744 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
See http://codereview.chromium.org/340045 for the original code. This includes a newer version of GTM that solves the problem with nib loading on 10.6. TEST=http://codereview.chromium.org/340045 BUG=none Review URL: http://codereview.chromium.org/343082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30743 0039d316-1c4b-4281-b951-d872f2087c98
-
slightlyoff@chromium.org authored
BUG=26506 TEST=None Review URL: http://codereview.chromium.org/343085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30742 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
Conditionally added pepper_test_plugin.gyp as all.gyp dependency based on whether enable_pepper variable is set to 1. Defaults to 0. Added run_as block to automatically launch chrome and load the plugin when the pepper_test_plugin project is run or debugged. See new instructions in updated README. TEST=none BUG=none Review URL: http://codereview.chromium.org/343070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30741 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
Review URL: http://codereview.chromium.org/339079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30738 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30737 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Review URL: http://codereview.chromium.org/345039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30732 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726 TBR=estade Review URL: http://codereview.chromium.org/343080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30731 0039d316-1c4b-4281-b951-d872f2087c98
-