Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98

reverts menu_button to what it was before the fix. This way 19597 is
still fixed, and we don't have this crash. I'm working on a
regression test for coverage of this, but I don't want to hold up
anything with the fix. 

BUG=26279
TEST=see bug

Review URL: http://codereview.chromium.org/344043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30651 0039d316-1c4b-4281-b951-d872f2087c98

I'm submitting this as a separate CL so that the binary file lands and
that I can get good try server results.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/339091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30650 0039d316-1c4b-4281-b951-d872f2087c98

R=ananta
TEST=none
BUG=26372

Review URL: http://codereview.chromium.org/348026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26258
TEST=Border color of location bar matches the buttons on each side.

Review URL: http://codereview.chromium.org/348029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30648 0039d316-1c4b-4281-b951-d872f2087c98

autorelease pool in our run loop source if there is one already on the stack 
above us. This allows Cocoa to clean up all the objects at the same time as it 
expects to do. There may be more "interesting" code that can be removed now 
that this is in. Initially we were going to implement it by checking the 
nesting levels of the runloops, but it turns out by the time sendEvent is 
called at the upper level we are already out of the "CFRunloopRun" call so 
our nesting count isn't a valid indicator of our state.

TEST=1) See bug 25857. 2) Start up. Open 3+ windows. Quit.
BUG=25857

Review URL: http://codereview.chromium.org/343024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30647 0039d316-1c4b-4281-b951-d872f2087c98

the incoming index. Callers expect GL errors to be raised for out of
range indices.

BUG=http://crbug.com/26331
TEST=WebKit/LayoutTests/fast/canvas/webgl/getActiveTest.html
(preexisting test; there are two remaining failures which are bugs in
the test)

Review URL: http://codereview.chromium.org/348027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30646 0039d316-1c4b-4281-b951-d872f2087c98

In theory this should result in a slightly faster app startup.

I will do a follow up change to merge it on Windows and get rid of
the code related to the extra file.

BUG=24035

Review URL: http://codereview.chromium.org/344038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22307
TEST=none

Review URL: http://codereview.chromium.org/340051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30643 0039d316-1c4b-4281-b951-d872f2087c98

This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages.

BUG=25822
TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog.
Review URL: http://codereview.chromium.org/342048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30642 0039d316-1c4b-4281-b951-d872f2087c98

for messages recieved after the render view host has been NULLed, causing
crashers with select drop-downs.


BUG=25290
TEST=Make sure select drop-downs work and don't crash the browser.


Review URL: http://codereview.chromium.org/348022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30641 0039d316-1c4b-4281-b951-d872f2087c98

ajwong basic math: FAIL.

BUG=22307
TEST=Clobber built test shell in release and found sumo built.

Review URL: http://codereview.chromium.org/342066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25952
TEST=always exists "successfully"

Review URL: http://codereview.chromium.org/343068


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30639 0039d316-1c4b-4281-b951-d872f2087c98

Fix several MAJOR crashers in Chrome+LocalStorage/Extensions.  Need to explicitly call Stop() in destructor (before the vtable is torn down) since we override CleanUp().

Filed bug to make this impossible in the future: http://code.google.com/p/chromium/issues/detail?id=26365

TEST=DOMStorageTests UI tests don't fail.
BUG=25413,25746

Review URL: http://codereview.chromium.org/345028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25068
TEST=Install O3D, open about:plugins; O3D should not be listed.

Review URL: http://codereview.chromium.org/341058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30637 0039d316-1c4b-4281-b951-d872f2087c98

My local bots (both Linux and Mac) were cycling green with this option all the last week
except for one real race (fixed tonight) and two benign reports suppressed recently.
This option will help us find more races, especially my beloved ref-counter races.

TEST=TSAN bots should remain green
Review URL: http://codereview.chromium.org/348020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
Review URL: http://codereview.chromium.org/344040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25822
TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation.
Review URL: http://codereview.chromium.org/343051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30633 0039d316-1c4b-4281-b951-d872f2087c98

corresponding ChromiumBridge method return false.

It turns out that NPP is always null in Chrome (due to
out-of-process plugins), and as a result, we were always
returning false anyways.

R=jam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/346026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30632 0039d316-1c4b-4281-b951-d872f2087c98

Fall abck to the system default font if the preferred font isn't available.

Also, only create the SkPaint struct once, not on every paint.

Also, make some more things const.

BUG=25693
TEST=badge still looks good, that crash goes away

Review URL: http://codereview.chromium.org/341045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30631 0039d316-1c4b-4281-b951-d872f2087c98

Style fixes to reflect belated review feedback on http://codereview.chromium.org/340036.

BUG=26233
TEST=None

Review URL: http://codereview.chromium.org/342064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30630 0039d316-1c4b-4281-b951-d872f2087c98

I tried to just piggy-back off of existing chrome client calls (particularly focus()), but that didn't handle blurs. 

webkit side is here: http://codereview.chromium.org/328034/show 

BUG=453

original review: http://codereview.chromium.org/337032/show


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30629 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/338050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30628 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/344036


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=arthropod
TEST=none
Review URL: http://codereview.chromium.org/340046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23993
TEST=Open incognito window. Click the bookmark sync button. Either the signin dialog
or the options panel should open.

Review URL: http://codereview.chromium.org/350005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26274
TEST=grant notifications permissions and restart browser

Review URL: http://codereview.chromium.org/339077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30623 0039d316-1c4b-4281-b951-d872f2087c98

is just cleanup.

Take 2 with a fix in sync code.

TBR=evanm

Review URL: http://codereview.chromium.org/350007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22307
TEST=built.

Review URL: http://codereview.chromium.org/343064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30621 0039d316-1c4b-4281-b951-d872f2087c98

Improve error message in the extension api docs build script.  When the json file used to build the html documentation is unreadable or has a syntax error, gives a clear error message.

BUG=18717
TEST=Manualy tested a missing input file and a file with a syntax error.

Review URL: http://codereview.chromium.org/343052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30620 0039d316-1c4b-4281-b951-d872f2087c98

of HtmlDialogView.

Added TODO to fix inaccurate font height metric for OS X font class (and maybe width).

Added the BrowserCommandExecutor protocol so that not just a
BrowserWindowController can be the window controller for a
ChromeEventProcessingWindow.

Added unittests.  Also tested manually with the bookmark sync setup
wizard dialog.

BUG=23073
TEST=added unittests, trybot, and manual testing

Review URL: http://codereview.chromium.org/344008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30618 0039d316-1c4b-4281-b951-d872f2087c98

R=darin
BUG=24596
TEST=no regressions

Review URL: http://codereview.chromium.org/343060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25620
TEST=Close all windows, try History->History (Cmd-Y); close window, try Window->Downloads (Shift-Cmd-J); close window, try Open Location... (Cmd-L).

Review URL: http://codereview.chromium.org/329004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30615 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/339086


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30614 0039d316-1c4b-4281-b951-d872f2087c98

an earlier webkit roll.

TBR=ojan

Review URL: http://codereview.chromium.org/343062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30613 0039d316-1c4b-4281-b951-d872f2087c98

Add storage API for simulating storage errors.

TEST=verify appcache update wrote to storage correctly
BUG=none

Review URL: http://codereview.chromium.org/326002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Enable bookmark sync, close and re-launch chrome, make sure there are no sync error message at the bottom of the NTP.

Original patch by albertb@chromium.org
Committed by davemoore@chromium.org

Review URL: http://codereview.chromium.org/341012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30611 0039d316-1c4b-4281-b951-d872f2087c98

2. Write the crash stack out to layout-test-results/LayoutTests/foo/bar-stack.txt
3. Add a link to the stack file in results.html
Review URL: http://codereview.chromium.org/346018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30610 0039d316-1c4b-4281-b951-d872f2087c98