git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61753,62461
TBR=glider
TEST=./tools/valgrind/waterfall.sh
Review URL: http://codereview.chromium.org/4651004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65647 0039d316-1c4b-4281-b951-d872f2087c98

a) Unknown nonzero error codes disappeared after the bot recovery
   (it was showing a "Recovered from a BSOD" message)
b) The CookieMonster tests were failing due to slow stl checks in Debug mode.
   This should be fixed by r65377 and r65384
BUG=62512,59642
TEST=TSan/Win should remain green
TBR=glider
Review URL: http://codereview.chromium.org/4713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65646 0039d316-1c4b-4281-b951-d872f2087c98

Upstreamed test expectations.

BUG=60384,60393,60651,60671,31342,61739,48982
TEST=none
TBR=mihaip

Review URL: http://codereview.chromium.org/4673008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8974
TEST=run unittest

Review URL: http://codereview.chromium.org/4703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:2287
TEST=Download a large file.  Pause the download.  Check that the rate changes to 0B/s

Review URL: http://codereview.chromium.org/4693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65642 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr

Review URL: http://codereview.chromium.org/4734003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=mihaip

Review URL: http://codereview.chromium.org/4664007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65639 0039d316-1c4b-4281-b951-d872f2087c98

time.

Bug=62636
TBR=joi

Review URL: http://codereview.chromium.org/4727004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65638 0039d316-1c4b-4281-b951-d872f2087c98

I think this issue was introduced in
http://codereview.chromium.org/3619002

We need to subtract margins from page size to calculate the size of printable areas.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4732002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65635 0039d316-1c4b-4281-b951-d872f2087c98

Fetch username/passwd from private data and use in sync tests.

BUG=60970

Review URL: http://codereview.chromium.org/4738004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65634 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4729002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=mihaip

Review URL: http://codereview.chromium.org/4732006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8967
TEST=none
TBR=dpolukhin
Review URL: http://codereview.chromium.org/4768001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65627 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc
BUG=none
TEST=SSLClientSocketTest*

Review URL: http://codereview.chromium.org/4130005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65626 0039d316-1c4b-4281-b951-d872f2087c98

Addresses an assert fired on the Mac whenever a new ConstrainedDialog is opened
in the sheet end callback of another dialog, either from two consecutive sheets
or having another sheet in the queue. This assert was fired from the client
certificate selection dialog.

(Also add myself to the AUTHORS file since I apparently never got around to
doing that for contributions after my internship.)

R=avi
BUG=56948
TEST=none

Review URL: http://codereview.chromium.org/4638005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65625 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade,jshin
BUG=61206
TEST=<http://codereview.chromium.org/4477002>
Review URL: http://codereview.chromium.org/4664001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65624 0039d316-1c4b-4281-b951-d872f2087c98

Also remove the other using directives, most of which were already explicitly qualified at various places in the file anyway.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4660009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8304
TEST=manually show password field (click on password protected wireless network or "join other network...") and make some network change (disconnect ethernet cable etc.), and check if the status is unchanged, then close the password field by any possible means and check if status update is working.

Review URL: http://codereview.chromium.org/4705003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65617 0039d316-1c4b-4281-b951-d872f2087c98

It derives from UITestBase.

TEST=ui_tests
BUG=62602

Review URL: http://codereview.chromium.org/4662005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65616 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65615 0039d316-1c4b-4281-b951-d872f2087c98

quite simple and just sets up the PPAPI dispatcher and loads the library.

There is a new command line switch --ppapi-out-of-process which runs PPAPI
plugins out of process using the new code path. There is some logic in
RenderView and PepperPluginModule for setting up this connection, but it should
be straightforward.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3915002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65614 0039d316-1c4b-4281-b951-d872f2087c98

the version mismatch warning dialog. Used this in ceee/ to only show
it once per tab.

Changed the logic in Firefox to show the warning dialog even when
in privileged mode. This will mean it gets shown once per Firefox
window.

Wrote a unit test for the additional logic in ChromeFrameActivex.

To write the unit test, used com_mock.py to generate a mock of
the IChromeFramePrivileged interface. This can be extended to
generate mocks of the other CF interfaces.

Discovered duplication of np_browser_functions.h and .cc, resolved
this to a single copy (the one under chrome_frame).

Changed things around so chrome_tab.idl is built only once; this
also lets me more easily depend on it in the com_mock rule.

BUG=none
TEST=chrome_frame_unittests.exe


Review URL: http://codereview.chromium.org/4563001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65613 0039d316-1c4b-4281-b951-d872f2087c98

messages bounced to the parent and wires it up for autocompleteedit,
which I'm going to need shortly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4637002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65612 0039d316-1c4b-4281-b951-d872f2087c98

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/4655003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65610 0039d316-1c4b-4281-b951-d872f2087c98

Update actions_in_current_group when removing an action so that it doesn't crash
afterwards.

BUG=61607,62609
TEST=manual (see bug)

Do not set text if it didn't change, because it registers a delete/insert undo-able action-couple.

Review URL: http://codereview.chromium.org/4683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65609 0039d316-1c4b-4281-b951-d872f2087c98

change:

This bug was causing problems with running unittests on the buildbots.

In particular, the code that patched the signature of the restorer function was
corrupting the FPU state.

And we couldn't debug this problem easily, because the missing NX support then
broke signal handling.

Evan helped with finding a reproducible test scenario in a Hardy VM, and after
applying this change the unittest (e.g. Chrome's browser_tests) succeeds.

Description:
On older 32bit kernels (e.g. Ubuntu Hardy), the seccomp sandbox fails to handle
signals correctly. This is primarily a result of the kernel not supporting
non-executable data segments. But it also runs into problems because the
format of the signal frame is subtly different and does not appear to always
include a "magic restorer function".

This changelist removes all dependencies on NX support from the 32bit version
of the code. And it eliminates the code that patches the restorer function.

Both of these features were originally added to make it easier for gdb to
debug code that runs inside of a signal handler. But given the observed problems
with this approach, it does not seem worth the effort.

64bit code seems unaffected by all of these problems -- presumably because
that architecture is a lot more recent. So, we'll not make any changes to it.

BUG=http://code.google.com/p/seccompsandbox/issues/detail?id=5
TEST=make test

Review URL: http://codereview.chromium.org/4732004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65608 0039d316-1c4b-4281-b951-d872f2087c98

It was affecting tests other than ui_tests and browser_tests, which potentially need to use regular GL. For example, plugins expect to be able to use regular GL with core animation.

In the future, we should be able to make more tests use osmesa by allowing a regular GL surface to be read back into an OSMesa surface in AcceleratedSurface on Mac.

TEST=ui_tests, browser_tests
BUG=62602

Review URL: http://codereview.chromium.org/4761001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65604 0039d316-1c4b-4281-b951-d872f2087c98

two window open notifications for the window pattern Internet Explorer*. Not clear why.

Updated the expectations of the test to account for this.

Review URL: http://codereview.chromium.org/4700003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65603 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/4632002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65602 0039d316-1c4b-4281-b951-d872f2087c98

TBR=chocobo@chromium.org
BUG=chromium-os:8718
TEST=open context/status menu and test if mouse click selects the menu item.

Review URL: http://codereview.chromium.org/4692002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65600 0039d316-1c4b-4281-b951-d872f2087c98

tests on a machine separate from your build machine. Useful e.g. if you
are running IE9 on your build machine, which the tests currently aren't
fully compatible with, or if you'd like to get other work done while the
tests run.

BUG=none
TEST=try out the instructions, see if they work

Review URL: http://codereview.chromium.org/4676003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65599 0039d316-1c4b-4281-b951-d872f2087c98

1. Introduced SandboxedFileSystemOperation.
2. Factored out most of the PathManager/QuotaManager related code from
FileSystemDispatcherHost to the SandboxedFileSystemOperation.

BUG=60243
TEST=none

Review URL: http://codereview.chromium.org/4054003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65598 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Remove a most visited site. The notification should be shown.

Review URL: http://codereview.chromium.org/4633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65596 0039d316-1c4b-4281-b951-d872f2087c98

not render any content until the user clicked on them. This is because in this context
IE8 attempts to inplace activate the object with the active document as the doc host.
We don't support in place activation and return E_NOTIMPL.

However ieframe specifically expects the return value to be OLEOBJ_E_INVALIDVERB and ends
up not sending in the other verbs like OLEIVERB_SHOW, OLEIVERB_UIACTIVATE etc leading to
this problem.

Fixes bug http://b/issue?id=3174688

Bug=3174688

Review URL: http://codereview.chromium.org/4690004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65595 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/4731001

Review URL: http://codereview.chromium.org/4719003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61605
TEST=In the bug
Review URL: http://codereview.chromium.org/4693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65592 0039d316-1c4b-4281-b951-d872f2087c98

  * Implement a _parse_source_data method to parse sample sources more efficiently.
  * Generate a hash of all source code for each sample.
  * Add hash to zip files in a file named VERSION.
  * Do not write zip files for samples where the hash has not changed.
  * Print modified zips in the 'Following files have changed' warning.
  * Sort keys in samples.json alphabetically when writing that file.

BUG=61024
TEST=See bug

Review URL: http://codereview.chromium.org/4106007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65591 0039d316-1c4b-4281-b951-d872f2087c98

Various cleanups.
BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/4476003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=29020,35221,62143,62595
TEST=N/A

Review URL: http://codereview.chromium.org/4759001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65589 0039d316-1c4b-4281-b951-d872f2087c98