Commits · 40142ec8cafdcc64595bde3dbf7354140915e88d · MediaTek / aiot / chromium / src

Aug 05, 2010

o3d: create a gles v2 context for the native gles2 backend · 40142ec8

piman@chromium.org authored 14 years ago

Review URL: http://codereview.chromium.org/3050038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55114 0039d316-1c4b-4281-b951-d872f2087c98

40142ec8

AutoFill: Add a re-sized generic CC icon. · fd133584

jhawkins@chromium.org authored 14 years ago

BUG=51077
TEST=none

Review URL: http://codereview.chromium.org/3036047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55112 0039d316-1c4b-4281-b951-d872f2087c98

fd133584

Change the existing extension samples page to an automatically-generated searchable directory. · 389509ac

kurrik@chromium.org authored 14 years ago

 * Fixes a typo in the maps_app sample that prevents the manifest from being parsed as valid JSON.
 * Adds code to build a samples.json file in the documentation root, for use by the jstemplate docs rendering process.
 * Adds build/sample.py, a class which parses an individual sample's metadata out of the filesystem
 * Adds css/samples.css for directory-specific styles (could be merged into base styles if this is an issue)
 * Adds images/sample-default-icon.png for samples which don't have 128px icons.
 * Adds js/sample_search.js as the source for the sample search code (was difficult to escape this through the JSTemplate code without being in a different file).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/2957009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55111 0039d316-1c4b-4281-b951-d872f2087c98

389509ac

libjingle roll: 24:27 · d50c2c49

sergeyu@chromium.org authored 14 years ago

In this libjingle version the problem with PseudoTCP P2P connections has been
fixed, as well as bunch of clang compilation issues.

BUG=50245
TEST=unittests

Review URL: http://codereview.chromium.org/3084019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55110 0039d316-1c4b-4281-b951-d872f2087c98

d50c2c49

Leftovers from wstring->string16 conversion in authentication code. · 294f0b4e

cbentzel@chromium.org authored 14 years ago

I'm really confused how this even compiled in the first case (such as the npos comparison).

BUG=50517
TEST=net_unittests, tested on Ubuntu against NTLM server + proxy.

Review URL: http://codereview.chromium.org/2808107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55109 0039d316-1c4b-4281-b951-d872f2087c98

294f0b4e

Disable two SPDY tests, as they sometimes crash net_unittest. · 2ff0bd0c

erikchen@google.com authored 14 years ago

Working on fix.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3084018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55108 0039d316-1c4b-4281-b951-d872f2087c98

2ff0bd0c

Check in a little toy that graphs history of words in the source. · 90aafff5

evan@chromium.org authored 14 years ago

Useful for tracking progress on projects like wstring removal.

Review URL: http://codereview.chromium.org/3017058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55107 0039d316-1c4b-4281-b951-d872f2087c98

90aafff5

Change top of search engine dialog to reflect newest omnibox. · 2c529af0

mirandac@chromium.org authored 14 years ago

BUG= 50095
TEST= new search engine dialog looks like current omnibox.
Review URL: http://codereview.chromium.org/3018041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55104 0039d316-1c4b-4281-b951-d872f2087c98

2c529af0

Refactored extension privilege enumeration and implemented URLPattern comparisons. · 8b3b54b4

cdn@chromium.org authored 14 years ago

This will allow checks on per origin extension resource access. Added origin
check when loading extension resources. 

BUG=45876
TEST=ExtensionTest.IsPrivilegeIncrease 
TEST=ExtensionTest.EffectiveHostPermissions
TEST=ExtensionBrowserTest.OriginPrivileges

Review URL: http://codereview.chromium.org/2808051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55103 0039d316-1c4b-4281-b951-d872f2087c98

8b3b54b4

Sending renderer notification when update job finishes (Used to notify cache complete). · 4164a731

kkanetkar@chromium.org authored 14 years ago

OnCacheSelected() event caches appcache info in appcache host. This
info is returned for appcache inspection by devtools.

BUG = None
TEST = Manual

Review URL: http://codereview.chromium.org/3074015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55101 0039d316-1c4b-4281-b951-d872f2087c98

4164a731

Fix DownloadUtilTest on Mac. Not sure what causes the difference. · 145f6e49

phajdan.jr@chromium.org authored 14 years ago

TBR=ahendrickson

TEST=unit_tests
BUG=48913

Review URL: http://codereview.chromium.org/3058052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55100 0039d316-1c4b-4281-b951-d872f2087c98

145f6e49

Remove the coordinate hack for zoomed plugin pages on the Mac. · 22329946

stuartmorgan@chromium.org authored 14 years ago

Now that the underlying bug is fixed, the relative coordinates can be trusted regardless of zoom level.

BUG=51078
TEST=Mouseovers should still work in all plugins on the Mac.

Review URL: http://codereview.chromium.org/3072026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55099 0039d316-1c4b-4281-b951-d872f2087c98

22329946

Add debuggin CHECK to help track down ExtensionHost crasher · f128af44

rafaelw@chromium.org authored 14 years ago

Hopefully this well tells us whether it's the ExtensionHost that has been deleted.

BUG=49114
TEST=none

Review URL: http://codereview.chromium.org/2883057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55097 0039d316-1c4b-4281-b951-d872f2087c98

f128af44

Better fix for Windows test failure. Delete the old file · aacd6561

tony@chromium.org authored 14 years ago

before trying to copy the plugin files over.

Review URL: http://codereview.chromium.org/3052041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55096 0039d316-1c4b-4281-b951-d872f2087c98

aacd6561

Implement server push protocol 2. · e3ebba0f

erikchen@google.com authored 14 years ago

TEST=net_unittests
BUG=34761

Review URL: http://codereview.chromium.org/3020032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55095 0039d316-1c4b-4281-b951-d872f2087c98

e3ebba0f

Fix unit_tests on Mac by renaming the MAc test name for DownloadUtilMacTest. · 1b7cde15

phajdan.jr@chromium.org authored 14 years ago

TBR=thakis

TEST=unit_tests
BUG=48913, 21479

Review URL: http://codereview.chromium.org/3085015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55094 0039d316-1c4b-4281-b951-d872f2087c98

1b7cde15

DOMUI: Base framework for the AutoFill page. · 1cd00632

jhawkins@chromium.org authored 14 years ago

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3044047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55093 0039d316-1c4b-4281-b951-d872f2087c98

1cd00632

Revert 55071 - Reland 54771 (and 54795) To enable TCP Preconnection by default · d6149fde

dhollowa@chromium.org authored 14 years ago

Leaks reported with this CL.

http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/6130/steps/heapcheck%20test:%20net/logs/stdio

Eg.

Leak of 24 bytes in 1 objects allocated from:
	 @ 84aece net::SSLClientSocketNSS::BufferRecv
	 @ 84b161 net::SSLClientSocketNSS::DoTransportIO
	 @ 84ca1f net::SSLClientSocketNSS::DoHandshakeLoop
	 @ 84ca6b net::SSLClientSocketNSS::OnHandshakeIOComplete
	 @ 84cadc net::SSLClientSocketNSS::OnRecvComplete
	 @ 84cbb0 net::SSLClientSocketNSS::BufferRecvComplete
	 @ 84ea4b void DispatchToMethod
	 @ 84ea7b CallbackImpl::RunWithParams
	 @ 4b3a10 CallbackRunner::Run
	 @ 853e7e net::TCPClientSocketLibevent::DoReadCallback
	 @ 85426f net::TCPClientSocketLibevent::DidCompleteRead
	 @ 856a5c net::TCPClientSocketLibevent::ReadWatcher::OnFileCanReadWithoutBlocking
	 @ 93d8fd base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking
	 @ 93d966 base::MessagePumpLibevent::OnLibeventNotification
	 @ 9da639 event_process_active
	 @ 9da923 event_base_loop
	 @ 93dfd0 base::MessagePumpLibevent::Run
	 @ 8f2873 MessageLoop::RunInternal
	 @ 8f2893 MessageLoop::RunHandler
	 @ 8f2938 MessageLoop::Run
	 @ 44b7f9 TestCompletionCallback::WaitForResult
	 @ 6a1ee6 SSLClientSocketTest_ConnectMismatched_Test::TestBody
	 @ 961831 testing::Test::Run
	 @ 965026 testing::internal::TestInfoImpl::Run
	 @ 96515c testing::TestCase::Run
	 @ 965bbe testing::internal::UnitTestImpl::RunAllTests
	 @ 965d35 testing::UnitTest::Run
	 @ 4a4bf7 TestSuite::Run
	 @ 4a3b6d main
	 @ 2adff5bb11c4 __libc_start_main

Suppression:
{
   <insert_a_suppression_name_here>
   Heapcheck:Leak
   fun:net::SSLClientSocketNSS::BufferRecv
   fun:net::SSLClientSocketNSS::DoTransportIO
   fun:net::SSLClientSocketNSS::DoHandshakeLoop
   fun:net::SSLClientSocketNSS::OnHandshakeIOComplete
   fun:net::SSLClientSocketNSS::OnRecvComplete
   fun:net::SSLClientSocketNSS::BufferRecvComplete
   fun:void DispatchToMethod
   fun:CallbackImpl::RunWithParams
   fun:CallbackRunner::Run
   fun:net::TCPClientSocketLibevent::DoReadCallback
   fun:net::TCPClientSocketLibevent::DidCompleteRead
   fun:net::TCPClientSocketLibevent::ReadWatcher::OnFileCanReadWithoutBlocking
   fun:base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking
   fun:base::MessagePumpLibevent::OnLibeventNotification
   fun:event_process_active
   fun:event_base_loop
   fun:base::MessagePumpLibevent::Run
   fun:MessageLoop::RunInternal
   fun:MessageLoop::RunHandler
   fun:MessageLoop::Run
   fun:TestCompletionCallback::WaitForResult
   fun:SSLClientSocketTest_ConnectMismatched_Test::TestBody
   fun:testing::Test::Run
   fun:testing::internal::TestInfoImpl::Run
   fun:testing::TestCase::Run
   fun:testing::internal::UnitTestImpl::RunAllTests
   fun:testing::UnitTest::Run
   fun:TestSuite::Run
   fun:main
   fun:__libc_start_main
}




I added defensive code in ClientSocketHandle::ReleaseSocket(),
which should preclude the crash that was reported on the
stability bot.

I added a second call to ReleaseSocket() from
~ClientSocketHandle to ensure that we updated the
related ClientSocket when we are torn down.

r=mbelshe
Review URL: http://codereview.chromium.org/3071022

TBR=jar@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55090 0039d316-1c4b-4281-b951-d872f2087c98

d6149fde

Clean up download code: · 7ba53e1d

phajdan.jr@chromium.org authored 14 years ago

- move filename generation parts and related code out of DownloadManager
  download_util is not the best place for it, but it's better than
  DownloadManager which we're trying to minimize

- clean up posting tasks to different threads. There's no need to create
  separate methods for that, it was cluttering the file needlessly

- other minor cleanups, like using static_cast instead of C-style cast

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3043048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55088 0039d316-1c4b-4281-b951-d872f2087c98

7ba53e1d

Modify the SPDY v1 hack to only advertise v1 and not v2 over NPN. · f0f569e6

mbelshe@chromium.org authored 14 years ago

There is no point in advertising a protocol that won't work.  (When
in v1 mode, the protocol frames will all say v1, which, to a v2 server
will likely be broken

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3072025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55086 0039d316-1c4b-4281-b951-d872f2087c98

f0f569e6

Revert 55072 - Revert 55063 - WebKit roll: 64705:64742. · 8a99eb44

dhollowa@chromium.org authored 14 years ago

TBR=jianli

Reverting this roll didn't seem to affect the test failures.  So am reverting the revert.

Mac 10.6 Bot were failing after this change in unit_tests and interactive_ui_tests.  Failures seen:

Failing tests:
BrowserFocusTest.ClickingMovesFocus
BrowserFocusTest.TabsRememberFocus
BrowserFocusTest.FAILS_TabsRememberFocusFindInPage
BrowserFocusTest.BackgroundBrowserDontStealFocus
BrowserFocusTest.FAILS_FocusTraversal
BrowserFocusTest.FAILS_FocusTraversalOnInterstitial
BrowserFocusTest.FindFocusTest
BrowserKeyEventsTest.CommandKeyEvents
BrowserKeyEventsTest.FLAKY_ReservedAccelerators
MouseLeaveTest.FAILS_TestOnMouseOut

Note: Google Test filter = BrowserFocusTest.ClickingMovesFocus
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserFocusTest
[ RUN      ] BrowserFocusTest.ClickingMovesFocus
...
/b/slave/chromium-dbg-mac-builder/build/src/chrome/../chrome/browser/browser_focus_uitest.cc:182: Failure
Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)
  Actual: false
Expected: true


and

[----------] 2 tests from BrowserWindowFullScreenControllerTest
[ RUN      ] BrowserWindowFullScreenControllerTest.TestFullscreen
[       OK ] BrowserWindowFullScreenControllerTest.TestFullscreen (375 ms)
[ RUN      ] BrowserWindowFullScreenControllerTest.TestActivate
/b/slave/chromium-dbg-mac-builder/build/src/chrome/browser/cocoa/browser_window_controller_unittest.mm:600: Failure
Value of: [controller_ createFullscreenWindow]
  Actual: 0xa9a4890
Expected: frontmostWindow
Which is: 0x1e256e60
[  FAILED  ] BrowserWindowFullScreenControllerTest.TestActivate (63 ms)
[----------] 2 tests from BrowserWindowFullScreenControllerTest (438 ms total)




Review URL: http://codereview.chromium.org/3072024

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3051035

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/3067034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55085 0039d316-1c4b-4281-b951-d872f2087c98

8a99eb44

Don't sync prefs::kAutoFillAuxiliaryProfilesEnabled on non-mac · be354e6a

skrul@chromium.org authored 14 years ago

BUG=51209

Review URL: http://codereview.chromium.org/3040037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55083 0039d316-1c4b-4281-b951-d872f2087c98

be354e6a

Fix the call to setClearingState which was causing a javascript error. · 89ad9791

csilv@chromium.org authored 14 years ago

BUG=none
TEST=Verify that dom-ui options window shows no javascript errors in the dev-tools panel.
Review URL: http://codereview.chromium.org/3061053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55082 0039d316-1c4b-4281-b951-d872f2087c98

89ad9791

[Mac] Flip the otr guy around. · a3275357

rohitrao@chromium.org authored 14 years ago

BUG=None
TEST=Otr guy should face in.
Review URL: http://codereview.chromium.org/3073027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55081 0039d316-1c4b-4281-b951-d872f2087c98

a3275357

Minor change to: http://codereview.chromium.org/3064033 · 351ab641

rch@chromium.org authored 14 years ago

to fix valgrind detected memeory leak.  Instead of
storing the spdy session in a smart pointer member
field, use a smart pointer local var in the method.
We end up checking the pool twice, but c'est la vie.
 
Refactor HttpNetworkTransaction to eliminate the SPDY
specific states of the state machine.  This required
adding two new states:

      STATE_INIT_STREAM
      STATE_INTI_STREAM_COMPLETE

The http_stream_ and spdy_http_stream_ member fields
have been removed, and replaced by a single stream_
member field which is initialized with either an
HttpBasicStream, or SpdyHttpStream depending on the
underlying connection.

In the process, the NetLog no longer receives TYPE_SPDY
events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc
needed to be modified accordingly.

BUG=50267
TEST=none

Review URL: http://codereview.chromium.org/3051034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55080 0039d316-1c4b-4281-b951-d872f2087c98

351ab641

Revert 55065 - Update V8 to version 2.3.5.1 · 878b0911

sgjesse@chromium.org authored 14 years ago

Looks as if this causes consistent failure of unit_tests/TestActivate on Mac 10.6.

TBR=sgjesse@google.com
Review URL: http://codereview.chromium.org/3051036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55078 0039d316-1c4b-4281-b951-d872f2087c98

878b0911

Revert 55063 - WebKit roll: 64705:64742. · 0e437ee0

dhollowa@chromium.org authored 14 years ago

TBR=jianli

Mac 10.6 Bot were failing after this change in unit_tests and interactive_ui_tests.  Failures seen:

Failing tests:
BrowserFocusTest.ClickingMovesFocus
BrowserFocusTest.TabsRememberFocus
BrowserFocusTest.FAILS_TabsRememberFocusFindInPage
BrowserFocusTest.BackgroundBrowserDontStealFocus
BrowserFocusTest.FAILS_FocusTraversal
BrowserFocusTest.FAILS_FocusTraversalOnInterstitial
BrowserFocusTest.FindFocusTest
BrowserKeyEventsTest.CommandKeyEvents
BrowserKeyEventsTest.FLAKY_ReservedAccelerators
MouseLeaveTest.FAILS_TestOnMouseOut

Note: Google Test filter = BrowserFocusTest.ClickingMovesFocus
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BrowserFocusTest
[ RUN      ] BrowserFocusTest.ClickingMovesFocus
...
/b/slave/chromium-dbg-mac-builder/build/src/chrome/../chrome/browser/browser_focus_uitest.cc:182: Failure
Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)
  Actual: false
Expected: true


and

[----------] 2 tests from BrowserWindowFullScreenControllerTest
[ RUN      ] BrowserWindowFullScreenControllerTest.TestFullscreen
[       OK ] BrowserWindowFullScreenControllerTest.TestFullscreen (375 ms)
[ RUN      ] BrowserWindowFullScreenControllerTest.TestActivate
/b/slave/chromium-dbg-mac-builder/build/src/chrome/browser/cocoa/browser_window_controller_unittest.mm:600: Failure
Value of: [controller_ createFullscreenWindow]
  Actual: 0xa9a4890
Expected: frontmostWindow
Which is: 0x1e256e60
[  FAILED  ] BrowserWindowFullScreenControllerTest.TestActivate (63 ms)
[----------] 2 tests from BrowserWindowFullScreenControllerTest (438 ms total)




Review URL: http://codereview.chromium.org/3072024

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3051035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55072 0039d316-1c4b-4281-b951-d872f2087c98

0e437ee0

Reland 54771 (and 54795) To enable TCP Preconnection by default · 78ed550d

jar@chromium.org authored 14 years ago

I added defensive code in ClientSocketHandle::ReleaseSocket(),
which should preclude the crash that was reported on the
stability bot.

I added a second call to ReleaseSocket() from
~ClientSocketHandle to ensure that we updated the
related ClientSocket when we are torn down.

r=mbelshe
Review URL: http://codereview.chromium.org/3071022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55071 0039d316-1c4b-4281-b951-d872f2087c98

78ed550d

New translate tests for pyauto.py · 14a0aacb

alyssad@chromium.org authored 14 years ago

This also includes a change to WaitUntilTranslateComplete.

Review URL: http://codereview.chromium.org/3030042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55070 0039d316-1c4b-4281-b951-d872f2087c98

14a0aacb

Including pthread.h, compile fix for Android. · 166326c6

bulach@chromium.org authored 14 years ago

pthread.h does not get including through the other include files on Android.
Original change: http://codereview.chromium.org/2808076/show, landing on behalf of Kristian.

Review URL: http://codereview.chromium.org/3007034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55069 0039d316-1c4b-4281-b951-d872f2087c98

166326c6

Disable EULA/update/register screens for non-official builds. · 8c075b36

nkostylev@google.com authored 14 years ago

BUG= http://crosbug.com/4646
TEST=Manual. These screens should not be shown on dev builds. Testing accelerators still work.

Review URL: http://codereview.chromium.org/3023039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55068 0039d316-1c4b-4281-b951-d872f2087c98

8c075b36

Fixes bug in tab dragging when rtl where the dragged tab was · 07e6950b

sky@chromium.org authored 14 years ago

incorrectly positioned.

BUG=51219
TEST=see bug

Review URL: http://codereview.chromium.org/3091008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55067 0039d316-1c4b-4281-b951-d872f2087c98

07e6950b

Add residual-style webkit tests suppression until the roll. · 7efbda02

pfeldman@chromium.org authored 14 years ago

TBR=jianli

Review URL: http://codereview.chromium.org/3013060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55066 0039d316-1c4b-4281-b951-d872f2087c98

7efbda02

Update V8 to version 2.3.5.1 · 1740026f

sgjesse@google.com authored 14 years ago

BUG=none
TEST=none
TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/3018039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55065 0039d316-1c4b-4281-b951-d872f2087c98

1740026f

Use suppressions_mac.txt for Mac-specific reports · c8c81376

timurrrr@chromium.org authored 14 years ago

TBR=glider
Review URL: http://codereview.chromium.org/3020069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55064 0039d316-1c4b-4281-b951-d872f2087c98

c8c81376

WebKit roll: 64705:64742. · e21ce0e9

pfeldman@chromium.org authored 14 years ago

TBR=jianli

Review URL: http://codereview.chromium.org/3072024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55063 0039d316-1c4b-4281-b951-d872f2087c98

e21ce0e9

Fetch OEM services customization manifest from URL async. · e67090cd

dpolukhin@chromium.org authored 14 years ago

BUG=chromium-os:5123
TEST=none

Review URL: http://codereview.chromium.org/3026048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55062 0039d316-1c4b-4281-b951-d872f2087c98

e67090cd

EULA screen enabling/disabling crash/metrics reporting renovated. · 75cf0f64

glotov@chromium.org authored 14 years ago

BUG=chromium-os:2884
TEST=none

Review URL: http://codereview.chromium.org/3069028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55061 0039d316-1c4b-4281-b951-d872f2087c98

75cf0f64

Prettify blocked plugin HTML UI: · c3dae0a2

bauerb@chromium.org authored 14 years ago

* Make run plugin link look more like a link (blue and underlined on hover).
* Change wording to "Run plug-in this time" ("load plug-in" might get confused with installing a plug-in)
* Add a small explanatory message

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3074021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55060 0039d316-1c4b-4281-b951-d872f2087c98

c3dae0a2

Widen one suppression (bug 40429), fix styling nits in two other suppressions · ba444404

timurrrr@chromium.org authored 14 years ago

BUG=40429,31634
TBR=jrg,ajwong,oshima
Review URL: http://codereview.chromium.org/3023040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55057 0039d316-1c4b-4281-b951-d872f2087c98

ba444404