Yet I cannot delete AutomationProxyForExternalTab because it is used by extension_uitest.cc.
Enable some tests meanwhile - now they should be stable enough.

BUG=18797,24664
TEST=ui_tests ok
Review URL: http://codereview.chromium.org/339009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31016 0039d316-1c4b-4281-b951-d872f2087c98

Continue to remove CHROME_FRAME_BUILD define from code that goes into chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line.

Also,

* At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it).
* The installer now propagates the presence of --verbose-logging to uninstalls.
* The chrome_launcher now allows the --chrome-frame switch through to chrome.
* The installer now accepts a --chrome-frame switch.
* Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer.


BUG=26012, 26603
TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly.


Review URL: http://codereview.chromium.org/345021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98

It broke handling of shortcuts that happen in the renderer (cmd-z, cmd-shift-v). Long-term, they should all be handled in the browser, but they aren't yet.

With this patch, cmd-left/right will again no longer work for web pages with a horizontal scrollbar.

BUG=26664,25856
TEST=Cmd-z, cmd-shift-z, cmd-shift-v should work again. cmd-left/right should no longer work on pages with a horizontal scrollbar.

Review URL: http://codereview.chromium.org/363008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20793
TBR=dglazkov
Review URL: http://codereview.chromium.org/361013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31013 0039d316-1c4b-4281-b951-d872f2087c98

NSPR/NSS error codes.  Add the error codes that may be reported by
TCPClientSocket to the error code mapping functions.

Map our network error codes to NSPR/NSS error codes in the async
completion code paths of transport_->Read() and transport_->Write().

R=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/357002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31012 0039d316-1c4b-4281-b951-d872f2087c98

It wasn't wired up to any errors yet, it wasn't hidden by default, it created an unnecessary horizontal space, and it would DCHECK (or worse) when that space was clicked.

BUG=26595
TEST=Displayed the bookmarks bar, verified that the gap to the left of "Other Bookmarks" went away and that it was no longer clickable.
R=estade

Review URL: http://codereview.chromium.org/360024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31011 0039d316-1c4b-4281-b951-d872f2087c98

Stop each ChromeThread before nulling out the entry in chrome_threads_.  This allows DCHECKs that the code is running on the correct thread to succeed.

BUG=26714
Review URL: http://codereview.chromium.org/363010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26265,26268

Review URL: http://codereview.chromium.org/360023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31009 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hamaji
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26360
TEST=cancel a notification

Review URL: http://codereview.chromium.org/363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31004 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r30843.

This broke the findbar/download shelf animation optimization.  I
originally was doing this as part of fixing issue 26495, but I
found a different way.

TBR=estade

Review URL: http://codereview.chromium.org/366009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31003 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/355026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31002 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure Linux packages are rebuilt if any of the packaging scripts or
config files change.

Review URL: http://codereview.chromium.org/360017


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31001 0039d316-1c4b-4281-b951-d872f2087c98

Clean up bookmark_editor_controller to so that is closes consistently as both a standard window and as a sheet.
Get rid of an unneeded member variable.
Clean up unittest to use new CocoaTest, and to clean up its windows properly.

BUG=none
TEST=Open the bookmark editing window and edit bookmarks. Make sure to test with both OK and Cancel.

Review URL: http://codereview.chromium.org/361011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31000 0039d316-1c4b-4281-b951-d872f2087c98

it does not get the keyboard input anymore and for text editable
nodes there is no caret.
This was happening because the focus is messed up when the selection does
not include the focused node.
This CL ensure the selection includes the focused node to work-around that
issue.


BUG=21388
TEST=Open google.com, CTRL-F and search for something not in the page.
     ESC to close the find-box. The search field on the Google page
     should have focus and typing should work.
     Now focus a link in the page, do a find for some text not in the
     page. Press ESC. Pressing enter should trigger the link.

Review URL: http://codereview.chromium.org/342099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30999 0039d316-1c4b-4281-b951-d872f2087c98

browser window.

BUG=18548
TEST=Open window with Legal Pad theme from the them gallery and make sure the red lines line up.

Review URL: http://codereview.chromium.org/351010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30998 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/363009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30997 0039d316-1c4b-4281-b951-d872f2087c98

Also added test expectations for the ruby tests. They
need to be rebaselined afterwards.

TBR=brettw
TEST=Tree stays green

Review URL: http://codereview.chromium.org/366006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30996 0039d316-1c4b-4281-b951-d872f2087c98

This may not yet correctly handle all possible variants of VMS,
because there multiple TCP/IP network stacks available for that
system.

TEST=Covered by net_unittests.
BUG=22193, 25520

Review URL: http://codereview.chromium.org/348036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30995 0039d316-1c4b-4281-b951-d872f2087c98

the icon. Otherwise, the badge looks off center.

BUG=26400
TEST=I guess this is just a matter of eyeballing
it. The badge should not look off-center when
compared to the icon, even with different sized
icons  and different width of text in the badge.

Review URL: http://codereview.chromium.org/362007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30994 0039d316-1c4b-4281-b951-d872f2087c98

make sure the function I was changing was never
called for multiline labels (it never was supposed
to work for multiline labels, even before my change).

Turns out, this flushed out a caller who calls it
for multiline labels, and gets the wrong results.

BUG=None
TEST=Trigger a javascript alert with multiple lines.
Make sure no DCHECK happens. If you set a breakpoint
on the function I'm changing and hover over the label,
when you step through the code, you'll see that it now
correctly computes the bounds of the label based on 
the width and calls SetContainsMouse with true 
instead of false.
Review URL: http://codereview.chromium.org/361001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30993 0039d316-1c4b-4281-b951-d872f2087c98

R=japhet
TEST=none
BUG=26291

Review URL: http://codereview.chromium.org/361010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30992 0039d316-1c4b-4281-b951-d872f2087c98

This change also removes flaky crash expectations. Those were incorrect.

R=japhet
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/360019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30991 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/346027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30990 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30989 0039d316-1c4b-4281-b951-d872f2087c98

Add 'meta charset=UTF-8' to the html of an iframe interstitial  to prevent non-ASCII characters from being garbled. 

BUG=26030
TEST=1. Launch Chrome with --lang=pt-BR (ja or most languages other than English should work) on Windows or 'LANGUAGE=pt_BR chrome' on Linux.
2. Go to http://www.notalegal.df.gov.br/area=1248.htm and the iframe interstitial doesn't have a garbled character.
Review URL: http://codereview.chromium.org/348060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30988 0039d316-1c4b-4281-b951-d872f2087c98

Changed common.gypi to automatically select cb_service of d3d9 pr gl in chrome builds.

Review URL: http://codereview.chromium.org/360018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30987 0039d316-1c4b-4281-b951-d872f2087c98

Removes accessibility-related WebCore dependencies from glue.

R=darin
TEST=none
BUG=24616

Review URL: http://codereview.chromium.org/348063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30986 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26715
TBR=beng


Review URL: http://codereview.chromium.org/365006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22199
TEST=dragging to scroll in web pages should again work.
Review URL: http://codereview.chromium.org/367001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30983 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/346044

BUG=26599
TEST=extension_popup_apitest.cc 


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30982 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=26692

Review URL: http://codereview.chromium.org/363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30981 0039d316-1c4b-4281-b951-d872f2087c98

Implement FormStructure and an initial method, EncodeUploadRequest.  This also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/355003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30980 0039d316-1c4b-4281-b951-d872f2087c98

You need <limits.h> for ULLONG_MAX.

Review URL: http://codereview.chromium.org/355025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30978 0039d316-1c4b-4281-b951-d872f2087c98

Also clean up some leaking tree paths.

BUG=22961
TEST=after sorting, task manager still works normally

Review URL: http://codereview.chromium.org/362001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30976 0039d316-1c4b-4281-b951-d872f2087c98

is also present, delete the user ticket and abort the update.

BUG=26702
TEST=keystone_install_test.sh
Review URL: http://codereview.chromium.org/365004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=insect
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/360014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30974 0039d316-1c4b-4281-b951-d872f2087c98

potentially hanging the interactive ui tests.

BUG=None
TEST=Run the interactive ui tests.
R=sky
Review URL: http://codereview.chromium.org/355024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30972 0039d316-1c4b-4281-b951-d872f2087c98

Instead of localizing "download" string in net_util.cc, make a caller,
download_manger, provide a localized string.

BUG=25289
TEST=NetUtilTest.GetSuggestedFilename,DownloadManagerTest.TestDownloadFilename

Original patch by hayato@google.com at:
http://codereview.chromium.org/343014/show

Review URL: http://codereview.chromium.org/367003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30971 0039d316-1c4b-4281-b951-d872f2087c98