- Sep 25, 2009
-
-
estade@chromium.org authored
TBR=jungshik Review URL: http://codereview.chromium.org/242001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27167 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Also make tab dragging slightly more robust. I tried really hard to avoid hackiness, but after many hours of wrestling with gtk and X, this is the best I could do. The main point of contention is that GTK (and our tab dragging code in particular) seems to be able to get X into a state where gdk_display_warp_pointer() doesn't send back any events (although it does move the X pointer). I tried to fix our code directly, but decided it was GTK that was broken. So I faked some mouse motion events to prod the tab dragging into working. This approach does not appear to be flaky, and is actually closer to the event stream that occurs when a user drags a tab than the obvious approach would be. (The tests themselves are somewhat flaky, but only due to WaitForURLDisplayedForTab() flakiness, which is a separate issue I'll look at later. The tests aren't on any buildbot for now so I'd like to leave them enabled.) BUG=22182 TEST=--gtest_filter=AutomatedUITest.Drag* Review URL: http://codereview.chromium.org/218017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27166 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 27, 2009
-
-
estade@chromium.org authored
Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach. Review URL: http://codereview.chromium.org/178002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24650 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 26, 2009
-
-
sky@chromium.org authored
. Moves listening from DidProcess to WillProcess. This is necessitated by the bookmark bar (chrome menu) tests that spawn a nested run loop, which results in DidProcess not getting sent and the test wedging. This brings the code closer in line with Windows. . If there is a mouse/keyboard grab, mouse/keyboard events are sent to the grabbed widget. . Deals with a NULL widget for sending keyboard events (tries to find focused widget). BUG=none TEST=none Review URL: http://codereview.chromium.org/173392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24420 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 21, 2009
-
-
estade@chromium.org authored
Also fix a bug in the Windows implementation of SendMouseMoveNotifyWhenDone where the task would never be run if the cursor was already in the destination position before the call. BUG=19076 BUG=19881 Review URL: http://codereview.chromium.org/174201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24027 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 20, 2009
-
-
estade@chromium.org authored
The most noteworthy change here is the implementation of SendMouseMove() and SendMouseClick() in ui_controls. I've combed the interwebs and I don't think it's possible to figure out the GdkWindow that is showing for a given (x,y) coordinate pair (except perhaps by delving into X), so we have to just send clicks to wherever the pointer lies. This is unfortunate in that it means we have to move the pointer, wait for it to get where it's going, and only then make the click. But on the bright side there's this super helpful function called gdk_display_warp_pointer() which makes moving the mouse a breeze. BUG=19076 Review URL: http://codereview.chromium.org/174113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23880 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 19, 2009
-
-
estade@chromium.org authored
Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking. Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs. Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong. Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes. BUG=19076 BUG=19659 TEST=all the ported interactive ui tests (as well as all the already-working tests) pass. TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf) Review URL: http://codereview.chromium.org/173030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23732 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 18, 2009
-
-
estade@chromium.org authored
also change the interface for SimulateOSKeyPress()/SendKeyPress() to take a VKEY_ value (defined in base/keyboard_codes.h) rather than a VK_ value. BUG=19076 Review URL: http://codereview.chromium.org/171079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23611 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 13, 2009
-
-
estade@chromium.org authored
I have verified that this is working on Linux, but still have yet to enable any new automated tests. Baby steps. BUG=19076 Review URL: http://codereview.chromium.org/164446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23386 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 12, 2009
-
-
estade@chromium.org authored
Partially based on patch by Dan Kegel. Review URL: http://codereview.chromium.org/164371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23209 0039d316-1c4b-4281-b951-d872f2087c98
-