Skip to content
Snippets Groups Projects
  1. Jan 15, 2011
  2. Jan 13, 2011
  3. Dec 02, 2010
  4. Sep 08, 2010
  5. Aug 26, 2010
  6. Jul 09, 2010
  7. Jul 01, 2010
  8. May 05, 2010
    • dhollowa@chromium.org's avatar
      AutoFill profile shouldn't be saved when cancelled during initial setup. · f749da53
      dhollowa@chromium.org authored
      Relanding after revert of: 46424
      http://codereview.chromium.org/1902003
      Fixing compile error on Windows.
      
      For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
      call now passes the new profile and credit card information to the dialog directly
      instead of saving it to the database and then invoking the dialog.  This facilitates
      "Cancel" in the dialog where the new information is not persisted.
      
      This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
      out of the preferences dialog and into the AutoFillDialogController itself.
      
      This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
      call.  More work is required on Linux and Windows to properly conform to this interface and
      fix bug 41010.  The Linux and Windows implementations will need to respect the new input
      parameters |imported_profile| and |imported_credit_card|.
      
      BUG=41010
      TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters
      
      Review URL: http://codereview.chromium.org/1952002
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46430 0039d316-1c4b-4281-b951-d872f2087c98
      f749da53
    • dhollowa@chromium.org's avatar
      Revert 46424 - AutoFill profile shouldn't be saved when cancelled during initial setup. · f5fb4d4b
      dhollowa@chromium.org authored
      For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
      call now passes the new profile and credit card information to the dialog directly
      instead of saving it to the database and then invoking the dialog.  This facilitates
      "Cancel" in the dialog where the new information is not persisted.
      
      This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
      out of the preferences dialog and into the AutoFillDialogController itself.
      
      This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
      call.  More work is required on Linux and Windows to properly conform to this interface and
      fix bug 41010.  The Linux and Windows implementations will need to respect the new input
      parameters |imported_profile| and |imported_credit_card|.
      
      BUG=41010
      TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters
      
      Review URL: http://codereview.chromium.org/1930002
      
      TBR=dhollowa@chromium.org
      Review URL: http://codereview.chromium.org/1902003
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46426 0039d316-1c4b-4281-b951-d872f2087c98
      f5fb4d4b
    • dhollowa@chromium.org's avatar
      AutoFill profile shouldn't be saved when cancelled during initial setup. · 425da017
      dhollowa@chromium.org authored
      For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted()
      call now passes the new profile and credit card information to the dialog directly
      instead of saving it to the database and then invoking the dialog.  This facilitates
      "Cancel" in the dialog where the new information is not persisted.
      
      This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic
      out of the preferences dialog and into the AutoFillDialogController itself.
      
      This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog()
      call.  More work is required on Linux and Windows to properly conform to this interface and
      fix bug 41010.  The Linux and Windows implementations will need to respect the new input
      parameters |imported_profile| and |imported_credit_card|.
      
      BUG=41010
      TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters
      
      Review URL: http://codereview.chromium.org/1930002
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46424 0039d316-1c4b-4281-b951-d872f2087c98
      425da017
  9. Mar 19, 2010
  10. Mar 06, 2010
    • dhollowa@chromium.org's avatar
      AutoFill Mac preference for enabling Address Book "me" card usage. · d60677ca
      dhollowa@chromium.org authored
      Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses.  This CL adds the Mac UI and the preference setup only.  It does not cover the functionality for fetching the actual Address Book data.  The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class.  The |addressSection_| outlet is set to the spacer following the new checkbox.  Unit tests are included for the addition of the preference at the mac dialog controller level.
      
      BUG=36496
      TEST=PersonalDataManagerTest, AutoFillDialogControllerTest
      
      Review URL: http://codereview.chromium.org/668171
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40803 0039d316-1c4b-4281-b951-d872f2087c98
      d60677ca
  11. Feb 12, 2010
    • dhollowa@chromium.org's avatar
      Autofill dialog for the Mac. This is UI only at this point. The UI is not... · 8ebfa3b6
      dhollowa@chromium.org authored
      Autofill dialog for the Mac.  This is UI only at this point.  The UI is not hooked up to the back end yet.  The UI demonstrates manipulation of one address and one credit card record.  Eventually buttons will be added to add and remove additional records.  The additions in this CL are:
        - Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog.
        - The autofill settings dialog now exists and allows the user to manipulate form autofill data.  Specifically address information and credit card information.
        - Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record.
        - The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView.
        - Sections are delimited visually with the SectionSeparatorView.  There are currently two sections, one for addresses and one for credit cards.
        - Unit tests are present that exercise the invocation of the dialog and check basic functionality.  Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI.
        - There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects.
        - Cocoa databinding is utilized to syncronize dependent parts of the UI.
        - All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below).
      
      The things remaining to do are:
      
        - Hook the UI up to the backend model, specifically the PersonalDataManager data.
        - Add support for arbitrary number of address and credit card records.  I.e. Add and Delete buttons.
        - Scroll-to-Point support for autoscrolling when tabbing between fields.
        - Billing and shipping address popups in the credit card section.
        - Any validation of input (need to circle back with UI folks on this).
        - Input validation unit tests.
        - String concatenation of the summary label needs to be internationalized.
      
      BUG=33029
      TEST=none
      
      Review URL: http://codereview.chromium.org/558066
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
      8ebfa3b6
  12. Jan 28, 2010
  13. Jan 24, 2010
  14. Jan 21, 2010
Loading