- Jan 15, 2011
-
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6335001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 13, 2011
-
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6122006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 02, 2010
-
-
ben@chromium.org authored
file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 08, 2010
-
-
dhollowa@chromium.org authored
Changes the AutoFill dialog on Mac to be modeless. Changes to preferences and AutoFill profile and credit card information is now saved immediately. Nib changes: Removes Save and Cancel buttons, activates Close and Minimize controls, and compacts dialog to account for new vertical space. BUG=49935 TEST=AutoFillDialogControllerTest.* Review URL: http://codereview.chromium.org/3302015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58869 0039d316-1c4b-4281-b951-d872f2087c98
-
- Aug 26, 2010
-
-
evan@chromium.org authored
Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jul 09, 2010
-
-
sky@chromium.org authored
BUG=44620 TEST=none Review URL: http://codereview.chromium.org/2920004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51973 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jul 01, 2010
-
-
jhawkins@chromium.org authored
AutoFill: Aggregate profile data. Remove the AutoFill InfoBar. Remove more remnants of shipping address and CVV. BUG=47426,47423 TEST=PersonalDataManager.* Review URL: http://codereview.chromium.org/2818033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 05, 2010
-
-
dhollowa@chromium.org authored
Relanding after revert of: 46424 http://codereview.chromium.org/1902003 Fixing compile error on Windows. For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1952002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46430 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1930002 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/1902003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46426 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1930002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46424 0039d316-1c4b-4281-b951-d872f2087c98
-
- Mar 19, 2010
-
-
jhawkins@chromium.org authored
AutoFill: Set the kAutoFillInfoBarShown pref to true if the user opens the AutoFill dialog. If the user has opened the dialog, AutoFill is implicitly enabled. BUG=38538 TEST=none Review URL: http://codereview.chromium.org/1077003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42139 0039d316-1c4b-4281-b951-d872f2087c98
-
- Mar 06, 2010
-
-
dhollowa@chromium.org authored
Adds a boolean preference to specify whether to use the Mac user's Address Book "me" card as a source of information for AutoFill addresses. This CL adds the Mac UI and the preference setup only. It does not cover the functionality for fetching the actual Address Book data. The changes to AutoFillDialog.xib add the checkbox UI and bind the checkbox to the |auxiliaryEnabled| property in the controller class. The |addressSection_| outlet is set to the spacer following the new checkbox. Unit tests are included for the addition of the preference at the mac dialog controller level. BUG=36496 TEST=PersonalDataManagerTest, AutoFillDialogControllerTest Review URL: http://codereview.chromium.org/668171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40803 0039d316-1c4b-4281-b951-d872f2087c98
-
- Feb 12, 2010
-
-
dhollowa@chromium.org authored
Autofill dialog for the Mac. This is UI only at this point. The UI is not hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are: - Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog. - The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information. - Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record. - The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView. - Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards. - Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI. - There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects. - Cocoa databinding is utilized to syncronize dependent parts of the UI. - All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below). The things remaining to do are: - Hook the UI up to the backend model, specifically the PersonalDataManager data. - Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons. - Scroll-to-Point support for autoscrolling when tabbing between fields. - Billing and shipping address popups in the credit card section. - Any validation of input (need to circle back with UI folks on this). - Input validation unit tests. - String concatenation of the summary label needs to be internationalized. BUG=33029 TEST=none Review URL: http://codereview.chromium.org/558066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 28, 2010
-
-
georgey@chromium.org authored
What works: 1. Layout (for the most part) 2. Editing and saving the items What does not 1. Scroll 2. Delete/Add buttons 3. some layout quirks 4. collapsible editable sets. BUG=33026 TEST=none for now. Review URL: http://codereview.chromium.org/554081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37357 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 24, 2010
-
-
jhawkins@chromium.org authored
BUG=18201 TEST=PersonalDataManagerTest.SetProfiles Review URL: http://codereview.chromium.org/545175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36978 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 21, 2010
-
-
jhawkins@chromium.org authored
Notify the AutoFillManager when the user clicks "Apply" or "OK". Adds an AutoFillDialogObserver interface that is used to send the profile information back to clients. BUG=none TEST=none Review URL: http://codereview.chromium.org/555023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36779 0039d316-1c4b-4281-b951-d872f2087c98
-