- Jun 16, 2010
-
-
http://codereview.chromium.org/2767013/showzelidrag@chromium.org authored
Add one more Chrome OS hardware class MetricsLog unit tests. Since the hardware class attribute is added to the XML when the log is closed, it's important to test for its presence in the encoded string when the log contains some events. The existing unit test covers only the case when the log is empty. BUG=none TEST=ran unit tests Review URL: http://codereview.chromium.org/2814005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49980 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
live updates in response to sycronization. BUG=41335 TEST=Open the 'Content settings' dialog on two separate instances of Chromium when both are synced to the same account. Change settings on computer A, settings should auto-update on computer B. Review URL: http://codereview.chromium.org/2063020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49979 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Removes collision with NAME_FULL checks in AutoFill code. Parallel implementations collided in the ether. These changes consolidate the implementations. BUG=46625 TEST=ContactInfoTest.TestSetFullName Review URL: http://codereview.chromium.org/2849008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49978 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@chromium.org authored
BUG=none TEST=after patching in 2844004, I was able to successfully modify the Nigori permanent node. Review URL: http://codereview.chromium.org/2815009 TBR=albertb@chromium.org Review URL: http://codereview.chromium.org/2860007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49977 0039d316-1c4b-4281-b951-d872f2087c98
-
bevc@chromium.org authored
Review URL: http://codereview.chromium.org/2829003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49976 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
They're metrically compatible with each other, but the former is sans serif (monospace) while ther latter is serif (monospace), which is why we didn't include this mapping in the two previous CLs (one by Evan and the other by me). However, on ChromeOS, we use 'Ascender Sans Mono' as a substitute for Courier New so that they have to be regarded as 'identical'. Without this change, a text node styled with 'Courier New' is not rendered with our replacement font while a text node styled with 'Courier New, momospace' or 'monospace' is rendered with our replacement font. BUG=cros:4006 TEST=See the bug. Review URL: http://codereview.chromium.org/2838003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49975 0039d316-1c4b-4281-b951-d872f2087c98
-
andreip@chromium.org authored
Review URL: http://codereview.chromium.org/2833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49974 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=None TEST=Core Animation plugins still work. Review URL: http://codereview.chromium.org/2805010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49973 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Review URL: http://codereview.chromium.org/2843006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49972 0039d316-1c4b-4281-b951-d872f2087c98
-
jerrica@google.com authored
I added a call to TruncateUTF8ToByteSize in order to truncate the title to 255 bytes. BUG=43675 TEST=none Review URL: http://codereview.chromium.org/2849002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49971 0039d316-1c4b-4281-b951-d872f2087c98
-
glotov@chromium.org authored
BUG=crosbug.com/525 TEST=none Review URL: http://codereview.chromium.org/2790012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49970 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
supported on Mac. BUG=45031 TEST=none Review URL: http://codereview.chromium.org/2812003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49969 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
Thanks to Randy Smith for tracking this down. BUG=31586 TEST=Valgrind Mac unit_tests stay green. Review URL: http://codereview.chromium.org/2798001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49968 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
BUG=none TEST=after patching in 2844004, I was able to successfully modify the Nigori permanent node. Review URL: http://codereview.chromium.org/2815009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49967 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@google.com authored
Review URL: http://codereview.chromium.org/2846007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49966 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@google.com authored
Refactor ImageDownloader/ImageDecoder into a separate classes. Resources submitted in http://codereview.chromium.org/2856003 BUG= http://crosbug.com/3486 TEST=Select "New User" screen, enter new account for this device. Enter incorrect password 3 times. After captcha is presented and entered login should succeed. Review URL: http://codereview.chromium.org/2729020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49965 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49963 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@chromium.org authored
BUG=none TEST=Run browser_tests --gtest_filter=WizardControllerFlowTest\.Accelerators Review URL: http://codereview.chromium.org/2862006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49961 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
changed we didn't remove the old buttons, which meant when you clicked on a button it might be past the bounds of the model. I don't think we ever do this, but it's the only thing I could see that could cause the crash. Once I've nailed this down I'll nuke the CHECKs. BUG=44642 TEST=none Review URL: http://codereview.chromium.org/2822010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49959 0039d316-1c4b-4281-b951-d872f2087c98
-
denisromanov@chromium.org authored
startup customization manifest. BUG=http://crosbug.com/3176 TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Welcome message should be in Italian. Review URL: http://codereview.chromium.org/2853006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49958 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=32906 TEST=none Review URL: http://codereview.chromium.org/2567004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49957 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
This may change later, but in the meantime, this is what we want for Japanese CrOS. BUG=cros:2635 (http://crosbug.com/2635) TEST=Change your UI language to Japanese and go to a web page specifying 'sans-serif', 'serif' or 'monospace' (wikipedia specifies 'sans-serif'). Make sure that IPAPGothic, IPAPMincho and IPAGothic are used. Review URL: http://codereview.chromium.org/2821007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49956 0039d316-1c4b-4281-b951-d872f2087c98
-
dtseng@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49955 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49954 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Review URL: http://codereview.chromium.org/2803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49953 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@google.com authored
Follow up CL to http://codereview.chromium.org/2820006 BUG=chromium-os:323 TEST=unit tests, and loading up a chromium os device and logging in Review URL: http://codereview.chromium.org/2851006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49952 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Review URL: http://codereview.chromium.org/2858008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49951 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@google.com authored
Add an option in the master_preferences to randomize the order of logos in the search engine selection screen. This allows us to cull out a small subset of users to take part in a test of the effects of logo position on search engine choice. I also filed http://crbug.com/46606 to remind me to revert this change when testing is complete. BUG=46302 TEST=Add the following options to master_preferences: "distribution": { "search_engine_experiment": true, "search_engine_experiment_randomize": true } Run a few times as --first-run, and see search engines appear in random order in the selection box. Review URL: http://codereview.chromium.org/2808006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49950 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
TBR=garykac BUG=46678 Review URL: http://codereview.chromium.org/2860005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49948 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
browser_accessibility_manager, to make it more clear that these are Windows-only source files. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49947 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Review URL: http://codereview.chromium.org/2800008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49946 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@chromium.org authored
BUG=46662 TBR=alokp Review URL: http://codereview.chromium.org/2858007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49945 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=46672 TBR=glider TEST=TSan/UI should become green Review URL: http://codereview.chromium.org/2833009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49944 0039d316-1c4b-4281-b951-d872f2087c98
-
andreip@chromium.org authored
Review URL: http://codereview.chromium.org/2872002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49943 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
Fix the error found by -Wextra, disable part of the test because it doesn't seem like it ever would have passed in the first place. BUG=46663 TEST=none Review URL: http://codereview.chromium.org/2802006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49941 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=46658 TBR=dhollowa Review URL: http://codereview.chromium.org/2846009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49940 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
- Make loops use {} instead of a ';' to make it clear there is no body to the loop. - Remove checks of unsigned values for <0 - coordinates should be CGFloat, not NSUInteger. BUG=34160 TEST=none Review URL: http://codereview.chromium.org/2865003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49939 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=NONE Test=RenderWidgetHostTest.CoalescesWheelEvents (existing) Review URL: http://codereview.chromium.org/2679003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49938 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=46571 TBR=willchan Review URL: http://codereview.chromium.org/2867006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49937 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Switches over to the new HTML5 Parser, originally in http://codereview.chromium.org/2809011. Review URL: http://codereview.chromium.org/2843005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49936 0039d316-1c4b-4281-b951-d872f2087c98
-