Review URL: http://codereview.chromium.org/248016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27354 0039d316-1c4b-4281-b951-d872f2087c98

This is still not perfect, but all least it should work
for all the use cases we currently have.

Review URL: http://codereview.chromium.org/254001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27353 0039d316-1c4b-4281-b951-d872f2087c98

tbr:oshima@chromium.org

Review URL: http://codereview.chromium.org/242028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27352 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/235037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27351 0039d316-1c4b-4281-b951-d872f2087c98

Tim's fix works.

Review URL: http://codereview.chromium.org/246018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27346 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/245023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27345 0039d316-1c4b-4281-b951-d872f2087c98

This should relieve the purify redness.

TBR=nick
TEST=ProfileSyncServiceTest, sync_unit_tests

Review URL: http://codereview.chromium.org/243023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27344 0039d316-1c4b-4281-b951-d872f2087c98

it fails too often on linux.

Also disable LayoutTests/transitions/transition-end-event-left.htmt

It looks like all the transition-end-event-* are flaky.

BUG:9798

Review URL: http://codereview.chromium.org/248015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27343 0039d316-1c4b-4281-b951-d872f2087c98

disabled because of flakyness, but it's not disabled, and it's
really flaky, so i'm disabling it for real.

BUG:22668

Review URL: http://codereview.chromium.org/242027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27342 0039d316-1c4b-4281-b951-d872f2087c98

because they started failing all the time.

TBR:pkasting
BUG:23213

Review URL: http://codereview.chromium.org/246017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27341 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27340 0039d316-1c4b-4281-b951-d872f2087c98

TBR=senorblanco@chromium.org
BUG=23197
TEST=None

Review URL: http://codereview.chromium.org/243020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27338 0039d316-1c4b-4281-b951-d872f2087c98

Add failure for newly added test for me to investigate.

TBR=senorblanco@chromium.org
TEST=None
BUG=None


Review URL: http://codereview.chromium.org/242023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27337 0039d316-1c4b-4281-b951-d872f2087c98

Rolling right up to the next breakage.

Adding new breakages that I need to investigate.

TBR=senorblanco@chromium.org
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/251006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=22926
Review URL: http://codereview.chromium.org/235033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27335 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=22926

Review URL: http://codereview.chromium.org/242015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27334 0039d316-1c4b-4281-b951-d872f2087c98

It only adds a svn:ignore.

NO CODE CHANGE.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/235035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27333 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Linux shared build.
TBR=maruel
Review URL: http://codereview.chromium.org/245020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27332 0039d316-1c4b-4281-b951-d872f2087c98

Update the TabContents::SavePage parameter to take FilePath instead of wstring to avoid conversions "To and From wstring".

BUG=None
TEST=run unit_tests.exe

Review URL: http://codereview.chromium.org/217008
Patch from tfarina.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/249011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23138,23139,23140
TEST=none
Review URL: http://codereview.chromium.org/249012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27329 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to remove these no-longer important comments in http://src.chromium.org/viewvc/chrome?view=rev&revision=27303.

TBR: arv

Review URL: http://codereview.chromium.org/242021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27328 0039d316-1c4b-4281-b951-d872f2087c98

Revert 27324 - First step towards NaClChrome integration:1. NaCl plugin becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002

TBR=bradnelson@google.com

Review URL: http://codereview.chromium.org/244017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bradnelson
Review URL: http://codereview.chromium.org/249014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27325 0039d316-1c4b-4281-b951-d872f2087c98

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98

APIs.  This change is purely additive.  I'll rip out the old mechanism in the
next patch.

R=agl

Review URL: http://codereview.chromium.org/243012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27323 0039d316-1c4b-4281-b951-d872f2087c98

I think/hope this is the last big CL for this.

*) Moved GAPIInterface enums to cmd_buffer_format.h

The reason is you should not have to include CODE 
to make data. The fact that the enums were in 
GAPIInterface, a class, meant you had to include
code if you wanted to make a command buffer.

*) Typed arguments where I could.

So for example Draw takes PrimitiveType instead of
uint32. CreateVertexBuffer takes a ResourceId

*) Renamed enums etc to match style guide.

*) Moved BitFields into specific commands

*) renamed arguments from id to type_id.



Review URL: http://codereview.chromium.org/234002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27322 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/222017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27321 0039d316-1c4b-4281-b951-d872f2087c98

It requires you to declare all views built an additional time. Sigh...

TBR=erikkay
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/244016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27320 0039d316-1c4b-4281-b951-d872f2087c98

Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions.

Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page).

Removed |type| from PageActions, which is currently ignored and was already removed from the docs.

Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition).

BUG=22099
TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up.
Review URL: http://codereview.chromium.org/243001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27319 0039d316-1c4b-4281-b951-d872f2087c98

Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002

TBR=gregoryd@google.com

Review URL: http://codereview.chromium.org/244014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27317 0039d316-1c4b-4281-b951-d872f2087c98

logging.h to suppress the definition of LOG() and friends unless
explicitly requested. Fix gyp paths to overrides files.

Review URL: http://codereview.chromium.org/225001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27316 0039d316-1c4b-4281-b951-d872f2087c98

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23151
TEST=none
TBR=dank
Review URL: http://codereview.chromium.org/242016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23078
TEST=No more menu item on download item

Review URL: http://codereview.chromium.org/246004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27312 0039d316-1c4b-4281-b951-d872f2087c98

how hash functions are specified for certain key types, and deleted
our std_hash.h. Fixed forward reference bug in cmd_buffer_format.h.
Built and tested on Windows and Mac.

Remaining workarounds: enabled C++ exceptions due to use of Objective
C try/catch in plugin_mac.mm; disabled warnings as errors due to
signed / unsigned issues in command buffer code, which will probably
need to be fixed by changing typedefs and argument types.

Review URL: http://codereview.chromium.org/249013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27311 0039d316-1c4b-4281-b951-d872f2087c98

change to this file was wrong, the new values for expectations are
'TEXT', 'IMAGE', and 'IMAGE+TEXT' ('BOTH' is not a valid value).

  R=ojan
  BUG=none
  TEST=none

Review URL: http://codereview.chromium.org/245019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22932
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/243015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27309 0039d316-1c4b-4281-b951-d872f2087c98

The problem had to do with the translation of the key codes.  There's another issue that surfaced
with the event.js code in IE when the events are handled by methods running in V8.  In that situation
it appears that event.keyIdentifier isn't actually a string and IE barfs when we call keyIdent.indexOf().  I added 
a check to make sure it's a string but I don't know if the fix really belongs somewhere in the V8 / IE bridge
Review URL: http://codereview.chromium.org/218002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23129
TEST=None

Review URL: http://codereview.chromium.org/231019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27307 0039d316-1c4b-4281-b951-d872f2087c98