TEST=seems to run ok now
BUG=39731

Review URL: http://codereview.chromium.org/2828006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49851 0039d316-1c4b-4281-b951-d872f2087c98

I'll move the DXT stuff out after this CL lands.

TEST=ran unit and conformance tests
BUG=44368

Review URL: http://codereview.chromium.org/2689006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49850 0039d316-1c4b-4281-b951-d872f2087c98

Add accessible_name property for info bubbles (so far added name to bookmark bubble object which implements WidgetWin).
TEST=none
BUG=9601
Review URL: http://codereview.chromium.org/2338001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49849 0039d316-1c4b-4281-b951-d872f2087c98

(Note: That was a TODO for Matt).

BUG=None
TEST=open the Certificate Manager window, select a tab, close it, open again, it
should opens in the tab you viewed last.

Review URL: http://codereview.chromium.org/2730016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49848 0039d316-1c4b-4281-b951-d872f2087c98

No explanation was given for what exactly was wrong when it was disabled, and it passes on the try bots.

BUG=None
TEST=SlowTermination should run and pass on Windows and Linux

Review URL: http://codereview.chromium.org/2825004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49847 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build release
BUG=none

Review URL: http://codereview.chromium.org/2800004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49846 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=46601
TBR=mpcomplete

Review URL: http://codereview.chromium.org/2868003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49844 0039d316-1c4b-4281-b951-d872f2087c98

In particular fullscreen_controller.mm:402:29: error: 'NSAnimation' may not respond to 'endFraction'

Review URL: http://codereview.chromium.org/2836002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49843 0039d316-1c4b-4281-b951-d872f2087c98

Fix up the issues that the new warnings raised.

BUG=none
TEST=build remoting cleanly

Review URL: http://codereview.chromium.org/2801003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49842 0039d316-1c4b-4281-b951-d872f2087c98

received a geometry update of size 0. The plugin has a bug where it ignores subsequent geometry updates.

Based on the webkit plugin implementation they have a quirk which handles this case for media player and divx.
To ensure that this quirk works correctly in cases where we only receive one geometry update we send out
geometry updates during paint as well if needed.

Fix is to mimic this behavior for Chromium.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=43916

Bug=43916

Review URL: http://codereview.chromium.org/2752009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49841 0039d316-1c4b-4281-b951-d872f2087c98

Adding a test case to DecodeVerbatimTest.
TEST=remoting_unittests

Review URL: http://codereview.chromium.org/2849006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49839 0039d316-1c4b-4281-b951-d872f2087c98

Relax the check to ensure that we just do substring match for "google.com" when testing inline autocomplete in the omnibox.

Review URL: http://codereview.chromium.org/2814002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2860002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49837 0039d316-1c4b-4281-b951-d872f2087c98

Remove duplicated code in AcceleratedSurface using PbufferGLContext instead.
This also fixes a crash caused by the OpenGL bindings not being initialized.

BUG=46286
TEST=flash plugin 10.1 works again in both mac 10.5 and 10.6

Review URL: http://codereview.chromium.org/2782006


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49836 0039d316-1c4b-4281-b951-d872f2087c98

Fix issue in Safari 5 on Mac OS X 10.6 on Mac Minis where drawInCGLContext/copyCGLContextForPixelFormat are called a second time during shutdown in certain hosting pages, causing an assert due to duplicate creation of the Renderer service.

TEST=repeatedly launched/exiting the affected O3D app and verified no crash or other issue
BUG=none

Review URL: http://codereview.chromium.org/2740011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49835 0039d316-1c4b-4281-b951-d872f2087c98

The last roll missed the fix for texture-npot.html, which is 61202.
BUG=none
TEST=none
TBR=kbr

Review URL: http://codereview.chromium.org/2805009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49834 0039d316-1c4b-4281-b951-d872f2087c98

O3D's Windows and Linux builds.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2808004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49833 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49832 0039d316-1c4b-4281-b951-d872f2087c98

Remove extraneous '\n' from ProcessGeneralNames.

BUG=43966
TEST=manual

Review URL: http://codereview.chromium.org/2733014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49831 0039d316-1c4b-4281-b951-d872f2087c98

Nib updates:
Toolbar.xib: Removed page menu and moved everything over to accomodate.
Prefs.xib: Removed "show options page/wrench menu" checkbox and moved everything up to accomodate.
BUG=45756
TEST=migration from having the pref hidden. It should become visible.
Review URL: http://codereview.chromium.org/2828005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/2844003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49829 0039d316-1c4b-4281-b951-d872f2087c98

Changes the tab close button to a dot, unless you're near the button
or the tab is selected.

The only difference between this and the first is that I missed a
remove from the set if the view was deleted, which resulted in a
crash. I've added an interactive test case that covers this.

BUG=45743
TEST=none

Review URL: http://codereview.chromium.org/2863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49828 0039d316-1c4b-4281-b951-d872f2087c98

This test is similar to other startup tests, with the exception that it loads multible tabs at once, and it tests both with and without the session restore command line flag. In both cases, WaitForInitialLoads waits for all the tabs to finish loading before returning.

BUG=44129
TEST=none

Review URL: http://codereview.chromium.org/2753001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49827 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2809009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile
TBR=michaeln

Review URL: http://codereview.chromium.org/2808005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49825 0039d316-1c4b-4281-b951-d872f2087c98

I'm pretty sure the problem is due to users downgrading to versions where --product-version is not available. See the bug for more details.

BUG=46547
TEST=none

Review URL: http://codereview.chromium.org/2813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49824 0039d316-1c4b-4281-b951-d872f2087c98

Make it a compile-time error instead of link-time.
Add a check to make sure you don't try to use it with a pointer.
BUG=41016

Review URL: http://codereview.chromium.org/1604042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49823 0039d316-1c4b-4281-b951-d872f2087c98

the new interface (provide a cache thread and callback).

BUG=26730
TEST=unit tests


Review URL: http://codereview.chromium.org/2739007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49819 0039d316-1c4b-4281-b951-d872f2087c98

This is protected with an #ifdef so that I can land the Chromium side in
advance of the WebKit patch.  See webkit.org/b/40451 for details.

R=sky
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2811007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49818 0039d316-1c4b-4281-b951-d872f2087c98

work around a problem in NaCl's GYP files where it infers 32-bit on
Linux in native_client/build/common.gypi.

A fix in Native Client and a DEPS roll in O3D are still needed to make
the Linux build fully work with the newer NaCl.

BUG=none
TEST=built O3D on Linux

Review URL: http://codereview.chromium.org/2851003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=43954
TEST=verify https://www.keynectis.com cert is recognized as EV on Windows and Linux

Review URL: http://codereview.chromium.org/2865001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49816 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2815005

TBR=alokp@chromium.org
Review URL: http://codereview.chromium.org/2840002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49815 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2815005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49814 0039d316-1c4b-4281-b951-d872f2087c98

This matches the behavior of other Mac browsers; until the new Advanced Key Handling spec is implemented by plugins and Chromium, the return value for key events can't be trusted to be meaningful.

BUG=42490
TEST=Typing should still work in plugins. Pressing delete in a Silverlight text field shouldn't go back in history.

Review URL: http://codereview.chromium.org/2811006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49812 0039d316-1c4b-4281-b951-d872f2087c98

Unicode bidi mirroring characters are not correctly mirrored in textfield and omnibox (which use CRichEditCtrl) while *inputting*. 

Since bidi mirroring characters are correctly mirrored when rendering the whole text, fix it by re-rendering the whole text every time the text changes.

NOTE: this change will mess up the undo queue. The continuous keystroke wont be treated as one undo event.
Every single keystroke is treated as a undo state.

Using the following as example:
1. paste string "abcd " into find-in-page;
2. type in 'e', 'f', and ' '.
3. paste string "xyz".

When undo, the string sequence will be:
"abcd ef xyz" => "abcd ef " ==> "abcd ef" ==> "abcd e" ==> "abcd " =>"".

Without the change, the string sequence is:
"abcd ef xyz" => "abcd ef " => "abcd " =>"".



BUG=46298
TEST=follow the steps described in the bug.
Review URL: http://codereview.chromium.org/2741007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49811 0039d316-1c4b-4281-b951-d872f2087c98

TEST=built chrome locally, ran with chromeos-wm.
BUG=none

Review URL: http://codereview.chromium.org/2716011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49810 0039d316-1c4b-4281-b951-d872f2087c98

ManifestTest.AppsDisabledByDefault.

Don't cache the value of the CommandLine, since unit_tests can modify it while
the process is running.

BUG=41280

Review URL: http://codereview.chromium.org/2824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49809 0039d316-1c4b-4281-b951-d872f2087c98

As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic.

const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice.

nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic.

Review URL: http://codereview.chromium.org/2769014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2850005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49806 0039d316-1c4b-4281-b951-d872f2087c98

There is no standalone dmgpatcher tool because the operation is tied too
closely to Keystone update application, but keystone_install is now able to
perform the dmgpatcher operation as an inverse to what dmgdiffer does when it
creates patch update disk images given an "old" and "new" existing disk image.

If keystone_install detects a .patch directory, it applies the dirpatches that
are contained therein using dirpatcher and goobspatch.  keystone_install
expects two dirpatches: one for the versioned directory, and one for the outer
app bundle.  These two dirpatches correspond exactly to the two rsyncs that
keystone_install performs when updating from a full-install disk image.

BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2832005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49805 0039d316-1c4b-4281-b951-d872f2087c98