- May 19, 2010
-
-
jshin@chromium.org authored
This shouldn't affect Win/Linux/Mac. See http://codereview.chromium.org/2025010 for the change. BUG=http://crosbug.com/2426 TEST=See the bug TBR=mark Review URL: http://codereview.chromium.org/2092001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47725 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=44599 TEST=none TBR=cbentzel,joi Review URL: http://codereview.chromium.org/2071019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47724 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=44128 TEST=player_wtl.exe --video-threads=6 d:\mediatests\crowd\crowd2.mp4 Review URL: http://codereview.chromium.org/2080008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47723 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
If you have two extensions with page actions, you can get into a state where it crashes if you refresh Extension A, then Extension B and Extension A again. BUG=http://crbug.com/44415 TEST=Covered by new test ExtensionBrowserTest.PageActionRefreshCrash Review URL: http://codereview.chromium.org/2134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47722 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/2096008/showgman@chromium.org authored
now that ANGLE has been updated or gcc 4.4.1 TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47721 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
The test should now fit on an 800x600 display, which is apparently what the 10.6 bots have. Removes the FLAKY marker since it should now pass on 10.6 bots. BUG=36670 TEST=PluginConvertPointTest should pass on 10.6 bots Review URL: http://codereview.chromium.org/2100008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47720 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This CL addresses a few issues related to the behavior of the onUpdated event. Issue 1: The page re-entering the load state and the completing was causing multiple 'complete' status events to be fired. We now only report the first 'complete' after the didNavigate message is fired (iframe navigation, for example). Issue 2: We were initializing the URL when the TabEntry was created, and this caused us to fail to send the url with the first navigation because we thought it wasn't changing. BUG=27208,37149 Review URL: http://codereview.chromium.org/2111010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47717 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=http://crbug.com/44189 TEST=included in base_unittests Review URL: http://codereview.chromium.org/2110010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47714 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
TBR=gman@chromium.org Review URL: http://codereview.chromium.org/2095014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47711 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@google.com authored
Changed image resizing logic to show full size ghost and question mark images. BUG=chromiumos:2856 TEST=Login and logout. Check that user images are not shown partially for short period of time before drawn correctly. Review URL: http://codereview.chromium.org/2136018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47710 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=44580 TBR=cbentzel,glider Review URL: http://codereview.chromium.org/2092016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47707 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
Cloud Printing proxy implementation on Linux using CUPS. BUG=none TEST=Try running cloud print proxy on linux and confirm printer list get uploaded, jobs get processed and printed. CodeReview URL=http://codereview.chromium.org/1933006 TBR=sanjeevr@chromium.org Review URL: http://codereview.chromium.org/2075020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47704 0039d316-1c4b-4281-b951-d872f2087c98
-
seanparent@google.com authored
Added support for urgent system notifications Added support for icons in system notifications and added a low battery icon. BUG=http://code.google.com/p/chromium-os/issues/detail?id=2692 TEST=none Review URL: http://codereview.chromium.org/2067016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47703 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
We will also need to revert WebKit rev r58675. BUG=43276 R=johnnyg@chromium.org TEST=none Review URL: http://codereview.chromium.org/2095010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47702 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47700 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
If deleting a bookmark button (due to sync) while a bookmark folder is open, be sure to close the folder. Surprisingly this is among the top browser crashes. BUG=37782 Review URL: http://codereview.chromium.org/2113014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47699 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=36670 TEST=N/A Review URL: http://codereview.chromium.org/2101008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47698 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=44589 TEST=none TBR=bulach,cbentzel,rjkroege Review URL: http://codereview.chromium.org/2110011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47697 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Fix false positive reporting of exceptions picked up during calls to LoadLibrary during DllRegisterServer. BUG=44468 Review URL: http://codereview.chromium.org/2089016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47696 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
Cloud Printing proxy implementation on Linux using CUPS. BUG=none TEST=Try running cloud print proxy on linux and confirm printer list get uploaded, jobs get processed and printed. CodeReview URL=http://codereview.chromium.org/1933006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47695 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47693 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
TEST=none BUG=none TBR=stoyan Review URL: http://codereview.chromium.org/2102010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47691 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
Adding a bit of logging to track down the reason for recent "LaunchBrowser(browser, page)" failures on the build bots. TEST=n/a BUG=none Review URL: http://codereview.chromium.org/2099005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47690 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
properly. At some point, somebody fixed the test to pass, but it wasn't really doing what was originally intended. Review URL: http://codereview.chromium.org/2121009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47689 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
a different compiler. TBR: sky Review URL: http://codereview.chromium.org/2104008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47688 0039d316-1c4b-4281-b951-d872f2087c98
-
pvalchev@google.com authored
based on sprewell's patch Review URL: http://codereview.chromium.org/2069009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47687 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/1851004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47686 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
BUG=44004 TEST=none Review URL: http://codereview.chromium.org/2099007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47683 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
- Also combined two different ways of writing these times into common code. - Tweaked the color / font of the output BUG=NONE TEST=Ensure that boot times still display on login screen. Review URL: http://codereview.chromium.org/2112006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47682 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/2072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47681 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
TBR=gman@chromium.org Review URL: http://codereview.chromium.org/2084011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47680 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
Disabling sync integration tests that depend on static data. The following tests need to be rewritten without a dependency on static data. LiveSyncTestDefaultIEFavorites.SC_BootStrapWithDefaultIEFavorites LiveSyncTestComplexHierarchy800BM.SC_BootStrapWithComplexBMHierarchy LiveSyncTestHugeHierarchy5500BM.SC_BootStrapWithHugeBMs LiveSyncTestPrePopulatedHistory1K.SC_AddFirstBMWithFavicon LiveSyncTestBasicHierarchy50BM.MC_PushExistingBMsToSecondClient LiveSyncTestBasicHierarchy50BMBothClients.MC_FirstUseExistingSameBMModelBothClients BUG=43917 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2096010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47679 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47677 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=none TEST=no visible change, works when compiled against 10.6 SDK Review URL: http://codereview.chromium.org/2131010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47676 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
Move data types used in the importer process to common/, in preparation for import to run out of process. BUG= 18774 TEST= none. Review URL: http://codereview.chromium.org/2106015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47675 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Apple's NSZombieEnabled setting makes it easier to catch messages to freed objects, but is mostly only useful in debugging environments. This implements a facility like NSZombieEnabled with the following additions: - The number of outstanding zombies can be configured. - Classes can opt-in to becoming zombies. - C++ destructors are correctly called on Leopard. The goal is to allow us to enable zombies in certain production builds to help debug some of the message-after-free bugs we have. BUG=35590,24987 TEST=everything Review URL: http://codereview.chromium.org/660411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47674 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Submitted for Hans Larsen (hansl@google.com), original change list at [http://codereview.chromium.org/2137005]. BUG=None TEST=None Review URL: http://codereview.chromium.org/2096013 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/2131018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47673 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
(such as when loading an unpacled extension). This is because we would reinterpret cast the user data of the HWND to a WidgetWin, and in that case the Windows dialog has a user-data that we did not set. This CL checks that the HWND is at least a WindowImpl before attempting to retrieve the WidgetWin, ensuring we won't mess with windows we did not create directly. BUG=44312 TEST=Open the extension page. Move the focus by pressing TAB to the "Load unpacked extension..." button. Press ENTER many times quickly so it opens/closes the "Select dir" dialog. It should not crash. Review URL: http://codereview.chromium.org/2124009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47672 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Use the flag for querying for thumbnails. Add timer to update TopSites (every second for now). BUG=None TEST='chrome --top-sites' git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47671 0039d316-1c4b-4281-b951-d872f2087c98
-
siggi@chromium.org authored
Submitted for Hans Larsen (hansl@google.com), original change list at [http://codereview.chromium.org/2137005]. BUG=None TEST=None Review URL: http://codereview.chromium.org/2096013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47670 0039d316-1c4b-4281-b951-d872f2087c98
-