- Jan 12, 2011
-
-
joi@chromium.org authored
with the fixes needed so we everything will stay green. BUG=None TEST=None Review URL: http://codereview.chromium.org/6128009 TBR=bradnelson@google.com Review URL: http://codereview.chromium.org/6189007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71197 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
Review URL: http://codereview.chromium.org/6220005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71196 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
BUG=68516 TEST=none Review URL: http://codereview.chromium.org/6231005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71195 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71193 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
BUG=none TEST=printing works after code changes. Review URL: http://codereview.chromium.org/6165004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71186 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@google.com authored
Created common test base class for views. Note: Textfield::RequestFocus is failing because Windows' FocusManager::ClearNativeFocus resets the focused view to NULL for some reason. I don't have win at hand and am now requesting win7. I will look into it once I've got win7. BUG=none TEST=native_textfield_views_unittest and textfield_views_model_unittest have been enabled for win. Review URL: http://codereview.chromium.org/6102003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71183 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Fixed crash caused by ResourceDispatcher::OnReceivedRedirect() indirectly running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method. BUG=chromium:65345, chromium-os:10721 TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps Review URL: http://codereview.chromium.org/6211005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71182 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Revert 71180 - Fixed crash caused by ResourceDispatcher::OnReceivedRedirect() indirectly running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method. BUG=chromium:65345, chromium-os:10721 TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps Review URL: http://codereview.chromium.org/6211005 TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/6100012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71181 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Fixed crash caused by ResourceDispatcher::OnReceivedRedirect() indirectly running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method. BUG=chromium:65345, chromium-os:10721 TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps Review URL: http://codereview.chromium.org/6211005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71180 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
CID=13943, 13746, 13749, 13597, 13249, 13145, 12875, 12874, 12871, 12438, 12436, 12431 BUG=none TEST=none Review URL: http://codereview.chromium.org/6076006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71179 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
When printing a page containing alpha blending on a printer which doesn't support alpha blending, post-process the metafile to replace the AlphaBlend calls with BitBlts from a software-composited rendering of the page so far. BUG=7434 TEST=see bug Review URL: http://codereview.chromium.org/5362002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71177 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6134010 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6130008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71176 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
Mark PrintPreviewUITest.PrintCommandDisabled flaky. BUG=69389,69390 TEST=none Review URL: http://codereview.chromium.org/6184003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71175 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=leak 000000002551055A goes away Review URL: http://codereview.chromium.org/6173009 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/6128010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71174 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=64870 64922 TEST=none Review URL: http://codereview.chromium.org/6174002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71172 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=no log parser errors on heapcheck bot Review URL: http://codereview.chromium.org/6220004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71171 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=leak 000000002551055A goes away Review URL: http://codereview.chromium.org/6173009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71170 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6134010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71169 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=68882 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71167 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=66822 TEST=None Review URL: http://codereview.chromium.org/6115004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71166 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Requested by William Grosso BUG=none TEST=Navigate to https://www.lgelements.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71165 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6109009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71164 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
The PrerenderResourceHandler will initiate prerendering of a web page under the following conditions: - The initial request is a GET for a ResourceType::PREFETCH resource. - The mime-type (sniffed or explicitly specified) of the resource is text/html. - The response status code is a 200. - The top-level page will not need to be revalidated until after it's guaranteed to be removed from potential use. The handler passes along all data to the backing resource handler. BUG=61745 TEST=unit_tests --gtest_filter="PrerenderResourceHandlerTest*" Manual Test: Start Chrome with --enable-page-prerender. Go to a page with a <link rel=prefetch> element. Navigate to that element, and make sure that it uses the prerendered view. Review URL: http://codereview.chromium.org/5912001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71162 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71161 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
This reverts commit 1d5eb805e2ca9cc97355cd73250f9838a5240a49. TBR=satorux@chromium.org BUG=chromium-os:9682 TEST=none Review URL: http://codereview.chromium.org/6176007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71160 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
BUG=chromium-os:9682 TEST='emerge-x86-generic chromeos-chrome' from source passes Review URL: http://codereview.chromium.org/5981001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71159 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
(This was a TODO for phajdan.jr). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6188004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71158 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/5553002varunjain@chromium.org authored
The earlier fix changes the behaviour of the find bar text field such that whenever the textfield is focused, all of the text inside it is selected. This was done to fix a regression where the text was not getting selected when switching tabs (read description on that issue for more info). However, this new behaviour could be undesirable as we may not need to select the whole text everytime find bar gains focus. Hence, in this fix, we undo the changes from the earlier fix and add the selectall behaviour at the right place (when the tab is switched). BUG=none TEST=Test added in the earlier CL still passes. Review URL: http://codereview.chromium.org/6188005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71157 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/6173008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71156 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/5986020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71153 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71151 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71149 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=69066 TEST=net_unittests Review URL: http://codereview.chromium.org/6207005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71148 0039d316-1c4b-4281-b951-d872f2087c98
-
hayato@chromium.org authored
TEST=none BUG=69349 TBR=jschuh Review URL: http://codereview.chromium.org/6139008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71147 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
TBR=senorblanco git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71144 0039d316-1c4b-4281-b951-d872f2087c98
-
rickcam@chromium.org authored
BUG=69324 TEST=manual Review URL: http://codereview.chromium.org/6151008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71143 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
Review URL: http://codereview.chromium.org/6235001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71142 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=67987 TEST=omnibox can show webp from filer or harddrive when mimetype or extension is wrong Review URL: http://codereview.chromium.org/6124007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71141 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Using the debugger, I can verify that previously we were redrawing the entire list once per row (e.g. 10 times if you delete a row in a list that has 10 rows). Now it only redraws once for the delete. BUG=69086 TEST=see above Review URL: http://codereview.chromium.org/6099016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71140 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
with the fixes needed so we everything will stay green. BUG=None TEST=None Review URL: http://codereview.chromium.org/6128009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71137 0039d316-1c4b-4281-b951-d872f2087c98
-