BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26608 0039d316-1c4b-4281-b951-d872f2087c98

(Coverity FORWARD_NULL error CID 6043.)

BUG=17101
TEST=none

Review URL: http://codereview.chromium.org/209038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26607 0039d316-1c4b-4281-b951-d872f2087c98

This avoids a problem building valgrind using MAKE_TARBLL=yes and USE_TARBALL=yes
on a different system.
BUG=none
TEST=install valgrind as documented in our bot setup page on a system without auto* installed.

Review URL: http://codereview.chromium.org/208027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/10937
BUG=http://crbug.com/13021
TEST=Omnibox context menu should contain paste and go/search.
Review URL: http://codereview.chromium.org/192008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26603 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18445
TEST=no

Review URL: http://codereview.chromium.org/216019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=purify layout tests

Review URL: http://codereview.chromium.org/206005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26599 0039d316-1c4b-4281-b951-d872f2087c98

TEST=presubmit doesn't throw an exception on private issues
BUG=none
Review URL: http://codereview.chromium.org/207030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26598 0039d316-1c4b-4281-b951-d872f2087c98

some time-outs with notifications.

BUG=22065
TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal*
     These tests should run in few seconds.

Review URL: http://codereview.chromium.org/210013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98

Hopefully this will help to address some valgrind issues.
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26596 0039d316-1c4b-4281-b951-d872f2087c98

Due to the plugin_list changes in rev 23501 internal plugins registered via a call to PluginList::RegisterInternalPlugin() are no longer being added to the plugin list when LoadPlugins() is called. Fix the problem by adding the internal plugins in LoadPlugins(). 

Original change by Marshall Greenblatt <magreenblatt@gmail.com> at http://codereview.chromium.org/173107.

Review URL: http://codereview.chromium.org/208026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26595 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22077
TEST=on a machine without Firefox, install the WMP NPAPI plugin and ensure that Chrome finds it
Review URL: http://codereview.chromium.org/214018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26594 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/215021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26593 0039d316-1c4b-4281-b951-d872f2087c98

On vista, this change hard breaks tab.title in extensions.

This reverts commit cabda9d732b49ed018821772398d732bbc1af75a (r26586).

TBR=rafaelw

Review URL: http://codereview.chromium.org/207032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26592 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22252
TEST=none

Review URL: http://codereview.chromium.org/207031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26591 0039d316-1c4b-4281-b951-d872f2087c98

Also search in "applications" subdirectory of each of XDG_DATA_DIRS.

TEST=See bug.
BUG=21995

Review URL: http://codereview.chromium.org/214010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26590 0039d316-1c4b-4281-b951-d872f2087c98

To reproduce this crash:
1. Set 'Always open files of this type' on the download shelf
   menu to checked for a particular file type.
2. Download a large file of that type.
3. Before the download completes, open its context menu on
   the shelf.
4. When the download completes, select 'Cancel' from the menu.
5. Crash.

The crash occurs because auto-opened downloads automatically
remove (and thus delete) themselves from the shelf even if
the menu is still running. Selecting a menu item at this point
will attempt to access the deleted object.

The fix is to let the menu know when the calling object is
becoming invalid, so we can avoid doing any further work.

BUG=20810
TEST=Try the above repro steps and notice that Chrome doesn't crash.

Review URL: http://codereview.chromium.org/213018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26589 0039d316-1c4b-4281-b951-d872f2087c98

format "HTTP/host:port" as the third argument (pszTargetName)
to InitializeSecurityContext.  This requires adding a
host_and_port parameter to some methods.

Remove obsolete (and incorrect) logging code in
HttpNetworkTransaction::PrepareForAuthRestart().

R=eroman
BUG=18009
TEST=none
Review URL: http://codereview.chromium.org/206022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21942
TEST=On Linux chrome, load a #anchor page in the background.  After
  the page loads, view the tab.  It should be scrolled to the right
  place.

Review URL: http://codereview.chromium.org/214002


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26587 0039d316-1c4b-4281-b951-d872f2087c98

(If you request tab information while the page is loading, the tab.title is undefined and it shouldn't be.)

Review URL: http://codereview.chromium.org/196125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26586 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/212017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26585 0039d316-1c4b-4281-b951-d872f2087c98

This is step 1 a multi-step process that is part of the webkit chromium port.

This step includes:
A. Refactoring the wtf, pcre & webcore targets into separate files javascriptcore.gypi and webcore.gyp, which would eventually move upstream.
B. Refactoring the feature_define variables into features.gypi, to allow two sets of feature defines - one for chromium port and one for chromium.
C. Refactoring the config target into config.gyp, since currently both javascriptcore and webcore target depend on it.

Next steps:
2. Eliminate config dependency.
3. Make features.gypi only override built-in variables that live upstream (so we don't have to maintain 2 parallel feature lists).
4. Really move webcore.gyp & javascriptcore.gyp to webkit.org

Review URL: http://codereview.chromium.org/212003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26584 0039d316-1c4b-4281-b951-d872f2087c98

the options dialog.  This was done a long long time ago because
we used to register the download dir pref in the Download Manager
constructor.  Since that's no longer the case, we don't need to
intialize the Download Manager.

Review URL: http://codereview.chromium.org/208021


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26583 0039d316-1c4b-4281-b951-d872f2087c98

the menu which is just going away.  This makes it consistent with
the edit dialog that comes up when editing directly on the toolbar.

Review URL: http://codereview.chromium.org/213015


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26582 0039d316-1c4b-4281-b951-d872f2087c98

long since been replaced by generated files from gyp.

Review URL: http://codereview.chromium.org/213013


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26581 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/208007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26579 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/213024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26578 0039d316-1c4b-4281-b951-d872f2087c98

ThreadSanitizer runs on release binaries.

This is a copy of http://codereview.chromium.org/201060
I wasn't a commiter at that time.

Please note that http://codereview.chromium.org/195078 was submitted recently which defines NVALGRIND for non-valgrind Release builds.
Review URL: http://codereview.chromium.org/195091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26576 0039d316-1c4b-4281-b951-d872f2087c98

- use better name for FTP LIST parsing code in about:credits
- don't open a second data socket
- add a comment explaining why we close the data socket at one point

TEST=Covered by net_unittests.
BUG=none

Review URL: http://codereview.chromium.org/207014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26575 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Chrome implementation of worker error reporting to report errors via event listeners, not just via onerror.
Rebaselined worker-script-error test to reflect new test case.
Re-enabled WorkerFastLayoutTests.

BUG=20822
TEST=none (enabling existing tests)

Review URL: http://codereview.chromium.org/207002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=switching tabs via key combos should still work.
Review URL: http://codereview.chromium.org/209031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26573 0039d316-1c4b-4281-b951-d872f2087c98

1. Allow hiding/showing of the legend.
2. Fix number of results input to actually work (i.e. invalidate old data).
3. Making clicking on test links put up a popup with the information
for the test across all builders.
4. Fix blamelists to not have an off-by-one error in the previous revision.
5. Make maxResults work when viewing an individual test across all builders.

Review URL: http://codereview.chromium.org/215019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26572 0039d316-1c4b-4281-b951-d872f2087c98

the new tests pass so remove them from test expectations

TBR=dglazkov
TEST=none
BUG=20509

Review URL: http://codereview.chromium.org/216017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26571 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=22252

Review URL: http://codereview.chromium.org/208024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26570 0039d316-1c4b-4281-b951-d872f2087c98

Changing the comparison form affects the warning messages
generated in various circumstances. See the codereview for
details.

Also, Apple docs claim that !symbol comparisons will not work.

Spotted by Matthew Vosburgh.

Review URL: http://codereview.chromium.org/214012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26569 0039d316-1c4b-4281-b951-d872f2087c98

I just changed the shelf to autosize horizontally and to be anchored at the bottom and the left and right sides in IB (it was anchored to the top left before and had no autoresizing).

BUG=none
TEST=Enable extension shelf in browser_window_controller.mm (turn #if 0 into #if 1), then build & start chromium. Resize the browser window. The shelf should now stay at the bottom of the window and stay sane.

Review URL: http://codereview.chromium.org/208023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/14908
TEST=Findbar should animate open and closed, unless switching tabs.
Review URL: http://codereview.chromium.org/195105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26567 0039d316-1c4b-4281-b951-d872f2087c98

mode.  This will prevent spurious renderer resizes and reduce flicker.

BUG=http://crbug.com/21666
TEST=Layout of www.google.com should not be messed up after exiting fullscreen
mode.
Review URL: http://codereview.chromium.org/210011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26566 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw
TEST=ExtensionAPIClientTest.GetLastFocusedWindow in unit_tests
BUG=22248
Review URL: http://codereview.chromium.org/207029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26565 0039d316-1c4b-4281-b951-d872f2087c98

The previous patch was reverted until buildbot master was restarted.

After the restart, GYP_DEFINES contains "release_valgrind_build=1"
http://build.chromium.org/buildbot/waterfall/builders/Chromium Linux Builder (valgrind)/builds/2/steps/gclient/logs/stdio
Review URL: http://codereview.chromium.org/196140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26564 0039d316-1c4b-4281-b951-d872f2087c98