Original review: http://codereview.chromium.org/340057

TBR=mpcomplete@chromium.org
BUG=22103
TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the
script should show up in the extension management UI. It should also work, though some scripts use
Firefox-specific APIs and those won't work in Chromium.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340077

TBR=sky@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98

(was looking in newest dir before).

  TEST=none
  R=ojan@chromium.org
  BUG=none

Review URL: http://codereview.chromium.org/353014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30912 0039d316-1c4b-4281-b951-d872f2087c98

(1) Move it into the HttpNetworkSession so that HttpNetworkTransaction can access it.
This is in anticipation of switching HTTP/HTTPS connections over to FLIP.
(2) Add some more functionality to FlipSessionPool, allowing HttpNetworkTransactions to check for
the existence of other, reusable FlipSessions.

Review URL: http://codereview.chromium.org/348066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20511
TEST=none
Review URL: http://codereview.chromium.org/342112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30908 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30907 0039d316-1c4b-4281-b951-d872f2087c98

This has been bugging me.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30905 0039d316-1c4b-4281-b951-d872f2087c98

valgrind as valgrind.sh.

Add script to locally reproduce the nonleak valgrind errors
found recently by the linux valgrind layout bot.

Review URL: http://codereview.chromium.org/351017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/340077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98

Also removed some of the testing hacks for URL rewriting
that are no longer needed.

This change removes the 'batching' of frames written
to the socket.  The reason for doing this is because
I'm going to need to start notifying to the upper layer
as progress is made on the writes (e.g. upload notifications).
When the frames are batched (potentially from different 
transactions), it becomes very difficult to know when each
write completes.  I don't think that batching is necessary, 
as writes will accummulate in the socket buffer, so this
should be a better approach.

BUG=none
TEST=flip_session_unittest.cc

Review URL: http://codereview.chromium.org/342088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30898 0039d316-1c4b-4281-b951-d872f2087c98

Some devtool tests hang on Windows, one fails on Linux.
I need to investigate more.

BUG=None
TBR=rafael
Review URL: http://codereview.chromium.org/348067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30897 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/346043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30896 0039d316-1c4b-4281-b951-d872f2087c98

The if was wrong. If the jscompiler exists we DON'T
want the non-compiled files.


Review URL: http://codereview.chromium.org/342108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rafaelw

Review URL: http://codereview.chromium.org/358001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30894 0039d316-1c4b-4281-b951-d872f2087c98

[Mac] Enables animations for the infobar.  Changes the control flow for infobar opening/closing to match Windows more closely.

Nib file changes:
- Embedded the InfoBarGradientView inside an AnimatableView.
- Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet.
- Bound the AnimatableView's delegate_ to the InfoBarController.

BUG=http://crbug.com/25599
TEST=Infobars should animate in and out, except for during tab switches.
Review URL: http://codereview.chromium.org/354008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98

the cache. We need to do this else we don't honor page expiration and
end up showing stale data for some sites.

BUG=21195
TEST=make sure session restore works.

Review URL: http://codereview.chromium.org/341043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/351024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30891 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= none
Review URL: http://codereview.chromium.org/342107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/340080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30889 0039d316-1c4b-4281-b951-d872f2087c98

Update the images for notification frames, since they had a transparent gap between the balloon and the shelf, and also on the left edge.

BUG=26631
TEST=create notifications over a busy desktop background

Review URL: http://codereview.chromium.org/351028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30887 0039d316-1c4b-4281-b951-d872f2087c98

TBR=phajdan.jr,jam
BUG=17806

Review URL: http://codereview.chromium.org/346045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26262

Review URL: http://codereview.chromium.org/344044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30884 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10442
TEST=none
TBR=hclam

Review URL: http://codereview.chromium.org/357001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30883 0039d316-1c4b-4281-b951-d872f2087c98

Use ChromeThread::DeleteOnIOThread in a few places where an object must be deleted on a certain thread.

BUG=25354
Review URL: http://codereview.chromium.org/342090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25354
Review URL: http://codereview.chromium.org/353015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30881 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate QueryOptions::most_recent_visit_only.  All non-unittest consumers of this set it to true, so just turn it on unconditionally.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30880 0039d316-1c4b-4281-b951-d872f2087c98

into problems when running several browser tests in the same process.
Turning previously failing tests on.

BUG=26540
TEST=Run the interactive UI tests on Windows and Linux.

Review URL: http://codereview.chromium.org/355014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30879 0039d316-1c4b-4281-b951-d872f2087c98

end up skipping the cache.

BUG=26175
TEST=unittests


Review URL: http://codereview.chromium.org/348053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25354

Review URL: http://codereview.chromium.org/353023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30876 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30875 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was conditional on !x64, but I fixed that earlier
today and forgot to readd the dependency.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30874 0039d316-1c4b-4281-b951-d872f2087c98

Changes the fallback order of Chromium win directories in the layout test formatter to (xp, vista, win7, win) to match changes in platform_utils_win.

R=ojan
BUG=none
TEST=run test_output_formatter.bat, the script should pull the correct baselines.

Review URL: http://codereview.chromium.org/341086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30873 0039d316-1c4b-4281-b951-d872f2087c98

in the past saying that these should be fixed immediately, but this impedes
our ability to run the tests on the bots without turning them red.
Needing to skip these tests to avoid making the bots red is silly.
Review URL: http://codereview.chromium.org/356007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30872 0039d316-1c4b-4281-b951-d872f2087c98

- Make some vertical spacing in basics more consistent
- Make some vertical spacing in personal stuff more consistent
- Make the views a bit wider to avoid some clipping and wrapping in a few languages.
- A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc).

TEST=window looks ok (given our strings it won't always look great, but shoot for ok).
BUG=26586
Review URL: http://codereview.chromium.org/351027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30871 0039d316-1c4b-4281-b951-d872f2087c98

xib changes:
- cell tags changed to make them styled independently
- button attribute "bordered" disabled

BUG=http://crbug.com/25644
TEST=as in bug

Review URL: http://codereview.chromium.org/341088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30869 0039d316-1c4b-4281-b951-d872f2087c98

This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil.

Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager,
ModelSafeWorker, etc from progress state.

BUG=25266
TEST=sync unit tests

Review URL: http://codereview.chromium.org/351026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30868 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/26138
TEST= none
Review URL: http://codereview.chromium.org/355013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30867 0039d316-1c4b-4281-b951-d872f2087c98

"Add Folder..." from either buttons or bar happier (always adds, doesn't edit).
"Add Folder..." now allows you to rename new folders the default name ("New Folder").


BUG=http://crbug.com/26364, http://crbug.com/26407

TEST=Over a bookmark button for a 'mark or folder, context menu --> Edit.
Make sure initial name is current name, not "New Folder".
Over button for 'mark, for folder, or bar itself: context menu --> Add Folder.
Make sure initial name is "New Folder", and that it creates a folder (not a rename).
Make sure you are allowed to create a folder named "New Folder".

Review URL: http://codereview.chromium.org/345045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30866 0039d316-1c4b-4281-b951-d872f2087c98

We set -fPIC just on the layout test plugins and only in 64-bit mode.
This fixes 44 plugin layout tests on 64-bit.

(Retry, now just npapi_layout_test_plugin and not npapi_test_plugin.)

BUG=18337,24271

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30851

Review URL: http://codereview.chromium.org/353022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30864 0039d316-1c4b-4281-b951-d872f2087c98

When drawing a Label it is important to adjust for
RTL not just when drawing, but also when computing
the size of the string.

Before this change, we'd compute using Font::GetStringWidth
(which uses ::GetTextExtentPoint32 *without* adjusting
the string for RTL) and draw using DoDrawText (which
adjusts for RTL and then draws using ::DrawText).

After this change, we now use SizeStringInt for
computing (so we now compute and draw using the
same ::DrawText function, thereby adjusting the 
string for RTL in both cases).

BUG=17949
TEST=Run chrome with --lang=he, press F11 and
the string in the bubble at the top should not
be elided.

Review URL: http://codereview.chromium.org/354014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30863 0039d316-1c4b-4281-b951-d872f2087c98