- Jul 27, 2010
-
-
victorw@chromium.org authored
TBR=jorlow TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53863 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
BUG=none TEST=should work exactly the same Review URL: http://codereview.chromium.org/3069006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53862 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
Both libxml and its direct dependencies need to define LIBXML_STATIC when libxml is a static library. Right now it is necessary to define this macro only on Windows, but the macro is intended to be cross-platform. R=evan BUG=50048 TEST=Windows build log should not contain "locally defined symbol XXX imported" linker warings such as: libxslt.lib(numbers.obj) : warning LNK4049: locally defined symbol _xmlFree imported Review URL: http://codereview.chromium.org/3063009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53861 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
Review URL: http://codereview.chromium.org/3047004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53858 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs. Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed. BUG=48713 TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs. Review URL: http://codereview.chromium.org/3046025 TBR=stuartmorgan@chromium.org Review URL: http://codereview.chromium.org/3058018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53857 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
Review URL: http://codereview.chromium.org/3059005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53856 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
o3d-webgl: Adjusting Sampler to throw an error if client attempts to use BORDER as uv address mode (not supported in WebGL). Review URL: http://codereview.chromium.org/3038014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53855 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
This could be caused by http://trac.webkit.org/changeset/64124/trunk. Created a bug and assigned to pfeldman to investigate. TBR=pfeldman BUG=50416 TESt=unit test passes git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53854 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
Fixes a small typo; reported in: http://groups.google.com/group/o3d-discuss/browse_thread/thread/db4be6e10594af70?hl=en Review URL: http://codereview.chromium.org/3045017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53853 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53852 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Also, the old method of passing around a pointer was not safe due to object lifetime issues. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53851 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@google.com authored
BUG=37201 TEST=net_unittests.exe --gtest_filter=NetUtilTest.IDNToUnicode* Review URL: http://codereview.chromium.org/3011012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53850 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs. Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed. BUG=48713 TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs. Review URL: http://codereview.chromium.org/3046025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53849 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
BUG=None TEST=Verify that the internal PDF plugin is disabled by default.s Review URL: http://codereview.chromium.org/3052015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53848 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3058011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53847 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
Extension functions should be allowed to make repeat requests to external protocol handling without needing a user gesture (see bug). This allows them to do so (and changes the method name for clarity). BUG=39178 TEST=NONE Review URL: http://codereview.chromium.org/2884040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53846 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Adds awareness of kAutoFillAuxiliaryProfilesEnabled preference to |OptionsUtil::ResetToDefaults()|, which is used to reset preferences from the "Under the Hood" / "Reset to Defaults" button. BUG=49873 TEST=AutoFillManagerTest.AuxiliaryProfilesReset Review URL: http://codereview.chromium.org/3054019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53845 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
The logic is taken from firefox. BUG=48346 TEST=unit tests; downloading the same .tar.gz file multiple times (see bug) Review URL: http://codereview.chromium.org/3018011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53844 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
during the review of r49350). BUG=none TEST=recompiled Patch from Mihai Parparita <mihaip@chromium.org>. Review URL: http://codereview.chromium.org/2854060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53843 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=50107 TEST=Run chrome --lang=he, click the wrench; the button and dropdown should align on the left edge, not the right. Review URL: http://codereview.chromium.org/3017033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53842 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Cleanup: Remove pointless GetInsets() override. Simplify |container_size_| to just be |container_width_|. Fix indenting/alignment, especially of function parameters. L"" -> std::wstring(). Don't handle assertion violations (style guide/simplicity). Reduce indenting via early-return or simpler-path-return. Streamline code where possible. Definition order should match declaration order. EXPECT_STREQ -> EXPECT_EQ. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3076001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53841 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
This CL includes: 1. Implementation of ui_test_utils_mac.mm 2. Fix for ui_controls_mac.mm 3. Port browser_keyevents_browsertest.cc to Mac and add some new tests for Mac. 4. Partially port browser_focus_uitest.cc to Mac, now can be compiled and run on Mac but some tests fail. 5. Add two functions into ui_test_utils.h: HideNativeWindow() and ShowAndFocusNativeWindow(). The latter one shows a window and grabs the input focus, which is useful for tests depending on fake keyboard/mouse events. Because browser_keyevents_browsertests.cc and browser_focus_uitest.cc belong to interactive_ui_tests, which is not available on Mac (see http://crbug.com/21276), in order to test them on Mac, you may want to move them into browser_tests locally. But it won't work on build and try bots, because these tests must be run with screen unlocked. This CL depends on CL: http://codereview.chromium.org/2973004 and http://codereview.chromium.org/2805075 BUG=22515 Keyboard handling needs unit tests BUG=48671 interactive_ui_test: BrowserKeyEventsTest.NormalKeyEvents is flaky BUG=48936 Browser window is opened inactivated when running an InProcessBrowserTest. TEST=none Review URL: http://codereview.chromium.org/2986004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53840 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=47883 TEST=manual (turning network connection off and on) Review URL: http://codereview.chromium.org/2809056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53839 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
with a weak pointer to avoid crashing at shutdown. BUG=50082 TEST=net_unittests Review URL: http://codereview.chromium.org/3054012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53838 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Avoid printing log errors during shutdown of HostResolverImpl when there are still requests outstanding. BUG=49692 Review URL: http://codereview.chromium.org/3023011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53837 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item. BUG=50307 TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed. TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately. Review URL: http://codereview.chromium.org/3020035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53833 0039d316-1c4b-4281-b951-d872f2087c98
-
ziadh@chromium.org authored
We would like to refine the numbers we started off with in the first experiment (then set to [4, 6, 8, 16] connections -- see http://codereview.chromium.org/2658006). Overall, 16 connections did not compare favorably to either 6 or 8 connections. At this point we'd like to modify and narrow down our range to span 5 to 9 connections. r=jar BUG=44491 Review URL: http://codereview.chromium.org/3077001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53832 0039d316-1c4b-4281-b951-d872f2087c98
-
ziadh@chromium.org authored
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=bulach TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53830 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@google.com authored
Also fix tsan failure for spdy_http_stream_unittest. Attempted to commit in http://codereview.chromium.org/3014030/show, ran into different tsan failure. TEST=net_unittests, tsan on windows for SpdyHttpStreamTest. BUG=46589, 47478, 50198 Review URL: http://codereview.chromium.org/2811072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53829 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
The fact that we have this weird vestigal "Default" directory is really confusing. :( Review URL: http://codereview.chromium.org/3014028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53828 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
alphabetization. Note that the F1 key is the "Back" key on Chrome OS, and F2 is "Forwards". BUG=none TEST=none Review URL: http://codereview.chromium.org/2878059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53827 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Doing the most simple eliding, which is to truncate and replace with ellipses on a character basis. I put this in the code rather than the .xib because this seems like it should be a hard-wired Omnibox behavior. BUG=50253 TEST=Put in a very long URL and check that it elides as the window gets too small for it to fit. You can easily craft long URLs by adding # and filling with whatever you desire after that. Review URL: http://codereview.chromium.org/3010031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53826 0039d316-1c4b-4281-b951-d872f2087c98
-
agayev@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3035032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53825 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. BUG=None. TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled. Review URL: http://codereview.chromium.org/3026025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
BUG=20504 TEST=greener valgrind TBR=evan@chromium.org,mark@chromium.org Review URL: http://codereview.chromium.org/3020036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53823 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
BUG=4994 TEST=none Review URL: http://codereview.chromium.org/3043024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53821 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
A field of the ViewHostMsg_Resource_Request structure was uninitialized. Also, includes a fix for an ASSERT_EQ that listed the expected value second instead of first. R=oshima BUG=50002 TEST=none Review URL: http://codereview.chromium.org/3052014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53820 0039d316-1c4b-4281-b951-d872f2087c98
-
ahendrickson@google.com authored
This covers the cases using GSSAPI for Negotiate to authenticate to a proxy, where: - The user does not have a TGT (Ticket Generating Ticket), or - The user is unable to get to the TGS (Ticket Granting Server). The bug was that the authentication system tried to reuse the Negotiate handler even though it was not possible for it to succeed, leading to infinite retries. BUG=33033 Test=None Review URL: http://codereview.chromium.org/3040015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53819 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Basically verifies that our assumptions on how FFmpeg works opening/seeking/parsing files remain intact. BUG=19865 TEST=run ffmpeg_unittests :) Review URL: http://codereview.chromium.org/3058004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53818 0039d316-1c4b-4281-b951-d872f2087c98
-