- Nov 03, 2010
-
-
timurrrr@chromium.org authored
BUG=61585 TBR=glider Review URL: http://codereview.chromium.org/4339003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64951 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/4262001/showhansl@google.com authored
The r64883 broke most unit tests in CEEE that relied on disabling logs while testing error paths. BUG=None TEST=None Review URL: http://codereview.chromium.org/4390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64948 0039d316-1c4b-4281-b951-d872f2087c98
-
hansl@google.com authored
Verify that we don't receive a NULL pointer for the session_id. This check will be removed as soon as getSessionId is implemented in ChromeFrame. Also, it is not needed for the other code path as ChromeFrame does make the check in it. BUG=3161153 TEST=None Review URL: http://codereview.chromium.org/4321007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64947 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@chromium.org authored
BUG=chromium-os:5612 TEST=None TBR=ers@chromium.org Review URL: http://codereview.chromium.org/4399001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64946 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
* Now there's a class named MasterPreferences that owns the json dictionary and supports methods that previously were global. * There's now a global object for the current process' master preference object, which avoids parsing the preference file multiple times. * Refactored the tests to be more data driven TEST=Run the installer util unit tests. Set the filter to *MasterPref* if you only want to run the tests affected by this change. BUG=none Review URL: http://codereview.chromium.org/4342001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64945 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
BUG=59890 TEST=Manual. Inspect32. Review URL: http://codereview.chromium.org/4292001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64943 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@google.com authored
causing this DCHECK to trigger because it was still checking for the old number of arguments. Changed the DCHECK condition to test for the correct number. BUG=0 TEST=None Review URL: http://codereview.chromium.org/4343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64942 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
This is an attempt to fix this valgrind error: http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20(valgrind)(2)/builds/210/steps/memory%20test:%20ui_1/logs/stdio It appears mmap might have been trying to map libosmesa.so to a fixed address. TEST=try BUG=61601 Review URL: http://codereview.chromium.org/4318005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64941 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
There appears to also be problems in ANGLE which have not been addressed yet, specifically GL_RGB textures are allocated D3DFMT_A8R8G8B8 instead of D3DFMT_X8R8G8B8. Prevent saved and target offscreen resources from being destroyed if we don't have a context. TEST=try, run demos locally BUG=61441 Review URL: http://codereview.chromium.org/4246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64940 0039d316-1c4b-4281-b951-d872f2087c98
-
caseq@google.com authored
BUG=http://crbug.com/61717 TEST=Build on VS 2005 Review URL: http://codereview.chromium.org/4271003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64939 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This should make svn sync again this directory. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64933 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
DO NOT SYNC TO THAT REVISION. Trying to workaround bug introduced in 64923. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64932 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
NO CODE CHANGE git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64930 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
NO CODE CHANGE. TBR=robertshield TEST=none BUG=none Review URL: http://codereview.chromium.org/4334003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64929 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=fbarchard TEST=none BUG=none Review URL: http://codereview.chromium.org/4386002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64928 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
BUG=55165 TEST=tools/licenses.py Review URL: http://codereview.chromium.org/4345001 TBR=fbarchard@chromium.org Review URL: http://codereview.chromium.org/4365002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64927 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
BUG=chromium-os:8465 TEST=Verify progress bar has new look now per chromium-os:8465. Review URL: http://codereview.chromium.org/4236001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64924 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=55165 TEST=tools/licenses.py Review URL: http://codereview.chromium.org/4345001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64923 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
The window size handling in PanelBrowserView::Init seems no longer needed and would cause problem now. BUG=chromium-os:8258 TEST=Verify fix for chromium-os:8258. Review URL: http://codereview.chromium.org/4170010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64922 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider BUG=61753 Review URL: http://codereview.chromium.org/4383001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64921 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=27786,60591 TEST=Enable 'Confirm to Quit' in about:flags. When you press Cmd+Q, it brings up the floaty panel telling you to hold the key combo. When you do, it quits after 1.5 seconds. Review URL: http://codereview.chromium.org/4220005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64920 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/4146012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64919 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64917 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
TBR=thakis BUG=48521 TEST= Review URL: http://codereview.chromium.org/4264004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64916 0039d316-1c4b-4281-b951-d872f2087c98
-
altimofeev@chromium.org authored
BUG=chromium-os:8161 TEST=manual Review URL: http://codereview.chromium.org/4332002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64915 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
Marking two OptionsUITests (TwoCommandsOneTab & CommandAgainGoesBackToOptionsTab) as DISALBED because of linux/views crashes TBR=csilv BUG=48521 TEST= Review URL: http://codereview.chromium.org/4370003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64914 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
This adds a device management backend implementation running over HTTP. BUG=None TEST=unit tests in device_management_backend_impl_unittest.cc Review URL: http://codereview.chromium.org/4098004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64912 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
TBR=rafaelw Review URL: http://codereview.chromium.org/4352003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64911 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Marking animations/suspend-resume-animation-events.html as failing, it appears to crash on Mac quite a bit. BUG=61739 TEST=None TBR=rolandsteiner, rafaelw Review URL: http://codereview.chromium.org/4372002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64910 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=61737 TBR=antonm Review URL: http://codereview.chromium.org/4374002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64909 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=61669 TEST=none Review URL: http://codereview.chromium.org/4234005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64907 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider BUG=59642 Review URL: http://codereview.chromium.org/4370002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64906 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=61731 TBR=glider TEST=TSan/Mac should go green Review URL: http://codereview.chromium.org/4379001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64905 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
These will be replaced by actual images for the about:conflicts page. TBR=huanr BUG=61723 TEST=None, these are new pngs, will be used in my next changelist. Review URL: http://codereview.chromium.org/4236002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64902 0039d316-1c4b-4281-b951-d872f2087c98
-
dilmah@chromium.org authored
BUG=http://crosbug.com/8458 TEST=Manual Review URL: http://codereview.chromium.org/4324001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64901 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Marking ExtensionAPiTest.ProcessesVsTaskManager as flaky. It appears to fail as the result of a resource leak of some kind. BUG=44991 TEST=None TBR=rafaelw, sky Review URL: http://codereview.chromium.org/4274003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64899 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
This would suppress reports like: http://build.chromium.org/p/chromium.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/259/steps/memory%20test:%20ui_9/logs/stdio ==14031== WARNING: Possible data race during read of size 4 at 0x801497C: {{{ ==14031== T0 (L{L37, L165}): ==14031== #0 ???//usr/lib/pango/1.6.0/modules/pango-arabic-lang.so /usr/lib/pango/1.6.0/modules/pango-arabic-lang.so ==14031== #1 pthread_mutex_lock /tmp/valgrind-src/tsan/tsan/ts_valgrind_intercepts.c:892 ==14031== #2 dlopen_doit /lib/tls/i686/cmov/libdl-2.7.so ==14031== #3 _dlerror_run /lib/tls/i686/cmov/libdl-2.7.so ... ==14031== Concurrent write(s) happened at (OR AFTER) these points: ==14031== T8 (Chrome_IOThread) (L{}): ==14031== #0 inflate_fast /build/buildd/zlib-1.2.3.3.dfsg/inffast.c:270 ==14031== #1 inflate /build/buildd/zlib-1.2.3.3.dfsg/inflate.c:954 ==14031== #2 GZipFilter::DoInflate(char*, int*) net/base/gzip_filter.cc:226 ==14031== #3 GZipFilter::ReadFilteredData(char*, int*) net/base/gzip_filter.cc:141 This may also speed TSan up a little bit. TBR=glider Review URL: http://codereview.chromium.org/4341003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64898 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
I wrote much of the cross-platform policy-providing mechanism for Chrome. Much of the policy code is cross platform, so I would like to apply for a Linux C++ readability review. However, my submitted CLs also contain Windows-specific code, so I'm unsure if Windows readability is more appropriate. * Implementation of managed policy abstraction on top of a preference store. This is the CL that is the initial preparation for implementing platform-specific policy - http://codereview.chromium.org/1692011 * Implement core mechanism to honor Windows Group Policy on top of initial CL - http://codereview.chromium.org/2119005 * Dynamic refresh of policy without restarting Chrome including Windows-specific code - http://codereview.chromium.org/2858060 BUG=none TEST=none Review URL: http://codereview.chromium.org/3774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64897 0039d316-1c4b-4281-b951-d872f2087c98
-
rolandsteiner@chromium.org authored
Also help to make the tree greener BUG=none TEST=none TBR=dumi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64895 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
instead of --show-possible. This flag appeared in trunk after Valgrind r11308 (valgrind-variant r60) TBR=timurrrr Review URL: http://codereview.chromium.org/4375001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64894 0039d316-1c4b-4281-b951-d872f2087c98
-