Review URL: http://codereview.chromium.org/6233001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71075 0039d316-1c4b-4281-b951-d872f2087c98

If an SSL handshake fails when client certificates are used, ensure that
the client certificate selected is removed from the SSL client auth
cache. This ensures that the user is prompted to select a certificate
again, as the cause of the failure may have been due to selecting the
wrong certificate or selecting no certificate when one is required.

The existing logic worked when TLS False Start was disabled, but could
fail when False Start was used or when the peer requests renegotiation.
This changes ensures the client certificate is removed from the cache by
moving the cache removal layer from the HttpStreamRequest to the
HttpNetworkTransaction.

Patch by: Ryan Sleevi

BUG=66424
TEST=HttpNetworkTransactionTest.ClientAuthCertCache*

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=thakis

Review URL: http://codereview.chromium.org/6132008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71070 0039d316-1c4b-4281-b951-d872f2087c98

Chromium repository to break circular dependencies on Chromium's
OpenGL bindings in app/gfx/gl.

The minimal changes to the code were made in order to break
dependencies on WebCore types and to make the code fit the Google C++
style guide as closely as possible. There are many references to
undesirable types like "long" in the WebGraphicsContext3D interface,
which are the source of the majority of lint errors and which will be
fixed in follow-on work.

The upstream WebGraphicsContext3DDefaultImpl will be deleted after
this lands.

Tested:
 - Various WebGL demos in Chrome
 - Built and ran WebGL layout tests in DRT

BUG=none
TEST=none (see above)

Review URL: http://codereview.chromium.org/6100009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71069 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/changeset/75484/ (rolled with r71043).

TBR=jschuh

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71068 0039d316-1c4b-4281-b951-d872f2087c98

make OnCallback() static to prevent the CompositeFilter from
becoming owned by other filter threads.

BUG=68784
TEST=None

Review URL: http://codereview.chromium.org/6226001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71067 0039d316-1c4b-4281-b951-d872f2087c98

TBR=joi@chromium.org
BUG=68516
TEST=none
Review URL: http://codereview.chromium.org/6109008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71066 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6155007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71065 0039d316-1c4b-4281-b951-d872f2087c98

Calls ChromeURLRequest::IsExternal() inside ResourceDispatcherHost to see if the URLRequestContext was a valid ChromeURLRequestContext at the point when it was set.

BUG=68766

Review URL: http://codereview.chromium.org/6094017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71064 0039d316-1c4b-4281-b951-d872f2087c98

otherwise causes subtle problems with extensions and breaks the
invariant that the tab id is unique.

BUG=68508
TEST=none

Review URL: http://codereview.chromium.org/6155003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71063 0039d316-1c4b-4281-b951-d872f2087c98

Enable GpuPixelBrowserTest.WebGLTeapot and add a test option for picking a custom directory for generated images.
BUG=59131
TEST=none
Review URL: http://codereview.chromium.org/6173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71062 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.

TBR=abarth
BUG=
TEST=

Review URL: http://codereview.chromium.org/6196005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71061 0039d316-1c4b-4281-b951-d872f2087c98

Rework how bookmark bar folder menus and submenus are layed out when scrolling, adding and removing bookmarks and during drag and drop operations. Make a subfolder menu appear as much on screen as possible.

Changed to the BookmarkBarFolderWindow.xib: Added view (visibleView_) between the window's content view and the rest of the content. Added scroll-up arrow and scroll-down arrow views. Added connections to controller of all views within the window.

BUG=54701
TEST=Test submenu appearance by creating a folder menu with lots of items with the bottom-most item being a sub-folder with several bookmark items of its own. Place the browser window such that the bookmark button for the sub-folder will appear near the bottom of the screen. Pop up the folder menu then pop up the sub-menu and verify that the sub-menu is shown on screen and does not require scrolling.

In all following cases of adding or removing bookmarks, either by using the contextual menus (cut/copy/paste/delete) or by dragging and dropping, verify that the top of the folder menu and the menu items (bookmark buttons) above the location of the addition/removal remain in the same position vertically on the screen; menu items below the affected bookmark should move upward (for a removal) or downward (for an addition) and the scroll-up arrow (the one at the bottom of the menu) should hide or show as appropriate.

Verify that dragging or pasting a wide menu item into a narrow folder menu causes the menu to widen. Verify that cutting or deleting a wide menu item from a folder menu will cause the menu to narrow.

Perform the listed tests for each of the folder menu arrangements.

Folder menu arrangements
------------------------
1. Folder with no items (one showing 'empty')
2. Folder with just a few items and neither the scroll-up or scroll-down arrow showing.
3. Folder with enough items such that adding one more should cause the scroll-up arrow to show.
4. Folder with enough items and the scroll-up arrow showing such that removing one item should cause the scroll-up arrow to hide.
5. Folder with enough items that the scroll-up arrow shows but after fully scrolling the menu fits completely on screen without any scrolling arrows showing.
6. Folder with enough items that the scroll-up arrow shows and can be scrolled up such that both scroll-up and scroll-down arrows can show with plenty of extra items.

Tests
-----
1. Cut a bookmark menu item.
2. Paste an item.
3. Paste another item.
4. Drag an item to a different place within the same folder menu.
5. Drag an item to a different folder menu (one each of those listed above).
6. Cut the first item.
7. Cut the last item.
8. Paste to the last item.
For scrollable arrangements #5 and #6:
9. Scroll up only a little (such that the scroll-down arrow does not appear) and cut an item.
10. Scroll up only a little (such that the scroll-down arrow does not appear) and paste an item.
For scrollable arrangement #6:
11. Scroll up so that both the scroll-up and scroll-down arrows appear and cut an item.
12. Scroll up so that both the scroll-up and scroll-down arrows appear and paste an item.

Review URL: http://codereview.chromium.org/5694001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71059 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration tests were using a timeout of 30 seconds for live
operations. Some of the sync stress tests are timing out because it
takes longer for a full sync cycle to complete.

This patch increases the timeout to 45 seconds in
profile_sync_service_harness.cc, and is expected to eliminate the
occasional failures on the builders.

TBR=tim@chromium.org
BUG=68207
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6125006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71058 0039d316-1c4b-4281-b951-d872f2087c98

TBR=joi

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71057 0039d316-1c4b-4281-b951-d872f2087c98

TableModelArrayController is a subclass of NSArrayController that adapts a TableModel (including groups) for use with Cocoa bindings.

Original CL: http://codereview.chromium.org/3327016

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5831001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68516
TEST=none
Review URL: http://codereview.chromium.org/6111008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6060008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69247
TEST=no crash

Review URL: http://codereview.chromium.org/6106012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71051 0039d316-1c4b-4281-b951-d872f2087c98

Fix problem with uninstallation of multi-install products.
We would incorrectly uninstall both installed products when we should only uninstall one.

BUG=68876
TEST=See bug description.


Review URL: http://codereview.chromium.org/6186006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9296
TEST=manual

Review URL: http://codereview.chromium.org/5966008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71048 0039d316-1c4b-4281-b951-d872f2087c98

RenderView load them directly, in response to the
LoadBlockedPlugins IPC message.

BUG=none
TEST=NPAPIVisiblePluginTester.ClickToPlay (pre-existing)

Review URL: http://codereview.chromium.org/6209004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71047 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6192006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71046 0039d316-1c4b-4281-b951-d872f2087c98

As per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ui_tests&tests=ViewSourceTest.ViewSourceInMenuDisabledWhileViewingSource

BUG=69249
TEST=none

Review URL: http://codereview.chromium.org/6133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71045 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yurys

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6222005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68877
TEST=Installing Chrome with --multi and then Chrome Frame with --multi works.

Review URL: http://codereview.chromium.org/6109006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=NativeTextfieldViewsTest.InsertionDeletionTest

Review URL: http://codereview.chromium.org/6119003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71041 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yurys

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=58235
TEST=none

Review URL: http://codereview.chromium.org/6148006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71039 0039d316-1c4b-4281-b951-d872f2087c98

(This was a TODO for phajdan.jr).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6187002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/6119005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71037 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71033 0039d316-1c4b-4281-b951-d872f2087c98

The UMA stat for the Wrench menu was only firing when Alt+F was pressed, not when mouse clicking. Move the recording of the event down into the funnel.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6130004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71029 0039d316-1c4b-4281-b951-d872f2087c98

As mentioned in the comment:
|bubble_| can be set to NULL in InfoBubbleClosing when we close the bubble
asynchronously. However, that can happen during the Show call above if the
window loses activation while we are getting to ready to show the bubble,
so we must check to make sure we still have a valid bubble before
proceeding.


BUG=59524
TEST=I tried creating a UI test for this, but wasn't able to reproduce the crash with
a test.

Review URL: http://codereview.chromium.org/6145002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
CID=14387

Review URL: http://codereview.chromium.org/6171004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71027 0039d316-1c4b-4281-b951-d872f2087c98

cleanup: Use the new libcros API StopInputMethodProcess() to terminate ibus-daemon instead of kill()

Using the API should be better then kill() because

o ibus-daemon could be terminated even if the daemon ignores or temporalily masks SIGTERM for some reason.
o libcros could know the connection between the library and the daemon will be terminated shortly, and could avoid using the connection after the API call.

This CL depends on http://codereview.chromium.org/6101006/.

BUG=chromium-os:9685
TEST=manually

Review URL: http://codereview.chromium.org/6216002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71026 0039d316-1c4b-4281-b951-d872f2087c98

Before the fix, the bubble was shown under the location bar of the
main browser window, rather than the location bar of the panel.

The #ifdef'ed code was originally added in
http://src.chromium.org/viewvc/chrome?view=rev&revision=46627
to fix crosbug.com/2783, but the code is no longer necessary:

1. We no longer have an issue that causes the site info popup to be shown full screen. In fact, the site info is now shown as a bubble.
2. We no longer show the location bar for the content browser (Ctrl-O)

BUG=chromium-os:9022
TEST=confirmed that the location is fixed on the netbook.

Review URL: http://codereview.chromium.org/6168001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=plugin_group_unittest.cc,plugin_lib_unittest.cc 
TBR=bauerb@chromium.org

Review URL: http://codereview.chromium.org/6205004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71024 0039d316-1c4b-4281-b951-d872f2087c98