BUG=10476
TEST=NONE
TBR=dglazkov
Review URL: http://codereview.chromium.org/239005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27141 0039d316-1c4b-4281-b951-d872f2087c98

CID=1640
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/225020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27140 0039d316-1c4b-4281-b951-d872f2087c98

Match the new interfaces used for StorageNamespace in WebKit.

TBR=dglazkov
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/219038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27139 0039d316-1c4b-4281-b951-d872f2087c98

Simplify life for people trying to pick a "readable" foreground color by not requiring them to provide two choices.  This also speeds the call up a tiny bit by not calculating the background luminance twice.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/220029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=14040
TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading.

Review URL: http://codereview.chromium.org/220028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27137 0039d316-1c4b-4281-b951-d872f2087c98

CID=1608
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27136 0039d316-1c4b-4281-b951-d872f2087c98

CID=1602
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27135 0039d316-1c4b-4281-b951-d872f2087c98

CID=1484
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Run a debug copy of Chromium over VNC, should not hit the DCHECK.
Review URL: http://codereview.chromium.org/218024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27133 0039d316-1c4b-4281-b951-d872f2087c98

instead of vista bot which is not stable now.

TBR=dpranke
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/224013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27132 0039d316-1c4b-4281-b951-d872f2087c98

Add about: and chrome:* to history.  Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/193071 ), r=me,brettw.

BUG=2958
TEST=Visit "about:", then hit ctrl-h and make sure it's in your history.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27131 0039d316-1c4b-4281-b951-d872f2087c98

This fixes leaks caused by not calling gtk_widget_destroy on
dialog windows when we exit.

While I'm here, fix a GList leak on Linux toolkit views.

Review URL: http://codereview.chromium.org/223015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27130 0039d316-1c4b-4281-b951-d872f2087c98

This way we get a native VMS listing and not a UNIX emulation mode, which is
slightly different than native UNIX and confuses the parser.

TEST=Covered by net_unittests.
BUG=22193

Review URL: http://codereview.chromium.org/215058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27129 0039d316-1c4b-4281-b951-d872f2087c98

The previous version of the code assumed that \r\n (CRLF) will always be used.

The FTP spec is extremely imprecise about the LISTing format.

TEST=See bug.
BUG=22879

Review URL: http://codereview.chromium.org/238001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/22882
TEST=Type something into the omnibox.  Option-return should open it in a new foreground tab.
TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url.
TEST=Option-leftclick on a link in a webpage should still prompt you to "save as."
Review URL: http://codereview.chromium.org/218032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27127 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
Review URL: http://codereview.chromium.org/239004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27126 0039d316-1c4b-4281-b951-d872f2087c98

Can optionally override default renderer with environment variable. One of:
GYP_DEFINES = "renderer=d3d9"
GYP_DEFINES = "renderer=gl"
GYP_DEFINES = "renderer=cb cb_service=d3d9"
GYP_DEFINES = "renderer=cb cb_service=gl"

Fixed some warnings.

Works on windows with D3D9 but not GL, mac or linux yet.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/208037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27125 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/235010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22947
TEST=none
Review URL: http://codereview.chromium.org/219033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27123 0039d316-1c4b-4281-b951-d872f2087c98

1. Downstreamed building webkit/extension/v8/*.cc files, which were built by upstream webcore by mistake. Now glue will build them.
   I tested that even though webcore still builds them, there are no errors if glue also builds them.
2. Added webkit_chromium_port variable to build/common.gypi which is turned off by default. Currently, nothing uses it but the chrome port will need it.

Review URL: http://codereview.chromium.org/220026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27122 0039d316-1c4b-4281-b951-d872f2087c98

Another draft of the overview, now with figures. Made related changes to the background pages and content scripts pages.

Review URL: http://codereview.chromium.org/225023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27121 0039d316-1c4b-4281-b951-d872f2087c98

CID=1510
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/218036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27120 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27119 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/238003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27118 0039d316-1c4b-4281-b951-d872f2087c98

pthreads in SyncerThread.  The old pthread impl can be used by
specifying --syncer-thread-pthreads for comparison until we
settle fully on the final impl (I have a MessageLoop-based impl
in progress).

The default SyncerThread is as close to the pthreads-impl semantics as
I could get, with one exception: it does not offer a time-out
when calling Stop(), because it greatly simplifies the implementation.
I first implemented it *with* the timeout, and for sake of
experimentation while this is in shuffle I am checking it in
as SyncerThreadTimedStop, available by using --syncer-thread-timed-stop. I'm not sure which we want ultimately, but it's useful to have around when building the MessageLoop based impl.

I had to refactor the interface slightly to allow multiple implementations,
I think it will be quite useful while working on the MessageLoop impl.

Added several tests to SyncerThreadUnittest, which all impls now pass (
just pass the command line flag to try each out).

TEST=SyncerThreadTest, SyncerThreadWithSyncerTest, integration tests

Review URL: http://codereview.chromium.org/214033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22932
TEST=Linux valgrind bots do not fail.
TBR=dank
Review URL: http://codereview.chromium.org/235009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27116 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben
Review URL: http://codereview.chromium.org/231022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98

We don't pass a format string starting with '-' to setproctitle(), but I was looking at doing that and found this small bug.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/218033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27114 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view.

BUG=None
TEST=Run all tests. Make sure focus is stored/restored properly in Chrome.

Review URL: http://codereview.chromium.org/214029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22926
TEST=still builds
Review URL: http://codereview.chromium.org/231020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98

CID=1633
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5490

Review URL: http://codereview.chromium.org/219015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27110 0039d316-1c4b-4281-b951-d872f2087c98

CID=1646
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/231007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27109 0039d316-1c4b-4281-b951-d872f2087c98

CID=1639
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/218011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27108 0039d316-1c4b-4281-b951-d872f2087c98

event_del is now called once if we reuse an event so there's no need to call it multiple times for each failure mode.

Review URL: http://codereview.chromium.org/235007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27107 0039d316-1c4b-4281-b951-d872f2087c98

CID=6204
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/227013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18268
TEST=run the included test under valgrind without the navigation_controller.cc change, then with.  The memcheck condititional jump error shouldn't fire with the fix.

Review URL: http://codereview.chromium.org/220002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/209027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12282
TEST=green layout bots

Review URL: http://codereview.chromium.org/222015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27102 0039d316-1c4b-4281-b951-d872f2087c98

- The order of:

radio_button = new views::RadioButton(..)
layout->AddView(radio_button)
radio_button->SetChecked(true);

Matters, if the last two statements are inverted we crash (??)


BUG=none
TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast


Review URL: http://codereview.chromium.org/225019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27101 0039d316-1c4b-4281-b951-d872f2087c98