- Jul 02, 2010
-
-
nkostylev@google.com authored
BUG= http://crosbug.com/4002 TEST=Manual: execute OOBE, make sure that update is available, wait for update to complete. If update_engine returns successful update code OOBE will proceed. Review URL: http://codereview.chromium.org/2807013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51509 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=47277 TEST=none Review URL: http://codereview.chromium.org/2841035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51508 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Also allow for editing them... The XIB change adds a column at the end of the table with a NSCheckboxCell in it and the title IDS_EXCEPTIONS_OTR_HEADER BUG=44480 TEST=manual Review URL: http://codereview.chromium.org/2858032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51507 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
TBR=pkasting Review URL: http://codereview.chromium.org/2854035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51506 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
and ServerDeletingFolderWeHaveAnOpenEntryIn is failing 100% of the time. BUG=39070, 46621 TEST=Syncer unittest, SyncerThreadTest TBR=skrul Review URL: http://codereview.chromium.org/2873039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51505 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=run_webkit_tests Review URL: http://codereview.chromium.org/2815044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51504 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=45547 TBR=johnnyg Review URL: http://codereview.chromium.org/2834034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51503 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
These iamge were based on existing linux-checkbox-*.png and modified by tkent. BUG=36321 TEST=none Review URL: http://codereview.chromium.org/2883013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51502 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=47277 TEST=none Review URL: http://codereview.chromium.org/2859040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51501 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
The sync integration tests use the methods defined in the ProfileSyncServiceTestHarness class to coordinate various sync related activities carried out by each test case. The sync codebase has ungergone significant change since this class was originally implemented. In this checkin, the class has been refactored to match the sync codebase. The pass rate for integration tests went up from ~20% to 90+% with this checkin. BUG=44957 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2876029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51500 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
BUG=36321,48154 TEST=This is a part of test code. Review URL: http://codereview.chromium.org/2876036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51499 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51495 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=34647 TEST=manual Review URL: http://codereview.chromium.org/2822044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51494 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change just replaces pointers used in remote_unittest with scoped_ptr<> to delete the memory used in the test, and replaces scoped_ptr<> in differ.h with scoped_array<> to avoid mismatched deletes. BUG=46678 TEST=make valgrind bots green. Review URL: http://codereview.chromium.org/2832043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51493 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
synced data types that the user has disabled. Despite my attempt at simplifying the purge code in Directory[BackingStore], I had to go back to my first attempt with DeleteEntries (which was previously reviewed separately), with a few extra gotchas in Directory::PurgeEntriesWithTypeIn. BUG=40252 TEST=CleanupDisabledTypesCommandTest, SyncableDirectoryTest, DirectoryBackingStoreTest Review URL: http://codereview.chromium.org/2865022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51491 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/2867042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51490 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/2819036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51489 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
To avoid the sporadic leaks in unit tests, explicitly trigger a V8 garbage collection during teardown. BUG=48145 Review URL: http://codereview.chromium.org/2833051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51488 0039d316-1c4b-4281-b951-d872f2087c98
-
slightlyoff@chromium.org authored
Previously we didn't pre-read at all if there was any configuration in the ChromeFrame key. This change makes that decision sensitive to the existance of the PreRead value, not just the existance of the ChromeFrame key. TEST=On Vista, create a ChromeFrame pref key, then run: chrome_frame_perftests.exe --gtest_filter=*X.PerfCold BUG=45510 Review URL: http://codereview.chromium.org/2844023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51486 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
Re-apply: http://codereview.chromium.org/2848036 The last commit was messed up. BUG=http://crosbug.com/4449 TEST=See bug report. TBR:satorux@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51485 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
TBR=yurys@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/2852039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51484 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
(Note: This was a TODO for akalin). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2867036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51483 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
BUG=chromium-os:4157 TEST=manually Review URL: http://codereview.chromium.org/2843044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51482 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
Revert 51480 - [Linux]When cancelling a composition, only focus out/in the IM context when it has focus. BUG=http://crosbug.com/4449 TEST=See bug report. Review URL: http://codereview.chromium.org/2856028 TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/2848036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51481 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
BUG=http://crosbug.com/4449 TEST=See bug report. Review URL: http://codereview.chromium.org/2856028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51480 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=48148 TEST=green tree Review URL: http://codereview.chromium.org/2865034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51479 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
BUG=45540 TEST=none Review URL: http://codereview.chromium.org/2824044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51478 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=34647 TEST=sync_listen_notifications Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51330 Review URL: http://codereview.chromium.org/2880008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51477 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
Sorry, this is making the Heapcheck bot unhappy. http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/4501/steps/heapcheck%20test:%20unit/logs/stdio i.e. The 197 largest leaks: Leak of 128 bytes in 1 objects allocated from: @ ed9000 __gnu_cxx::new_allocator::allocate @ ed9027 std::_Vector_base::_M_allocate @ ed932c std::vector::_M_insert_aux @ ed94e4 std::vector::push_back @ ed59b2 HostContentSettingsMap::GetSettingsForOneType @ 11f2edb ContentExceptionsTableModel @ e491e1 ContentExceptionsWindowGtk @ 5fdbb7 ContentExceptionsWindowGtkUnittest::BuildWindow @ 5facf2 ContentExceptionsWindowGtkUnittest_TestComplexRemoval_Test::TestBody @ 15b7dfd testing::Test::Run @ 15bb5f2 testing::internal::TestInfoImpl::Run @ 15bb728 testing::TestCase::Run @ 15bc18a testing::internal::UnitTestImpl::RunAllTests @ 15bc301 testing::UnitTest::Run @ 14b7b33 TestSuite::Run @ 14b627d main @ 2b410ff7e1c4 __libc_start_main Revert 51450 - Reland r51414: "GTK: Fix sorting in content exception window." Don't use scoped_ptr in unit test. Manually delete the dailog (which deletes ContentExceptionsWindowGtk.) First Review URL: http://codereview.chromium.org/2876032 BUG=47841 TEST=ContentExceptionsWindowGtkUnittest.* + see bug. Ran valgrind on several gtk tests including new ones and fixed the memory errors. Review URL: http://codereview.chromium.org/2881009 TBR=erg@google.com Review URL: http://codereview.chromium.org/2876034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51476 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=45765 TEST=manual Review URL: http://codereview.chromium.org/2861040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51475 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
-To the right of the star (inside the URL entry): add 2 pixels. -Between the tabstrip and window controls: add 16 pixels (only when using the custom frame and the window is maximized). BUG=47487 TEST=manual Review URL: http://codereview.chromium.org/2881006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51474 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=48151 TEST=green tree Review URL: http://codereview.chromium.org/2856029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51473 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=47259 TEST=http/tests/local/blob/send-data-blob.html Review URL: http://codereview.chromium.org/2865033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51472 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@chromium.org authored
BUG=41558 TEST=Login ChromeOS with a RTL language, the text in the omnibox should be right aligned. Review URL: http://codereview.chromium.org/2833052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51471 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Linux: Undo a bit of tcmalloc gyp change from r49597. The reverted change puts direct_dependent_settings inside a configuration dictionary, which is invalid. BUG=45067 TEST=GYP_DEFINES='linux_use_tcmalloc=0' gclient runhooks works. Review URL: http://codereview.chromium.org/2819031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51470 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Review URL: http://codereview.chromium.org/2841034 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/2881010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51469 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=html5lib/runner.html Review URL: http://codereview.chromium.org/2804036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51468 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
content scripts. Review URL: http://codereview.chromium.org/2864035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51467 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
turns on the OpenGL ES GLSL -> OpenGL GLSL translator in WebGL. This will be removed in a few weeks it becomes the default but we need it now for testing. TEST=hand tested BUG=none Review URL: http://codereview.chromium.org/2815008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51466 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=48144 TEST=green bots Review URL: http://codereview.chromium.org/2829036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51465 0039d316-1c4b-4281-b951-d872f2087c98
-