- Jun 29, 2010
-
-
jshin@chromium.org authored
For the actual changes, see http://codereview.chromium.org/2843032/show http://codereview.chromium.org/2001011/show BUG=40496,38632 TEST=See TEST fields for the above two CLs. TBR=gwilson Review URL: http://codereview.chromium.org/2866030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51141 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=34647 TEST=none Review URL: http://codereview.chromium.org/2836032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51140 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
I made the parent_ pointer a WeakPtr. It is correct to not free the offscreen texture ID if the parent is destroyed first. It is freed as part of the parent's destruction. TEST=trybot BUG=47594 Review URL: http://codereview.chromium.org/2882004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51139 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
are bad. BUG=44797 TEST=make sure control-alt-b doesn't work. Review URL: http://codereview.chromium.org/2885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51138 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=47809 TEST=notifications on windows Review URL: http://codereview.chromium.org/2861035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51137 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=erikkay BUG=47575 TEST=Greener bots Review URL: http://codereview.chromium.org/2887001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51136 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Adds test coverage for the various update cases to make sure they are all handled correctly. Also fixes a regression during the recent PasswordStore refactoring that caused the Mac implementation to run queries on the wrong thread (found by the new unit tests). BUG=35603 TEST=See bug; other password update cases should continue to work as before. Review URL: http://codereview.chromium.org/2818035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51135 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=thestig BUG=47863 TEST=Greener valgind bots Review URL: http://codereview.chromium.org/2810039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51134 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
TBR=levin BUG=none TEST=none Review URL: http://codereview.chromium.org/2832032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51133 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
BUG=44407 TEST=Perform the steps outlined in the bug and verify that after step #5 the folders are no longer still active. Review URL: http://codereview.chromium.org/2849026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51132 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@google.com authored
Turns out calling Close() from an infobar class to close it is a bad idea as it only removes its associated view so it is not displayed, but the tab contents still belives it is showing. RemoveInfoBar() should be called instead. I made the InfobarContainer methods private and made InfobarContainer a friend to prevent other people from running into the same problem. BUG=47669 TEST=Open a www.google.de In the translate infobar, click Nope. Navigate away from the page, it should not crash. Review URL: http://codereview.chromium.org/2873029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51131 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
chromium-linux-fontconfig-renderstyle.html is failing because of differences in the Freetype library across platforms. Suppress this test until I can spin up a build on a Hardy box to generate a new baseline. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51130 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@chromium.org authored
Tooltip text is changed from email to "<display name> (<domain>)". BUG=cros:2318 TEST=Verify that tooltips are shown only for users with equal display names. Tooltips show display name and domain. Review URL: http://codereview.chromium.org/2877002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51129 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
doesn't appear in latest logs, so no point in keeping the code around. BUG=44642 TEST=none Review URL: http://codereview.chromium.org/2824036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51128 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=sky BUG=47575 TEST=Green dbg-shlib Linux bot Review URL: http://codereview.chromium.org/2827035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51127 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@google.com authored
BUG= http://crosbug.com/323 TEST=none Review URL: http://codereview.chromium.org/2870033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51126 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
BUG=47846 TBR=dglazkov,patrick,huanr Review URL: http://codereview.chromium.org/2847034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51125 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2811023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51124 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=47844 TEST=TSan/Mac should become green TBR=glider Review URL: http://codereview.chromium.org/2799040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51123 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=47843 TBR=glider Review URL: http://codereview.chromium.org/2827034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51122 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
BUG=47839 TBR=patrick,dglazkov Review URL: http://codereview.chromium.org/2855028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51120 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
[Mac] Remove the nacl clobber hook, GYP seems to have all the deps handing setup right for Xcode (when expressed in the .gyp files). So this shouldn't be needed any more. BUG=none TEST=none Review URL: http://codereview.chromium.org/2848030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51119 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider BUG=47836 Review URL: http://codereview.chromium.org/2876015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51118 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
The members added into ViewMsg_Print_Params will be used to tell printers' setting to renderer process. Maybe ViewMsg_Print_Params::printable_size should be printable_area, but I've just added margin_top and margin_left for now because printable_size is used from several code so I wanted to avoid a big change. The members added into ViewHostMsg_DidPrintPage_Params will be used to tell web authors' page setting to browser process. BUG=47277 TEST=none Review URL: http://codereview.chromium.org/2805045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51117 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
TBR=levin BUG=none TEST=none Review URL: http://codereview.chromium.org/2810038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51116 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51112 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
Tracking patch by mavrommatis, original review here: <http://codereview.chromium.org/1991005> Original description follows: (1) Group plugins with the same name together. (2) Show a download link for plugin versions with known security problems in about:plugins. BUG=3910 TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Review URL: http://codereview.chromium.org/2835018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51110 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51109 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
There is a case while SocketStream is connecting, WebSocketJob is closed and SocketStream notifies it is connected. In this case, we should just ignore OnConnected event. BUG=47818 TEST=websocket/tests/url-with-credential.html Review URL: http://codereview.chromium.org/2823034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51108 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2886001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51107 0039d316-1c4b-4281-b951-d872f2087c98
-
fschneider@chromium.org authored
Review URL: http://codereview.chromium.org/2852027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51106 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
TBR=mnaganov@chromium.org TEST=None BUG=None Review URL: http://codereview.chromium.org/2859032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51105 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=47277 TEST=none Review URL: http://codereview.chromium.org/2847025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51104 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/2864027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51103 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@chromium.org authored
to enabling them dynamically - only when the application really needs them. I am working on some test cases for this, and will add them. But wanted to send out the concept for review. In this implementation, I modify the message loop to detect when the application has requested high resolution timers. Note that there are multiple MessageLoops active in a single process. After a period of time, we simply shut it off again. We could have set a timer or kept a count of active timers, or any number of more complex algorithms. But I think this algorithm is very simple and good enough. If an application continues needing high resolution timers for more than 1s, we'll turn the high-resolution timers back on again. One last change - since we've implemented the clamp at 4ms, there isn't a lot of point to our use of 1ms for timeBeginPeriod. I've modified that to 2 (which is half of 4ms, our target minimal interval). BUG=46531 TEST=MessageLoop.HighResolutionTimers Review URL: http://codereview.chromium.org/2822035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51102 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Disabling the ChromeFrame reference build perf memory test as it causes a crash for subsequent test runs. Bug=47812 TBR=amit Review URL: http://codereview.chromium.org/2845030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51101 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
The --app browser launch code path was previously untested, which resulted in us shipping a release where it was broken. BUG=47544 TEST=ui_tests Review URL: http://codereview.chromium.org/2847032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51100 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@google.com authored
NSGraphicsContext flipped. But it is not true for TestShell. This change make the graphics context flipped. Note that this will break - LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html - LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html - LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html because the expectation is wrong. BUG=46989 TEST=LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html,LayoutTests/fast/dom/HTMLMeterElement/meter-element.html Patch written by morrita@g Original code review: http://codereview.chromium.org/2799020/show Review URL: http://codereview.chromium.org/2824038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51096 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Attempt to fix ChromeFrame perf test failures on the experimental builder. The test fails because of a crash while running one of the chrome frame creation tests. This test causes a crash on the builder and it appears to occur because of multiple chrome frame dlls being loaded in the process. One from the regular release\servers folder and the other one from the reference build. Attempted fix is to add a sleep after the call to CoFreeUnusedLibraries to allow the currently loaded chrome frame binary to unload. TBR=amit Review URL: http://codereview.chromium.org/2840024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51095 0039d316-1c4b-4281-b951-d872f2087c98
-
mdm@chromium.org authored
Linux: delete the unencrypted login database file after a successful password store migration, since otherwise fragments of password data may be left in it. BUG=25404 TEST=the "Login Data" file should get deleted and recreated from scratch after migration Review URL: http://codereview.chromium.org/2866023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51094 0039d316-1c4b-4281-b951-d872f2087c98
-