- Mar 26, 2010
-
-
sky@chromium.org authored
after landing. BUG=none TEST=none TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/1394006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42772 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
version_build_patch is built as BUILD.PATCH and then used to set DYLIB_CURRENT_VERSION and DYLIB_COMPATIBILITY_VERSION on Mac OS X. These VERSION strings have the format X.Y.Z, where X cannot exceed 65535 and Y and Z cannot exceed 255 (see the ld man page). In order to allow PATCH to exceed 255, change version_build_patch to BUILD.PATCH/256.PATCH%256. BUG=39244 TEST=Set PATCH > 255 in chrome/VERSION, rebuild, and use otool -L to confirm version Patch by Jay Soffian <jaysoffian@gmail.com> Review URL: http://codereview.chromium.org/1322002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42771 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
identical login prompts to dismiss themselves. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/1039004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42770 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
- Move DownloadManager's unique path helpers into download utils; - Use those functions to make shortcut file name unqiue. BUG=642 TEST=Verify fixes for issue 642. Review URL: http://codereview.chromium.org/1276003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42769 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
xib change: added tag to fields that are used for credit card numbers. BUG=http://crbug.com/38259 TEST=as in bug Review URL: http://codereview.chromium.org/1219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42768 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
- unify timeout handling - remove unneccessary assertions that clutter the code They were mostly there because earlier the automation framework was less reliable. Now the same checks (or equivalent) are always done in the framework itself. TEST=none BUG=none Review URL: http://codereview.chromium.org/1377001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42767 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
already running would end up creating an extra tab. BUG=11594 TEST=open chrome with a single tabbed browser, turn on session restore, navigate to a page with a popup, close the tabbed browser, create a new window ala control-n (or double click on the desktop), and make the restored window doesn't end upw Review URL: http://codereview.chromium.org/1371002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42766 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
Scott's insight in comment 18 on the bug report was correct; fixed by relinquishing control on call to UpdatePageActions, so that we don't try to look at the private variables of a dying this ptr. BUG= 35864 TEST= no crash. Review URL: http://codereview.chromium.org/1397001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42764 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider Review URL: http://codereview.chromium.org/1343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42763 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider Review URL: http://codereview.chromium.org/1359004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42762 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42761 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider Review URL: http://codereview.chromium.org/1408002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42760 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Revert 42757 - Uses GeolocationContentSettingsMap on GeolocationPermissionContext to persist settings. TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1141004 TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/1394005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42759 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
It will work on PIN, not Valgrind, but currently I'm adding it to tools valgrind. We plan to merge tools/valgrind with tools/heapcheck intor tools/memory or something like that - later. BUG=28363,39456 Review URL: http://codereview.chromium.org/1356006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42758 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1141004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42757 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine. Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL. http://imgur.com/tWJhg BUG=11246 TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears. Review URL: http://codereview.chromium.org/1345005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42756 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/1361004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42755 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=39381 TEST=Mac Valgrind isn't red Review URL: http://codereview.chromium.org/1401003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42754 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
BUG=33071 TEST=drags to omnibox in popup should be denied. drags to omnibox in normal window should be allowed and load the url. Review URL: http://codereview.chromium.org/1225007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42753 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=39147 TEST=Existing tests in extensions_service_unittest.cc Review URL: http://codereview.chromium.org/1278003 Patch from Mattias Nissler. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42752 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Review URL: http://codereview.chromium.org/1242008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42751 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
BUG=chromiumos:2036 TEST=Run out/Debug/browser_tests --gtest_filter=LoginManagerViewTest.TestBasic Review URL: http://codereview.chromium.org/1256004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42750 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
Depends on http://codereview.chromium.org/1369002 BUG=11246 TEST=--enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html Review URL: http://codereview.chromium.org/1348002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42749 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
We did the original abuse because we were past the 4.1 string freeze and needed to add new features, but we can fix this for chrome 5. TEST=The labels should be things like "Key:" instead of "Name:" and so on. BUG=34669 Review URL: http://codereview.chromium.org/1317004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42746 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
Allow running tests with enabled but closed Web Inspector. Corresponding WebKit change: https://bugs.webkit.org/show_bug.cgi?id=36610 Review URL: http://codereview.chromium.org/1359001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42745 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42743 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
Suppress large-expressions in chromium tree while landing expectation change upstream. This test is failing on Mac and on Windows in debug mode already with a JS stack overflow exception. It is just at the limit on Linux now so occasionally fails and occasionally passes. Review URL: http://codereview.chromium.org/1366004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42741 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
lleak checker on and off. Review URL: http://codereview.chromium.org/1334002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42740 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/1344002joth@chromium.org authored
Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1369002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42739 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
failure multiple times. BUG=39214 TEST=included new fancy unit test Review URL: http://codereview.chromium.org/1294002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42738 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
I plan to further rearrange the files after landing this CL so that the names make sense again. TEST=browser tests and live sync tests BUG=none Review URL: http://codereview.chromium.org/1310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42737 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
BUG=none TEST=net_unittests passes Review URL: http://codereview.chromium.org/1108002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42736 0039d316-1c4b-4281-b951-d872f2087c98
-
sgjesse@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/1315008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42735 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
BUG=39425,39424,39423 TEST=none TBR=levin Review URL: http://codereview.chromium.org/1360004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42734 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
This will be needed when a .gyp file is added. Also removing an svn:ignore on third_party. TBR=cpu@chromium.org, mal@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42733 0039d316-1c4b-4281-b951-d872f2087c98
-
slightlyoff@chromium.org authored
See: http://codereview.chromium.org/858003 TBR=tommi BUG=22846 TEST=On IE 8, clear the cache entirely, watch GCF launch (via task manager) Review URL: http://codereview.chromium.org/1343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42732 0039d316-1c4b-4281-b951-d872f2087c98
-
denisromanov@chromium.org authored
BUG=37960 TEST=Run unit_tests. Review URL: http://codereview.chromium.org/1216007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42731 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
FormManager::InferLabelForElement to form_field.cc until the FormData/FormFieldValues consolidation is finished. BUG=33031 TEST=none Review URL: http://codereview.chromium.org/1394003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42730 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
bug=none test=none Review URL: http://codereview.chromium.org/1344004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42729 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
bug=none test=none TBR=fbarchard@chromium.org Review URL: http://codereview.chromium.org/1401002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42728 0039d316-1c4b-4281-b951-d872f2087c98
-