- Nov 04, 2009
-
-
thestig@chromium.org authored
Revert 30938 - Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. BUG=20012,20714,23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/262020 Review URL: http://codereview.chromium.org/359001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30939 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. BUG=20012,20714,23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/262020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30938 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
Commented on http://codereview.chromium.org/345025 BUG=none TEST=none Review URL: http://codereview.chromium.org/355022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30937 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
BUG=26324 TEST=none Review URL: http://codereview.chromium.org/342113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30936 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
R=TBR BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30935 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@google.com authored
TBR=yaar TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30933 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
TEST=build bots should start spitting out debug info to stdio BUG=25952 TBR=maruel Review URL: http://codereview.chromium.org/342115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30932 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/312003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30931 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=Open two windows, open a file dialog in one, quit the browser in other. There should not be any GTK assertion errors. Review URL: http://codereview.chromium.org/339096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30930 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
R=ojan@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30929 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
whitelisting of this flag. BUG=none TEST=The following command should not assert: chrome\Debug\servers\chrome_launcher.exe --enable-experimental-extension-apis Review URL: http://codereview.chromium.org/353026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30928 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
BUG=19316 TEST=Install an extension. Text in download UI should mention both themes and extensions, not just extensions. Review URL: http://codereview.chromium.org/351032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30927 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
BUG=none TEST=none R=ojan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30926 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Original review: http://codereview.chromium.org/340057 TBR=mpcomplete@chromium.org BUG=22103 TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the script should show up in the extension management UI. It should also work, though some scripts use Firefox-specific APIs and those won't work in Chromium. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30925 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
(was looking in newest dir before). TEST=none R=ojan@chromium.org BUG=none Review URL: http://codereview.chromium.org/353014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30912 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
(1) Move it into the HttpNetworkSession so that HttpNetworkTransaction can access it. This is in anticipation of switching HTTP/HTTPS connections over to FLIP. (2) Add some more functionality to FlipSessionPool, allowing HttpNetworkTransactions to check for the existence of other, reusable FlipSessions. Review URL: http://codereview.chromium.org/348066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30909 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=20511 TEST=none Review URL: http://codereview.chromium.org/342112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30908 0039d316-1c4b-4281-b951-d872f2087c98
-
oritm@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30907 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This has been bugging me. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30905 0039d316-1c4b-4281-b951-d872f2087c98
-
dkegel@google.com authored
valgrind as valgrind.sh. Add script to locally reproduce the nonleak valgrind errors found recently by the linux valgrind layout bot. Review URL: http://codereview.chromium.org/351017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30904 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
Also removed some of the testing hacks for URL rewriting that are no longer needed. This change removes the 'batching' of frames written to the socket. The reason for doing this is because I'm going to need to start notifying to the upper layer as progress is made on the writes (e.g. upload notifications). When the frames are batched (potentially from different transactions), it becomes very difficult to know when each write completes. I don't think that batching is necessary, as writes will accummulate in the socket buffer, so this should be a better approach. BUG=none TEST=flip_session_unittest.cc Review URL: http://codereview.chromium.org/342088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30898 0039d316-1c4b-4281-b951-d872f2087c98
-
jcampan@chromium.org authored
Some devtool tests hang on Windows, one fails on Linux. I need to investigate more. BUG=None TBR=rafael Review URL: http://codereview.chromium.org/348067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30897 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
Review URL: http://codereview.chromium.org/346043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30896 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
The if was wrong. If the jscompiler exists we DON'T want the non-compiled files. Review URL: http://codereview.chromium.org/342108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30895 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none TBR=rafaelw Review URL: http://codereview.chromium.org/358001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30894 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 03, 2009
-
-
rohitrao@chromium.org authored
[Mac] Enables animations for the infobar. Changes the control flow for infobar opening/closing to match Windows more closely. Nib file changes: - Embedded the InfoBarGradientView inside an AnimatableView. - Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet. - Bound the AnimatableView's delegate_ to the InfoBarController. BUG=http://crbug.com/25599 TEST=Infobars should animate in and out, except for during tab switches. Review URL: http://codereview.chromium.org/354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
the cache. We need to do this else we don't honor page expiration and end up showing stale data for some sites. BUG=21195 TEST=make sure session restore works. Review URL: http://codereview.chromium.org/341043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=none TEST=trybots Review URL: http://codereview.chromium.org/351024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30891 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
BUG= none TEST= none Review URL: http://codereview.chromium.org/342107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30890 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/340080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30889 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Update the images for notification frames, since they had a transparent gap between the balloon and the shelf, and also on the left edge. BUG=26631 TEST=create notifications over a busy desktop background Review URL: http://codereview.chromium.org/351028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30887 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
TBR=phajdan.jr,jam BUG=17806 Review URL: http://codereview.chromium.org/346045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30886 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=26262 Review URL: http://codereview.chromium.org/344044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30884 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=10442 TEST=none TBR=hclam Review URL: http://codereview.chromium.org/357001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30883 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Use ChromeThread::DeleteOnIOThread in a few places where an object must be deleted on a certain thread. BUG=25354 Review URL: http://codereview.chromium.org/342090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30882 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/353015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30881 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers of this set it to true, so just turn it on unconditionally. BUG=none TEST=none Review URL: http://codereview.chromium.org/341087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30880 0039d316-1c4b-4281-b951-d872f2087c98
-