ThreadSanitizer runs on release binaries.

This is a copy of http://codereview.chromium.org/201060
I wasn't a commiter at that time.

Please note that http://codereview.chromium.org/195078 was submitted recently which defines NVALGRIND for non-valgrind Release builds.
Review URL: http://codereview.chromium.org/195091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26576 0039d316-1c4b-4281-b951-d872f2087c98

- use better name for FTP LIST parsing code in about:credits
- don't open a second data socket
- add a comment explaining why we close the data socket at one point

TEST=Covered by net_unittests.
BUG=none

Review URL: http://codereview.chromium.org/207014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26575 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Chrome implementation of worker error reporting to report errors via event listeners, not just via onerror.
Rebaselined worker-script-error test to reflect new test case.
Re-enabled WorkerFastLayoutTests.

BUG=20822
TEST=none (enabling existing tests)

Review URL: http://codereview.chromium.org/207002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=switching tabs via key combos should still work.
Review URL: http://codereview.chromium.org/209031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26573 0039d316-1c4b-4281-b951-d872f2087c98

1. Allow hiding/showing of the legend.
2. Fix number of results input to actually work (i.e. invalidate old data).
3. Making clicking on test links put up a popup with the information
for the test across all builders.
4. Fix blamelists to not have an off-by-one error in the previous revision.
5. Make maxResults work when viewing an individual test across all builders.

Review URL: http://codereview.chromium.org/215019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26572 0039d316-1c4b-4281-b951-d872f2087c98

the new tests pass so remove them from test expectations

TBR=dglazkov
TEST=none
BUG=20509

Review URL: http://codereview.chromium.org/216017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26571 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=22252

Review URL: http://codereview.chromium.org/208024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26570 0039d316-1c4b-4281-b951-d872f2087c98

Changing the comparison form affects the warning messages
generated in various circumstances. See the codereview for
details.

Also, Apple docs claim that !symbol comparisons will not work.

Spotted by Matthew Vosburgh.

Review URL: http://codereview.chromium.org/214012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26569 0039d316-1c4b-4281-b951-d872f2087c98

I just changed the shelf to autosize horizontally and to be anchored at the bottom and the left and right sides in IB (it was anchored to the top left before and had no autoresizing).

BUG=none
TEST=Enable extension shelf in browser_window_controller.mm (turn #if 0 into #if 1), then build & start chromium. Resize the browser window. The shelf should now stay at the bottom of the window and stay sane.

Review URL: http://codereview.chromium.org/208023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/14908
TEST=Findbar should animate open and closed, unless switching tabs.
Review URL: http://codereview.chromium.org/195105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26567 0039d316-1c4b-4281-b951-d872f2087c98

mode.  This will prevent spurious renderer resizes and reduce flicker.

BUG=http://crbug.com/21666
TEST=Layout of www.google.com should not be messed up after exiting fullscreen
mode.
Review URL: http://codereview.chromium.org/210011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26566 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw
TEST=ExtensionAPIClientTest.GetLastFocusedWindow in unit_tests
BUG=22248
Review URL: http://codereview.chromium.org/207029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26565 0039d316-1c4b-4281-b951-d872f2087c98

The previous patch was reverted until buildbot master was restarted.

After the restart, GYP_DEFINES contains "release_valgrind_build=1"
http://build.chromium.org/buildbot/waterfall/builders/Chromium Linux Builder (valgrind)/builds/2/steps/gclient/logs/stdio
Review URL: http://codereview.chromium.org/196140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26564 0039d316-1c4b-4281-b951-d872f2087c98

[Windows] Bookmark-menu button should be themed like any other menu button. 
Command: 
$ chrome --bookmark-menu 

BUG=18954
TEST=open chrome/chromium with --bookmark-menu switch in the command line, apply a theme, see if the bookmark-menu 
is themed? Reset to default theme, see if the bookmark-menu come backs
to default state.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/208017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26563 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/211012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26562 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/216004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26561 0039d316-1c4b-4281-b951-d872f2087c98

Remove the theme popup menu and just have a reset button to match the other platforms.  This avoids us needed extra localization strings, and we'll look to pick up any new UI when it's done for all platforms.
Remove the autoseparating_menu since it is no longer used.

TEST=Prefs just has a reset button and no theme popup list.
BUG=none
Review URL: http://codereview.chromium.org/214011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=17918
TEST=popups get a title, nobody else does. Expose should show title.
Review URL: http://codereview.chromium.org/209020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26559 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/173556

TBR=mpcomplete@chromium.org
Patch from Jerry Tang <tangjie@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26556 0039d316-1c4b-4281-b951-d872f2087c98

permissions array in its manifest.

This was caused an old attempt to display a warning in this
situation, back when we were ambitious.

BUG=22157
TEST=Install extension associated with bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26534

Review URL: http://codereview.chromium.org/213009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26555 0039d316-1c4b-4281-b951-d872f2087c98

WebCore::SecurityOrigin.

This provides us a little wiggle room in the future in
case we ever want to provide more details about a
security origin beyond just its stringified value.
This was done on recommendation from Adam Barth.

R=jorlow
BUG=21967
TEST=none

Review URL: http://codereview.chromium.org/211013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26554 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/213021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26553 0039d316-1c4b-4281-b951-d872f2087c98

can happen if a plugin is reinitialized, in which case the plugin instance is torn down and a new one
is initialized. If the second initialization fails, we have a plugin instance in the renderer which has
a NULL delegate_.

Fix is to add a NULL check for the delegate in the paint function.

Fixes http://code.google.com/p/chromium/issues/detail?id=22196

Bug=22196

Review URL: http://codereview.chromium.org/215018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26552 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/216021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/210014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26550 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

Review URL: http://codereview.chromium.org/214019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26548 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/207028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26547 0039d316-1c4b-4281-b951-d872f2087c98

We get into trouble if FrameLoaderClient::createPlugin returns non-
null if the EMBED element was removed from the DOM during NPP_New.

This CL makes changes to main.cpp to support the layout test, which
corresponds to http://trac.webkit.org/changeset/48361.

R=jam
BUG=21841
TEST=covered by layout test

Review URL: http://codereview.chromium.org/211008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26546 0039d316-1c4b-4281-b951-d872f2087c98

This allows usage of e.g. HeadersIterator without pulling in all of icu.

TEST=no code change.
BUG=none

Review URL: http://codereview.chromium.org/213017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26545 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements GetCurrentCountryID() function for Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/203079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26544 0039d316-1c4b-4281-b951-d872f2087c98

This rolls back 26540, gregoryd's attempt at a nacl landing.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/213019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=gregoryd

Review URL: http://codereview.chromium.org/211021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26542 0039d316-1c4b-4281-b951-d872f2087c98

Build -dbgsym Debian packages. These contain the stripped-out debugging symbols and can be installed on a system to automatically enable symbolic debugging.

Review URL: http://codereview.chromium.org/210018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26541 0039d316-1c4b-4281-b951-d872f2087c98

First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required

TBR=bradnelson

Review URL: http://codereview.chromium.org/207025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98

that has an empty"

TBR=rafaelw@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26538 0039d316-1c4b-4281-b951-d872f2087c98

Check for supported schemes and examine request methods at key points. We support http, https, and file (dbg only) URLs for now.

* Added IsSchemeSupported, IsMethodSupported and IsMethodAndSchemeSupported helpers, and string constants.

* Check for supported schemes and methods during cache selection and during request interception. Must be GET for cache selectino, GET or HEAD for request interception.

* Renamed some data members in WebApplicationCacheHostImpl to more closely match naming elsewhere.

* Added AppCacheHost::Observer to make life easier. (I like the observer model, and even noticed that the chrome code base has a multi-threaded version too (ala Gears)... nice :)

* Switched to using the observer model in AppCacheRequestDispatcher instead of a WeakPtr. One of the observable methods is OnDestructionImminent(host).

* Added gyp dependency on the net library

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/205017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26537 0039d316-1c4b-4281-b951-d872f2087c98

When the download shelf menu option 'Remove' is chosen,
the view is removed and deleted (along with the object
representing the download) so we must not access them
after the removal.

This CL NULLs the download pointer in the menu to
prevent any futher access.

BUG=20810
TEST=Remove an item from the download shelf and Chrome
     should not crash.
Review URL: http://codereview.chromium.org/216018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26536 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/207019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26535 0039d316-1c4b-4281-b951-d872f2087c98

permissions array in its manifest.

This was caused an old attempt to display a warning in this
situation, back when we were ambitious.

BUG=22157
TEST=Install extension associated with bug.

Review URL: http://codereview.chromium.org/213009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none 
TEST=flip_session_unittest.cc flip_network_transaction_unittest.cc flip_framer_test.cc 

Review URL: http://codereview.chromium.org/210016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26533 0039d316-1c4b-4281-b951-d872f2087c98