- Dec 05, 2010
-
-
petermayo@chromium.org authored
directory in the root. TEST=Locally on a bot like machine (no prior fix). Try bots (with chmod /var/run). BUG=none Review URL: http://codereview.chromium.org/5617004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68312 0039d316-1c4b-4281-b951-d872f2087c98
-
mad@google.com authored
As described in more details in the bug description, if we use COM for these and RPC for the other events, then they could arrive out of order. BUG=65316 TEST=Create as many tabs as quickly as possible and watch the logs (sawbuck) for errors. Review URL: http://codereview.chromium.org/5647001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68311 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
For the menus to work correctly, the X messge pump also needs updating to allow nested event dispatching. BUG=None TEST=On a touchui build, non-GTK context menus in web-pages should work correctly. Review URL: http://codereview.chromium.org/5110011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68309 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68303 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 04, 2010
-
-
tfarina@chromium.org authored
- Remove 'Select trusted SSL certificates' text. BUG=63841 TEST=visual Review URL: http://codereview.chromium.org/5573008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68301 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
This CL add a GetInstance() method to singleton classes instead of relying on the callers to use Singleton<T>. In some cases I have used the LazyInstance<T> pattern as that was simpler. This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. I have selected all files under src/app and src/base which use Singleton<T> in this CL. Once this CL goes in I'll work on the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5527004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68300 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG= 65153 TEST=See hard to repro scenario in bug... Review URL: http://codereview.chromium.org/5622001 TBR=mad@google.com Review URL: http://codereview.chromium.org/5595005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68299 0039d316-1c4b-4281-b951-d872f2087c98
-
mad@google.com authored
BUG= 65153 TEST=See hard to repro scenario in bug... Review URL: http://codereview.chromium.org/5622001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68298 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
(relanding for vitalybuka@chromium.org) BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5609005 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/5649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68297 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
Fixed leaking of BrokerRpcClient. (relanding for vitalybuka@chromium.org) BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/5544010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68296 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=65462 TEST=WebResourceServiceTest.UnpackPromoSignal Review URL: http://codereview.chromium.org/5648001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68295 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68293 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5609005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68292 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5606005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68291 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68290 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68285 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=65408 TEST=none Review URL: http://codereview.chromium.org/5544009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68283 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68282 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak BUG=65404 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68281 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=63820 TEST=visual Review URL: http://codereview.chromium.org/5513006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68280 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
This might have helped catch an earlier bug, where we were shelling out to lsb_release on Linux. BUG=21782 Review URL: http://codereview.chromium.org/4149006 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5625005 TBR=victorw@chromium.org Review URL: http://codereview.chromium.org/5588005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68277 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68276 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
This might have helped catch an earlier bug, where we were shelling out to lsb_release on Linux. BUG=21782 Review URL: http://codereview.chromium.org/4149006 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5625005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68270 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Notification UI should not be reset at browser-close, as the notification ui logic will try to close open balloons during shutdown, resulting in a crash later. BUG=65071 TEST=unit tests Review URL: http://codereview.chromium.org/5511002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68269 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=63816 TEST=none Review URL: http://codereview.chromium.org/5255005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68268 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=none (just refactoring) Review URL: http://codereview.chromium.org/5593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68265 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=63852 TEST=none Review URL: http://codereview.chromium.org/5290003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68264 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5364002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68263 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/5560005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68262 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
if multiple BHO's attempted to start the metrics service object from different threads. Fix is to lock access to the Start and Stop methods. Fixes bug http://b/issue?id=3251823 BUG=3251823 TEST=none Review URL: http://codereview.chromium.org/5519007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68261 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This might have helped catch an earlier bug, where we were shelling out to lsb_release on Linux. BUG=21782 Review URL: http://codereview.chromium.org/4149006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68258 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
incognito window's URL bar. BUG=65184 TEST=See bug for repro Review URL: http://codereview.chromium.org/5511007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68256 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
- Fix the spikes on text of certain font by using round line join instead of default mitter join; - Use the same 0.7 black as other icons instead of 1.0 black; BUG=chromium-os:9787 TEST=Verify fix for chromium-os:9787 Review URL: http://codereview.chromium.org/5522007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68255 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Make the AppCacheDispatcherHost be a MessageFilter so that ResourceMessageFilter doesn't have to know about it and vice versa. Review URL: http://codereview.chromium.org/5625003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68254 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68253 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Fix the callers and add base::win in the call sites. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68251 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Text change in r67269 inverted the whitelist checkbox logic. - Add an "inverted_pref" property to PrefCheckBox so that we could map a checkbox to user inverted pref value; - Update user settings UI and messages; BUG=chromium-os:9788 TEST=Verify fix for chromium-os:9788 Review URL: http://codereview.chromium.org/5530005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68249 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5320001 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/5529004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68244 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 03, 2010
-
-
derat@chromium.org authored
I'm checking these in separately from the changes that will start using them so I can send those later changes to the trybots. BUG=chromium-os:8473,chromium-os:4816 TEST=none TBR=glotov Review URL: http://codereview.chromium.org/5597003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68242 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68239 0039d316-1c4b-4281-b951-d872f2087c98
-