- Jan 14, 2011
-
-
dimich@chromium.org authored
The test failed before was fixed. TBR=hayato BUG=none TEST=none Review URL: http://codereview.chromium.org/6258005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71465 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Also moves more common code into InlineEditableItem, and fixes some styling issues with inline-editable lists. BUG=63817 TEST=Startup pages should be editable in DOMUI prefs. Also, the lead selection in an editable list should show top and bottom borders. Review URL: http://codereview.chromium.org/6303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71464 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
(Previously committed r71334, reverted r71400. Added null check pointed out by jam.) Add some tests (for aborting calls). BUG=none TEST=ppapi_tests Review URL: http://codereview.chromium.org/6280005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71463 0039d316-1c4b-4281-b951-d872f2087c98
-
lzheng@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/6151010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71462 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=68267 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6192007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71461 0039d316-1c4b-4281-b951-d872f2087c98
-
cstefansen@google.com authored
This change ensures that the appropriate command line flag (SetCrashReporterCommandLine()) is set for the NaCl process and read by the NaCl main process when it starts. TEST= 0. Ensure that Native Client is DEPS'ed in at revision 4097 or higher 1. From src/ issue ./build/gyp_chromim -f make -dlinux_breakpad=1 2. Build Chromium (debug build) 3. With env. variable CHROME_HEADLESS=1 and NACL_CRASH_TEST=1 run out/Debug/chrome --enable-nacl --enable-crash-reporter 4. Visit a page that attempts to load a NaCl module, e.g., http://naclports.googlecode.com/svn/trunk/src/gallery/index.html 5. Observe that a .dmp file is created in ~/.config/chromium/Crash\ Reports/ BUG= http://code.google.com/p/nativeclient/issues/detail?id=206 Review URL: http://codereview.chromium.org/6193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71459 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
BUG=65189 TEST=TaskManagerBrowserTest.KillBGContents Review URL: http://codereview.chromium.org/6226002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71458 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@google.com authored
Return NULL when GetProfileSyncService() is called without a cros_user argument (if not already initialized) and protect the settings code when sync service is NULL. A side effect of this is that sync will be disabled if chrome is not started from the login screen in ChromeOS (e.g. when debugging), instead of being initialized without a valid backend, so e.g. settings will not have a sync section, and about:sync will show 'sync disabled'. BUG=chromium-os:10777,chromium-os:10893 TEST=Test proxy settings from login screen, sync settings page, and about:sync. Review URL: http://codereview.chromium.org/6260002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71457 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
The sync tests were using verbose logging in the past in order to help debug flaky and failing tests. Now that the tests are mostly green, the verbosity can be dialed down. This patch reduces the verbosity of sync test logging. In addition, a couple of bookmark tests occasionally fail due to a mismatch, and the logs don't make it clear where the test fails. This patch adds more detailed logging during bookmark comparison. TBR=tim@chromium.org BUG=none TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6351001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71456 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Create a gfx/resources dir to hold gfx package resources. - bitmap_brush_image.png used to be the only gfx resource for canvas_direct2d_unittest; - Files prefixed with "linux-" are from webkit/glue/resources. They will be used by NativeThemeLinux as we move webkit RenderTheme parts drawing code into it. The original files will still live for a while after we finish the switch. BUG=chromium-os:9256 TEST=none. No behavior change. Review URL: http://codereview.chromium.org/6362002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71455 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
BUG=chromium-os:6788 TEST=none Review URL: http://codereview.chromium.org/6300003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71454 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=compile and trybots Review URL: http://codereview.chromium.org/6283005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71453 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
1. Record them prior to the missing-start shortcut. 2. Don't share a recorded boolean with the legacy times. TEST=NONE BUG=NONE Review URL: http://codereview.chromium.org/6276001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71452 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
This is the Chromium side of my WebKit change that fixes some Find issues with text marked as user-select-none. Basically, it should now find matches within such text and therefore we get 1 of 1 instead of 0 of 0 in this test. BUG=68494 TEST=This CL modifies a test to catch this. Review URL: http://codereview.chromium.org/6315005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71451 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
Maintain backwards compatibility with the array of strings. TEST=interactive_ui_tests --gtest_filter=InstantTest.* BUG=None Review URL: http://codereview.chromium.org/6310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71450 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
Remove FLAKY for test PrintPreviewUITest.PrintCommandDisabled (rebooting the builder per thestig's suggestion fixed the flakiness). BUG=69389 TEST=none Review URL: http://codereview.chromium.org/6289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71449 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@chromium.org authored
BUG=68478 TEST=ExtensionServiceTest.ExternalPrefProvider, add an extension key to the windows registry with a typo in the id. Review URL: http://codereview.chromium.org/6053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71448 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
away while waiting for the right notification then we could crash when attempting to send the message. If this is it I'll update the other observers that have a similar problem. BUG=63647 TEST=none Review URL: http://codereview.chromium.org/6291002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71447 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This patch adds a histogram to measure what the delay would have been, had we waited for information from DNS in order to make a certificate verification decision. BUG=none TEST=none http://codereview.chromium.org/6329001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71445 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
sync doesn't run an HttpCache and therefore sync's requests don't pickup an SSLHostInfo. BUG=69522 TEST=don't crash on startup http://codereview.chromium.org/6355003/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71444 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6360001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71443 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@chromium.org authored
BUG=67702 TEST=BrowserTest.OpenAppWindowLikeNtp,BrowserTest.AppIdSwitch,manually open a few apps and see that windows taskbar hilights the right window. Review URL: http://codereview.chromium.org/6086004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71442 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
Add a command line flag to specify the minimum flash version implementing the NPP_ClearSiteData API. BUG=58235 TEST=none Review URL: http://codereview.chromium.org/6242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71441 0039d316-1c4b-4281-b951-d872f2087c98
-
erikwright@chromium.org authored
BUG=None TEST=chrome_frame_unittests --gtest_filter=InfobarsInfobarWindowTest.SlidingTest Review URL: http://codereview.chromium.org/6231006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71440 0039d316-1c4b-4281-b951-d872f2087c98
-
asanka@chromium.org authored
This test runs into intermittent timeouts. Logging is being added to help track down causes. BUG=69266 TEST=none Review URL: http://codereview.chromium.org/6156008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71439 0039d316-1c4b-4281-b951-d872f2087c98
-
hayato@chromium.org authored
BUG=none TEST=none TBR=jschuh Review URL: http://codereview.chromium.org/6351002 TBR=hayato@chromium.org Review URL: http://codereview.chromium.org/6275002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71438 0039d316-1c4b-4281-b951-d872f2087c98
-
hayato@chromium.org authored
BUG=none TEST=none TBR=jschuh Review URL: http://codereview.chromium.org/6351002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71437 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=58235 TEST=none Review URL: http://codereview.chromium.org/6260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71436 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Write chrome://sync-internals DOMUI page which is like about:sync but automatically updates on sync events. Make about:sync{,-internals} aliases for chrome://sync-internals. More diagnostic capabilities will be added to chrome://sync-internals in future CLs. BUG=69500 TEST=Manual Review URL: http://codereview.chromium.org/6299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71435 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
Relevant crash report: http://crash/reportdetail?reportid=c48906f8d604a9d5#crashing_thread BUG=69608 TEST=none Review URL: http://codereview.chromium.org/6333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71434 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/5686002/bulach@chromium.org authored
BUG=none TEST=compiles with use_openssl=1 Review URL: http://codereview.chromium.org/6307001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71433 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6304003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71432 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
-Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change just disables all MultiProcessNotificationTests added by r71418 <http://crrev.com/71418>. It seems this crash happens in the code used by all MultiProcessNotificationTests, i.e. this crash probably happens on all MultiProcessNotificationTests. (I may be wrong.) TBR=dmaclach,thestig,glider BUG=69641 TEST=make the "Chromium Mac (valgrind)" bot green. Review URL: http://codereview.chromium.org/6269005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71428 0039d316-1c4b-4281-b951-d872f2087c98
-
gfeher@chromium.org authored
Move blocking IO of loading the lists of external extensions from the UI thread to the FILE thread. Remove the ExternalPolicyExtensionProvider-specific parts from ExtensionsService. Side-effects: reduce the number of PostTask operations from 9 to 4. Trigger uninstall of external extensions immediately after they are removed from a policy. BUG=65107,63667 TEST=ExtensionManagementTest.ExternalPolicyRefresh for the new functionality, lot of other extension tests are updated Review URL: http://codereview.chromium.org/5742008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71427 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71425 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change just disables MultiProcessNotificationTests added by r71418 <http://crrev.com/71418> because they always crash on the "Chromium Mac (valgrind)" bot. (We also disable other MultiProcessNotificationTests?) TBR=dmaclach,thestig,timurrrr BUG=69641 TEST=make the "Chromium Mac (valgrind)" bot green. Review URL: http://codereview.chromium.org/6321004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71423 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
interface to the automation provider. The testing automation provider was incorrectly assuming that the tab handle would be a parameter in the TabLoaded message. This changed with jam's change to clean up the automation messages used by chrome frame. The other bug was with the AutomationMsg_Hello message which was passing an incorrect protocol version to chrome frame. BUG=none TEST=ChromeFrame net tests should run. TBR=amit Review URL: http://codereview.chromium.org/6324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71422 0039d316-1c4b-4281-b951-d872f2087c98
-
gfeher@chromium.org authored
The new concept is the following: policy_templates.json contains all the data necessary to generate templates: policy names, English captions, descriptions, etc. This gets translated the following GRIT gatherer: policy_json.py. The text of the translated JSON file is then picked up, parsed, and passed to the writers by template_formatter.py. BUG=64898 TEST=PolicyJsonUnittest.* Review URL: http://codereview.chromium.org/6134006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71421 0039d316-1c4b-4281-b951-d872f2087c98
-