- Oct 25, 2024
-
-
Shu Yang authored
onLoadDocumentSuccess / onLoadDocumentError callback may be invoked on PdfViewerFragment restoration. We do not #setDocumentUri and record Android.Pdf.DocumentLoad for these cases. To have comparable records counts, DocumentLoadResult and DocumentLoadTime should only be recorded when there is a paired Android.Pdf.DocumentLoad. (cherry picked from commit c61aa6fa) Low-Coverage-Reason: TRIVIAL_CHANGE Bug: 375041802 Fixed: 375260743 Change-Id: I7c2f6066badb2d992a32ba1d126106c5af8e8e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954033 Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sirisha Kavuluru <skavuluru@google.com> Commit-Queue: Shu Yang <shuyng@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1372451} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958978 Cr-Commit-Position: refs/branch-heads/6778@{#813} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729808185-15ddb1ac9e3d0268d4511f8fb66481b60bc3685b-6a3112bc.profdata to chrome-android64-6778-1729810245-03acd155881ced079dbf89ea53b656c762044416-2d09dc13.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic0285964a57846a2632020c35f2bd92ece3a80bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963404 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#812} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
- Oct 24, 2024
-
-
Ben Mason authored
Change-Id: I5b2bc8d4c7c70b944f975cfdef4bb0f17ce4023e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963081 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#811} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1729799348-21b26356c77908a3a1112dc6d7a946dfb3597976-3dede127.profdata to chrome-mac-arm-6778-1729806342-c02103b7784e8d27ce17c2bba0022d865d2a7c88-d460ff65.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifab0b8b49b95a0d87c5ccfe4e51196fb7ab88b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963462 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#810} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729803601-f0ebc66b42a281799d83131876e853caf00b437d-c0653df0.profdata to chrome-android64-6778-1729808185-15ddb1ac9e3d0268d4511f8fb66481b60bc3685b-6a3112bc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic0a7a5b1a27c5812386633ddb02e07e15e6ea3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963460 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#809} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Arthur Milchior authored
Also, the button remains pressed during the switch. If the switch fail, `[self restartUpdates]` is called. This should have been called previously, because if the list of account or the error state changed during a failed switch, we would not have updated the view to show it. It also ensure that the spinner is removed and the cell gets unselected. Result can be seen on https://drive.google.com/file/d/1P7axaUFm9_C8cKeA7L_uexXPLG0c_CV-/view?usp=drive_link (cherry picked from commit ee804d25) Fixed: 373328642 Change-Id: I6085ba013bef83f17ae611683710bff3121f7027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941623 Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1370760} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961141 Cr-Commit-Position: refs/branch-heads/6778@{#808} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729800903-d4ed5b5aa02f5cdfb38236919b532c9d159e487a-8d413236.profdata to chrome-android64-6778-1729803601-f0ebc66b42a281799d83131876e853caf00b437d-c0653df0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Id3da83754de6e5764389d617c69fde052e5fb3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963382 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#807} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-6778-1729770119-9bb2408421758b751249c6330205b936845d4b9b-17356080.profdata to chrome-win32-6778-1729792496-7a5f0ad0dc4154142525c6af846969c01a932198-7e1b3bdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f3f46d9bad614a8822a2718c986151d9e4e8510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960575 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#806} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-6778-1729770119-25abc6940865ae73da94c28d64f9e8113f68abc7-17356080.profdata to chrome-win64-6778-1729792496-ae0c8dad2a1822fabfe9f807afd82bc4a144807b-7e1b3bdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1bf67a0886d4c1e26b5985e4d05aa4637d36a4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962998 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#805} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Orin Jaworski authored
This CL adds string view trimming logic to the word match boost search so that terms next to various ASCII characters won't be missed. The test data is updated to show an example where a word in quotation marks was missed before but now is found to increase the boost. Queries and passages are also now tokenized and trimmed in exactly the same way, with shared logic and constants. (cherry picked from commit 9565ed34) Bug: 366208372, 361654005 Change-Id: I634a1a19e7a5afedf4378994c5e5eac159c75589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941613 Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1371546} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962853 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#804} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
John Lee authored
This CL updates strings and icons for History Search settings when the experimental settings page refresh flag is on and if answers are available as part of the history search feature. Also, mark a couple existing strings that were updated as translateable="false" so that the merge can be done easily. History search is only available in English. http://screen/5Ni7EiFbtEbTkXf http://screen/6oicnBwi6bCNV5K (cherry picked from commit 6dde0cf7) Fixed: 373434139 Change-Id: Ib8241ad841c7d9badd0a3820407e57f9525c676a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941316 Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1371076} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962383 Cr-Commit-Position: refs/branch-heads/6778@{#803} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Benjamin Williams authored
This CL introduces unit tests to improve code coverage for all new and existing Tips (Magic Stack) related classes. Specifically, it adds tests for the following classes: - TipsModuleView - TipsPasswordsCoordinator - SavePasswordsInstructionalOverlayViewController - SavePasswordsInstructionalViewController - UseAutofillInstructionalOverlayViewController - UseAutofillInstructionalViewController These tests cover the UI configuration, localized strings, and accessibility of these classes, ensuring they function correctly and meet the required standards. (cherry picked from commit 73918861) Change-Id: Ia3640125b11298d23599c8cac09c1514446be41d Fixed: 374768832,375432984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938931 Commit-Queue: Benjamin Williams <bwwilliams@google.com> Auto-Submit: Benjamin Williams <bwwilliams@google.com> Reviewed-by:
Scott Yoder <scottyoder@google.com> Commit-Queue: Scott Yoder <scottyoder@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1371550} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962526 Cr-Commit-Position: refs/branch-heads/6778@{#802} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729793795-9e092d1de06ffe81889dff2cbbaf69eaf09214b9-6842d3d8.profdata to chrome-android64-6778-1729800903-d4ed5b5aa02f5cdfb38236919b532c9d159e487a-8d413236.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibe0b34f43e633184089f49b9439e787372261091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963111 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#801} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Ryan Sultanem authored
This change is similar to https://crrev.com/c/5947126/5 but with some adaptation to the padding and gaps. The previous full merged solution had issues with even longer texts (using flexbox layout). This solution (using grid layout) is more complete and was already used in the move password dialog. Long text solutions (check the last item): - grid: https://screenshot.googleplex.com/BnvpCLLZGqboGgB - flexbox: https://screenshot.googleplex.com/BDLwTj3zCSEEwpQ Initial fix description: Fixes: - subtitle font size and line length. - section padding - long name ellipses (with grid layout solution) New: https://screenshot.googleplex.com/5FvSrdV2PeFQYeb Old: https://screenshot.googleplex.com/A2KCH3Z3KgEyv7W (cherry picked from commit 92ae2b6a) Fixed: 374738209 Change-Id: Ie4071923641552a96063286e3e64c6e8e22de023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5957016 Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Ryan Sultanem <rsult@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1372756} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961864 Auto-Submit: Ryan Sultanem <rsult@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#800} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-6778-1729770119-d924c8b8624d6c7e99235ff89a6932206445b2e3-17356080.profdata to chrome-mac-6778-1729792496-49860f3a38d194cea9e4727df63af1f7bb37c72d-7e1b3bdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98274a944f12495779455f3bcbe96ea82a86f21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963102 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#799} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Benjamin Williams authored
This CL fixes a crash that occurs when toggling Chrome tips on and off in the Magic Stack edit carousel, followed by reloading the homepage. The crash happens because the Tips module is re-added to the Magic Stack without a valid TipsMagicStackMediator. This fix ensures that a valid TipsMagicStackMediator exists before re-adding the Tips module, allowing the module to be correctly constructed, interacted with, and properly managed within the Magic Stack's lifecycle. (cherry picked from commit 2c0a47e8) Fixed: 374313240,375432924 Change-Id: Ic86c73a2a250102b87b4a116414a7b84daee0cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5952624 Commit-Queue: Benjamin Williams <bwwilliams@google.com> Auto-Submit: Benjamin Williams <bwwilliams@google.com> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1371991} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963137 Reviewed-by:
Scott Yoder <scottyoder@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#798} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Thomas Guilbert authored
This CL tentatively fixes an issue where an RTCDataChannel can be closed due to an error, but it crashes if the RTCError doesn't have any error details set. This results in a NOTREACHED being hit when creating the RTCErrorEvent. While this CL fixes the crash, there might be underlying issues that need to be addressed further. (cherry picked from commit 1116bad3) Fixed: 373898146 Change-Id: I06027cc666d709ae3eee72832508bf6283ab3954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937135 Reviewed-by:
Florent Castelli <orphis@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1370595} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961157 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#797} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1729792496-74b0aea507a4dda7ca0a940514997855353b448c-7e1b3bdb.profdata to chrome-mac-arm-6778-1729799348-21b26356c77908a3a1112dc6d7a946dfb3597976-3dede127.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I5461143908e10c2ab60c2ddeb959f38dcd90a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962664 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#796} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729792089-93441a4cb57d28426b950d2f3e169a933cb4f4ba-b13d0f25.profdata to chrome-android64-6778-1729793795-9e092d1de06ffe81889dff2cbbaf69eaf09214b9-6842d3d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: If0d54542e853843842928e8c8269894e7937fb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962988 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#795} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Bryan Nguyen authored
(cherry picked from commit 158c63f1) Bug: 375067118, b:359912571 Change-Id: Ie61f3dca951ed43cc8ddd3e08c194ae379a17b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5952842 Reviewed-by:
Jason Hu <hujasonx@google.com> Commit-Queue: Bryan Nguyen <nguyenbryan@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1372306} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962363 Auto-Submit: Bryan Nguyen <nguyenbryan@google.com> Commit-Queue: Jason Hu <hujasonx@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#794} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-6778-1729770119-b8ff6b2a0122607d90160145115a928733baf7f7-17356080.profdata to chrome-linux-6778-1729792496-88a20c965f8dd3069f31b807267968ccb5f0dc47-7e1b3bdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8f9ccf6d950755b10089eed5b642709923cb64d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963002 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#793} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Orin Jaworski authored
(cherry picked from commit 80b19165) Bug: 374132193 Change-Id: I49965feb89a0601164e01343cda37737f289d1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5940371 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1370286} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962617 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#792} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Baran Erfani authored
(cherry picked from commit 622b01b4) Dump without crashes can be noisy in stable. This flag will enable us to turn it off and on in different versions of Chrome avoiding extra noises while being informed about them happening. Bug: 374365779, 373617224, 375170577 Change-Id: Iee0536c303a571f962b1816667d2fbc67da8ff46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950247 Reviewed-by:
William Liu <liuwilliam@chromium.org> Reviewed-by:
Khushal Sagar <khushalsagar@chromium.org> Commit-Queue: Baran Erfani <baranerf@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1372216} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953097 Cr-Commit-Position: refs/branch-heads/6778@{#791} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Rohit Rao authored
(cherry picked from commit 9b8090c0) Bug: 365549194 Change-Id: I8c3bedcc3dec82b387f31fc67a89bdf6031f6ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953614 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1372093} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961772 Auto-Submit: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#790} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1729784387-8eb1d7720591a524ea1fb318d6d3aa9c079b01ea-95bb3806.profdata to chrome-mac-arm-6778-1729792496-74b0aea507a4dda7ca0a940514997855353b448c-7e1b3bdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I76195474c0bd7767455367097020edd618e75f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962555 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#789} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Justin Cohen authored
This reverts commit 7a0215d1. Reason for revert: Revert for weeks 3 and 4 of beta. See go/partition-alloc-rollout-v4 for details. Original change's description: > ios: Enable PA-E checks for metadata corruption issue investigation > > Bug: 371135823 > Change-Id: Ia2d5ed7a9f466be89af144f5f07239151bf05bb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5925134 > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Auto-Submit: Justin Cohen <justincohen@chromium.org> > Reviewed-by:
Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1367514} (cherry picked from commit 682f0aca) Bug: 371135823 Change-Id: I0f1aa4144a5c945b407579416b5b855a601b0727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962418 Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1373384} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962480 Commit-Queue: Harry Souders <harrysouders@google.com> Reviewed-by:
Harry Souders <harrysouders@google.com> Owners-Override: Harry Souders <harrysouders@google.com> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#788} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Steven Holte authored
(cherry picked from commit ab7d0521) Bug: 372535307 Change-Id: I3c8ff10d896e309c34b997d3d22793ccbd5fbf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950645 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Jun Zou <junzou@chromium.org> Auto-Submit: Steven Holte <holte@chromium.org> Reviewed-by:
Zekun Jiang <zekunjiang@google.com> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1372250} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960798 Commit-Queue: Zekun Jiang <zekunjiang@google.com> Auto-Submit: Zekun Jiang <zekunjiang@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#787} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Ben Mason authored
Change-Id: I7e8f07c59583095df4ee4eef4a22628fae7d45b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961159 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#786} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Khushal Sagar authored
(cherry picked from commit 0e8f81e4) Bug: 375051688, 375238441 Change-Id: Ie684b68feb6ee0dc89cc34d3230bf1089720fc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5955570 Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Auto-Submit: Khushal Sagar <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1372487} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961985 Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by:
William Liu <liuwilliam@chromium.org> Commit-Queue: William Liu <liuwilliam@chromium.org> Cr-Commit-Position: refs/branch-heads/6778@{#785} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729789369-f423b3acca3494dd1252f49f5f3d0437e25e533f-a9ac806d.profdata to chrome-android64-6778-1729792089-93441a4cb57d28426b950d2f3e169a933cb4f4ba-b13d0f25.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Id0256ebfe28834ce9aad2d8c6911a212e04fe4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5963098 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#784} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729786993-08ec7f60a4b9a49fc12d4a570af1a213366b040b-cd03a389.profdata to chrome-android64-6778-1729789369-f423b3acca3494dd1252f49f5f3d0437e25e533f-a9ac806d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I33203e0aeb132f73c9966f1abbcead3a215a5cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962544 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#783} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Xianzhu Wang authored
We failed to update scrolling_contents_cull_rect on the cc scroll tree if a scroll only caused repaint but not a full PaintArtifactCompositor update. The wrong cull rect caused false paint checkerboarding. Now update scrolling_contents_cull_rect on the cc scroll tree during PaintChunksToCcLayer::UpdateLayerProperties() to ensure it is updated for both full and repaint-only updates. (cherry picked from commit 633b1b17) Bug: 373664061 Change-Id: Ibbc153e256f5f6c64c6003ad8e3a820eff60882a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5940118 Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1372212} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962359 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#782} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
David Bienvenu authored
This is a reland of commit 69eb90b5 with a fix for the test failure, which is to move the setting of drag_drop_in_progress_ so that it's set for both the touch and non-touch case. Original change's description: > win: tweaks to touch drag. > > Verify that mouse cursor is in the drag source window. > > Tested manually. > > Low-Coverage-Reason: HARD_TO_TEST > Bug: 40312079, 370856871 > Change-Id: I800e915f566d63354e4e1d1e1f7edd79200f7553 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5927282 > Reviewed-by:
Scott Violet <sky@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1370869} (cherry picked from commit 5398c8d0) Low-Coverage-Reason: HARD_TO_TEST Bug: 40312079, 370856871, 374385590 Change-Id: I387757524615c3b3fe4dd6865825331db5bee44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5943487 Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1371525} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5952499 Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#781} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-6778-1729749474-482894a5b92558a41d315a49d46ca407d83dc5d8-a526e8e9.profdata to chrome-win64-6778-1729770119-25abc6940865ae73da94c28d64f9e8113f68abc7-17356080.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m131.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I95169951ae30050dc574c39b296db71e45921511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962022 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#780} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
PKI Metadata Updates Bot authored
Automatic update for 2024-10-24 UTC Change-Id: I814602b9e533217921446243c0138c7602897386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961742 Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com> Cr-Commit-Position: refs/branch-heads/6778@{#779} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729784387-3f0c2fb931ee79cfb9631e1112234101a25e9f64-95bb3806.profdata to chrome-android64-6778-1729786993-08ec7f60a4b9a49fc12d4a570af1a213366b040b-cd03a389.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: If537dc53d65d178d25881f19ee3ebba173ef88a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960560 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#778} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6778-1729777904-2cd01c1a9119763c5b857b43b09eb3aaa3400060-888c86be.profdata to chrome-mac-arm-6778-1729784387-8eb1d7720591a524ea1fb318d6d3aa9c079b01ea-95bb3806.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Id84792aa04a250d686dfa9d71c2a7f44368eaa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962567 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#777} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Chrome Release Autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-6778-1729782015-1271a7e8a0aa375de43bc8bc84e1df6bca41f55c-e30e5756.profdata to chrome-android64-6778-1729784387-3f0c2fb931ee79cfb9631e1112234101a25e9f64-95bb3806.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: If8a9e86022f83b767ae98ea3bc9b3fd9eea62e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962566 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#776} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Robbie Gibson authored
(cherry picked from commit 0c1e4f88) Bug: 374360783 Change-Id: I86dee74a62b32d934c2e58290c79e3239bfcbf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5943582 Auto-Submit: Robbie Gibson <rkgibson@google.com> Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Gayane Petrosyan <gayane@google.com> Commit-Queue: Gayane Petrosyan <gayane@google.com> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1371519} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958770 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Paul Adedeji <pauladedeji@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#775} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-
Wenyu Fu authored
Make DynamicSafeAreaInsets a web settings, and let the browser decide if the feature should be turned on based on activity configurations. This CL limits the feature to users that are eligible for edge to edge for Chrome on Android. Context: When Chrome draws edge to edge, the tab content area will draw into the bottom notch. This feature is targeting phones with Android R+ and using the gesture navigation mode. (cherry picked from commit 072611d7) Fixed: 375244094 Bug: 374387520 Change-Id: Id53a88e9d6e9c3565fe53aaaebe0f6bb174b2c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5943708 Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charles Hager <clhager@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Theresa Sullivan <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1372441} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5959335 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6778@{#774} Cr-Branched-From: b21671ca-refs/heads/main@{#1368529}
-