- Jan 20, 2011
-
-
agl@chromium.org authored
In order to better log mixed-scripting issues I want to get the URL into Chrome land. This involves a WebKit change ([1]) but, by making this change first, we can decouple of the two changes. [1] https://bugs.webkit.org/show_bug.cgi?id=52384 BUG=none TEST=compile http://codereview.chromium.org/6272003/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71881 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6314010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71880 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71879 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6278009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71878 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 19, 2011
-
-
msw@chromium.org authored
BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6292009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71877 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@google.com authored
When code was moved from browser.cc to browser_navigator.cc, the logic for spawning popup windows was either mis-copied or copied from a different code path; any browser of TYPE_APP (e.g. TYPE_APP_POPUP) should create popup windows of TYPE_APP_POPUP. BUG=chromium-os:11040 TEST=See issue + UI auto tests Review URL: http://codereview.chromium.org/6296011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71876 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
TBR=wtc BUG=67928 TEST=JingleSessionTest.* should pass on XP bot Review URL: http://codereview.chromium.org/6338010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71875 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
TBR=jknotten Review URL: http://codereview.chromium.org/6286004 TBR=dimich@chromium.org Review URL: http://codereview.chromium.org/6372004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71874 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Move SSL resources out of browser\security\resources into browser\resources alongside the rest of the resources (and interstitials). Review URL: http://codereview.chromium.org/6326007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71872 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
TBR=jknotten Review URL: http://codereview.chromium.org/6286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71871 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
- Adds spacing under the header on all subpages (preventing, e.g., lists from abutting the header underline) - Aligns the "Add" button to the left edge of the list above it, and adds space between the two. - Fixes the left-side padding of the new <select> style. BUG=None TEST=Spacing on startup page manager subpage should be better. Review URL: http://codereview.chromium.org/6299011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71869 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6368008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71867 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6359002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71866 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
truth for linux only). Updating FILES to the right name, just for good measure. BUG=None TEST=None Review URL: http://codereview.chromium.org/6354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71865 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=70166 TEST=none Review URL: http://codereview.chromium.org/6287005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71862 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
(This was a TODO for phajdan.jr). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71861 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
This variable was uninitialized and the compiler gave a warning (which got converted into an error because we compile using -Werror) when GetIDAndCountOfFormElement() and its children are inlined. This is because there is a path in that function that returns true but leaves the pair_id variable uninitialized (if s.Step() is 0). Note that I am not a Chromium committer so you will have to commit this. Patch by asharif; http://codereview.chromium.org/6293011/ BUG=70144 TEST=no visible change git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71860 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Manually merge r71828 svn pset svn:eol-style LF \ chrome/browser/automation/testing_automation_provider_gtk.cc \ chrome/browser/speech/speech_input_bubble_gtk.cc BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71859 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=67956 TEST=manual Review URL: http://codereview.chromium.org/6330005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71858 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Delete strings from .grd files that are at least 6 months old and aren't used anywhere. BUG=none TEST=compile Review URL: http://codereview.chromium.org/6260013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71857 0039d316-1c4b-4281-b951-d872f2087c98
-
ace@chromium.org authored
Modifying some downloads hooks to act per-window (so that incognito windows can be correctly targetted) and updating some surrounding test cases. BUG=59259 Review URL: http://codereview.chromium.org/6159001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71856 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Converted passphrase-related notifications to SyncFrontend methods. Removed some unneeded parameters from SyncBackendHost constructor. Moved some function definitions into .cc files. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/6380004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71855 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6254011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71854 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6326006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71853 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71850 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
TEST=ran the conformance tests BUG=none Review URL: http://codereview.chromium.org/6282008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71849 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
Review URL: http://codereview.chromium.org/6242007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71848 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
TBR=scherkus Review URL: http://codereview.chromium.org/6250016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71846 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=70157 TEST=greener tree TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/6351008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71845 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Change all the places where the multi-purpose sync error link is surfaced to call a common routine that either shows a login prompt or shows the passphrase prompt depending on the reason for the error. BUG=68962 TEST=none Review URL: http://codereview.chromium.org/6293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71844 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
BUG=none TEST=search for techcrunch and notice how the preloaded techcrunch.com is used despite the redirect Review URL: http://codereview.chromium.org/6288007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71843 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
The PluginVersionInfo structure just mirrored the Windows file metadata format. Since we want to create a WebPluginInfo anyway, just store a WebPluginInfo as the internal plugin info. TEST=refactoring change, should be covered by existing tests Review URL: http://codereview.chromium.org/6162008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71841 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
BUG=70086 TEST=manual builds in various configurations Review URL: http://codereview.chromium.org/6310013 Build failure on windows trying to include gtk related headers. http://build.chromium.org/p/chromium/builders/Win%20Builder/builds/4080 TBR=anicolao@google.com Review URL: http://codereview.chromium.org/6309008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71840 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
TEST=compiles BUG=none Review URL: http://codereview.chromium.org/6347008 TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/6303011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71839 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
TEST=compiles BUG=none Review URL: http://codereview.chromium.org/6347008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71837 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CSS values provided by Glen Murphy <glen@chromium.org>. BUG=none TEST=none Review URL: http://codereview.chromium.org/6241006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71836 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
- Adds oninput handling to live-save the homepage pref. I had avoided this before because I didn't want to pollute metrics, but this pref doesn't actually have a metric. (Also, if one is added, we can increment it only on the onchange events.) - Does URL fixup for onchange events (not oninput, because it would make typing impossible). BUG=69901,62851 TEST=Change the homepage to a non-canonical URL; it should be updated on blur to a full URL. On ChromeOS, power off the machine after changing the home page, but not blurring the field; it should be saved. Review URL: http://codereview.chromium.org/6332006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71835 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
r536 All surfaces follow D3D Y convention http://codereview.appspot.com/3265041 r535 Build fix needed on certain platforms. Explicitly cast away const. http://codereview.appspot.com/4043042 TEST=try BUG=none Review URL: http://codereview.chromium.org/6254010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71834 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
This is just a move CL, code changes will come in a followup. Moving the files will make the next code review easier. BUG=56415 TEST=None Review URL: http://codereview.chromium.org/6265010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71833 0039d316-1c4b-4281-b951-d872f2087c98
-
anicolao@google.com authored
BUG=70086 TEST=manual builds in various configurations Review URL: http://codereview.chromium.org/6310013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71832 0039d316-1c4b-4281-b951-d872f2087c98
-