BUG=64371
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68760 0039d316-1c4b-4281-b951-d872f2087c98

to the renderer and eventually to the browser. We rely on the HCURSOR getting marshaled
across on windows. However this regressed when code to validate the custom cursor info
was added in the WebCursor deserialization routines.

Fixes bug http://code.google.com/p/chromium/issues/list?cursor=39436

BUG=39436
TEST=Covered by new custom cursor deserialization unit test.

Review URL: http://codereview.chromium.org/5686001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68759 0039d316-1c4b-4281-b951-d872f2087c98

Blair Kutzman (forwarded by PhistucK).

TBR=aa
BUG=none
TEST=link at bottom of analytics tutorial works

Review URL: http://codereview.chromium.org/5713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68756 0039d316-1c4b-4281-b951-d872f2087c98

This still uses the old-style controls for adding and removing entries, but it moves them to the sub-page as an incremental step toward the mocks.

BUG=63817
TEST=The new Manage Startup Pages button in the Basics section should open a subpage where pages can be added and removed.

Review URL: http://codereview.chromium.org/5594006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5588011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68754 0039d316-1c4b-4281-b951-d872f2087c98

Also align favicon and title at their vertical center instead of at the baseline to match the tab look.

BUG=50307
TEST=Open tabpose. Titles shouldn't be blurry.

Review URL: http://codereview.chromium.org/5729001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66072

Review URL: http://codereview.chromium.org/5731001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68752 0039d316-1c4b-4281-b951-d872f2087c98

- Add basic highlighting for search results.
- Allow partial page title search matches.

BUG=59267
TEST=Perform searches in the webui settings window.
Review URL: http://codereview.chromium.org/5562011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68751 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to test experimental library features, and to track a known openssl version.
Also bumps OpenSSL 65717:68738, to fix up the default CA root path in the reference library.

BUG=None
TEST=Still builds & runs!

Review URL: http://codereview.chromium.org/5625012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68749 0039d316-1c4b-4281-b951-d872f2087c98

BUG=make chrome fails with GYP_DEFINES='chromeos=1 library=shared_library'
TEST=see BUG

Review URL: http://codereview.chromium.org/5690001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68748 0039d316-1c4b-4281-b951-d872f2087c98

Will re-enable after a canary goes out with this off.

BUG=65948
TEST=none

Review URL: http://codereview.chromium.org/5592009

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5727001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68747 0039d316-1c4b-4281-b951-d872f2087c98

for in the future.)

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/5574006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66054
TEST=None
TBR=mnissler@chromium.org

Review URL: http://codereview.chromium.org/5725001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68745 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5188003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68744 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65684
TEST=None

Review URL: http://codereview.chromium.org/5638002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68743 0039d316-1c4b-4281-b951-d872f2087c98

and the corresponding end event on destruction.

BUG=64981
TEST=NetLog.ScopedNetLogEventTest

Review URL: http://codereview.chromium.org/5560013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66054
TEST=None
TBR=mnissler@chromium.org

Review URL: http://codereview.chromium.org/5705002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68740 0039d316-1c4b-4281-b951-d872f2087c98

This is a continuation of http://codereview.chromium.org/5519016/, adds a new GetInstance() method for remaining files with singleton classes under chrome/browser.

For types declared and used within the same .cc file, I changed them over to LazyInstance<T>.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5711001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68739 0039d316-1c4b-4281-b951-d872f2087c98

This reworks the PrefStore interface, specifically:

- Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store
- Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations
- Remove special handling of default and user pref store from PrefValueStore and put it into PrefService
- Pref change notification handling now almost exclusively handled through PrefValueStore
- Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list)

BUG=64232
TEST=existing unit tests

Review URL: http://codereview.chromium.org/5646003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98

Create a superclass of FileBasedPolicyProvider that abstracts how a provider can provide policy on the UI thread that is loaded from the FILE thread.

BUG=65094
TEST=AsynchronousPolicyProvider.*

Review URL: http://codereview.chromium.org/5562002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68735 0039d316-1c4b-4281-b951-d872f2087c98

(landing on behalf of kristianm, original patch:
http://codereview.chromium.org/5528003/
)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5678002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68734 0039d316-1c4b-4281-b951-d872f2087c98

Fix broken </ br> tags in extension_api.json

For the zipfile changes:
TBR=kurrik

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5563012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68733 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68730 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68728 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces general support in PluginGroup for multiple version ranges with one minimum secure version each, to be used e.g. for multiple major versions currently supported by their manufacturer.

BUG=65207
TEST=test_shell_tests: PluginGroupTest*

Review URL: http://codereview.chromium.org/5621006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68726 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5697001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68725 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes half of the files under chrome/browser using Singleton<T>.
The rest of the files will be sent in a second CL.

In one case I used a LazyInstance<T> instead of Singleton<T> as that was simpler and necessary since T was a typedef and can't add member functions to it.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5519016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68723 0039d316-1c4b-4281-b951-d872f2087c98

This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it.

This CL includes files under chrome/service and /net with related files elsewhere.

Suggested files to focus for reviewers:
- @sanjeevr for chrome/common and chrome/service
- @ukai for net/websockets
- @agl for rest of net

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5634005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68722 0039d316-1c4b-4281-b951-d872f2087c98

Suppressions for MakeTestUrl are not sufficient. I have a fix that I will land in the morning.

BUG=65993
TEST=None
TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/5695001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68720 0039d316-1c4b-4281-b951-d872f2087c98

- Offers option to run plugin (clickjack-proof).
- Offers option to hide blocking placeholder.
- Retains Inspect Element; it's also useful to see the <embed>.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/5639004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65993
TEST=None
TBR=gavinp@chromium.org

Review URL: http://codereview.chromium.org/5692001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68718 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65993
TEST=None
TBR=gavinp@chromium.org

Review URL: http://codereview.chromium.org/5688001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65940
TEST=None
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/5684001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65988
TEST=None
TBR=sergeyu@chromium.org

Review URL: http://codereview.chromium.org/5683001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68710 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ctguil
Review URL: http://codereview.chromium.org/5682001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65988
TEST=None
TBR=sergeyu@chromium.org

Review URL: http://codereview.chromium.org/5680001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68705 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ctguil
Review URL: http://codereview.chromium.org/5678001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68703 0039d316-1c4b-4281-b951-d872f2087c98

With the recent Singleton refactoring, these tests started exposing some inherent problems with singletons, namely that one test can reference a state set by a different test, which can cause all sorts of flakiness.
Furthermore, some of these tests could reference the registry which may have some user specific settings that could cause the tests to fail

To work around these issues, I'm adding a few utility classes for tests (registry virtualization) and exposing a method to reset singletons before a test is run.

TEST=Fixes flakiness and a few tests that could fail on the waterfall.
BUG=none

Review URL: http://codereview.chromium.org/5564009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Everything builds.

Review URL: http://codereview.chromium.org/5633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68700 0039d316-1c4b-4281-b951-d872f2087c98

Will re-enable after a canary goes out with this off.

BUG=65948
TEST=none

Review URL: http://codereview.chromium.org/5592009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68696 0039d316-1c4b-4281-b951-d872f2087c98