- Dec 14, 2010
-
-
darin@chromium.org authored
multi-DLL build on Windows. TBR=maruel Review URL: http://codereview.chromium.org/5827001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69178 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Have Chrome Frame "support" IE conditional comment tags (of the downlevel-hidden variety) by ignoring them (rather than treating them as comment start/end) when parsing HTML streams. BUG=65627 TEST=chrome_frame_unittests.exe, also syntax like <!--[if IE]><meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><![endif]--> will now activate CF. Offtopic: I wonder what happens if I paste HTML into CL comments. Heh. Review URL: http://codereview.chromium.org/5708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69177 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5712009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69176 0039d316-1c4b-4281-b951-d872f2087c98
-
erikwright@chromium.org authored
Implement a ReadyPromptContent that displays a prompt to accept, temporarily decline, or permanently decline ready mode. Implement a RegistryReadyModeState that manages the state (based on user's decision) in the registry. Interfaces to integrate those with the installer. BUG=None TEST=chrome_frame_unittests --gtest_filter='Ready*' Review URL: http://codereview.chromium.org/5747002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69175 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/5717003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69174 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
Review URL: http://codereview.chromium.org/5786005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69172 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Review URL: http://codereview.chromium.org/5796007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69171 0039d316-1c4b-4281-b951-d872f2087c98
-
motek@chromium.org authored
They are still errors, but DCHECKs make use of automated testing tools against the debug build virtually impossible. This will be followed-up. BUG=66863 BUG=66864 TEST=none Review URL: http://codereview.chromium.org/5751001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69170 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
When the URL ends in /stdio, tack on /text after it. Review URL: http://codereview.chromium.org/5826002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69169 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Revert 69165 - Merge the installer, installer_util and setup_util namespaces into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/5756007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69167 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69165 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
This was a timing issue: we had a pref change observer that was triggering refresh of NTP. Inside this refresh, we checked the promo status. But setting up the pref tree of an extension during installation was also triggering this listener. BUG=64736 TEST=See bug Review URL: http://codereview.chromium.org/5750005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69164 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Followup to http://codereview.chromium.org/5730004/. Need to cover memcheck suppressions too. BUG=61409 TEST=Memory bots. Review URL: http://codereview.chromium.org/5755007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69163 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@google.com authored
TBR=thestig BUG=49279,66853 TEST=none Review URL: http://codereview.chromium.org/5814003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69161 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
FileBasedPolicyLoader PrefValueStorePolicyRefreshTest.TestPolicyRefresh test leak suppression on Mac Expands the suppression to include new signature. BUG=66102 TEST=Memory bots. TBR=danno@chromium.org, mnissler@chromium.org Review URL: http://codereview.chromium.org/5791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69158 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69157 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
Add in support for client-based geolocation in WebKit. Default to disabled (ENABLE_CLIENT_BASED_GEOLOCATION=0) in features_override.gypi until all the WebKit patches (see https://bugs.webkit.org/show_bug.cgi?id=45752) have landed. When we switch over to client-based geolocation, we should remove the old non-client-based geolocation code. BUG=55907 Review URL: http://codereview.chromium.org/5612005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69156 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=66741 TEST=none Review URL: http://codereview.chromium.org/5711004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69155 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
termination has been noticed by the browser before reloading the associated tab. BUG=64708 TEST=none Review URL: http://codereview.chromium.org/5755003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69154 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Change '\w+' to [A-Za-z0-9]{2,63} in email address regexp. This allows hypen to be used in domain name part of an email and sets a 2-63 chars length limit. Use the same email alias pattern for format3 as in format1 and format2. BUG=chromium-os:10250 TEST=Verify fix for chromim-os:10250. Review URL: http://codereview.chromium.org/5812004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69153 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/5744005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69152 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=59131 TEST=none Review URL: http://codereview.chromium.org/5698009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69151 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Followup to http://codereview.chromium.org/5730004/. Need to cover memcheck suppressions too. BUG=61409 TEST=Memory bots. Review URL: http://codereview.chromium.org/5761002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69150 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=pfeldman Review URL: http://codereview.chromium.org/5814002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69149 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=66702 TEST=none Contributed by: asanka@google.com Review URL: http://codereview.chromium.org/5716004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69148 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
And a few places that it touches. BUG=23581 Review URL: http://codereview.chromium.org/5729005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69147 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
See https://bugs.webkit.org/show_bug.cgi?id=49764 for the WebKit side of this change. R=michaeln BUG=none TEST=none Review URL: http://codereview.chromium.org/5139005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69146 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
To print the character code, we should cast the wchar_t to an int. The code currently happens to work because we don't compile with -fshort-wchars, and thus wchar_t is four bytes, which coincides with what %d in the snprintf format string expects. However, it's not portable, and Clang complains about this. BUG=none TEST=browser_tests --gtest_filter=RenderViewTest.OnHandleKeyboardEvent Review URL: http://codereview.chromium.org/5755005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69145 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
BUG=none TEST=focusing a text field shows the placeholder keyboard Review URL: http://codereview.chromium.org/5747001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69142 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG=64321 TEST=adhoc (visit http://www/~eisinger/redirect.html) Review URL: http://codereview.chromium.org/5382006 Patch from James Simonsen <simonjam@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69141 0039d316-1c4b-4281-b951-d872f2087c98
-
dmaclach@chromium.org authored
BUG=37026 TEST=NONE Review URL: http://codereview.chromium.org/5804004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69138 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69137 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
Build broken by gspencer@chromium.org: use of ResultCodes without including chrome/common/result_codes.h. TBR=sky@chromium.org BUG=touchui buildbot failure TEST=none Review URL: http://codereview.chromium.org/5791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69136 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=none TEST=chrome receives touch events after logging in on chromeos Review URL: http://codereview.chromium.org/5726006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69135 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
This fix makes GestureManager conform to the new way of doing Singletons. As per satish@'s email Tue, Dec 14, 2010. "Changes to Singleton<T> pattern usage" This affects the touchui build only. Original CL is http://codereview.chromium.org/3192002 BUG= TEST= Review URL: http://codereview.chromium.org/5696005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69133 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=none TEST=none http://codereview.chromium.org/5803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69132 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=66453 TEST=none Review URL: http://codereview.chromium.org/5762002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69131 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5816001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69130 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
BUG=65298 TEST=none Review URL: http://codereview.chromium.org/5753006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69129 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
- in STL vector<> has no data() member. BUG=None TEST=Builds. base_unittest --gtest_filter=*Sym* Review URL: http://codereview.chromium.org/5705006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69128 0039d316-1c4b-4281-b951-d872f2087c98
-