Skip to content
Snippets Groups Projects
  1. Nov 05, 2009
  2. Nov 04, 2009
  3. Nov 02, 2009
  4. Oct 30, 2009
  5. Oct 22, 2009
  6. Oct 21, 2009
  7. Oct 14, 2009
  8. Oct 10, 2009
    • nsylvain@chromium.org's avatar
      Revert 28558 because this is clearly responsible for · ee0aab23
      nsylvain@chromium.org authored
      breaking the interactive ui tests. It just needs a clobber.
      
      It looks like 2 parts of the code don't agree on the number of
      buttons on the bookmark bar. Maybe because part of the code is
      compiled with CHROME_PERSONALIZATION = 1 while the test is compiled
      with CHROME_PERSONALIZATION = 0. Maybe this new gyp change broke the
      define propagation. This is really easy to replicate, and should also
      be easy to debug.
      
      Original Log:
      Relanding the interactive UI tests GYP factor out, as it turns
      out it is not responsible for breaking the interactive ui tests.
      
      
      Review URL: http://codereview.chromium.org/271046
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28668 0039d316-1c4b-4281-b951-d872f2087c98
      ee0aab23
  9. Oct 09, 2009
  10. Oct 08, 2009
  11. Oct 06, 2009
  12. Oct 05, 2009
  13. Sep 29, 2009
  14. Sep 27, 2009
  15. Sep 25, 2009
  16. Sep 15, 2009
    • yaar@chromium.org's avatar
      Force inclusion of build/common.gypi for all chromium gyp files. · 21642abd
      yaar@chromium.org authored
      Why: Simpler build code. If everybody includes it, it should be included automatically.
      Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
      
      What was done:
      1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
      2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
      3. lots of gyp files were fixed to not refer to build/common.gypi any more.
      4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
      5. build/common.gypi was left empty, because there are some external projects that still refer to it.
      
      Things that are left to do after this patch is in:
      1. The following external files (in other repositories) need to stop include common.gypi
        ./third_party/hunspell/hunspell.gyp
        ./third_party/icu/icu.gyp
        ./v8/tools/gyp/v8.gyp
      2. Once nobody refers to common.gypi anymore, delete common.gypi
         -or-
         Delete gyp_chromium.gypi and move its content back to common.gypi
      
      Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
      
      Review URL: http://codereview.chromium.org/206006
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
      21642abd
    • agl@chromium.org's avatar
      Linux: remove tcmalloc from build/all.gyp · c14c3b6d
      agl@chromium.org authored
      Make sure that there are no references to tcmalloc code in the Linux build.
      
      This is part of an attempt to reland r26264.
      
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26292 0039d316-1c4b-4281-b951-d872f2087c98
      c14c3b6d
  17. Sep 14, 2009
  18. Sep 11, 2009
  19. Sep 09, 2009
    • jshin@chromium.org's avatar
      Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the... · 28062949
      jshin@chromium.org authored
      Replace icu38/icu38.gyp  with icu/icu.gyp in gyp files replace all the references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc
      
      
      In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). 
      
      Also updated is the test results for net_util_unittests.
      
      
      This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). 
      
      BUG=8198
      TEST=On all platforms, all the targets are built fine.
      
      Review URL: http://codereview.chromium.org/172031
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
      28062949
  20. Sep 08, 2009
  21. Aug 26, 2009
  22. Aug 02, 2009
  23. Jul 30, 2009
  24. Jul 27, 2009
  25. Jul 24, 2009
  26. Jul 23, 2009
  27. Jul 22, 2009
    • agl@chromium.org's avatar
      Split the IPC code into ipc/ · 946d1b2c
      agl@chromium.org authored
      This splits the ipc code from the common project.  The 'common' project pulls in
      all of webkit, the v8 bindings, skia, googleurl, and a number of other projects
      which makes it very difficult to deal with especially for external projects
      wanting just to use some of Chromium's infrastructure.  This puts the ipc code
      into its top-level ipc/ directory with a dependency only on base.  The common
      project depends on the new ipc/ipc.gyp:ipc target so that all projects currently
      pulling common in to get the IPC code still have it available.  This mostly
      follows agl's pre-gyp attempt to do this which was r13062.
      
      Known issues:
      - Currently a number of projects depend on chrome/chrome.gyp:common in order to
      use the IPC infrastructure.  Rather than fixing all of these dependencies I have
      made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules
      section of DEPS so that checkdeps.py doesn't complain.  Over time projects that
      need IPC should depend on the IPC project themselves and dependencies on common
      removed, although I don't think many projects that need IPC will be able to get
      away without common currently.
      - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a
      ipc/ should not refer to files in chrome/... now.  I'm not sure how to resolve
      this since it's really an IDE bug
      - the named pipe name (windows+linux) and the logging event name (all) + env
      variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion
      of ipc/ being an independent library.  I think this should be examined in a
      subsequent, much smaller patch.
      - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way
      to create a dependency from ipc/ to chrome/common/chrome_counters. This is the
      same approach that r13062 took.
      
      http://codereview.chromium.org/155905
      
      (Patch from James Robinson)
      
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
      946d1b2c
    • dpranke@google.com's avatar
      revert change 21252, which broke the mac build for some reason · 89858523
      dpranke@google.com authored
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21262 0039d316-1c4b-4281-b951-d872f2087c98
      89858523
    • dpranke@google.com's avatar
      make 'test_shell' target depend on everything needed to pass layout_tests · 31856be7
      dpranke@google.com authored
      This adds project dependencies to test_shell so that all (and only?)
      the targets needed for the layout_tests to run cleanly are built. On most
      platforms this is test_shell, npapi_test_plugin, and test_worker, and on
      the Mac this adds the layout_test_helper binary as well
      
      also, this moves image_diff from chrome/tools/test to tools/
      
      R=mmentovai@google.com, darin@google.com
      BUG=none
      TEST=none
      
      Review URL: http://codereview.chromium.org/149714
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98
      31856be7
  28. Jul 18, 2009
  29. Jul 08, 2009
    • agl@chromium.org's avatar
      Linux: SUID sandbox support · 4378a822
      agl@chromium.org authored
        * Make processes dumpable when they crash.
        * Find crashing processes by searching for a socket inode, rather
          than relying on SCM_CREDENTIALS. The kernel doesn't translate PIDs
          between PID namespaces with SCM_CREDENTIALS, so we can't use the
          PID there.
        * Use a command line flag to the renderer to enable crash dumping.
          Previously it tried to access the user's home directory for this
          information.
        * Search for a sandbox helper binary and, if found, use it.
        * Include the source for a sandbox helper binary. It's currently not
          built by default.
      
      http://codereview.chromium.org/149230
      R=evan,markus
      BUG=8081
      
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20110 0039d316-1c4b-4281-b951-d872f2087c98
      4378a822
  30. Jun 16, 2009
  31. Jun 15, 2009
Loading