BUG=26509
TEST=none

Review URL: http://codereview.chromium.org/340072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31050 0039d316-1c4b-4281-b951-d872f2087c98

Enable the OK button when editing a bookmark even when there is no text, and keep alignment correct in both cases. Also strip out newlines from bookmark titles.

[Patch by feldstein.]

BUG=26353
TEST=Add and remove titles from bookmarks in the bookmark bar and verify that they look correct, and icons are centered when there is no text.

Review URL: http://codereview.chromium.org/353024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31047 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26614
Review URL: http://codereview.chromium.org/360035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31046 0039d316-1c4b-4281-b951-d872f2087c98

on shutdown when extensions were running.

BUG=15708
BUG=26652

Review URL: http://codereview.chromium.org/355032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31045 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 20036
TEST= install glossy blue theme. See curved corner (overlay) in upper left hand corner.
Note that it does not appear in the incognito version of the theme (now it appears in the jarringly wrong color).
Review URL: http://codereview.chromium.org/361018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31043 0039d316-1c4b-4281-b951-d872f2087c98

This is strictly a no-op refactor, it does not change any code (just re-orders it within the file).
This addresses a TODO to tidy the code.

TBR=darin
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/360030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31040 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 26704
TEST= change themes. browser does not crash.
Review URL: http://codereview.chromium.org/366015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31036 0039d316-1c4b-4281-b951-d872f2087c98

TBR=amit

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31035 0039d316-1c4b-4281-b951-d872f2087c98

TCV's size allocate message.  This avoids a spurious size-allocate
being sent to the renderers when creating a new tab.  The extra
size-allocate is called by the build-in GtkFixed's size allocate
method.

Another way to think of this is that we only size our RWH directly
and decouple it's sizing from the GTK+ widget's sizing.

BUG=26495

Review URL: http://codereview.chromium.org/363012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31031 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 26689
TEST= none
Review URL: http://codereview.chromium.org/362012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31030 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw
BUG=None
TEST=This is fixing a test.

Review URL: http://codereview.chromium.org/367006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31029 0039d316-1c4b-4281-b951-d872f2087c98

Also grasp at straws trying to fix a crash bug.

BUG=21201

Review URL: http://codereview.chromium.org/345058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31024 0039d316-1c4b-4281-b951-d872f2087c98

Restoring r29827. The skia file is new to this attempt, and may be what was causing a unit test to crash last time.

Refactor security-icon code to a more general form, also more consistent with
the Windows implementation, in preparation for implementing page actions.

Review URL: http://codereview.chromium.org/264037

BUG=14899, 22922, 12281
TEST=unit tests included
Review URL: http://codereview.chromium.org/348069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31023 0039d316-1c4b-4281-b951-d872f2087c98

ones more prominently.

Also added an unused string for 'getting more extensions',
so we can translate.

Converted 'Developer Tools' references to 'Developer Mode',
to avoid confusion with Chrome's developer tools.

TEST=Load extension b_foo through --load-extension.
Open chrome://extensions/ and notice extension b_foo is
on top, even though another extension a_foo normally would
appear at the top due to alphabetical sorting. Then disable
an extension and notice it should turn all gray. Enable,
and it should no longer be gray.
BUG=http://crbug.com/26699, http://crbug.com/25850

Review URL: http://codereview.chromium.org/365008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31021 0039d316-1c4b-4281-b951-d872f2087c98

- Baselines match between labels and top control for:
  - default browser (basics)
  - browsing data (personal stuff)
  - themes (personal stuff)
- The list for startup urls and the textbox for homepage are both indented to the start of the text on the radio they go with.
- The gap above the list for startup urls and the textbox for homepage and their radio buttons is the same.

BUG=26703
TEST=Baseline match, gap between radio and field/list is the same, field/list are left aligned
Review URL: http://codereview.chromium.org/362011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23258
TEST=We get approximate memory usage in about:memory for sandboxed renderers.
Review URL: http://codereview.chromium.org/365007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26660
TEST=no visible difference. Make sure volume still works.  Code size should go down marginally.

Review URL: http://codereview.chromium.org/357004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31018 0039d316-1c4b-4281-b951-d872f2087c98

Yet I cannot delete AutomationProxyForExternalTab because it is used by extension_uitest.cc.
Enable some tests meanwhile - now they should be stable enough.

BUG=18797,24664
TEST=ui_tests ok
Review URL: http://codereview.chromium.org/339009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31016 0039d316-1c4b-4281-b951-d872f2087c98

Continue to remove CHROME_FRAME_BUILD define from code that goes into chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line.

Also,

* At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it).
* The installer now propagates the presence of --verbose-logging to uninstalls.
* The chrome_launcher now allows the --chrome-frame switch through to chrome.
* The installer now accepts a --chrome-frame switch.
* Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer.


BUG=26012, 26603
TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly.


Review URL: http://codereview.chromium.org/345021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20793
TBR=dglazkov
Review URL: http://codereview.chromium.org/361013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31013 0039d316-1c4b-4281-b951-d872f2087c98

It wasn't wired up to any errors yet, it wasn't hidden by default, it created an unnecessary horizontal space, and it would DCHECK (or worse) when that space was clicked.

BUG=26595
TEST=Displayed the bookmarks bar, verified that the gap to the left of "Other Bookmarks" went away and that it was no longer clickable.
R=estade

Review URL: http://codereview.chromium.org/360024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31011 0039d316-1c4b-4281-b951-d872f2087c98

Stop each ChromeThread before nulling out the entry in chrome_threads_.  This allows DCHECKs that the code is running on the correct thread to succeed.

BUG=26714
Review URL: http://codereview.chromium.org/363010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26265,26268

Review URL: http://codereview.chromium.org/360023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31009 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26360
TEST=cancel a notification

Review URL: http://codereview.chromium.org/363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31004 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r30843.

This broke the findbar/download shelf animation optimization.  I
originally was doing this as part of fixing issue 26495, but I
found a different way.

TBR=estade

Review URL: http://codereview.chromium.org/366009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31003 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure Linux packages are rebuilt if any of the packaging scripts or
config files change.

Review URL: http://codereview.chromium.org/360017


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31001 0039d316-1c4b-4281-b951-d872f2087c98

Clean up bookmark_editor_controller to so that is closes consistently as both a standard window and as a sheet.
Get rid of an unneeded member variable.
Clean up unittest to use new CocoaTest, and to clean up its windows properly.

BUG=none
TEST=Open the bookmark editing window and edit bookmarks. Make sure to test with both OK and Cancel.

Review URL: http://codereview.chromium.org/361011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31000 0039d316-1c4b-4281-b951-d872f2087c98

browser window.

BUG=18548
TEST=Open window with Legal Pad theme from the them gallery and make sure the red lines line up.

Review URL: http://codereview.chromium.org/351010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30998 0039d316-1c4b-4281-b951-d872f2087c98

the icon. Otherwise, the badge looks off center.

BUG=26400
TEST=I guess this is just a matter of eyeballing
it. The badge should not look off-center when
compared to the icon, even with different sized
icons  and different width of text in the badge.

Review URL: http://codereview.chromium.org/362007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30994 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30989 0039d316-1c4b-4281-b951-d872f2087c98

Add 'meta charset=UTF-8' to the html of an iframe interstitial  to prevent non-ASCII characters from being garbled. 

BUG=26030
TEST=1. Launch Chrome with --lang=pt-BR (ja or most languages other than English should work) on Windows or 'LANGUAGE=pt_BR chrome' on Linux.
2. Go to http://www.notalegal.df.gov.br/area=1248.htm and the iframe interstitial doesn't have a garbled character.
Review URL: http://codereview.chromium.org/348060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30988 0039d316-1c4b-4281-b951-d872f2087c98

Removes accessibility-related WebCore dependencies from glue.

R=darin
TEST=none
BUG=24616

Review URL: http://codereview.chromium.org/348063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26715
TBR=beng


Review URL: http://codereview.chromium.org/365006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22199
TEST=dragging to scroll in web pages should again work.
Review URL: http://codereview.chromium.org/367001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30983 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/346044

BUG=26599
TEST=extension_popup_apitest.cc 


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30982 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=26692

Review URL: http://codereview.chromium.org/363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30981 0039d316-1c4b-4281-b951-d872f2087c98

Implement FormStructure and an initial method, EncodeUploadRequest.  This also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/355003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30980 0039d316-1c4b-4281-b951-d872f2087c98

Also clean up some leaking tree paths.

BUG=22961
TEST=after sorting, task manager still works normally

Review URL: http://codereview.chromium.org/362001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30976 0039d316-1c4b-4281-b951-d872f2087c98

is also present, delete the user ticket and abort the update.

BUG=26702
TEST=keystone_install_test.sh
Review URL: http://codereview.chromium.org/365004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=insect
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/360014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30974 0039d316-1c4b-4281-b951-d872f2087c98