- Nov 06, 2024
-
-
Awad Osman authored
Our UX and PM want the password leak toggle to be the first option under the advanced section on the chrome://settings/security page. Screenshot(Before):https://crbug.com/370770920#comment3 Screenshot(After):https://crbug.com/370770920#comment9 Bug: 370770920 Change-Id: Id5dab3089c2db2fe8a1159fb971875f8e91ef27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998450 Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Awad Osman <awado@google.com> Cr-Commit-Position: refs/heads/main@{#1378950}
-
Morten Stenshorne authored
Enabled by default since M106. Bug: 356235206 Change-Id: Ie26282921d5b5e62e47851dc24e4f80ea41d0707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999732 Reviewed-by:
Ryan Tarpine <rtarpine@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378949}
-
Ravjit authored
Bug: 377543821 Change-Id: I590e3853dd02c365472c6bbd54c141e3a1769268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999256 Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Auto-Submit: Ravjit Uppal <ravjit@chromium.org> Owners-Override: Ravjit Uppal <ravjit@google.com> Cr-Commit-Position: refs/heads/main@{#1378948}
-
Mariam Ali authored
Due to slow model build, sometimes JNI framework hangs/crashes due to attempting to destroy a model object as we're creating a new one. This CL works around this issue by keeping a reference of the old model and posting the destroy task so it doesn't conflict with the new model creation callback. Fixed: 370355422 Bug: b:254415177 Change-Id: I925ed5e649f02a894fefcccc4c4d6ba72e6d770e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998871 Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Auto-Submit: Mariam Ali <alimariam@google.com> Commit-Queue: Mariam Ali <alimariam@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378947}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a93080b8dd0..2cc99f154455 2024-11-06 jleconte@webrtc.org Disable use_fuzztest_wrapper for bots not using libfuzzer. 2024-11-05 jianlin.qiu@intel.com Cleanup H.265 TODOs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:41480904 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I89db0cdc757dd3d69d5ec3538c255b32934671eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000012 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378946}
-
chromium-autoroll authored
https://boringssl.googlesource.com/boringssl.git/+log/ddc0647304a8..abed22499d36 2024-11-06 filippo@golang.org runner: don't assume BlockMod implements SetIV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/boringssl-chromium Please CC boringssl-cabal@google.com,boringssl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in BoringSSL: https://crbug.com/boringssl/new To file a bug in Chromium: https://crbug.com/new To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: boringssl-cabal@google.com Change-Id: I7db7b350492025ba6c785fbbffb8c29483b0db74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000091 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378945}
-
chromium-autoroll authored
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1730872697-2417395c72f23a0f50d3cc7086ebf99324de4fc9-5f89eabf.profdata to chrome-android32-main-1730894247-c100c36d794188e554f0ea110fcc02b6f9ee831c-7d07d388.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I62b1f45a30e4d72010083da416ca1c4798937ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000034 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378944}
-
Yoav Weiss authored
Import maps currently have to load before any ES module and there can only be a single import map per document. That makes them fragile and potentially slow to use in real-life scenarios: Any module that loads before them breaks the entire app, and in apps with many modules the become a large blocking resource, as the entire map for all possible modules needs to load first. This implements https://github.com/whatwg/html/pull/10528 to solve that. Change-Id: I54e1b9cdfe989d61c85d73a5fd384f860273ad9a Bug: 358379381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776262 Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378943}
-
Eitan Goldberger authored
The approved API proposal: https://docs.google.com/document/d/16C6iMB9lsnAZDKc6Ea2Ep-jZj23SOUgI5n62W-FI9gk/ Here is the relevant design doc: go/read-aloud-eng-design-phase3 Bug: 360395015 Change-Id: I44bba75c5633a8a3e5a2459278707c168ad3e530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954665 Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Eitan Goldberger <eitang@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378942}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/b810c7c47e85..22a263775eac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC bwwilliams@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ie665bbfafd1a0b7dcebbf6aca4f15a7cbc0788e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998286 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378941}
-
Antonio Gomes authored
... and related logic now that lacros project is terminated. In summary, the CL removes lacros-specific logic in the touched files, as well as an unneeded include. R=hidehiko@chromium.org, neis@chromium.org Bug: 377475532, 373971535 Change-Id: I53d089f6e4946744eb0c4a6d5d1eb1db3f7c5013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993442 Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378940}
-
Christoph Schwering authored
StringToFormControlTypeDiscouraged() hits a NOTREACHED() if the string is not a FormControlType. This CL handles invalid form control types on iOS gracefully. This is just a precaution -- the JavaScript code currently guarantees that the form control type string is valid. Bug: 375235165 Change-Id: I9b612e7a52a25f7bbb2e2c19547fec220d99dc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979823 Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378939}
-
Norge Vizcay authored
Bug: 322286677 Change-Id: I9ef2efdd59607ada300b77fc712a915c1830b1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991449 Reviewed-by:
Jan Keitel <jkeitel@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/main@{#1378938}
-
Theo Cristea authored
Change-Id: Iff924c4e31b8554dce92ef78c356736758722a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5982924 Reviewed-by:
Bruno Braga <brunobraga@google.com> Commit-Queue: Theo Cristea <theocristea@google.com> Reviewed-by:
Jan Keitel <jkeitel@google.com> Cr-Commit-Position: refs/heads/main@{#1378937}
-
Ewann Pelle authored
Adds an util that contains alerts for shareKit flows. Bug: 375587446 Change-Id: I64b17a0fdf42c9d7e759ca60c4cad58fbdd210ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993850 Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378936}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1730887133-a8f419f2d619915d5a3a412a0f72b28721e595c3-c866ebe2.profdata to chrome-mac-arm-main-1730894247-2ced54210c1fb5bc238a4b10eac367c5cc295e66-7d07d388.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I822ed58b91a52fd5b58426ae988b75c6a58c3e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000171 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378935}
-
Maksim Sisov authored
No functional changes are done. Bug: 373972275, 373971535, 374073840 Change-Id: I60925a29fa4ca0de965ffed92ed061e29ce74445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993752 Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#1378934}
-
Maksim Sisov authored
No functional changes are done. 1) Renamed IS_CHROMEOS_ASH to IS_CHROMEOS (also in gn files) 3) Removed chromeos_buildflags.h includes and deps 2) General clean ups. Bug: 373972275, 377330004 Change-Id: I83e6fd58ce42f6dd839f415a293b0533ef34148e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993411 Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#1378933}
-
Anthi Orfanou authored
This reverts commit c65f29cb. Reason for revert: A test condition (re-authentication completed) was flaky or completely failing in some builders. This is now removed and it can be added back only when we have a suitable way to wait for the interstitial to be replaced first. Original change's description: > Revert "Add UMA metrics for Youtube subframe re-auth interstitial" > > This reverts commit 0966ddf5. > > Reason for revert: breaks CI bot "Linux Tests (Wayland)" > > Original change's description: > > Add UMA metrics for Youtube subframe re-auth interstitial > > > > NO_IFTTT=Fixing a typo in FamilyLinkUserReauthenticationInterstitialState, no functional change. > > > > Bug: 374254038 > > Change-Id: Id75da9967f760e27c586ce0eef53a2ada13082d8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966313 > > Reviewed-by:
James Lee <ljjlee@google.com> > > Commit-Queue: Anthi Orfanou <anthie@google.com> > > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > > Reviewed-by:
Duong Dac <ddac@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1378277} > > Bug: 374254038 > Change-Id: I490d92fca601d0ddf27a3b54d80a826fb7d17739 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994310 > Owners-Override: Titouan Rigoudy <titouan@chromium.org> > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1378353} Bug: 374254038 Change-Id: Ia5f554edf7f22e8acc16460b08b95e2a8ca655ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994213 Reviewed-by:
James Lee <ljjlee@google.com> Commit-Queue: Anthi Orfanou <anthie@google.com> Cr-Commit-Position: refs/heads/main@{#1378932}
-
Antonio Gomes authored
Lacros is obsolete and to be removed from the Chromium code base. R=hidehiko@chromium.org, neis@chromium.org Bug: 377410087, 373971535 Change-Id: I0fa2b469100e8da008cb93842e4db61ee17aaf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992806 Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#1378931}
-
Maksim Sisov authored
No functional changes are done. 1) Removed code under IS_CHROMEOS_LACROS 2) Renamed IS_CHROMEOS_ASH to IS_CHROMEOS 3) Removed chromeos_buildflags.h includes and deps 4) General clean ups. Bug: 373972275, 373971535, 377410075 Change-Id: I8ab093d228304ae60afe6ef1ee73a639630919a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993732 Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#1378930}
-
Maksim Sisov authored
No functional changes are done. 1) Merged is_chromeos and is_chromeos_ash condition sections in .gn file 2) General clean ups. Bug: 373972275, 377330005 Change-Id: Icd8b83161a0668d21afaf26daf9e02036c449783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993451 Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#1378929}
-
Ivan Šandrk authored
In order to prevent students from getting out of the restricted mode, prevent tampering with the system time. Remember the highest seen system time and write some logic around it (since the system time can be changed by removing the CMOS battery). Bug: b:345186543 Change-Id: I9d2dbe4769d5340b1421f5a2cb8663c8d083a34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5971575 Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378928}
-
Maksim Sisov authored
No functional changes are done. 1) Removed code under IS_CHROMEOS_LACROS 2) Renamed IS_CHROMEOS_ASH to IS_CHROMEOS 3) Removed chromeos_buildflags.h includes and deps 4) General clean ups. Bug: 373972275, 373971535, 377330006 Change-Id: I3279245d58311f30148999df2cffaad2244825e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993510 Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378927}
-
Kerker Yang authored
BUG=none TEST=none Change-Id: I9be8a750df9023a266eebb1a0604135c6dcb58d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5997851 Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Byron Lee <byronlee@chromium.org> Commit-Queue: Kerker Yang <kerker@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378926}
-
Simon Hangl authored
Change-Id: I58328008b95ccceb778b9e5c5dd12ff3161f3513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999530 Commit-Queue: Simon Hangl <simonha@google.com> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378925}
-
Keita Suzuki authored
This CL adds new metrics to measure SessionCreationInitiator for Quic and Spdy, for session to GWS. Since we want to record the creation initiator for each session with at least one request (i.e. a session that has been used at least once in order to avoid recording preconnects which the connection was established was never used), we conduct the following: - Check how many streams we created for the session (preconnects do not request a stream) - If we created more than one stream, we record the metric when destructing the session (following other metrics). Bug: 372873699 Change-Id: I98e57fcbbd96b06b19e23d742b67a3dd192be718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992511 Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378924}
-
Christoph Schwering authored
The feature was renamed in crrev.com/c/5979941. Bug: 375569869 Change-Id: Ia5d5ae3db84e41078ea4e5570d6ddd0b8025063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999350 Reviewed-by:
Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/main@{#1378923}
-
Maksim Sisov authored
No functional changes are done. 1) Removed chromeos_buildflags.h includes and deps 2) General clean ups (eg OWNERS file cleaned up from the lacros ownership as there are no files left) Bug: 373972275, 377324997 Change-Id: I18d02c6044b1a2aaafc2cd7554c964d7db1a110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993412 Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378922}
-
Mohannad Farrag authored
The current implementation expects that `--bindgen-flags` will always exist if there's one or more flag. However, that's not the case in reality because `--bindgen-flags` is always there regardless of whether there's flags or not. See https://source.chromium.org/chromium/chromium/src/+/main:build/rust/rust_bindgen_generator.gni;l=179-187 Bug: 373864033 Change-Id: I5816d06b7be688946dc5d0186a0852aa9588093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994214 Reviewed-by:
Etienne Dechamps <edechamps@google.com> Commit-Queue: Etienne Dechamps <edechamps@google.com> Auto-Submit: Mohannad Farrag <aymanm@google.com> Cr-Commit-Position: refs/heads/main@{#1378921}
-
David Bertoni authored
There is a lot of code which conflates !IS_ANDROID with ENABLE_EXTENSIONS. This makes it difficult to control building the Extensions system. This is one of a series of CLs to fix these issues related to the safeBrowsingPrivate API and its implementation. Bug: 376722712 Change-Id: Iba00dcf76fa41e146dea91b91554342fb64df0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981231 Auto-Submit: David Bertoni <dbertoni@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378920}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/0df66cd0cc85..dbc0c5f711d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com,samarchehade@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: samarchehade@google.com No-Try: true Change-Id: I7764fff87dc539ba48f7637d2c70ebbd433e4a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998439 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378919}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/browser/platform_experience/win.git/+log/7c60cfc9b960..94f84a711f2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/platform-experience-win-chromium Please CC chrome-platform-experience-win@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-rel-ready Bug: None Tbr: chrome-platform-experience-win@google.com Change-Id: Id06624449609a778dc76194a2a24e7ae4910d23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998282 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378918}
-
Steinar H. Gunderson authored
Change-Id: I5d1d3136bc96f870fd3730ce5291e7eb8402b60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993499 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378917}
-
Jihad Hanna authored
This CL merges some duplicate logic and removes a useless container that could be inferred from others. Bug: 40227071 Change-Id: Ib729455233b9cd26c48052a04b4dc6acb3b23f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993733 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Florian Leimgruber <fleimgruber@google.com> Commit-Queue: Jihad Hanna <jihadghanna@google.com> Cr-Commit-Position: refs/heads/main@{#1378916}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/d1f75795c4e9..b810c7c47e85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC bwwilliams@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:360184707 Change-Id: Ibd4698525bd69bde8bc554a5c92d225cd17ec236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998477 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378915}
-
Tanmoy Mollik authored
This cl adds button onClickListeners for the buttons in signin promo. Low-Coverage-Reason: TESTS_IN_SEPARATE_CL Bug: 327387704 Change-Id: If44be048ffb903aa32ac7e49d00031abfaedbdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5945945 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378914}
-
Jan Keitel authored
Changing the suggestion content of a popup can lead to an increase in size that can lead the popup to hide. Similarly, it causes re-checking whether its bounds overlap with dialogs that can trigger hiding the popup. As a result, controller() is not guaranteed to be non-null after attempting to update the popup's bounds. This CL adds an early return if updating the popup caused it to issue a hide call to the controller. It also adds a CHECK (that is not yet fatal) to confirm that there are no other effects that can cause the controller to hide. Bug: 377592474 Change-Id: I63a733887adfc0e94727325a24c2755e9fd9e3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998650 Commit-Queue: Jan Keitel <jkeitel@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1378913}
-
chromium-internal-autoroll authored
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202411060100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/Qha0yB9w33zhI0ZMShbW-HswDT9ev1GanSUgZtQFJr0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com,cros-projector@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I0b9e98d86550ae477868b52a99c8983a8bea466c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998475 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378912}
-
Maksim Sisov authored
No functional changes are done. 1) Renamed IS_CHROMEOS_ASH to IS_CHROMEOS 2) Removed chromeos_buildflags.h includes and deps 3) General clean ups. Bug: 373972275, 377410076 Change-Id: I722e0e0aed8aa38c79d4d6cf30844fb2b21bc22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993581 Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378911}
-